]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/GContact.php
Rename Friendica\Database\dba to Friendica\Database\DBA
[friendica.git] / src / Model / GContact.php
index 8f16c07fc1906576a5935e8d4a14a299e2772f8b..8dbc37c22860adc6454277be4528d85713666c0f 100644 (file)
@@ -6,18 +6,16 @@
  */
 namespace Friendica\Model;
 
+use Exception;
 use Friendica\Core\Config;
 use Friendica\Core\System;
 use Friendica\Core\Worker;
+use Friendica\Database\DBA;
 use Friendica\Database\DBM;
-use Friendica\Model\Contact;
-use Friendica\Model\Profile;
 use Friendica\Network\Probe;
 use Friendica\Protocol\PortableContact;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
-use dba;
-use Exception;
 
 require_once 'include/dba.php';
 
@@ -62,7 +60,7 @@ class GContact
 
                $search .= "%";
 
-               $results = dba::p("SELECT `nurl` FROM `gcontact`
+               $results = DBA::p("SELECT `nurl` FROM `gcontact`
                        WHERE NOT `hide` AND `network` IN (?, ?, ?) AND
                                ((`last_contact` >= `last_failure`) OR (`updated` >= `last_failure`)) AND
                                (`addr` LIKE ? OR `name` LIKE ? OR `nick` LIKE ?) $extra_sql
@@ -71,7 +69,7 @@ class GContact
                );
 
                $gcontacts = [];
-               while ($result = dba::fetch($results)) {
+               while ($result = DBA::fetch($results)) {
                        $urlparts = parse_url($result["nurl"]);
 
                        // Ignore results that look strange.
@@ -239,10 +237,8 @@ class GContact
 
                        if ($alternate && ($gcontact['network'] == NETWORK_OSTATUS)) {
                                // Delete the old entry - if it exists
-                               $r = q("SELECT `id` FROM `gcontact` WHERE `nurl` = '%s'", dbesc(normalise_link($orig_profile)));
-                               if (DBM::is_result($r)) {
-                                       q("DELETE FROM `gcontact` WHERE `nurl` = '%s'", dbesc(normalise_link($orig_profile)));
-                                       q("DELETE FROM `glink` WHERE `gcid` = %d", intval($r[0]["id"]));
+                               if (DBA::exists('gcontact', ['nurl' => normalise_link($orig_profile)])) {
+                                       DBA::delete('gcontact', ['nurl' => normalise_link($orig_profile)]);
                                }
                        }
                }
@@ -566,15 +562,16 @@ class GContact
 
                if (strlen(Config::get('system', 'directory'))) {
                        $x = Network::fetchUrl(get_server()."/pubsites");
-                       if ($x) {
+                       if (!empty($x)) {
                                $j = json_decode($x);
-                               if ($j->entries) {
+                               if (!empty($j->entries)) {
                                        foreach ($j->entries as $entry) {
                                                PortableContact::checkServer($entry->url);
 
                                                $url = $entry->url . '/poco';
-                                               if (! in_array($url, $done)) {
-                                                       PortableContact::loadWorker(0, 0, 0, $entry->url . '/poco');
+                                               if (!in_array($url, $done)) {
+                                                       PortableContact::loadWorker(0, 0, 0, $url);
+                                                       $done[] = $url;
                                                }
                                        }
                                }
@@ -664,6 +661,11 @@ class GContact
                $last_failure_str = '';
                $last_contact_str = '';
 
+               if (empty($contact["network"])) {
+                       logger("Empty network for contact url ".$contact["url"]." - Called by: ".System::callstack(), LOGGER_DEBUG);
+                       return false;
+               }
+
                if (in_array($contact["network"], [NETWORK_PHANTOM])) {
                        logger("Invalid network for contact url ".$contact["url"]." - Called by: ".System::callstack(), LOGGER_DEBUG);
                        return false;
@@ -686,7 +688,7 @@ class GContact
                        $contact["url"] = self::cleanContactUrl($contact["url"]);
                }
 
-               dba::lock('gcontact');
+               DBA::lock('gcontact');
                $r = q(
                        "SELECT `id`, `last_contact`, `last_failure`, `network` FROM `gcontact` WHERE `nurl` = '%s' LIMIT 1",
                        dbesc(normalise_link($contact["url"]))
@@ -733,7 +735,7 @@ class GContact
                                $doprobing = in_array($r[0]["network"], [NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS, ""]);
                        }
                }
-               dba::unlock();
+               DBA::unlock();
 
                if ($doprobing) {
                        logger("Last Contact: ". $last_contact_str." - Last Failure: ".$last_failure_str." - Checking: ".$contact["url"], LOGGER_DEBUG);
@@ -784,11 +786,11 @@ class GContact
 
                // Bugfix: We had an error in the storing of keywords which lead to the "0"
                // This value is still transmitted via poco.
-               if ($contact["keywords"] == "0") {
+               if (!empty($contact["keywords"]) && ($contact["keywords"] == "0")) {
                        unset($contact["keywords"]);
                }
 
-               if ($public_contact[0]["keywords"] == "0") {
+               if (!empty($public_contact[0]["keywords"]) && ($public_contact[0]["keywords"] == "0")) {
                        $public_contact[0]["keywords"] = "";
                }
 
@@ -869,13 +871,13 @@ class GContact
                                        'generation' => $contact['generation'], 'updated' => $contact['updated'],
                                        'server_url' => $contact['server_url'], 'connect' => $contact['connect']];
 
-                       dba::update('gcontact', $updated, $condition, $fields);
+                       DBA::update('gcontact', $updated, $condition, $fields);
 
                        // Now update the contact entry with the user id "0" as well.
                        // This is used for the shadow copies of public items.
                        /// @todo Check if we really should do this.
                        // The quality of the gcontact table is mostly lower than the public contact
-                       $public_contact = dba::selectFirst('contact', ['id'], ['nurl' => normalise_link($contact["url"]), 'uid' => 0]);
+                       $public_contact = DBA::selectFirst('contact', ['id'], ['nurl' => normalise_link($contact["url"]), 'uid' => 0]);
                        if (DBM::is_result($public_contact)) {
                                logger("Update public contact ".$public_contact["id"], LOGGER_DEBUG);
 
@@ -885,7 +887,7 @@ class GContact
                                                'network', 'bd', 'gender',
                                                'keywords', 'alias', 'contact-type',
                                                'url', 'location', 'about'];
-                               $old_contact = dba::selectFirst('contact', $fields, ['id' => $public_contact["id"]]);
+                               $old_contact = DBA::selectFirst('contact', $fields, ['id' => $public_contact["id"]]);
 
                                // Update it with the current values
                                $fields = ['name' => $contact['name'], 'nick' => $contact['nick'],
@@ -901,7 +903,7 @@ class GContact
                                }
 
 
-                               dba::update('contact', $fields, ['id' => $public_contact["id"]], $old_contact);
+                               DBA::update('contact', $fields, ['id' => $public_contact["id"]], $old_contact);
                        }
                }
 
@@ -993,7 +995,7 @@ class GContact
 
                $statistics = json_decode($result["body"]);
 
-               if (is_object($statistics->config)) {
+               if (!empty($statistics->config)) {
                        if ($statistics->config->instance_with_ssl) {
                                $server = "https://";
                        } else {
@@ -1003,8 +1005,7 @@ class GContact
                        $server .= $statistics->config->instance_address;
 
                        $hostname = $statistics->config->instance_address;
-               } else {
-                       /// @TODO is_object() above means here no object, still $statistics is being used as object
+               } elseif (!empty($statistics)) {
                        if ($statistics->instance_with_ssl) {
                                $server = "https://";
                        } else {
@@ -1016,7 +1017,7 @@ class GContact
                        $hostname = $statistics->instance_address;
                }
 
-               if (is_object($statistics->users)) {
+               if (!empty($statistics->users)) {
                        foreach ($statistics->users as $nick => $user) {
                                $profile_url = $server."/".$user->nickname;
 
@@ -1024,9 +1025,13 @@ class GContact
                                                "name" => $user->fullname,
                                                "addr" => $user->nickname."@".$hostname,
                                                "nick" => $user->nickname,
-                                               "about" => $user->bio,
                                                "network" => NETWORK_OSTATUS,
                                                "photo" => System::baseUrl()."/images/person-175.jpg"];
+
+                               if (isset($user->bio)) {
+                                       $contact["about"] = $user->bio;
+                               }
+
                                self::getId($contact);
                        }
                }