<?php
-
/**
- * @file src/Model/GlobalContact.php
- * @brief This file includes the GlobalContact class with directory related functions
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <https://www.gnu.org/licenses/>.
+ *
*/
+
namespace Friendica\Model;
use DOMDocument;
use DOMXPath;
use Exception;
-use Friendica\Core\Config;
use Friendica\Core\Logger;
use Friendica\Core\Protocol;
+use Friendica\Core\Search;
use Friendica\Core\System;
use Friendica\Core\Worker;
use Friendica\Database\DBA;
+use Friendica\DI;
use Friendica\Network\Probe;
use Friendica\Protocol\ActivityPub;
use Friendica\Protocol\PortableContact;
use Friendica\Util\Strings;
/**
- * @brief This class handles GlobalContact related functions
+ * This class handles GlobalContact related functions
*/
class GContact
{
/**
- * @brief Search global contact table by nick or name
+ * Search global contact table by nick or name
*
* @param string $search Name or nick
* @param string $mode Search mode (e.g. "community")
}
// check supported networks
- if (Config::get('system', 'diaspora_enabled')) {
+ if (DI::config()->get('system', 'diaspora_enabled')) {
$diaspora = Protocol::DIASPORA;
} else {
$diaspora = Protocol::DFRN;
}
- if (!Config::get('system', 'ostatus_disabled')) {
+ if (!DI::config()->get('system', 'ostatus_disabled')) {
$ostatus = Protocol::OSTATUS;
} else {
$ostatus = Protocol::DFRN;
}
// check if we search only communities or every contact
- if ($mode === "community") {
- $extra_sql = " AND `community`";
+ if ($mode === 'community') {
+ $extra_sql = ' AND `community`';
} else {
- $extra_sql = "";
+ $extra_sql = '';
}
- $search .= "%";
+ $search .= '%';
$results = DBA::p("SELECT `nurl` FROM `gcontact`
WHERE NOT `hide` AND `network` IN (?, ?, ?, ?) AND
- ((`last_contact` >= `last_failure`) OR (`updated` >= `last_failure`)) AND
+ NOT `failed` AND
(`addr` LIKE ? OR `name` LIKE ? OR `nick` LIKE ?) $extra_sql
GROUP BY `nurl` ORDER BY `nurl` DESC LIMIT 1000",
Protocol::DFRN, Protocol::ACTIVITYPUB, $ostatus, $diaspora, $search, $search, $search
$gcontacts = [];
while ($result = DBA::fetch($results)) {
- $urlparts = parse_url($result["nurl"]);
+ $urlparts = parse_url($result['nurl']);
// Ignore results that look strange.
// For historic reasons the gcontact table does contain some garbage.
- if (!empty($urlparts['query']) || !empty($urlparts['fragment'])) {
+ if (empty($result['nurl']) || !empty($urlparts['query']) || !empty($urlparts['fragment'])) {
continue;
}
- $gcontacts[] = Contact::getDetailsByURL($result["nurl"], local_user());
+ $gcontacts[] = Contact::getByURLForUser($result['nurl'], local_user());
}
+ DBA::close($results);
return $gcontacts;
}
/**
- * @brief Link the gcontact entry with user, contact and global contact
+ * Link the gcontact entry with user, contact and global contact
*
* @param integer $gcid Global contact ID
* @param integer $uid User ID
}
/**
- * @brief Sanitize the given gcontact data
+ * Sanitize the given gcontact data
*
* Generation:
* 0: No definition
*/
public static function sanitize($gcontact)
{
- if ($gcontact['url'] == "") {
+ if (empty($gcontact['url'])) {
throw new Exception('URL is empty');
}
+ $gcontact['server_url'] = $gcontact['server_url'] ?? '';
+
$urlparts = parse_url($gcontact['url']);
- if (!isset($urlparts["scheme"])) {
- throw new Exception("This (".$gcontact['url'].") doesn't seem to be an url.");
+ if (empty($urlparts['scheme'])) {
+ throw new Exception('This (' . $gcontact['url'] . ") doesn't seem to be an url.");
}
- if (in_array($urlparts["host"], ["twitter.com", "identi.ca"])) {
- throw new Exception('Contact from a non federated network ignored. ('.$gcontact['url'].')');
+ if (in_array($urlparts['host'], ['twitter.com', 'identi.ca'])) {
+ throw new Exception('Contact from a non federated network ignored. (' . $gcontact['url'] . ')');
}
// Don't store the statusnet connector as network
// We can't simply set this to Protocol::OSTATUS since the connector could have fetched posts from friendica as well
if ($gcontact['network'] == Protocol::STATUSNET) {
- $gcontact['network'] = "";
+ $gcontact['network'] = '';
}
// Assure that there are no parameter fragments in the profile url
- if (empty($gcontact["network"]) || in_array($gcontact["network"], Protocol::FEDERATED)) {
+ if (empty($gcontact['*network']) || in_array($gcontact['network'], Protocol::FEDERATED)) {
$gcontact['url'] = self::cleanContactUrl($gcontact['url']);
}
- $alternate = PortableContact::alternateOStatusUrl($gcontact['url']);
-
// The global contacts should contain the original picture, not the cached one
- if (($gcontact['generation'] != 1) && stristr(Strings::normaliseLink($gcontact['photo']), Strings::normaliseLink(System::baseUrl()."/photo/"))) {
- $gcontact['photo'] = "";
+ if (($gcontact['generation'] != 1) && stristr(Strings::normaliseLink($gcontact['photo']), Strings::normaliseLink(DI::baseUrl() . '/photo/'))) {
+ $gcontact['photo'] = '';
}
- if (!isset($gcontact['network'])) {
+ if (empty($gcontact['network'])) {
+ $gcontact['network'] = '';
+
$condition = ["`uid` = 0 AND `nurl` = ? AND `network` != '' AND `network` != ?",
Strings::normaliseLink($gcontact['url']), Protocol::STATUSNET];
$contact = DBA::selectFirst('contact', ['network'], $condition);
if (DBA::isResult($contact)) {
- $gcontact['network'] = $contact["network"];
+ $gcontact['network'] = $contact['network'];
}
- if (($gcontact['network'] == "") || ($gcontact['network'] == Protocol::OSTATUS)) {
+ if (($gcontact['network'] == '') || ($gcontact['network'] == Protocol::OSTATUS)) {
$condition = ["`uid` = 0 AND `alias` IN (?, ?) AND `network` != '' AND `network` != ?",
$gcontact['url'], Strings::normaliseLink($gcontact['url']), Protocol::STATUSNET];
$contact = DBA::selectFirst('contact', ['network'], $condition);
if (DBA::isResult($contact)) {
- $gcontact['network'] = $contact["network"];
+ $gcontact['network'] = $contact['network'];
}
}
}
- $gcontact['server_url'] = '';
- $gcontact['network'] = '';
-
$fields = ['network', 'updated', 'server_url', 'url', 'addr'];
$gcnt = DBA::selectFirst('gcontact', $fields, ['nurl' => Strings::normaliseLink($gcontact['url'])]);
if (DBA::isResult($gcnt)) {
- if (!isset($gcontact['network']) && ($gcnt["network"] != Protocol::STATUSNET)) {
- $gcontact['network'] = $gcnt["network"];
+ if (!isset($gcontact['network']) && ($gcnt['network'] != Protocol::STATUSNET)) {
+ $gcontact['network'] = $gcnt['network'];
}
if ($gcontact['updated'] <= DBA::NULL_DATETIME) {
- $gcontact['updated'] = $gcnt["updated"];
+ $gcontact['updated'] = $gcnt['updated'];
}
- if (!isset($gcontact['server_url']) && (Strings::normaliseLink($gcnt["server_url"]) != Strings::normaliseLink($gcnt["url"]))) {
- $gcontact['server_url'] = $gcnt["server_url"];
+ if (!isset($gcontact['server_url']) && (Strings::normaliseLink($gcnt['server_url']) != Strings::normaliseLink($gcnt['url']))) {
+ $gcontact['server_url'] = $gcnt['server_url'];
}
if (!isset($gcontact['addr'])) {
- $gcontact['addr'] = $gcnt["addr"];
+ $gcontact['addr'] = $gcnt['addr'];
}
}
- if ((!isset($gcontact['network']) || !isset($gcontact['name']) || !isset($gcontact['addr']) || !isset($gcontact['photo']) || !isset($gcontact['server_url']) || $alternate)
+ if ((!isset($gcontact['network']) || !isset($gcontact['name']) || !isset($gcontact['addr']) || !isset($gcontact['photo']) || !isset($gcontact['server_url']))
&& GServer::reachable($gcontact['url'], $gcontact['server_url'], $gcontact['network'], false)
) {
$data = Probe::uri($gcontact['url']);
- if ($data["network"] == Protocol::PHANTOM) {
- throw new Exception('Probing for URL '.$gcontact['url'].' failed');
+ if ($data['network'] == Protocol::PHANTOM) {
+ throw new Exception('Probing for URL ' . $gcontact['url'] . ' failed');
}
- $orig_profile = $gcontact['url'];
-
- $gcontact["server_url"] = $data["baseurl"];
+ $gcontact['server_url'] = $data['baseurl'];
+ $gcontact['failed'] = false;
$gcontact = array_merge($gcontact, $data);
-
- if ($alternate && ($gcontact['network'] == Protocol::OSTATUS)) {
- // Delete the old entry - if it exists
- if (DBA::exists('gcontact', ['nurl' => Strings::normaliseLink($orig_profile)])) {
- DBA::delete('gcontact', ['nurl' => Strings::normaliseLink($orig_profile)]);
- }
- }
}
if (!isset($gcontact['name']) || !isset($gcontact['photo'])) {
}
if (!in_array($gcontact['network'], Protocol::FEDERATED)) {
- throw new Exception('No federated network ('.$gcontact['network'].') detected for URL '.$gcontact['url']);
+ throw new Exception('No federated network (' . $gcontact['network'] . ') detected for URL ' . $gcontact['url']);
}
- if (!isset($gcontact['server_url'])) {
+ if (empty($gcontact['server_url'])) {
// We check the server url to be sure that it is a real one
- $server_url = Contact::getBasepath($gcontact['url']);
+ $server_url = self::getBasepath($gcontact['url']);
// We are now sure that it is a correct URL. So we use it in the future
- if ($server_url != "") {
+ if ($server_url != '') {
$gcontact['server_url'] = $server_url;
}
}
// The server URL doesn't seem to be valid, so we don't store it.
if (!GServer::check($gcontact['server_url'], $gcontact['network'])) {
- $gcontact['server_url'] = "";
+ $gcontact['server_url'] = '';
}
return $gcontact;
"SELECT count(*) as `total`
FROM `glink` INNER JOIN `gcontact` on `glink`.`gcid` = `gcontact`.`id`
WHERE `glink`.`cid` = %d AND `glink`.`uid` = %d AND
- ((`gcontact`.`last_contact` >= `gcontact`.`last_failure`) OR
- (`gcontact`.`updated` >= `gcontact`.`last_failure`))
- AND `gcontact`.`nurl` IN (select nurl from contact where uid = %d and self = 0 and blocked = 0 and hidden = 0 and id != %d ) ",
+ NOT `gcontact`.`failed`
+ AND `gcontact`.`nurl` IN (select nurl from contact where uid = %d and self = 0 and blocked = 0 and hidden = 0 and id != %d) ",
intval($cid),
intval($uid),
intval($uid),
intval($cid)
);
- // Logger::log("countCommonFriends: $uid $cid {$r[0]['total']}");
if (DBA::isResult($r)) {
return $r[0]['total'];
}
"SELECT count(*) as `total`
FROM `glink` INNER JOIN `gcontact` on `glink`.`gcid` = `gcontact`.`id`
where `glink`.`zcid` = %d
- and `gcontact`.`nurl` in (select nurl from contact where uid = %d and self = 0 and blocked = 0 and hidden = 0 ) ",
+ and `gcontact`.`nurl` in (select nurl from contact where uid = %d and self = 0 and blocked = 0 and hidden = 0) ",
intval($zcid),
intval($uid)
);
WHERE `glink`.`cid` = %d and `glink`.`uid` = %d
AND `contact`.`uid` = %d AND `contact`.`self` = 0 AND `contact`.`blocked` = 0
AND `contact`.`hidden` = 0 AND `contact`.`id` != %d
- AND ((`gcontact`.`last_contact` >= `gcontact`.`last_failure`) OR (`gcontact`.`updated` >= `gcontact`.`last_failure`))
+ AND NOT `gcontact`.`failed`
$sql_extra LIMIT %d, %d",
intval($cid),
intval($uid),
"SELECT `gcontact`.*
FROM `glink` INNER JOIN `gcontact` on `glink`.`gcid` = `gcontact`.`id`
where `glink`.`zcid` = %d
- and `gcontact`.`nurl` in (select nurl from contact where uid = %d and self = 0 and blocked = 0 and hidden = 0 )
+ and `gcontact`.`nurl` in (select nurl from contact where uid = %d and self = 0 and blocked = 0 and hidden = 0)
$sql_extra limit %d, %d",
intval($zcid),
intval($uid),
"SELECT count(*) as `total`
FROM `glink` INNER JOIN `gcontact` on `glink`.`gcid` = `gcontact`.`id`
where `glink`.`cid` = %d and `glink`.`uid` = %d AND
- ((`gcontact`.`last_contact` >= `gcontact`.`last_failure`) OR (`gcontact`.`updated` >= `gcontact`.`last_failure`))",
+ NOT `gcontact`.`failed`",
intval($cid),
intval($uid)
);
INNER JOIN `gcontact` on `glink`.`gcid` = `gcontact`.`id`
LEFT JOIN `contact` ON `contact`.`nurl` = `gcontact`.`nurl` AND `contact`.`uid` = %d
WHERE `glink`.`cid` = %d AND `glink`.`uid` = %d AND
- ((`gcontact`.`last_contact` >= `gcontact`.`last_failure`) OR (`gcontact`.`updated` >= `gcontact`.`last_failure`))
+ NOT `gcontact`.`failed`
ORDER BY `gcontact`.`name` ASC LIMIT %d, %d ",
intval($uid),
intval($cid),
return [];
}
- /*
- * Uncommented because the result of the queries are to big to store it in the cache.
- * We need to decide if we want to change the db column type or if we want to delete it.
- */
- //$list = Cache::get("suggestion_query:".$uid.":".$start.":".$limit);
- //if (!is_null($list)) {
- // return $list;
- //}
-
$network = [Protocol::DFRN, Protocol::ACTIVITYPUB];
- if (Config::get('system', 'diaspora_enabled')) {
+ if (DI::config()->get('system', 'diaspora_enabled')) {
$network[] = Protocol::DIASPORA;
}
- if (!Config::get('system', 'ostatus_disabled')) {
+ if (!DI::config()->get('system', 'ostatus_disabled')) {
$network[] = Protocol::OSTATUS;
}
- $sql_network = implode("', '", $network);
- $sql_network = "'".$sql_network."'";
+ $sql_network = "'" . implode("', '", $network) . "'";
/// @todo This query is really slow
// By now we cache the data for five minutes
AND NOT `gcontact`.`name` IN (SELECT `name` FROM `contact` WHERE `uid` = %d)
AND NOT `gcontact`.`id` IN (SELECT `gcid` FROM `gcign` WHERE `uid` = %d)
AND `gcontact`.`updated` >= '%s' AND NOT `gcontact`.`hide`
- AND `gcontact`.`last_contact` >= `gcontact`.`last_failure`
+ AND NOT `gcontact`.`failed`
AND `gcontact`.`network` IN (%s)
GROUP BY `glink`.`gcid` ORDER BY `gcontact`.`updated` DESC,`total` DESC LIMIT %d, %d",
intval($uid),
);
if (DBA::isResult($r) && count($r) >= ($limit -1)) {
- /*
- * Uncommented because the result of the queries are to big to store it in the cache.
- * We need to decide if we want to change the db column type or if we want to delete it.
- */
- //Cache::set("suggestion_query:".$uid.":".$start.":".$limit, $r, Cache::FIVE_MINUTES);
-
return $r;
}
AND NOT `gcontact`.`name` IN (SELECT `name` FROM `contact` WHERE `uid` = %d)
AND NOT `gcontact`.`id` IN (SELECT `gcid` FROM `gcign` WHERE `uid` = %d)
AND `gcontact`.`updated` >= '%s'
- AND `gcontact`.`last_contact` >= `gcontact`.`last_failure`
+ AND NOT `gcontact`.`failed`
AND `gcontact`.`network` IN (%s)
ORDER BY rand() LIMIT %d, %d",
intval($uid),
$list = [];
foreach ($r2 as $suggestion) {
- $list[$suggestion["nurl"]] = $suggestion;
+ $list[$suggestion['nurl']] = $suggestion;
}
foreach ($r as $suggestion) {
- $list[$suggestion["nurl"]] = $suggestion;
+ $list[$suggestion['nurl']] = $suggestion;
}
while (sizeof($list) > ($limit)) {
array_pop($list);
}
- /*
- * Uncommented because the result of the queries are to big to store it in the cache.
- * We need to decide if we want to change the db column type or if we want to delete it.
- */
- //Cache::set("suggestion_query:".$uid.":".$start.":".$limit, $list, Cache::FIVE_MINUTES);
return $list;
}
$done = [];
/// @TODO Check if it is really neccessary to poll the own server
- PortableContact::loadWorker(0, 0, 0, System::baseUrl() . '/poco');
+ PortableContact::loadWorker(0, 0, 0, DI::baseUrl() . '/poco');
- $done[] = System::baseUrl() . '/poco';
+ $done[] = DI::baseUrl() . '/poco';
- if (strlen(Config::get('system', 'directory'))) {
- $x = Network::fetchUrl(get_server()."/pubsites");
+ if (strlen(DI::config()->get('system', 'directory'))) {
+ $x = DI::httpRequest()->fetch(Search::getGlobalDirectory() . '/pubsites');
if (!empty($x)) {
$j = json_decode($x);
if (!empty($j->entries)) {
}
// Query your contacts from Friendica and Redmatrix/Hubzilla for their contacts
- $r = q(
- "SELECT DISTINCT(`poco`) AS `poco` FROM `contact` WHERE `network` IN ('%s', '%s')",
- DBA::escape(Protocol::DFRN),
- DBA::escape(Protocol::DIASPORA)
- );
-
- if (DBA::isResult($r)) {
- foreach ($r as $rr) {
- $base = substr($rr['poco'], 0, strrpos($rr['poco'], '/'));
- if (! in_array($base, $done)) {
- PortableContact::loadWorker(0, 0, 0, $base);
- }
+ $contacts = DBA::p("SELECT DISTINCT(`poco`) AS `poco` FROM `contact` WHERE `network` IN (?, ?)", Protocol::DFRN, Protocol::DIASPORA);
+ while ($contact = DBA::fetch($contacts)) {
+ $base = substr($contact['poco'], 0, strrpos($contact['poco'], '/'));
+ if (!in_array($base, $done)) {
+ PortableContact::loadWorker(0, 0, 0, $base);
}
}
+ DBA::close($contacts);
}
/**
- * @brief Removes unwanted parts from a contact url
+ * Removes unwanted parts from a contact url
*
* @param string $url Contact url
*
{
$parts = parse_url($url);
- if (!isset($parts["scheme"]) || !isset($parts["host"])) {
+ if (empty($parts['scheme']) || empty($parts['host'])) {
return $url;
}
- $new_url = $parts["scheme"]."://".$parts["host"];
+ $new_url = $parts['scheme'] . '://' . $parts['host'];
- if (isset($parts["port"])) {
- $new_url .= ":".$parts["port"];
+ if (!empty($parts['port'])) {
+ $new_url .= ':' . $parts['port'];
}
- if (isset($parts["path"])) {
- $new_url .= $parts["path"];
+ if (!empty($parts['path'])) {
+ $new_url .= $parts['path'];
}
if ($new_url != $url) {
- Logger::log("Cleaned contact url ".$url." to ".$new_url." - Called by: ".System::callstack(), Logger::DEBUG);
+ Logger::info('Cleaned contact url', ['url' => $url, 'new_url' => $new_url, 'callstack' => System::callstack()]);
}
return $new_url;
}
/**
- * @brief Replace alternate OStatus user format with the primary one
- *
- * @param array $contact contact array (called by reference)
- * @return void
- * @throws \Friendica\Network\HTTPException\InternalServerErrorException
- * @throws \ImagickException
- */
- public static function fixAlternateContactAddress(&$contact)
- {
- if (($contact["network"] == Protocol::OSTATUS) && PortableContact::alternateOStatusUrl($contact["url"])) {
- $data = Probe::uri($contact["url"]);
- if ($contact["network"] == Protocol::OSTATUS) {
- Logger::log("Fix primary url from ".$contact["url"]." to ".$data["url"]." - Called by: ".System::callstack(), Logger::DEBUG);
- $contact["url"] = $data["url"];
- $contact["addr"] = $data["addr"];
- $contact["alias"] = $data["alias"];
- $contact["server_url"] = $data["baseurl"];
- }
- }
- }
-
- /**
- * @brief Fetch the gcontact id, add an entry if not existed
+ * Fetch the gcontact id, add an entry if not existed
*
* @param array $contact contact array
*
*/
public static function getId($contact)
{
- $gcontact_id = 0;
- $doprobing = false;
- $last_failure_str = '';
- $last_contact_str = '';
-
- if (empty($contact["network"])) {
- Logger::log("Empty network for contact url ".$contact["url"]." - Called by: ".System::callstack(), Logger::DEBUG);
+ if (empty($contact['network'])) {
+ Logger::notice('Empty network', ['url' => $contact['url'], 'callstack' => System::callstack()]);
return false;
}
- if (in_array($contact["network"], [Protocol::PHANTOM])) {
- Logger::log("Invalid network for contact url ".$contact["url"]." - Called by: ".System::callstack(), Logger::DEBUG);
+ if (in_array($contact['network'], [Protocol::PHANTOM])) {
+ Logger::notice('Invalid network', ['url' => $contact['url'], 'callstack' => System::callstack()]);
return false;
}
- if ($contact["network"] == Protocol::STATUSNET) {
- $contact["network"] = Protocol::OSTATUS;
+ if ($contact['network'] == Protocol::STATUSNET) {
+ $contact['network'] = Protocol::OSTATUS;
}
- // All new contacts are hidden by default
- if (!isset($contact["hide"])) {
- $contact["hide"] = true;
+ // Remove unwanted parts from the contact url (e.g. '?zrl=...')
+ if (in_array($contact['network'], Protocol::FEDERATED)) {
+ $contact['url'] = self::cleanContactUrl($contact['url']);
}
- // Replace alternate OStatus user format with the primary one
- self::fixAlternateContactAddress($contact);
-
- // Remove unwanted parts from the contact url (e.g. "?zrl=...")
- if (in_array($contact["network"], Protocol::FEDERATED)) {
- $contact["url"] = self::cleanContactUrl($contact["url"]);
+ $condition = ['nurl' => Strings::normaliseLink($contact['url'])];
+ $gcontact = DBA::selectFirst('gcontact', ['id'], $condition, ['order' => ['id']]);
+ if (DBA::isResult($gcontact)) {
+ return $gcontact['id'];
}
- DBA::lock('gcontact');
- $fields = ['id', 'last_contact', 'last_failure', 'network'];
- $gcnt = DBA::selectFirst('gcontact', $fields, ['nurl' => Strings::normaliseLink($contact["url"])]);
- if (DBA::isResult($gcnt)) {
- $gcontact_id = $gcnt["id"];
-
- // Update every 90 days
- if (in_array($gcnt["network"], [Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS, ""])) {
- $last_failure_str = $gcnt["last_failure"];
- $last_failure = strtotime($gcnt["last_failure"]);
- $last_contact_str = $gcnt["last_contact"];
- $last_contact = strtotime($gcnt["last_contact"]);
- $doprobing = (((time() - $last_contact) > (90 * 86400)) && ((time() - $last_failure) > (90 * 86400)));
- }
- } else {
- $contact['location'] = $contact['location'] ?? '';
- $contact['about'] = $contact['about'] ?? '';
- $contact['generation'] = $contact['generation'] ?? 0;
-
- q(
- "INSERT INTO `gcontact` (`name`, `nick`, `addr` , `network`, `url`, `nurl`, `photo`, `created`, `updated`, `location`, `about`, `hide`, `generation`)
- VALUES ('%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d)",
- DBA::escape($contact["name"]),
- DBA::escape($contact["nick"]),
- DBA::escape($contact["addr"]),
- DBA::escape($contact["network"]),
- DBA::escape($contact["url"]),
- DBA::escape(Strings::normaliseLink($contact["url"])),
- DBA::escape($contact["photo"]),
- DBA::escape(DateTimeFormat::utcNow()),
- DBA::escape(DateTimeFormat::utcNow()),
- DBA::escape($contact["location"]),
- DBA::escape($contact["about"]),
- intval($contact["hide"]),
- intval($contact["generation"])
- );
-
- $condition = ['nurl' => Strings::normaliseLink($contact["url"])];
- $cnt = DBA::selectFirst('gcontact', ['id', 'network'], $condition, ['order' => ['id']]);
- if (DBA::isResult($cnt)) {
- $gcontact_id = $cnt["id"];
- $doprobing = in_array($cnt["network"], [Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS, ""]);
- }
- }
- DBA::unlock();
+ $contact['location'] = $contact['location'] ?? '';
+ $contact['about'] = $contact['about'] ?? '';
+ $contact['generation'] = $contact['generation'] ?? 0;
+ $contact['hide'] = $contact['hide'] ?? true;
- if ($doprobing) {
- Logger::log("Last Contact: ". $last_contact_str." - Last Failure: ".$last_failure_str." - Checking: ".$contact["url"], Logger::DEBUG);
- Worker::add(PRIORITY_LOW, 'GProbe', $contact["url"]);
- }
+ $fields = ['name' => $contact['name'], 'nick' => $contact['nick'] ?? '', 'addr' => $contact['addr'] ?? '', 'network' => $contact['network'],
+ 'url' => $contact['url'], 'nurl' => Strings::normaliseLink($contact['url']), 'photo' => $contact['photo'],
+ 'created' => DateTimeFormat::utcNow(), 'updated' => DateTimeFormat::utcNow(), 'location' => $contact['location'],
+ 'about' => $contact['about'], 'hide' => $contact['hide'], 'generation' => $contact['generation'], 'failed' => false];
- return $gcontact_id;
+ DBA::insert('gcontact', $fields);
+
+ // We intentionally aren't using lastInsertId here. There is a chance for duplicates.
+ $gcontact = DBA::selectFirst('gcontact', ['id'], $condition, ['order' => ['id']]);
+ if (!DBA::isResult($gcontact)) {
+ Logger::info('GContact creation failed', $fields);
+ // Shouldn't happen
+ return 0;
+ }
+ return $gcontact['id'];
}
/**
- * @brief Updates the gcontact table from a given array
+ * Updates the gcontact table from a given array
*
* @param array $contact contact array
*
}
$public_contact = DBA::selectFirst('gcontact', [
- 'name', 'nick', 'photo', 'location', 'about', 'addr', 'generation', 'birthday', 'gender', 'keywords',
+ 'name', 'nick', 'photo', 'location', 'about', 'addr', 'generation', 'birthday', 'keywords', 'gsid', 'failed',
'contact-type', 'hide', 'nsfw', 'network', 'alias', 'notify', 'server_url', 'connect', 'updated', 'url'
], ['id' => $gcontact_id]);
$contact['network'] = Protocol::OSTATUS;
}
- // Replace alternate OStatus user format with the primary one
- self::fixAlternateContactAddress($contact);
-
if (!isset($contact['updated'])) {
$contact['updated'] = DateTimeFormat::utcNow();
}
$contact['server_url'] = Strings::normaliseLink($contact['server_url']);
}
+ if (!empty($contact['server_url']) && empty($contact['gsid'])) {
+ $contact['gsid'] = GServer::getID($contact['server_url']);
+ }
+
if (empty($contact['addr']) && !empty($contact['server_url']) && !empty($contact['nick'])) {
$hostname = str_replace('http://', '', $contact['server_url']);
$contact['addr'] = $contact['nick'] . '@' . $hostname;
if ((($contact['generation'] > 0) && ($contact['generation'] <= $public_contact['generation'])) || ($public_contact['generation'] == 0)) {
foreach ($fields as $field => $data) {
if ($contact[$field] != $public_contact[$field]) {
- Logger::debug('Difference found.', ['contact' => $contact["url"], 'field' => $field, 'new' => $contact[$field], 'old' => $public_contact[$field]]);
+ Logger::debug('Difference found.', ['contact' => $contact['url'], 'field' => $field, 'new' => $contact[$field], 'old' => $public_contact[$field]]);
$update = true;
}
}
if ($contact['generation'] < $public_contact['generation']) {
- Logger::debug('Difference found.', ['contact' => $contact["url"], 'field' => 'generation', 'new' => $contact['generation'], 'old' => $public_contact['generation']]);
+ Logger::debug('Difference found.', ['contact' => $contact['url'], 'field' => 'generation', 'new' => $contact['generation'], 'old' => $public_contact['generation']]);
$update = true;
}
}
if ($update) {
Logger::debug('Update gcontact.', ['contact' => $contact['url']]);
- $condition = ['`nurl` = ? AND (`generation` = 0 OR `generation` >= ?)',
- Strings::normaliseLink($contact["url"]), $contact["generation"]];
- $contact["updated"] = DateTimeFormat::utc($contact["updated"]);
+ $condition = ["`nurl` = ? AND (`generation` = 0 OR `generation` >= ?)",
+ Strings::normaliseLink($contact['url']), $contact['generation']];
+ $contact['updated'] = DateTimeFormat::utc($contact['updated']);
$updated = [
'photo' => $contact['photo'], 'name' => $contact['name'],
'nick' => $contact['nick'], 'addr' => $contact['addr'],
'network' => $contact['network'], 'birthday' => $contact['birthday'],
- 'gender' => $contact['gender'], 'keywords' => $contact['keywords'],
+ 'keywords' => $contact['keywords'],
'hide' => $contact['hide'], 'nsfw' => $contact['nsfw'],
'contact-type' => $contact['contact-type'], 'alias' => $contact['alias'],
'notify' => $contact['notify'], 'url' => $contact['url'],
'location' => $contact['location'], 'about' => $contact['about'],
'generation' => $contact['generation'], 'updated' => $contact['updated'],
- 'server_url' => $contact['server_url'], 'connect' => $contact['connect']
+ 'server_url' => $contact['server_url'], 'connect' => $contact['connect'],
+ 'failed' => $contact['failed'], 'gsid' => $contact['gsid']
];
DBA::update('gcontact', $updated, $condition, $fields);
return;
}
- if (!$force && !PortableContact::updateNeeded($gcontact['created'], $gcontact['updated'], $gcontact['last_failure'], $gcontact['last_contact'])) {
+ if (!$force && !GServer::updateNeeded($gcontact['created'], $gcontact['updated'], $gcontact['last_failure'], $gcontact['last_contact'])) {
Logger::info("Don't update profile", ['url' => $data['url'], 'updated' => $gcontact['updated']]);
return;
}
return;
}
- // When the profile doesn't have got a feed, then we exit here
- if (empty($data['poll'])) {
- return;
- }
-
- if ($data['network'] == Protocol::ACTIVITYPUB) {
+ if (!empty($data['outbox'])) {
+ self::updateFromOutbox($data['outbox'], $data);
+ } elseif (!empty($data['poll']) && ($data['network'] == Protocol::ACTIVITYPUB)) {
self::updateFromOutbox($data['poll'], $data);
- } else {
+ } elseif (!empty($data['poll'])) {
self::updateFromFeed($data);
}
}
return false;
}
- $curlResult = Network::curl($gserver['noscrape'] . '/' . $data['nick']);
+ $curlResult = DI::httpRequest()->get($gserver['noscrape'] . '/' . $data['nick']);
if ($curlResult->isSuccess() && !empty($curlResult->getBody())) {
$noscrape = json_decode($curlResult->getBody(), true);
- if (!empty($noscrape)) {
+ if (!empty($noscrape) && !empty($noscrape['updated'])) {
$noscrape['updated'] = DateTimeFormat::utc($noscrape['updated'], DateTimeFormat::MYSQL);
- $fields = ['last_contact' => DateTimeFormat::utcNow(), 'updated' => $noscrape['updated']];
+ $fields = ['failed' => false, 'last_contact' => DateTimeFormat::utcNow(), 'updated' => $noscrape['updated']];
DBA::update('gcontact', $fields, ['nurl' => Strings::normaliseLink($data['url'])]);
return true;
}
} elseif ($curlResult->isTimeout()) {
// On a timeout return the existing value, but mark the contact as failure
- $fields = ['last_failure' => DateTimeFormat::utcNow()];
+ $fields = ['failed' => true, 'last_failure' => DateTimeFormat::utcNow()];
DBA::update('gcontact', $fields, ['nurl' => Strings::normaliseLink($data['url'])]);
return true;
}
/**
* Update a global contact via an ActivityPub Outbox
*
- * @param string $data Probing result
+ * @param string $feed
+ * @param array $data Probing result
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
private static function updateFromOutbox(string $feed, array $data)
{
$items = $outbox['orderedItems'];
} elseif (!empty($outbox['first']['orderedItems'])) {
$items = $outbox['first']['orderedItems'];
+ } elseif (!empty($outbox['first']['href']) && ($outbox['first']['href'] != $feed)) {
+ self::updateFromOutbox($outbox['first']['href'], $data);
+ return;
} elseif (!empty($outbox['first'])) {
- self::updateFromOutbox($outbox['first'], $data);
+ if (is_string($outbox['first']) && ($outbox['first'] != $feed)) {
+ self::updateFromOutbox($outbox['first'], $data);
+ } else {
+ Logger::warning('Unexpected data', ['outbox' => $outbox]);
+ }
return;
} else {
$items = [];
}
$last_updated = '';
-
foreach ($items as $activity) {
- if ($last_updated < $activity['published']) {
- $last_updated = $activity['published'];
+ if (!empty($activity['published'])) {
+ $published = DateTimeFormat::utc($activity['published']);
+ } elseif (!empty($activity['object']['published'])) {
+ $published = DateTimeFormat::utc($activity['object']['published']);
+ } else {
+ continue;
+ }
+
+ if ($last_updated < $published) {
+ $last_updated = $published;
}
}
return;
}
- $fields = ['last_contact' => DateTimeFormat::utcNow(), 'updated' => $last_updated];
+ $fields = ['failed' => false, 'last_contact' => DateTimeFormat::utcNow(), 'updated' => $last_updated];
DBA::update('gcontact', $fields, ['nurl' => Strings::normaliseLink($data['url'])]);
}
private static function updateFromFeed(array $data)
{
// Search for the newest entry in the feed
- $curlResult = Network::curl($data['poll']);
+ $curlResult = DI::httpRequest()->get($data['poll']);
if (!$curlResult->isSuccess()) {
- $fields = ['last_failure' => DateTimeFormat::utcNow()];
- DBA::update('gcontact', $fields, ['nurl' => Strings::normaliseLink($profile)]);
+ $fields = ['failed' => true, 'last_failure' => DateTimeFormat::utcNow()];
+ DBA::update('gcontact', $fields, ['nurl' => Strings::normaliseLink($data['url'])]);
Logger::info("Profile wasn't reachable (no feed)", ['url' => $data['url']]);
return;
return;
}
- $fields = ['last_contact' => DateTimeFormat::utcNow(), 'updated' => $last_updated];
+ $fields = ['failed' => false, 'last_contact' => DateTimeFormat::utcNow(), 'updated' => $last_updated];
DBA::update('gcontact', $fields, ['nurl' => Strings::normaliseLink($data['url'])]);
}
/**
- * @brief Updates the gcontact entry from a given public contact id
+ * Updates the gcontact entry from a given public contact id
*
* @param integer $cid contact id
* @return void
}
/**
- * @brief Updates the gcontact entry from a given public contact url
+ * Updates the gcontact entry from a given public contact url
*
* @param string $url contact url
* @return integer gcontact id
}
/**
- * @brief Helper function for updateFromPublicContactID and updateFromPublicContactURL
+ * Helper function for updateFromPublicContactID and updateFromPublicContactURL
*
* @param array $condition contact condition
* @return integer gcontact id
*/
private static function updateFromPublicContact($condition)
{
- $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords', 'gender',
+ $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords',
'bd', 'contact-type', 'network', 'addr', 'notify', 'alias', 'archive', 'term-date',
'created', 'updated', 'avatar', 'success_update', 'failure_update', 'forum', 'prv',
- 'baseurl', 'sensitive', 'unsearchable'];
+ 'baseurl', 'gsid', 'sensitive', 'unsearchable', 'failed'];
$contact = DBA::selectFirst('contact', $fields, array_merge($condition, ['uid' => 0, 'network' => Protocol::FEDERATED]));
if (!DBA::isResult($contact)) {
return 0;
}
- $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords', 'gender', 'generation',
+ $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords', 'generation',
'birthday', 'contact-type', 'network', 'addr', 'notify', 'alias', 'archived', 'archive_date',
'created', 'updated', 'photo', 'last_contact', 'last_failure', 'community', 'connect',
- 'server_url', 'nsfw', 'hide', 'id'];
+ 'server_url', 'gsid', 'nsfw', 'hide', 'id', 'failed'];
$old_gcontact = DBA::selectFirst('gcontact', $fields, ['nurl' => $contact['nurl']]);
$do_insert = !DBA::isResult($old_gcontact);
$gcontact = [];
// These fields are identical in both contact and gcontact
- $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords', 'gender',
- 'contact-type', 'network', 'addr', 'notify', 'alias', 'created', 'updated'];
+ $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords', 'gsid',
+ 'contact-type', 'network', 'addr', 'notify', 'alias', 'created', 'updated', 'failed'];
foreach ($fields as $field) {
$gcontact[$field] = $contact[$field];
}
/**
- * @brief Updates the gcontact entry from probe
+ * Updates the gcontact entry from probe
*
* @param string $url profile link
* @param boolean $force Optional forcing of network probing (otherwise we use the cached data)
{
$data = Probe::uri($url, $force);
- if (in_array($data["network"], [Protocol::PHANTOM])) {
- $fields = ['last_failure' => DateTimeFormat::utcNow()];
+ if (in_array($data['network'], [Protocol::PHANTOM])) {
+ $fields = ['failed' => true, 'last_failure' => DateTimeFormat::utcNow()];
DBA::update('gcontact', $fields, ['nurl' => Strings::normaliseLink($url)]);
Logger::info('Invalid network for contact', ['url' => $data['url'], 'callstack' => System::callstack()]);
return false;
}
- $data["server_url"] = $data["baseurl"];
+ $data['server_url'] = $data['baseurl'];
+ $data['failed'] = false;
self::update($data);
}
/**
- * @brief Update the gcontact entry for a given user id
+ * Update the gcontact entry for a given user id
*
* @param int $uid User ID
* @return bool
*/
public static function updateForUser($uid)
{
- $r = q(
- "SELECT `profile`.`locality`, `profile`.`region`, `profile`.`country-name`,
- `profile`.`name`, `profile`.`about`, `profile`.`gender`,
- `profile`.`pub_keywords`, `profile`.`dob`, `profile`.`photo`,
- `profile`.`net-publish`, `user`.`nickname`, `user`.`hidewall`,
- `contact`.`notify`, `contact`.`url`, `contact`.`addr`
- FROM `profile`
- INNER JOIN `user` ON `user`.`uid` = `profile`.`uid`
- INNER JOIN `contact` ON `contact`.`uid` = `profile`.`uid`
- WHERE `profile`.`uid` = %d AND `profile`.`is-default` AND `contact`.`self`",
- intval($uid)
- );
+ $profile = Profile::getByUID($uid);
+ if (empty($profile)) {
+ Logger::error('Cannot find profile', ['uid' => $uid]);
+ return false;
+ }
- if (!DBA::isResult($r)) {
- Logger::log('Cannot find user with uid=' . $uid, Logger::INFO);
+ $user = User::getOwnerDataById($uid);
+ if (empty($user)) {
+ Logger::error('Cannot find user', ['uid' => $uid]);
return false;
}
+ $userdata = array_merge($profile, $user);
+
$location = Profile::formatLocation(
- ["locality" => $r[0]["locality"], "region" => $r[0]["region"], "country-name" => $r[0]["country-name"]]
+ ['locality' => $userdata['locality'], 'region' => $userdata['region'], 'country-name' => $userdata['country-name']]
);
- // The "addr" field was added in 3.4.3 so it can be empty for older users
- if ($r[0]["addr"] != "") {
- $addr = $r[0]["nickname"].'@'.str_replace(["http://", "https://"], "", System::baseUrl());
- } else {
- $addr = $r[0]["addr"];
+ $gcontact = ['name' => $userdata['name'], 'location' => $location, 'about' => $userdata['about'],
+ 'keywords' => $userdata['pub_keywords'],
+ 'birthday' => $userdata['dob'], 'photo' => $userdata['photo'],
+ "notify" => $userdata['notify'], 'url' => $userdata['url'],
+ "hide" => !$userdata['net-publish'],
+ 'nick' => $userdata['nickname'], 'addr' => $userdata['addr'],
+ "connect" => $userdata['addr'], "server_url" => DI::baseUrl(),
+ "generation" => 1, 'network' => Protocol::DFRN];
+
+ self::update($gcontact);
+ }
+
+ /**
+ * Get the basepath for a given contact link
+ *
+ * @param string $url The gcontact link
+ * @param boolean $dont_update Don't update the contact
+ *
+ * @return string basepath
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+ * @throws \ImagickException
+ */
+ public static function getBasepath($url, $dont_update = false)
+ {
+ $gcontact = DBA::selectFirst('gcontact', ['server_url'], ['nurl' => Strings::normaliseLink($url)]);
+ if (!empty($gcontact['server_url'])) {
+ return $gcontact['server_url'];
+ } elseif ($dont_update) {
+ return '';
}
- $gcontact = ["name" => $r[0]["name"], "location" => $location, "about" => $r[0]["about"],
- "gender" => $r[0]["gender"], "keywords" => $r[0]["pub_keywords"],
- "birthday" => $r[0]["dob"], "photo" => $r[0]["photo"],
- "notify" => $r[0]["notify"], "url" => $r[0]["url"],
- "hide" => ($r[0]["hidewall"] || !$r[0]["net-publish"]),
- "nick" => $r[0]["nickname"], "addr" => $addr,
- "connect" => $addr, "server_url" => System::baseUrl(),
- "generation" => 1, "network" => Protocol::DFRN];
+ self::updateFromProbe($url, true);
- self::update($gcontact);
+ // Fetch the result
+ $gcontact = DBA::selectFirst('gcontact', ['server_url'], ['nurl' => Strings::normaliseLink($url)]);
+ if (empty($gcontact['server_url'])) {
+ Logger::info('No baseurl for gcontact', ['url' => $url]);
+ return '';
+ }
+
+ Logger::info('Found baseurl for gcontact', ['url' => $url, 'baseurl' => $gcontact['server_url']]);
+ return $gcontact['server_url'];
}
/**
- * @brief Fetches users of given GNU Social server
+ * Fetches users of given GNU Social server
*
* If the "Statistics" addon is enabled (See http://gstools.org/ for details) we query user data with this.
*
*/
public static function fetchGsUsers($server)
{
- Logger::log("Fetching users from GNU Social server ".$server, Logger::DEBUG);
+ Logger::info('Fetching users from GNU Social server', ['server' => $server]);
- $url = $server."/main/statistics";
+ $url = $server . '/main/statistics';
- $curlResult = Network::curl($url);
+ $curlResult = DI::httpRequest()->get($url);
if (!$curlResult->isSuccess()) {
return false;
}
if (!empty($statistics->config->instance_address)) {
if (!empty($statistics->config->instance_with_ssl)) {
- $server = "https://";
+ $server = 'https://';
} else {
- $server = "http://";
+ $server = 'http://';
}
$server .= $statistics->config->instance_address;
$hostname = $statistics->config->instance_address;
} elseif (!empty($statistics->instance_address)) {
if (!empty($statistics->instance_with_ssl)) {
- $server = "https://";
+ $server = 'https://';
} else {
- $server = "http://";
+ $server = 'http://';
}
$server .= $statistics->instance_address;
if (!empty($statistics->users)) {
foreach ($statistics->users as $nick => $user) {
- $profile_url = $server."/".$user->nickname;
+ $profile_url = $server . '/' . $user->nickname;
- $contact = ["url" => $profile_url,
- "name" => $user->fullname,
- "addr" => $user->nickname."@".$hostname,
- "nick" => $user->nickname,
+ $contact = ['url' => $profile_url,
+ 'name' => $user->fullname,
+ 'addr' => $user->nickname . '@' . $hostname,
+ 'nick' => $user->nickname,
"network" => Protocol::OSTATUS,
- "photo" => System::baseUrl()."/images/person-300.jpg"];
+ 'photo' => DI::baseUrl() . '/images/person-300.jpg'];
if (isset($user->bio)) {
- $contact["about"] = $user->bio;
+ $contact['about'] = $user->bio;
}
self::getId($contact);
}
/**
- * @brief Asking GNU Social server on a regular base for their user data
+ * Asking GNU Social server on a regular base for their user data
+ *
* @return void
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
*/
public static function discoverGsUsers()
{
- $requery_days = intval(Config::get("system", "poco_requery_days"));
+ $requery_days = intval(DI::config()->get('system', 'poco_requery_days'));
$last_update = date("c", time() - (60 * 60 * 24 * $requery_days));
$r = DBA::select('gserver', ['nurl', 'url'], [
'`network` = ?
- AND `last_contact` >= `last_failure`
+ AND NOT `failed`
AND `last_poco_query` < ?',
Protocol::OSTATUS,
$last_update
}
foreach ($r as $server) {
- self::fetchGsUsers($server["url"]);
- q("UPDATE `gserver` SET `last_poco_query` = '%s' WHERE `nurl` = '%s'", DBA::escape(DateTimeFormat::utcNow()), DBA::escape($server["nurl"]));
+ self::fetchGsUsers($server['url']);
+ DBA::update('gserver', ['last_poco_query' => DateTimeFormat::utcNow()], ['nurl' => $server['nurl']]);
}
}
public static function getRandomUrl()
{
$r = DBA::selectFirst('gcontact', ['url'], [
- '`network` = ?
- AND `last_contact` >= `last_failure`
+ '`network` = ?
+ AND NOT `failed`
AND `updated` > ?',
Protocol::DFRN,
DateTimeFormat::utc('now - 1 month'),