]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/GContact.php
Issue 8735: Ensure the correct data type for "hide"
[friendica.git] / src / Model / GContact.php
index 6dbd393f52aaa6515d80e3c8bec9f19f6ef06e76..fb4df9a63ae834d0bbab4dde8c0409859702a36f 100644 (file)
@@ -28,6 +28,7 @@ use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
 use Friendica\Core\System;
 use Friendica\Core\Search;
+use Friendica\Core\Worker;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Network\Probe;
@@ -42,6 +43,19 @@ use Friendica\Util\Strings;
  */
 class GContact
 {
+       /**
+        * No discovery of followers/followings
+        */
+       const DISCOVERY_NONE = 0;
+       /**
+        * Only discover followers/followings from direct contacts
+        */
+       const DISCOVERY_DIRECT = 1;
+       /**
+        * Recursive discovery of followers/followings
+        */
+       const DISCOVERY_RECURSIVE = 2;
+
        /**
         * Search global contact table by nick or name
         *
@@ -93,12 +107,13 @@ class GContact
 
                        // Ignore results that look strange.
                        // For historic reasons the gcontact table does contain some garbage.
-                       if (!empty($urlparts['query']) || !empty($urlparts['fragment'])) {
+                       if (empty($result['nurl']) || !empty($urlparts['query']) || !empty($urlparts['fragment'])) {
                                continue;
                        }
 
                        $gcontacts[] = Contact::getDetailsByURL($result['nurl'], local_user());
                }
+               DBA::close($results);
                return $gcontacts;
        }
 
@@ -549,6 +564,7 @@ class GContact
                                PortableContact::loadWorker(0, 0, 0, $base);
                        }
                }
+               DBA::close($contacts);
        }
 
        /**
@@ -611,11 +627,6 @@ class GContact
                        $contact['network'] = Protocol::OSTATUS;
                }
 
-               // All new contacts are hidden by default
-               if (!isset($contact['hide'])) {
-                       $contact['hide'] = true;
-               }
-
                // Remove unwanted parts from the contact url (e.g. '?zrl=...')
                if (in_array($contact['network'], Protocol::FEDERATED)) {
                        $contact['url'] = self::cleanContactUrl($contact['url']);
@@ -630,6 +641,7 @@ class GContact
                        $contact['location'] = $contact['location'] ?? '';
                        $contact['about'] = $contact['about'] ?? '';
                        $contact['generation'] = $contact['generation'] ?? 0;
+                       $contact['hide'] = $contact['hide'] ?? true;
 
                        $fields = ['name' => $contact['name'], 'nick' => $contact['nick'] ?? '', 'addr' => $contact['addr'] ?? '', 'network' => $contact['network'],
                                'url' => $contact['url'], 'nurl' => Strings::normaliseLink($contact['url']), 'photo' => $contact['photo'],
@@ -674,7 +686,7 @@ class GContact
                }
 
                $public_contact = DBA::selectFirst('gcontact', [
-                       'name', 'nick', 'photo', 'location', 'about', 'addr', 'generation', 'birthday', 'keywords',
+                       'name', 'nick', 'photo', 'location', 'about', 'addr', 'generation', 'birthday', 'keywords', 'gsid',
                        'contact-type', 'hide', 'nsfw', 'network', 'alias', 'notify', 'server_url', 'connect', 'updated', 'url'
                ], ['id' => $gcontact_id]);
 
@@ -736,6 +748,10 @@ class GContact
                        $contact['server_url'] = Strings::normaliseLink($contact['server_url']);
                }
 
+               if (!empty($contact['server_url']) && empty($contact['gsid'])) {
+                       $contact['gsid'] = GServer::getID($contact['server_url']);
+               }
+
                if (empty($contact['addr']) && !empty($contact['server_url']) && !empty($contact['nick'])) {
                        $hostname = str_replace('http://', '', $contact['server_url']);
                        $contact['addr'] = $contact['nick'] . '@' . $hostname;
@@ -775,7 +791,8 @@ class GContact
                                'notify' => $contact['notify'], 'url' => $contact['url'],
                                'location' => $contact['location'], 'about' => $contact['about'],
                                'generation' => $contact['generation'], 'updated' => $contact['updated'],
-                               'server_url' => $contact['server_url'], 'connect' => $contact['connect']
+                               'server_url' => $contact['server_url'], 'connect' => $contact['connect'],
+                               'gsid' => $contact['gsid']
                        ];
 
                        DBA::update('gcontact', $updated, $condition, $fields);
@@ -870,11 +887,11 @@ class GContact
                        $items = $outbox['orderedItems'];
                } elseif (!empty($outbox['first']['orderedItems'])) {
                        $items = $outbox['first']['orderedItems'];
-               } elseif (!empty($outbox['first']['href'])) {
+               } elseif (!empty($outbox['first']['href']) && ($outbox['first']['href'] != $feed)) {
                        self::updateFromOutbox($outbox['first']['href'], $data);
                        return;
                } elseif (!empty($outbox['first'])) {
-                       if (is_string($outbox['first'])) {
+                       if (is_string($outbox['first']) && ($outbox['first'] != $feed)) {
                                self::updateFromOutbox($outbox['first'], $data);
                        } else {
                                Logger::warning('Unexpected data', ['outbox' => $outbox]);
@@ -1000,7 +1017,7 @@ class GContact
                $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords',
                        'bd', 'contact-type', 'network', 'addr', 'notify', 'alias', 'archive', 'term-date',
                        'created', 'updated', 'avatar', 'success_update', 'failure_update', 'forum', 'prv',
-                       'baseurl', 'sensitive', 'unsearchable'];
+                       'baseurl', 'gsid', 'sensitive', 'unsearchable'];
 
                $contact = DBA::selectFirst('contact', $fields, array_merge($condition, ['uid' => 0, 'network' => Protocol::FEDERATED]));
                if (!DBA::isResult($contact)) {
@@ -1010,7 +1027,7 @@ class GContact
                $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords', 'generation',
                        'birthday', 'contact-type', 'network', 'addr', 'notify', 'alias', 'archived', 'archive_date',
                        'created', 'updated', 'photo', 'last_contact', 'last_failure', 'community', 'connect',
-                       'server_url', 'nsfw', 'hide', 'id'];
+                       'server_url', 'gsid', 'nsfw', 'hide', 'id'];
 
                $old_gcontact = DBA::selectFirst('gcontact', $fields, ['nurl' => $contact['nurl']]);
                $do_insert = !DBA::isResult($old_gcontact);
@@ -1021,7 +1038,7 @@ class GContact
                $gcontact = [];
 
                // These fields are identical in both contact and gcontact
-               $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords',
+               $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords', 'gsid',
                        'contact-type', 'network', 'addr', 'notify', 'alias', 'created', 'updated'];
 
                foreach ($fields as $field) {
@@ -1136,7 +1153,7 @@ class GContact
                                'keywords' => $userdata['pub_keywords'],
                                'birthday' => $userdata['dob'], 'photo' => $userdata['photo'],
                                "notify" => $userdata['notify'], 'url' => $userdata['url'],
-                               "hide" => ($userdata['hidewall'] || !$userdata['net-publish']),
+                               "hide" => !$userdata['net-publish'],
                                'nick' => $userdata['nickname'], 'addr' => $userdata['addr'],
                                "connect" => $userdata['addr'], "server_url" => DI::baseUrl(),
                                "generation" => 1, 'network' => Protocol::DFRN];
@@ -1275,6 +1292,129 @@ class GContact
                }
        }
 
+       /**
+        * Fetches the followers of a given profile and adds them
+        *
+        * @param string $url URL of a profile
+        * @return void
+        */
+       public static function discoverFollowers(string $url)
+       {
+               $gcontact = DBA::selectFirst('gcontact', ['id', 'last_discovery'], ['nurl' => Strings::normaliseLink(($url))]);
+               if (!DBA::isResult($gcontact)) {
+                       return;
+               }
+
+               if ($gcontact['last_discovery'] > DateTimeFormat::utc('now - 1 month')) {
+                       Logger::info('Last discovery was less then a month before.', ['url' => $url, 'discovery' => $gcontact['last_discovery']]);
+                       return;
+               }
+
+               $gcid = $gcontact['id'];
+
+               $apcontact = APContact::getByURL($url);
+
+               if (!empty($apcontact['followers']) && is_string($apcontact['followers'])) {
+                       $followers = ActivityPub::fetchItems($apcontact['followers']);
+               } else {
+                       $followers = [];
+               }
+
+               if (!empty($apcontact['following']) && is_string($apcontact['following'])) {
+                       $followings = ActivityPub::fetchItems($apcontact['following']);
+               } else {
+                       $followings = [];
+               }
+
+               if (!empty($followers) || !empty($followings)) {
+                       if (!empty($followers)) {
+                               // Clear the follower list, since it will be recreated in the next step
+                               DBA::update('gfollower', ['deleted' => true], ['gcid' => $gcid]);
+                       }
+
+                       $contacts = [];
+                       foreach (array_merge($followers, $followings) as $contact) {
+                               if (is_string($contact)) {
+                                       $contacts[] = $contact;
+                               } elseif (!empty($contact['url']) && is_string($contact['url'])) {
+                                       $contacts[] = $contact['url'];
+                               }
+                       }
+                       $contacts = array_unique($contacts);
+
+                       Logger::info('Discover AP contacts', ['url' => $url, 'contacts' => count($contacts)]);
+                       foreach ($contacts as $contact) {
+                               $gcontact = DBA::selectFirst('gcontact', ['id'], ['nurl' => Strings::normaliseLink(($contact))]);
+                               if (DBA::isResult($gcontact)) {
+                                       $fields = [];
+                                       if (in_array($contact, $followers)) {
+                                               $fields = ['gcid' => $gcid, 'follower-gcid' => $gcontact['id']];
+                                       } elseif (in_array($contact, $followings)) {
+                                               $fields = ['gcid' => $gcontact['id'], 'follower-gcid' => $gcid];
+                                       }
+
+                                       if (!empty($fields)) {
+                                               Logger::info('Set relation between contacts', $fields);
+                                               DBA::update('gfollower', ['deleted' => false], $fields, true);
+                                               continue;
+                                       }
+                               }
+
+                               if (!Network::isUrlBlocked($contact)) {
+                                       Logger::info('Discover new AP contact', ['url' => $contact]);
+                                       Worker::add(PRIORITY_LOW, 'UpdateGContact', $contact, 'nodiscover');
+                               } else {
+                                       Logger::info('No discovery, the URL is blocked.', ['url' => $contact]);
+                               }
+                       }
+                       if (!empty($followers)) {
+                               // Delete all followers that aren't undeleted
+                               DBA::delete('gfollower', ['gcid' => $gcid, 'deleted' => true]);
+                       }
+
+                       DBA::update('gcontact', ['last_discovery' => DateTimeFormat::utcNow()], ['id' => $gcid]);
+                       Logger::info('AP contacts discovery finished, last discovery set', ['url' => $url]);
+                       return;
+               }
+
+               $data = Probe::uri($url);
+               if (empty($data['poco'])) {
+                       return;
+               }
+
+               $curlResult = Network::curl($data['poco']);
+               if (!$curlResult->isSuccess()) {
+                       return;
+               }
+               $poco = json_decode($curlResult->getBody(), true);
+               if (empty($poco['entry'])) {
+                       return;
+               }
+
+               Logger::info('PoCo Discovery started', ['url' => $url, 'contacts' => count($poco['entry'])]);
+
+               foreach ($poco['entry'] as $entries) {
+                       if (!empty($entries['urls'])) {
+                               foreach ($entries['urls'] as $entry) {
+                                       if ($entry['type'] == 'profile') {
+                                               if (DBA::exists('gcontact', ['nurl' => Strings::normaliseLink(($entry['value']))])) {
+                                                       continue;
+                                               }
+                                               if (!Network::isUrlBlocked($entry['value'])) {
+                                                       Logger::info('Discover new PoCo contact', ['url' => $entry['value']]);
+                                                       Worker::add(PRIORITY_LOW, 'UpdateGContact', $entry['value'], 'nodiscover');
+                                               } else {
+                                                       Logger::info('No discovery, the URL is blocked.', ['url' => $entry['value']]);
+                                               }
+                                       }
+                               }
+                       }
+               }
+
+               DBA::update('gcontact', ['last_discovery' => DateTimeFormat::utcNow()], ['id' => $gcid]);
+               Logger::info('PoCo Discovery finished', ['url' => $url]);
+       }
+
        /**
         * Returns a random, global contact of the current node
         *