]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/Item.php
Merge branch 'friendica:develop' into 6606-k-alin-mysql-unix-socket
[friendica.git] / src / Model / Item.php
index 96cf5c488c35b1f9b599958bdd399876d0a20fd7..4a3b6ed580df7d732e4520ec0746b10bdd15c9ec 100644 (file)
@@ -74,6 +74,11 @@ class Item
        const PR_RELAY = 74;
        const PR_FETCHED = 75;
 
+       // system.accept_only_sharer setting values
+       const COMPLETION_NONE    = 1;
+       const COMPLETION_COMMENT = 0;
+       const COMPLETION_LIKE    = 2;
+
        // Field list that is used to display the items
        const DISPLAY_FIELDLIST = [
                'uid', 'id', 'parent', 'guid', 'network', 'gravity',
@@ -1231,8 +1236,11 @@ class Item
                        return;
                }
 
+               $self_contact = Contact::selectFirst(['id'], ['uid' => $item['uid'], 'self' => true]);
+               $self = !empty($self_contact) ? $self_contact['id'] : 0;
+               
                $cid = Contact::getIdForURL($author['url'], $item['uid']);
-               if (empty($cid) || !Contact::isSharing($cid, $item['uid'])) {
+               if (empty($cid) || (!Contact::isSharing($cid, $item['uid']) && ($cid != $self))) {
                        Logger::info('The resharer is not a following contact: quit', ['resharer' => $author['url'], 'uid' => $item['uid'], 'cid' => $cid]);
                        return;
                }
@@ -1403,7 +1411,7 @@ class Item
                $is_reshare = ($item['gravity'] == GRAVITY_ACTIVITY) && ($item['verb'] == Activity::ANNOUNCE);
 
                if ((($item['gravity'] == GRAVITY_PARENT) || $is_reshare) &&
-                       DI::pConfig()->get($uid, 'system', 'accept_only_sharer') &&
+                       DI::pConfig()->get($uid, 'system', 'accept_only_sharer') == self::COMPLETION_NONE &&
                        !Contact::isSharingByURL($item['author-link'], $uid) &&
                        !Contact::isSharingByURL($item['owner-link'], $uid)) {
                        Logger::info('Contact is not a follower, thread will not be stored', ['author' => $item['author-link'], 'uid' => $uid]);
@@ -1442,26 +1450,36 @@ class Item
                }
 
                $post = Post::selectFirst(['uid', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'private'], ['uri-id' => $uriid, 'origin' => true]);
-               if (empty($post)) {
-                       if (Post::exists(['uri-id' => $uriid, 'uid' => 0])) {
-                               return 0;
-                       } else {
+               if (!empty($post)) {
+                       if (in_array($post['private'], [Item::PUBLIC, Item::UNLISTED])) {
+                               return $post['uid'];
+                       }
+
+                       $pcid = Contact::getPublicIdByUserId($uid);
+                       if (empty($pcid)) {
                                return null;
                        }
-               }
 
-               if (in_array($post['private'], [Item::PUBLIC, Item::UNLISTED])) {
-                       return $post['uid'];
-               }
+                       foreach (Item::enumeratePermissions($post, true) as $receiver) {
+                               if ($receiver == $pcid) {
+                                       return $post['uid'];
+                               }
+                       }
 
-               $pcid = Contact::getPublicIdByUserId($uid);
-               if (empty($pcid)) {
                        return null;
                }
 
-               foreach (Item::enumeratePermissions($post, true) as $receiver) {
-                       if ($receiver == $pcid) {
-                               return $post['uid'];
+               if (Post::exists(['uri-id' => $uriid, 'uid' => 0])) {
+                       return 0;
+               }
+
+               // When the post belongs to a a forum then all forum users are allowed to access it
+               foreach (Tag::getByURIId($uriid, [Tag::MENTION, Tag::EXCLUSIVE_MENTION]) as $tag) {
+                       if (DBA::exists('contact', ['uid' => $uid, 'nurl' => Strings::normaliseLink($tag['url']), 'contact-type' => Contact::TYPE_COMMUNITY])) {
+                               $target_uid = User::getIdForURL($tag['url']);
+                               if (!empty($target_uid)) {
+                                       return $target_uid;
+                               }
                        }
                }
 
@@ -1930,7 +1948,7 @@ class Item
 
                $owner = User::getOwnerDataById($uid);
                if (!DBA::isResult($owner)) {
-                       Logger::warning('User not found, quitting.', ['uid' => $uid]);
+                       Logger::warning('User not found, quitting here.', ['uid' => $uid]);
                        return false;
                }
 
@@ -1939,55 +1957,50 @@ class Item
                        return false;
                }
 
-               $item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id]);
+               $item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id, 'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT], 'origin' => false]);
                if (!DBA::isResult($item)) {
-                       Logger::warning('Post not found, quitting.', ['id' => $item_id]);
+                       Logger::debug('Post is an activity or origin or not found at all, quitting here.', ['id' => $item_id]);
                        return false;
                }
 
-               if ($item['wall'] || $item['origin'] || ($item['gravity'] != GRAVITY_PARENT)) {
-                       Logger::debug('Wall item, origin item or no parent post, quitting here.', ['wall' => $item['wall'], 'origin' => $item['origin'], 'gravity' => $item['gravity'], 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
-                       return false;
-               }
+               if ($item['gravity'] == GRAVITY_PARENT) {
+                       $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
+                       foreach ($tags as $tag) {
+                               if (Strings::compareLink($owner['url'], $tag['url'])) {
+                                       $mention = true;
+                                       Logger::info('Mention found in tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+                               }
+                       }
 
-               $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
-               foreach ($tags as $tag) {
-                       if (Strings::compareLink($owner['url'], $tag['url'])) {
-                               $mention = true;
-                               Logger::info('Mention found in tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+                       if (!$mention) {
+                               Logger::info('Top-level post without mention is deleted.', ['uri' => $item['uri'], $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+                               Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
+                               return true;
                        }
-               }
 
-               // This check can most likely be removed since we always are having the tags
-               if (!$mention) {
-                       $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER);
-                       if ($cnt) {
-                               foreach ($matches as $mtch) {
-                                       if (Strings::compareLink($owner['url'], $mtch[1])) {
-                                               $mention = true;
-                                               Logger::notice('Mention found in body.', ['mention' => $mtch[2], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
-                                       }
+                       $arr = ['item' => $item, 'user' => $owner];
+
+                       Hook::callAll('tagged', $arr);
+               } else {
+                       $tags = Tag::getByURIId($item['parent-uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
+                       foreach ($tags as $tag) {
+                               if (Strings::compareLink($owner['url'], $tag['url'])) {
+                                       $mention = true;
+                                       Logger::info('Mention found in parent tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
                                }
                        }
-               }
 
-               if (!$mention) {
-                       Logger::info('Top-level post without mention is deleted.', ['uri' => $item['uri'], $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
-                       Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
-                       return true;
+                       if (!$mention) {
+                               Logger::debug('No mentions found in parent, quitting here.', ['id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+                               return false;
+                       }
                }
 
-               $arr = ['item' => $item, 'user' => $owner];
-
-               Hook::callAll('tagged', $arr);
-
                Logger::info('Community post will be distributed', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
 
                if ($owner['page-flags'] == User::PAGE_FLAGS_PRVGROUP) {
-                       Group::getMembersForForum($owner['id']);
-
-                       $allow_cid = '<' . $owner['id'] . '>';
-                       $allow_gid = '<' . Group::getIdForForum($owner['id']) . '>';
+                       $allow_cid = '';
+                       $allow_gid = '<' . Group::FOLLOWERS . '>';
                        $deny_cid  = '';
                        $deny_gid  = '';
                        self::performActivity($item['id'], 'announce', $uid, $allow_cid, $allow_gid, $deny_cid, $deny_gid);
@@ -3200,30 +3213,20 @@ class Item
        }
 
        /**
-        * Is the given item array a post that is sent as starting post to a forum?
+        * Does the given uri-id belongs to a post that is sent as starting post to a forum?
         *
-        * @param array $item
-        * @param array $owner
+        * @param int $uri_id
         *
         * @return boolean "true" when it is a forum post
         */
-       public static function isForumPost(array $item, array $owner = [])
+       public static function isForumPost(int $uri_id)
        {
-               if (empty($owner)) {
-                       $owner = User::getOwnerDataById($item['uid']);
-                       if (empty($owner)) {
-                               return false;
+               foreach (Tag::getByURIId($uri_id, [Tag::EXCLUSIVE_MENTION]) as $tag) {
+                       if (DBA::exists('contact', ['uid' => 0, 'nurl' => Strings::normaliseLink($tag['url']), 'contact-type' => Contact::TYPE_COMMUNITY])) {
+                               return true;
                        }
                }
-
-               if (($item['author-id'] == $item['owner-id']) ||
-                       ($owner['id'] == $item['contact-id']) ||
-                       ($item['uri-id'] != $item['parent-uri-id']) ||
-                       $item['origin']) {
-                       return false;
-               }
-
-               return Contact::isForum($item['contact-id']);
+               return false;
        }
 
        /**