const PR_RELAY = 74;
const PR_FETCHED = 75;
+ // system.accept_only_sharer setting values
+ const COMPLETION_NONE = 1;
+ const COMPLETION_COMMENT = 0;
+ const COMPLETION_LIKE = 2;
+
// Field list that is used to display the items
const DISPLAY_FIELDLIST = [
'uid', 'id', 'parent', 'guid', 'network', 'gravity',
'inform', 'deleted', 'extid', 'post-type', 'post-reason', 'gravity',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid',
'author-id', 'author-link', 'author-name', 'author-avatar', 'owner-id', 'owner-link', 'contact-uid',
- 'signed_text', 'network', 'wall', 'contact-id', 'plink', 'forum_mode', 'origin',
+ 'signed_text', 'network', 'wall', 'contact-id', 'plink', 'origin',
'thr-parent-id', 'parent-uri-id', 'postopts', 'pubmail',
'event-created', 'event-edited', 'event-start', 'event-finish',
'event-summary', 'event-desc', 'event-location', 'event-type',
'postopts', 'plink', 'resource-id', 'event-id', 'inform',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'post-type', 'post-reason',
'private', 'pubmail', 'visible', 'starred',
- 'unseen', 'deleted', 'origin', 'forum_mode', 'mention', 'global', 'network',
+ 'unseen', 'deleted', 'origin', 'mention', 'global', 'network',
'title', 'content-warning', 'body', 'location', 'coord', 'app',
'rendered-hash', 'rendered-html', 'object-type', 'object', 'target-type', 'target',
'author-id', 'author-link', 'author-name', 'author-avatar', 'author-network',
$fields = ['uid', 'uri', 'parent-uri', 'id', 'deleted',
'uri-id', 'parent-uri-id',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid',
- 'wall', 'private', 'forum_mode', 'origin', 'author-id'];
+ 'wall', 'private', 'origin', 'author-id'];
$condition = ['uri-id' => $item['thr-parent-id'], 'uid' => $item['uid']];
$params = ['order' => ['id' => false]];
$parent = Post::selectFirst($fields, $condition, $params);
$item['inform'] = trim($item['inform'] ?? '');
$item['file'] = trim($item['file'] ?? '');
+ // Communities aren't working with the Diaspora protoccol
+ if (($uid != 0) && ($item['network'] == Protocol::DIASPORA)) {
+ $user = User::getById($uid, ['account-type']);
+ if ($user['account-type'] == Contact::TYPE_COMMUNITY) {
+ Logger::info('Community posts are not supported via Diaspora');
+ return 0;
+ }
+ }
+
// Items cannot be stored before they happen ...
if ($item['created'] > DateTimeFormat::utcNow()) {
$item['created'] = DateTimeFormat::utcNow();
$item['parent-uri'] = $toplevel_parent['uri'];
$item['parent-uri-id'] = $toplevel_parent['uri-id'];
$item['deleted'] = $toplevel_parent['deleted'];
- $item['allow_cid'] = $toplevel_parent['allow_cid'];
- $item['allow_gid'] = $toplevel_parent['allow_gid'];
- $item['deny_cid'] = $toplevel_parent['deny_cid'];
- $item['deny_gid'] = $toplevel_parent['deny_gid'];
+
+ // Reshares have to keep their permissions to allow forums to work
+ if (!$item['origin'] || ($item['verb'] != Activity::ANNOUNCE)) {
+ $item['allow_cid'] = $toplevel_parent['allow_cid'];
+ $item['allow_gid'] = $toplevel_parent['allow_gid'];
+ $item['deny_cid'] = $toplevel_parent['deny_cid'];
+ $item['deny_gid'] = $toplevel_parent['deny_gid'];
+ }
+
$parent_origin = $toplevel_parent['origin'];
// Don't federate received participation messages
$item['private'] = $toplevel_parent['private'];
}
- /*
- * Edge case. We host a public forum that was originally posted to privately.
- * The original author commented, but as this is a comment, the permissions
- * weren't fixed up so it will still show the comment as private unless we fix it here.
- */
- if ((intval($toplevel_parent['forum_mode']) == 1) && ($toplevel_parent['private'] != self::PUBLIC)) {
- $item['private'] = self::PUBLIC;
- }
-
// If its a post that originated here then tag the thread as "mention"
if ($item['origin'] && $item['uid']) {
DBA::update('post-thread-user', ['mention' => true], ['uri-id' => $item['parent-uri-id'], 'uid' => $item['uid']]);
return;
}
+ $self_contact = Contact::selectFirst(['id'], ['uid' => $item['uid'], 'self' => true]);
+ $self = !empty($self_contact) ? $self_contact['id'] : 0;
+
$cid = Contact::getIdForURL($author['url'], $item['uid']);
- if (empty($cid) || !Contact::isSharing($cid, $item['uid'])) {
+ if (empty($cid) || (!Contact::isSharing($cid, $item['uid']) && ($cid != $self))) {
Logger::info('The resharer is not a following contact: quit', ['resharer' => $author['url'], 'uid' => $item['uid'], 'cid' => $cid]);
return;
}
$is_reshare = ($item['gravity'] == GRAVITY_ACTIVITY) && ($item['verb'] == Activity::ANNOUNCE);
if ((($item['gravity'] == GRAVITY_PARENT) || $is_reshare) &&
- DI::pConfig()->get($uid, 'system', 'accept_only_sharer') &&
+ DI::pConfig()->get($uid, 'system', 'accept_only_sharer') == self::COMPLETION_NONE &&
!Contact::isSharingByURL($item['author-link'], $uid) &&
!Contact::isSharingByURL($item['owner-link'], $uid)) {
Logger::info('Contact is not a follower, thread will not be stored', ['author' => $item['author-link'], 'uid' => $uid]);
}
if ((($item['gravity'] == GRAVITY_COMMENT) || $is_reshare) && !Post::exists(['uri-id' => $item['thr-parent-id'], 'uid' => $uid])) {
- // Only do an auto complete with the source uid "0" to prevent privavy problems
+ // Fetch the origin user for the post
+ $origin_uid = self::GetOriginUidForUriId($item['thr-parent-id'], $uid);
+ if (is_null($origin_uid)) {
+ Logger::info('Origin item was not found', ['uid' => $uid, 'uri-id' => $item['thr-parent-id']]);
+ return 0;
+ }
+
$causer = $item['causer-id'] ?: $item['author-id'];
- $result = self::storeForUserByUriId($item['thr-parent-id'], $uid, ['causer-id' => $causer, 'post-reason' => self::PR_FETCHED]);
+ $result = self::storeForUserByUriId($item['thr-parent-id'], $uid, ['causer-id' => $causer, 'post-reason' => self::PR_FETCHED], $origin_uid);
Logger::info('Fetched thread parent', ['uri-id' => $item['thr-parent-id'], 'uid' => $uid, 'causer' => $causer, 'result' => $result]);
}
return $stored;
}
+ /**
+ * Returns the origin uid of a post if the given user is allowed to see it.
+ *
+ * @param int $uriid
+ * @param int $uid
+ * @return int
+ */
+ private static function GetOriginUidForUriId(int $uriid, int $uid)
+ {
+ if (Post::exists(['uri-id' => $uriid, 'uid' => $uid])) {
+ return $uid;
+ }
+
+ $post = Post::selectFirst(['uid', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'private'], ['uri-id' => $uriid, 'origin' => true]);
+ if (!empty($post)) {
+ if (in_array($post['private'], [Item::PUBLIC, Item::UNLISTED])) {
+ return $post['uid'];
+ }
+
+ $pcid = Contact::getPublicIdByUserId($uid);
+ if (empty($pcid)) {
+ return null;
+ }
+
+ foreach (Item::enumeratePermissions($post, true) as $receiver) {
+ if ($receiver == $pcid) {
+ return $post['uid'];
+ }
+ }
+
+ return null;
+ }
+
+ if (Post::exists(['uri-id' => $uriid, 'uid' => 0])) {
+ return 0;
+ }
+
+ // When the post belongs to a a forum then all forum users are allowed to access it
+ foreach (Tag::getByURIId($uriid, [Tag::MENTION, Tag::EXCLUSIVE_MENTION]) as $tag) {
+ if (DBA::exists('contact', ['uid' => $uid, 'nurl' => Strings::normaliseLink($tag['url']), 'contact-type' => Contact::TYPE_COMMUNITY])) {
+ $target_uid = User::getIdForURL($tag['url']);
+ if (!empty($target_uid)) {
+ return $target_uid;
+ }
+ }
+ }
+
+ return null;
+ }
+
/**
* Store a public item array for the given users
*
return 0;
}
+ // Data from the "post-user" table
unset($item['id']);
unset($item['mention']);
unset($item['starred']);
unset($item['pinned']);
unset($item['ignored']);
unset($item['pubmail']);
- unset($item['forum_mode']);
-
unset($item['event-id']);
unset($item['hidden']);
unset($item['notification-type']);
+ unset($item['post-reason']);
+
+ // Data from the "post-delivery-data" table
+ unset($item['postopts']);
+ unset($item['inform']);
$item['uid'] = $uid;
$item['origin'] = 0;
$owner = User::getOwnerDataById($uid);
if (!DBA::isResult($owner)) {
- Logger::warning('User not found, quitting.', ['uid' => $uid]);
+ Logger::warning('User not found, quitting here.', ['uid' => $uid]);
return false;
}
return false;
}
- $item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id]);
+ $item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id, 'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT], 'origin' => false]);
if (!DBA::isResult($item)) {
- Logger::warning('Post not found, quitting.', ['id' => $item_id]);
+ Logger::debug('Post is an activity or origin or not found at all, quitting here.', ['id' => $item_id]);
return false;
}
- if ($item['wall'] || $item['origin'] || ($item['gravity'] != GRAVITY_PARENT)) {
- Logger::debug('Wall item, origin item or no parent post, quitting here.', ['wall' => $item['wall'], 'origin' => $item['origin'], 'gravity' => $item['gravity'], 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- return false;
- }
+ if ($item['gravity'] == GRAVITY_PARENT) {
+ $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
+ foreach ($tags as $tag) {
+ if (Strings::compareLink($owner['url'], $tag['url'])) {
+ $mention = true;
+ Logger::info('Mention found in tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ }
+ }
- $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
- foreach ($tags as $tag) {
- if (Strings::compareLink($owner['url'], $tag['url'])) {
- $mention = true;
- Logger::info('Mention found in tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ if (!$mention) {
+ Logger::info('Top-level post without mention is deleted.', ['uri' => $item['uri'], $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
+ return true;
}
- }
- // This check can most likely be removed since we always are having the tags
- if (!$mention) {
- $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER);
- if ($cnt) {
- foreach ($matches as $mtch) {
- if (Strings::compareLink($owner['url'], $mtch[1])) {
- $mention = true;
- Logger::notice('Mention found in body.', ['mention' => $mtch[2], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- }
+ $arr = ['item' => $item, 'user' => $owner];
+
+ Hook::callAll('tagged', $arr);
+ } else {
+ $tags = Tag::getByURIId($item['parent-uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
+ foreach ($tags as $tag) {
+ if (Strings::compareLink($owner['url'], $tag['url'])) {
+ $mention = true;
+ Logger::info('Mention found in parent tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
}
}
- }
- if (!$mention) {
- Logger::info('Top-level post without mention is deleted.', ['uri' => $item['uri'], $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
- return true;
+ if (!$mention) {
+ Logger::debug('No mentions found in parent, quitting here.', ['id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ return false;
+ }
}
- $arr = ['item' => $item, 'user' => $owner];
-
- Hook::callAll('tagged', $arr);
-
Logger::info('Community post will be distributed', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- self::performActivity($item['id'], 'announce', $uid);
-
- /**
- * All the following lines are only needed for private forums and compatibility to older systems without AP support.
- * A possible way would be that the followers list of a forum would always be readable by all followers.
- * So this would mean that the comment distribution could be done exactly for the intended audience.
- * Or possibly we could store the receivers that had been in the "announce" message above and use this.
- */
-
- // also reset all the privacy bits to the forum default permissions
- if ($owner['allow_cid'] || $owner['allow_gid'] || $owner['deny_cid'] || $owner['deny_gid']) {
- $private = self::PRIVATE;
- } elseif (DI::pConfig()->get($owner['uid'], 'system', 'unlisted')) {
- $private = self::UNLISTED;
+ if ($owner['page-flags'] == User::PAGE_FLAGS_PRVGROUP) {
+ $allow_cid = '';
+ $allow_gid = '<' . Group::FOLLOWERS . '>';
+ $deny_cid = '';
+ $deny_gid = '';
+ self::performActivity($item['id'], 'announce', $uid, $allow_cid, $allow_gid, $deny_cid, $deny_gid);
} else {
- $private = self::PUBLIC;
+ self::performActivity($item['id'], 'announce', $uid);
}
- $permissionSet = DI::permissionSet()->selectOrCreate(
- DI::permissionSetFactory()->createFromString(
- $owner['uid'],
- $owner['allow_cid'],
- $owner['allow_gid'],
- $owner['deny_cid'],
- $owner['deny_gid']
- ));
-
- $forum_mode = ($owner['page-flags'] == User::PAGE_FLAGS_PRVGROUP) ? 2 : 1;
-
- $fields = ['wall' => true, 'origin' => true, 'forum_mode' => $forum_mode, 'contact-id' => $owner['id'],
- 'owner-id' => Contact::getPublicIdByUserId($uid), 'private' => $private, 'psid' => $permissionSet->id];
- self::update($fields, ['id' => $item['id']]);
-
- Worker::add(['priority' => PRIORITY_HIGH, 'dont_fork' => true], 'Notifier', Delivery::POST, (int)$item['uri-id'], (int)$item['uid']);
-
Logger::info('Community post had been distributed', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
return false;
}
*
* Toggle activities as like,dislike,attend of an item
*
- * @param int $item_id
+ * @param int $item_id
* @param string $verb
* Activity verb. One of
* like, unlike, dislike, undislike, attendyes, unattendyes,
* attendno, unattendno, attendmaybe, unattendmaybe,
* announce, unannouce
+ * @param int $uid
+ * @param string $allow_cid
+ * @param string $allow_gid
+ * @param string $deny_cid
+ * @param string $deny_gid
* @return bool
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
* array $arr
* 'post_id' => ID of posted item
*/
- public static function performActivity(int $item_id, string $verb, int $uid)
+ public static function performActivity(int $item_id, string $verb, int $uid, string $allow_cid = null, string $allow_gid = null, string $deny_cid = null, string $deny_gid = null)
{
if (empty($uid)) {
return false;
'body' => $activity,
'verb' => $activity,
'object-type' => $objtype,
- 'allow_cid' => $item['allow_cid'],
- 'allow_gid' => $item['allow_gid'],
- 'deny_cid' => $item['deny_cid'],
- 'deny_gid' => $item['deny_gid'],
+ 'allow_cid' => $allow_cid ?? $item['allow_cid'],
+ 'allow_gid' => $allow_gid ?? $item['allow_gid'],
+ 'deny_cid' => $deny_cid ?? $item['deny_cid'],
+ 'deny_gid' => $deny_gid ?? $item['deny_gid'],
'visible' => 1,
'unseen' => 1,
];
}
/**
- * Is the given item array a post that is sent as starting post to a forum?
+ * Does the given uri-id belongs to a post that is sent as starting post to a forum?
*
- * @param array $item
- * @param array $owner
+ * @param int $uri_id
*
* @return boolean "true" when it is a forum post
*/
- public static function isForumPost(array $item, array $owner = [])
+ public static function isForumPost(int $uri_id)
{
- if (empty($owner)) {
- $owner = User::getOwnerDataById($item['uid']);
- if (empty($owner)) {
- return false;
+ foreach (Tag::getByURIId($uri_id, [Tag::EXCLUSIVE_MENTION]) as $tag) {
+ if (DBA::exists('contact', ['uid' => 0, 'nurl' => Strings::normaliseLink($tag['url']), 'contact-type' => Contact::TYPE_COMMUNITY])) {
+ return true;
}
}
-
- if (($item['author-id'] == $item['owner-id']) ||
- ($owner['id'] == $item['contact-id']) ||
- ($item['uri-id'] != $item['parent-uri-id']) ||
- $item['origin']) {
- return false;
- }
-
- return Contact::isForum($item['contact-id']);
+ return false;
}
/**