]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/Item.php
Post update script to move old content from the item table
[friendica.git] / src / Model / Item.php
index 5fe03a81b6d661fe792a3d633cf4f6cb96260a13..57090da4cb2b5bb2d0eab457823c59726204e2df 100644 (file)
@@ -117,6 +117,16 @@ class Item extends BaseObject
                        }
                }
 
+               // Build the tag string out of the term entries
+               if (isset($row['id']) && array_key_exists('tag', $row)) {
+                       $row['tag'] = Term::tagTextFromItemId($row['id']);
+               }
+
+               // Build the file string out of the term entries
+               if (isset($row['id']) && array_key_exists('file', $row)) {
+                       $row['file'] = Term::fileTextFromItemId($row['id']);
+               }
+
                // We can always comment on posts from these networks
                if (isset($row['writable']) && !empty($row['network']) &&
                        in_array($row['network'], [NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS])) {
@@ -525,6 +535,16 @@ class Item extends BaseObject
         */
        private static function constructSelectFields($fields, $selected)
        {
+               // To be able to fetch the tags we need the item id
+               if (in_array('tag', $selected) && !in_array('id', $selected)) {
+                       $selected[] = 'id';
+               }
+
+               // To be able to fetch the files we need the item id
+               if (in_array('file', $selected) && !in_array('id', $selected)) {
+                       $selected[] = 'id';
+               }
+
                $selection = [];
                foreach ($fields as $table => $table_fields) {
                        foreach ($table_fields as $field => $select) {
@@ -594,7 +614,7 @@ class Item extends BaseObject
                // We cannot simply expand the condition to check for origin entries
                // The condition needn't to be a simple array but could be a complex condition.
                // And we have to execute this query before the update to ensure to fetch the same data.
-               $items = dba::select('item', ['id', 'origin', 'uri', 'plink'], $condition);
+               $items = dba::select('item', ['id', 'origin', 'uri', 'plink', 'icid'], $condition);
 
                $content_fields = [];
                foreach (array_merge(self::CONTENT_FIELDLIST, self::MIXED_CONTENT_FIELDLIST) as $field) {
@@ -604,6 +624,20 @@ class Item extends BaseObject
                        }
                }
 
+               if (array_key_exists('tag', $fields)) {
+                       $tags = $fields['tag'];
+                       unset($fields['tag']);
+               } else {
+                       $tags = '';
+               }
+
+               if (array_key_exists('file', $fields)) {
+                       $files = $fields['file'];
+                       unset($fields['file']);
+               } else {
+                       $files = '';
+               }
+
                if (!empty($fields)) {
                        $success = dba::update('item', $fields, $condition);
 
@@ -622,8 +656,29 @@ class Item extends BaseObject
                                $content_fields['plink'] =  $item['plink'];
                        }
                        self::updateContent($content_fields, ['uri' => $item['uri']]);
-                       Term::insertFromTagFieldByItemId($item['id']);
-                       Term::insertFromFileFieldByItemId($item['id']);
+
+                       if (empty($item['icid'])) {
+                               $item_content = dba::selectFirst('item-content', [], ['uri' => $item['uri']]);
+                               if (DBM::is_result($item_content)) {
+                                       $item_fields = ['icid' => $item_content['id']];
+                                       // Clear all fields in the item table that have a content in the item-content table
+                                       foreach ($item_content as $field => $content) {
+                                               if (in_array($field, self::MIXED_CONTENT_FIELDLIST) && !empty($item_content[$field])) {
+                                                       $item_fields[$field] = '';
+                                               }
+                                       }
+                                       dba::update('item', $item_fields, ['id' => $item['id']]);
+                               }
+                       }
+
+                       if (!empty($tags)) {
+                               Term::insertFromTagFieldByItemId($item['id'], $tags);
+                       }
+
+                       if (!empty($files)) {
+                               Term::insertFromFileFieldByItemId($item['id'], $files);
+                       }
+
                        self::updateThread($item['id']);
 
                        // We only need to notfiy others when it is an original entry from us.
@@ -693,7 +748,7 @@ class Item extends BaseObject
                $fields = ['id', 'uri', 'uid', 'parent', 'parent-uri', 'origin',
                        'deleted', 'file', 'resource-id', 'event-id', 'attach',
                        'verb', 'object-type', 'object', 'target', 'contact-id'];
-               $item = dba::selectFirst('item', $fields, ['id' => $item_id]);
+               $item = self::selectFirst($fields, ['id' => $item_id]);
                if (!DBM::is_result($item)) {
                        logger('Item with ID ' . $item_id . " hasn't been found.", LOGGER_DEBUG);
                        return false;
@@ -704,7 +759,7 @@ class Item extends BaseObject
                        return false;
                }
 
-               $parent = dba::selectFirst('item', ['origin'], ['id' => $item['parent']]);
+               $parent = self::selectFirst(['origin'], ['id' => $item['parent']]);
                if (!DBM::is_result($parent)) {
                        $parent = ['origin' => false];
                }
@@ -760,8 +815,8 @@ class Item extends BaseObject
                        'object' => '', 'target' => '', 'tag' => '', 'postopts' => '', 'attach' => '', 'file' => ''];
                dba::update('item', $item_fields, ['id' => $item['id']]);
 
-               Term::insertFromTagFieldByItemId($item['id']);
-               Term::insertFromFileFieldByItemId($item['id']);
+               Term::insertFromTagFieldByItemId($item['id'], '');
+               Term::insertFromFileFieldByItemId($item['id'], '');
                self::deleteThread($item['id'], $item['parent-uri']);
 
                if (!self::exists(["`uri` = ? AND `uid` != 0 AND NOT `deleted`", $item['uri']])) {
@@ -784,7 +839,7 @@ class Item extends BaseObject
                } elseif ($item['uid'] != 0) {
 
                        // When we delete just our local user copy of an item, we have to set a marker to hide it
-                       $global_item = dba::selectFirst('item', ['id'], ['uri' => $item['uri'], 'uid' => 0, 'deleted' => false]);
+                       $global_item = self::selectFirst(['id'], ['uri' => $item['uri'], 'uid' => 0, 'deleted' => false]);
                        if (DBM::is_result($global_item)) {
                                dba::update('user-item', ['hidden' => true], ['iid' => $global_item['id'], 'uid' => $item['uid']], true);
                        }
@@ -808,7 +863,7 @@ class Item extends BaseObject
                        return;
                }
 
-               $i = dba::selectFirst('item', ['id', 'contact-id', 'tag'], ['uri' => $xt->id, 'uid' => $item['uid']]);
+               $i = self::selectFirst(['id', 'contact-id', 'tag'], ['uri' => $xt->id, 'uid' => $item['uid']]);
                if (!DBM::is_result($i)) {
                        return;
                }
@@ -1024,7 +1079,7 @@ class Item extends BaseObject
                        $condition = ["`uri` = ? AND `uid` = ? AND `network` IN (?, ?, ?)",
                                trim($item['uri']), $item['uid'],
                                NETWORK_DIASPORA, NETWORK_DFRN, NETWORK_OSTATUS];
-                       $existing = dba::selectFirst('item', ['id', 'network'], $condition);
+                       $existing = self::selectFirst(['id', 'network'], $condition);
                        if (DBM::is_result($existing)) {
                                // We only log the entries with a different user id than 0. Otherwise we would have too many false positives
                                if ($uid != 0) {
@@ -1181,7 +1236,7 @@ class Item extends BaseObject
                                'wall', 'private', 'forum_mode', 'origin'];
                        $condition = ['uri' => $item['parent-uri'], 'uid' => $item['uid']];
                        $params = ['order' => ['id' => false]];
-                       $parent = dba::selectFirst('item', $fields, $condition, $params);
+                       $parent = self::selectFirst($fields, $condition, $params);
 
                        if (DBM::is_result($parent)) {
                                // is the new message multi-level threaded?
@@ -1195,7 +1250,7 @@ class Item extends BaseObject
                                                'parent-uri' => $item['parent-uri'],
                                                'uid' => $item['uid']];
                                        $params = ['order' => ['id' => false]];
-                                       $toplevel_parent = dba::selectFirst('item', $fields, $condition, $params);
+                                       $toplevel_parent = self::selectFirst($fields, $condition, $params);
 
                                        if (DBM::is_result($toplevel_parent)) {
                                                $parent = $toplevel_parent;
@@ -1340,6 +1395,20 @@ class Item extends BaseObject
 
                logger('' . print_r($item,true), LOGGER_DATA);
 
+               if (array_key_exists('tag', $item)) {
+                       $tags = $item['tag'];
+                       unset($item['tag']);
+               } else {
+                       $tags = '';
+               }
+
+               if (array_key_exists('file', $item)) {
+                       $files = $item['file'];
+                       unset($item['file']);
+               } else {
+                       $files = '';
+               }
+
                // We are doing this outside of the transaction to avoid timing problems
                self::insertContent($item);
 
@@ -1447,7 +1516,7 @@ class Item extends BaseObject
                 * in it.
                 */
                if (!$deleted && !$dontcache) {
-                       $posted_item = dba::selectFirst('item', [], ['id' => $current_post]);
+                       $posted_item = self::selectFirst(self::ITEM_FIELDLIST, ['id' => $current_post]);
                        if (DBM::is_result($posted_item)) {
                                if ($notify) {
                                        Addon::callHooks('post_local_end', $posted_item);
@@ -1471,8 +1540,13 @@ class Item extends BaseObject
                 * Due to deadlock issues with the "term" table we are doing these steps after the commit.
                 * This is not perfect - but a workable solution until we found the reason for the problem.
                 */
-               Term::insertFromTagFieldByItemId($current_post);
-               Term::insertFromFileFieldByItemId($current_post);
+               if (!empty($tags)) {
+                       Term::insertFromTagFieldByItemId($current_post, $tags);
+               }
+
+               if (!empty($files)) {
+                       Term::insertFromFileFieldByItemId($current_post, $files);
+               }
 
                if ($item['parent-uri'] === $item['uri']) {
                        self::addShadow($current_post);
@@ -1590,7 +1664,7 @@ class Item extends BaseObject
        public static function distribute($itemid, $signed_text = '')
        {
                $condition = ["`id` IN (SELECT `parent` FROM `item` WHERE `id` = ?)", $itemid];
-               $parent = dba::selectFirst('item', ['owner-id'], $condition);
+               $parent = self::selectFirst(['owner-id'], $condition);
                if (!DBM::is_result($parent)) {
                        return;
                }
@@ -1623,7 +1697,7 @@ class Item extends BaseObject
                $origin_uid = 0;
 
                if ($item['uri'] != $item['parent-uri']) {
-                       $parents = dba::select('item', ['uid', 'origin'], ["`uri` = ? AND `uid` != 0", $item['parent-uri']]);
+                       $parents = self::select(['uid', 'origin'], ["`uri` = ? AND `uid` != 0", $item['parent-uri']]);
                        while ($parent = dba::fetch($parents)) {
                                $users[$parent['uid']] = $parent['uid'];
                                if ($parent['origin'] && !$item['origin']) {
@@ -1702,9 +1776,9 @@ class Item extends BaseObject
         */
        public static function addShadow($itemid)
        {
-               $fields = ['uid', 'private', 'moderated', 'visible', 'deleted', 'network'];
+               $fields = ['uid', 'private', 'moderated', 'visible', 'deleted', 'network', 'uri'];
                $condition = ['id' => $itemid, 'parent' => [0, $itemid]];
-               $item = dba::selectFirst('item', $fields, $condition);
+               $item = self::selectFirst($fields, $condition);
 
                if (!DBM::is_result($item)) {
                        return;
@@ -1725,36 +1799,36 @@ class Item extends BaseObject
                        return;
                }
 
+               if (self::exists(['uri' => $item['uri'], 'uid' => 0])) {
+                       return;
+               }
+
                $item = self::selectFirst(self::ITEM_FIELDLIST, ['id' => $itemid]);
 
-               if (DBM::is_result($item) && ($item["allow_cid"] == '') && ($item["allow_gid"] == '') &&
-                       ($item["deny_cid"] == '') && ($item["deny_gid"] == '')) {
-
-                       if (!self::exists(['uri' => $item['uri'], 'uid' => 0])) {
-                               // Preparing public shadow (removing user specific data)
-                               $item['uid'] = 0;
-                               unset($item['id']);
-                               unset($item['parent']);
-                               unset($item['wall']);
-                               unset($item['mention']);
-                               unset($item['origin']);
-                               unset($item['starred']);
-                               if ($item['uri'] == $item['parent-uri']) {
-                                       $item['contact-id'] = $item['owner-id'];
-                               } else {
-                                       $item['contact-id'] = $item['author-id'];
-                               }
+               if (DBM::is_result($item)) {
+                       // Preparing public shadow (removing user specific data)
+                       $item['uid'] = 0;
+                       unset($item['id']);
+                       unset($item['parent']);
+                       unset($item['wall']);
+                       unset($item['mention']);
+                       unset($item['origin']);
+                       unset($item['starred']);
+                       if ($item['uri'] == $item['parent-uri']) {
+                               $item['contact-id'] = $item['owner-id'];
+                       } else {
+                               $item['contact-id'] = $item['author-id'];
+                       }
 
-                               if (in_array($item['type'], ["net-comment", "wall-comment"])) {
-                                       $item['type'] = 'remote-comment';
-                               } elseif ($item['type'] == 'wall') {
-                                       $item['type'] = 'remote';
-                               }
+                       if (in_array($item['type'], ["net-comment", "wall-comment"])) {
+                               $item['type'] = 'remote-comment';
+                       } elseif ($item['type'] == 'wall') {
+                               $item['type'] = 'remote';
+                       }
 
-                               $public_shadow = self::insert($item, false, false, true);
+                       $public_shadow = self::insert($item, false, false, true);
 
-                               logger("Stored public shadow for thread ".$itemid." under id ".$public_shadow, LOGGER_DEBUG);
-                       }
+                       logger("Stored public shadow for thread ".$itemid." under id ".$public_shadow, LOGGER_DEBUG);
                }
        }
 
@@ -2010,7 +2084,7 @@ class Item extends BaseObject
 
        public static function getGuidById($id)
        {
-               $item = dba::selectFirst('item', ['guid'], ['id' => $id]);
+               $item = self::selectFirst(['guid'], ['id' => $id]);
                if (DBM::is_result($item)) {
                        return $item['guid'];
                } else {
@@ -2044,8 +2118,6 @@ class Item extends BaseObject
                        $item = dba::fetch_first("SELECT `item`.`id`, `user`.`nickname` FROM `item`
                                INNER JOIN `user` ON `user`.`uid` = `item`.`uid`
                                WHERE `item`.`visible` AND NOT `item`.`deleted` AND NOT `item`.`moderated`
-                                       AND `item`.`allow_cid` = ''  AND `item`.`allow_gid` = ''
-                                       AND `item`.`deny_cid`  = '' AND `item`.`deny_gid`  = ''
                                        AND NOT `item`.`private` AND `item`.`wall`
                                        AND `item`.`guid` = ?", $guid);
                        if (DBM::is_result($item)) {
@@ -2074,7 +2146,7 @@ class Item extends BaseObject
                $community_page = (($user['page-flags'] == PAGE_COMMUNITY) ? true : false);
                $prvgroup = (($user['page-flags'] == PAGE_PRVGROUP) ? true : false);
 
-               $item = dba::selectFirst('item', [], ['id' => $item_id]);
+               $item = self::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id]);
                if (!DBM::is_result($item)) {
                        return;
                }
@@ -2347,17 +2419,8 @@ class Item extends BaseObject
 
        private static function hasPermissions($obj)
        {
-               return (
-                       (
-                               x($obj, 'allow_cid')
-                       ) || (
-                               x($obj, 'allow_gid')
-                       ) || (
-                               x($obj, 'deny_cid')
-                       ) || (
-                               x($obj, 'deny_gid')
-                       )
-               );
+               return !empty($obj['allow_cid']) || !empty($obj['allow_gid']) ||
+                       !empty($obj['deny_cid']) || !empty($obj['deny_gid']);
        }
 
        private static function samePermissions($obj1, $obj2)
@@ -2423,74 +2486,79 @@ class Item extends BaseObject
                        return;
                }
 
+               $condition = ["`uid` = ? AND NOT `deleted` AND `id` = `parent` AND `gravity` = ?",
+                       $uid, GRAVITY_PARENT];
+
                /*
                 * $expire_network_only = save your own wall posts
                 * and just expire conversations started by others
                 */
-               $expire_network_only = PConfig::get($uid,'expire', 'network_only');
-               $sql_extra = (intval($expire_network_only) ? " AND wall = 0 " : "");
+               $expire_network_only = PConfig::get($uid, 'expire', 'network_only', false);
+
+               if ($expire_network_only) {
+                       $condition[0] .= " AND NOT `wall`";
+               }
 
                if ($network != "") {
-                       $sql_extra .= sprintf(" AND network = '%s' ", dbesc($network));
+                       $condition[0] .= " AND `network` = ?";
+                       $condition[] = $network;
 
                        /*
                         * There is an index "uid_network_received" but not "uid_network_created"
                         * This avoids the creation of another index just for one purpose.
                         * And it doesn't really matter wether to look at "received" or "created"
                         */
-                       $range = "AND `received` < UTC_TIMESTAMP() - INTERVAL %d DAY ";
+                       $condition[0] .= " AND `received` < UTC_TIMESTAMP() - INTERVAL ? DAY";
+                       $condition[] = $days;
                } else {
-                       $range = "AND `created` < UTC_TIMESTAMP() - INTERVAL %d DAY ";
+                       $condition[0] .= " AND `created` < UTC_TIMESTAMP() - INTERVAL ? DAY";
+                       $condition[] = $days;
                }
 
-               $r = q("SELECT `file`, `resource-id`, `starred`, `type`, `id` FROM `item`
-                       WHERE `uid` = %d $range
-                       AND `id` = `parent`
-                       $sql_extra
-                       AND `deleted` = 0",
-                       intval($uid),
-                       intval($days)
-               );
+               $items = self::select(['file', 'resource-id', 'starred', 'type', 'id'], $condition);
 
-               if (!DBM::is_result($r)) {
+               if (!DBM::is_result($items)) {
                        return;
                }
 
-               $expire_items = PConfig::get($uid, 'expire', 'items', 1);
+               $expire_items = PConfig::get($uid, 'expire', 'items', true);
 
                // Forcing expiring of items - but not notes and marked items
                if ($force) {
                        $expire_items = true;
                }
 
-               $expire_notes = PConfig::get($uid, 'expire', 'notes', 1);
-               $expire_starred = PConfig::get($uid, 'expire', 'starred', 1);
-               $expire_photos = PConfig::get($uid, 'expire', 'photos', 0);
+               $expire_notes = PConfig::get($uid, 'expire', 'notes', true);
+               $expire_starred = PConfig::get($uid, 'expire', 'starred', true);
+               $expire_photos = PConfig::get($uid, 'expire', 'photos', false);
 
-               logger('User '.$uid.': expire: # items=' . count($r). "; expire items: $expire_items, expire notes: $expire_notes, expire starred: $expire_starred, expire photos: $expire_photos");
-
-               foreach ($r as $item) {
+               $expired = 0;
 
+               while ($item = Item::fetch($items)) {
                        // don't expire filed items
 
-                       if (strpos($item['file'],'[') !== false) {
+                       if (strpos($item['file'], '[') !== false) {
                                continue;
                        }
 
                        // Only expire posts, not photos and photo comments
 
-                       if ($expire_photos == 0 && strlen($item['resource-id'])) {
+                       if (!$expire_photos && strlen($item['resource-id'])) {
                                continue;
-                       } elseif ($expire_starred == 0 && intval($item['starred'])) {
+                       } elseif (!$expire_starred && intval($item['starred'])) {
                                continue;
-                       } elseif ($expire_notes == 0 && $item['type'] == 'note') {
+                       } elseif (!$expire_notes && $item['type'] == 'note') {
                                continue;
-                       } elseif ($expire_items == 0 && $item['type'] != 'note') {
+                       } elseif (!$expire_items && $item['type'] != 'note') {
                                continue;
                        }
 
                        self::deleteById($item['id'], PRIORITY_LOW);
+
+                       ++$expired;
                }
+               dba::close($items);
+               logger('User ' . $uid . ": expired $expired items; expire items: $expire_items, expire notes: $expire_notes, expire starred: $expire_starred, expire photos: $expire_photos");
        }
 
        public static function firstPostDate($uid, $wall = false)
@@ -2560,7 +2628,7 @@ class Item extends BaseObject
 
                logger('like: verb ' . $verb . ' item ' . $item_id);
 
-               $item = dba::selectFirst('item', [], ['`id` = ? OR `uri` = ?', $item_id, $item_id]);
+               $item = self::selectFirst(self::ITEM_FIELDLIST, ['`id` = ? OR `uri` = ?', $item_id, $item_id]);
                if (!DBM::is_result($item)) {
                        logger('like: unknown item ' . $item_id);
                        return false;
@@ -2737,7 +2805,7 @@ EOT;
                        'moderated', 'visible', 'starred', 'bookmark', 'contact-id',
                        'deleted', 'origin', 'forum_mode', 'mention', 'network', 'author-id', 'owner-id'];
                $condition = ["`id` = ? AND (`parent` = ? OR `parent` = 0)", $itemid, $itemid];
-               $item = dba::selectFirst('item', $fields, $condition);
+               $item = self::selectFirst($fields, $condition);
 
                if (!DBM::is_result($item)) {
                        return;
@@ -2759,7 +2827,7 @@ EOT;
                        'deleted', 'origin', 'forum_mode', 'network', 'author-id', 'owner-id'];
                $condition = ["`id` = ? AND (`parent` = ? OR `parent` = 0)", $itemid, $itemid];
 
-               $item = dba::selectFirst('item', $fields, $condition);
+               $item = self::selectFirst($fields, $condition);
                if (!DBM::is_result($item)) {
                        return;
                }