use Friendica\Core\Worker;
use Friendica\Database\DBA;
use Friendica\DI;
-use Friendica\Model\Post;
use Friendica\Protocol\Activity;
use Friendica\Protocol\ActivityPub;
use Friendica\Protocol\Diaspora;
use Friendica\Util\Strings;
use Friendica\Util\Temporal;
use Friendica\Worker\Delivery;
+use GuzzleHttp\Psr7\Uri;
use LanguageDetection\Language;
class Item
const PR_GLOBAL = 73;
const PR_RELAY = 74;
const PR_FETCHED = 75;
+ const PR_COMPLETION = 76;
+ const PR_DIRECT = 77;
+ const PR_ACTIVITY = 78;
+ const PR_DISTRIBUTE = 79;
+ const PR_PUSHED = 80;
+ const PR_LOCAL = 81;
// system.accept_only_sharer setting values
const COMPLETION_NONE = 1;
// Field list that is used to display the items
const DISPLAY_FIELDLIST = [
'uid', 'id', 'parent', 'guid', 'network', 'gravity',
- 'uri-id', 'uri', 'thr-parent-id', 'thr-parent', 'parent-uri-id', 'parent-uri',
+ 'uri-id', 'uri', 'thr-parent-id', 'thr-parent', 'parent-uri-id', 'parent-uri', 'conversation',
'commented', 'created', 'edited', 'received', 'verb', 'object-type', 'postopts', 'plink',
'wall', 'private', 'starred', 'origin', 'parent-origin', 'title', 'body', 'language',
'content-warning', 'location', 'coord', 'app', 'rendered-hash', 'rendered-html', 'object',
'event-created', 'event-edited', 'event-start', 'event-finish',
'event-summary', 'event-desc', 'event-location', 'event-type',
'event-nofinish', 'event-ignore', 'event-id',
- "question-id", "question-multiple", "question-voters", "question-end-time",
- "has-categories", "has-media",
+ 'question-id', 'question-multiple', 'question-voters', 'question-end-time',
+ 'has-categories', 'has-media',
'delivery_queue_count', 'delivery_queue_done', 'delivery_queue_failed'
];
// Field list that is used to deliver items via the protocols
const DELIVER_FIELDLIST = ['uid', 'id', 'parent', 'uri-id', 'uri', 'thr-parent', 'parent-uri', 'guid',
- 'parent-guid', 'received', 'created', 'edited', 'verb', 'object-type', 'object', 'target',
+ 'parent-guid', 'conversation', 'received', 'created', 'edited', 'verb', 'object-type', 'object', 'target',
'private', 'title', 'body', 'raw-body', 'location', 'coord', 'app',
'inform', 'deleted', 'extid', 'post-type', 'post-reason', 'gravity',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid',
// All fields in the item table
const ITEM_FIELDLIST = ['id', 'uid', 'parent', 'uri', 'parent-uri', 'thr-parent',
- 'guid', 'uri-id', 'parent-uri-id', 'thr-parent-id', 'vid',
+ 'guid', 'uri-id', 'parent-uri-id', 'thr-parent-id', 'conversation', 'vid',
'contact-id', 'wall', 'gravity', 'extid', 'psid',
'created', 'edited', 'commented', 'received', 'changed', 'verb',
'postopts', 'plink', 'resource-id', 'event-id', 'inform',
foreach ($notify_items as $notify_item) {
$post = Post::selectFirst(['uri-id', 'uid'], ['id' => $notify_item]);
- Worker::add(PRIORITY_HIGH, "Notifier", Delivery::POST, (int)$post['uri-id'], (int)$post['uid']);
+ Worker::add(PRIORITY_HIGH, 'Notifier', Delivery::POST, (int)$post['uri-id'], (int)$post['uid']);
}
return $rows;
*
* @param array $condition The condition for finding the item entries
* @param integer $priority Priority for the notification
+ * @return void
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function markForDeletion($condition, $priority = PRIORITY_HIGH)
+ public static function markForDeletion(array $condition, int $priority = PRIORITY_HIGH)
{
$items = Post::select(['id'], $condition);
while ($item = Post::fetch($items)) {
*
* @param array $condition The condition for finding the item entries
* @param integer $uid User who wants to delete this item
+ * @return void
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function deleteForUser($condition, $uid)
+ public static function deleteForUser(array $condition, int $uid)
{
if ($uid == 0) {
return;
if ($item['uid'] == $uid) {
self::markForDeletionById($item['id'], PRIORITY_HIGH);
} elseif ($item['uid'] != 0) {
- Logger::notice('Wrong ownership. Not deleting item', ['id' => $item['id']]);
+ Logger::warning('Wrong ownership. Not deleting item', ['id' => $item['id']]);
}
}
DBA::close($items);
*
* @param integer $item_id
* @param integer $priority Priority for the notification
- *
* @return boolean success
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function markForDeletionById($item_id, $priority = PRIORITY_HIGH)
+ public static function markForDeletionById(int $item_id, int $priority = PRIORITY_HIGH): bool
{
Logger::info('Mark item for deletion by id', ['id' => $item_id, 'callstack' => System::callstack()]);
// locate item to be deleted
// If item has attachments, drop them
$attachments = Post\Media::getByURIId($item['uri-id'], [Post\Media::DOCUMENT]);
foreach($attachments as $attachment) {
- if (preg_match("|attach/(\d+)|", $attachment['url'], $matches)) {
+ if (preg_match('|attach/(\d+)|', $attachment['url'], $matches)) {
Attach::delete(['id' => $matches[1], 'uid' => $item['uid']]);
}
}
// send the notification upstream/downstream
if ($priority) {
- Worker::add(['priority' => $priority, 'dont_fork' => true], "Notifier", Delivery::DELETION, (int)$item['uri-id'], (int)$item['uid']);
+ Worker::add(['priority' => $priority, 'dont_fork' => true], 'Notifier', Delivery::DELETION, (int)$item['uri-id'], (int)$item['uid']);
}
} elseif ($item['uid'] != 0) {
Post\User::update($item['uri-id'], $item['uid'], ['hidden' => true]);
return true;
}
- public static function guid($item, $notify)
+ /**
+ * Get guid from given item record
+ *
+ * @param array $item Item record
+ * @param bool Whether to notify (?)
+ * @return string Guid
+ */
+ public static function guid(array $item, bool $notify): string
{
if (!empty($item['guid'])) {
return trim($item['guid']);
return $guid;
}
- private static function contactId($item)
+ /**
+ * Returns contact id from given item record
+ *
+ * @param array $item Item record
+ * @return int Contact id
+ */
+ private static function contactId(array $item): int
{
- if (!empty($item['contact-id']) && DBA::exists('contact', ['self' => true, 'id' => $item['contact-id']])) {
- return $item['contact-id'];
- } elseif (($item['gravity'] == GRAVITY_PARENT) && !empty($item['uid']) && !empty($item['contact-id']) && Contact::isSharing($item['contact-id'], $item['uid'])) {
- return $item['contact-id'];
- } elseif (!empty($item['uid']) && !Contact::isSharing($item['author-id'], $item['uid'])) {
+ if ($item['uid'] == 0) {
return $item['author-id'];
- } elseif (!empty($item['contact-id'])) {
- return $item['contact-id'];
- } else {
- $contact_id = Contact::getIdForURL($item['author-link'], $item['uid']);
+ }
+
+ if ($item['origin']) {
+ $owner = User::getOwnerDataById($item['uid']);
+ return $owner['id'];
+ }
+
+ if (!empty($item['causer-id']) && Contact::isSharing($item['causer-id'], $item['uid'], true)) {
+ $cdata = Contact::getPublicAndUserContactID($item['causer-id'], $item['uid']);
+ if (!empty($cdata['user'])) {
+ return $cdata['user'];
+ }
+ }
+
+ if ($item['gravity'] == GRAVITY_PARENT) {
+ if (Contact::isSharingByURL($item['owner-link'], $item['uid'], true)) {
+ $contact_id = Contact::getIdForURL($item['owner-link'], $item['uid']);
+ } else {
+ $contact_id = Contact::getIdForURL($item['owner-link']);
+ }
if (!empty($contact_id)) {
return $contact_id;
}
}
- return $item['author-id'];
+
+ if (Contact::isSharingByURL($item['author-link'], $item['uid'], true)) {
+ $contact_id = Contact::getIdForURL($item['author-link'], $item['uid']);
+ } else {
+ $contact_id = Contact::getIdForURL($item['author-link']);
+ }
+
+ if (!empty($contact_id)) {
+ return $contact_id;
+ }
+
+ Logger::warning('contact-id could not be fetched, using self contact instead.', ['uid' => $item['uid'], 'item' => $item]);
+ $self = Contact::selectFirst(['id'], ['self' => true, 'uid' => $item['uid']]);
+ return $self['id'];
}
/**
* @param array $item The item fields that are to be inserted
* @throws \Exception
*/
- private static function spool($orig_item)
+ private static function spool(array $item)
{
// Now we store the data in the spool directory
// We use "microtime" to keep the arrival order and "mt_rand" to avoid duplicates
$file = 'item-' . round(microtime(true) * 10000) . '-' . mt_rand() . '.msg';
$spoolpath = System::getSpoolPath();
- if ($spoolpath != "") {
+ if ($spoolpath != '') {
$spool = $spoolpath . '/' . $file;
- file_put_contents($spool, json_encode($orig_item));
+ file_put_contents($spool, json_encode($item));
Logger::warning("Item wasn't stored - Item was spooled into file", ['file' => $file]);
}
}
/**
* Check if the item array is a duplicate
*
- * @param array $item
+ * @param array $item Item record
* @return boolean is it a duplicate?
*/
- private static function isDuplicate(array $item)
+ private static function isDuplicate(array $item): bool
{
// Checking if there is already an item with the same guid
$condition = ['guid' => $item['guid'], 'network' => $item['network'], 'uid' => $item['uid']];
/**
* Check if the item array is valid
*
- * @param array $item
+ * @param array $item Item record
* @return boolean item is valid
*/
- public static function isValid(array $item)
+ public static function isValid(array $item): bool
{
// When there is no content then we don't post it
if (($item['body'] . $item['title'] == '') && (empty($item['uri-id']) || !Post\Media::existsByURIId($item['uri-id']))) {
if (!empty($item['uid'])) {
$owner = User::getOwnerDataById($item['uid'], false);
if (!$owner) {
- Logger::notice('Missing item user owner data', ['uid' => $item['uid']]);
+ Logger::warning('Missing item user owner data', ['uid' => $item['uid']]);
return false;
}
/**
* Check if the item array is too old
*
- * @param array $item
+ * @param array $item Item record
* @return boolean item is too old
*/
- public static function isTooOld(array $item)
+ public static function isTooOld(array $item): bool
{
// check for create date and expire time
$expire_interval = DI::config()->get('system', 'dbclean-expire-days', 0);
/**
* Return the id of the given item array if it has been stored before
*
- * @param array $item
- * @return integer item id
+ * @param array $item Item record
+ * @return integer Item id or zero on error
*/
- private static function getDuplicateID(array $item)
+ private static function getDuplicateID(array $item): int
{
if (empty($item['network']) || in_array($item['network'], Protocol::FEDERATED)) {
- $condition = ["`uri-id` = ? AND `uid` = ? AND `network` IN (?, ?, ?, ?)",
- $item['uri-id'], $item['uid'],
- Protocol::ACTIVITYPUB, Protocol::DIASPORA, Protocol::DFRN, Protocol::OSTATUS];
+ $condition = ['`uri-id` = ? AND `uid` = ? AND `network` IN (?, ?, ?, ?)',
+ $item['uri-id'],
+ $item['uid'],
+ Protocol::ACTIVITYPUB,
+ Protocol::DIASPORA,
+ Protocol::DFRN,
+ Protocol::OSTATUS
+ ];
$existing = Post::selectFirst(['id', 'network'], $condition);
if (DBA::isResult($existing)) {
// We only log the entries with a different user id than 0. Otherwise we would have too many false positives
'uri-id' => $item['uri-id'],
'uid' => $item['uid'],
'network' => $item['network'],
- 'existing_id' => $existing["id"],
- 'existing_network' => $existing["network"]
+ 'existing_id' => $existing['id'],
+ 'existing_network' => $existing['network']
]);
}
- return $existing["id"];
+ return $existing['id'];
}
}
return 0;
}
+ /**
+ * Fetch the uri-id of the parent for the given uri-id
+ *
+ * @param integer $uriid
+ * @return integer
+ */
+ public static function getParent(int $uriid): int
+ {
+ $thread_parent = Post::selectFirstPost(['thr-parent-id', 'gravity'], ['uri-id' => $uriid]);
+ if (empty($thread_parent)) {
+ return 0;
+ }
+
+ if ($thread_parent['gravity'] == GRAVITY_PARENT) {
+ return $uriid;
+ }
+
+ return self::getParent($thread_parent['thr-parent-id']);
+ }
+
/**
* Fetch top-level parent data for the given item array
*
* @return array item array with parent data
* @throws \Exception
*/
- private static function getTopLevelParent(array $item)
+ private static function getTopLevelParent(array $item): array
{
$fields = ['uid', 'uri', 'parent-uri', 'id', 'deleted',
'uri-id', 'parent-uri-id',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid',
'wall', 'private', 'origin', 'author-id'];
- $condition = ['uri-id' => $item['thr-parent-id'], 'uid' => $item['uid']];
+ $condition = ['uri-id' => [$item['thr-parent-id'], $item['parent-uri-id']], 'uid' => $item['uid']];
$params = ['order' => ['id' => false]];
$parent = Post::selectFirst($fields, $condition, $params);
- if (!DBA::isResult($parent) && $item['origin']) {
- $stored = Item::storeForUserByUriId($item['thr-parent-id'], $item['uid']);
- Logger::info('Stored thread parent item for user', ['uri-id' => $item['thr-parent-id'], 'uid' => $item['uid'], 'stored' => $stored]);
- $parent = Post::selectFirst($fields, $condition, $params);
+ if (!DBA::isResult($parent) && Post::exists(['uri-id' => [$item['thr-parent-id'], $item['parent-uri-id']], 'uid' => 0])) {
+ $stored = Item::storeForUserByUriId($item['thr-parent-id'], $item['uid'], ['post-reason' => Item::PR_COMPLETION]);
+ if (!$stored && ($item['thr-parent-id'] != $item['parent-uri-id'])) {
+ $stored = Item::storeForUserByUriId($item['parent-uri-id'], $item['uid'], ['post-reason' => Item::PR_COMPLETION]);
+ }
+ if ($stored) {
+ Logger::info('Stored thread parent item for user', ['uri-id' => $item['thr-parent-id'], 'uid' => $item['uid'], 'stored' => $stored]);
+ $parent = Post::selectFirst($fields, $condition, $params);
+ }
}
if (!DBA::isResult($parent)) {
- Logger::notice('item parent was not found - ignoring item', ['thr-parent-id' => $item['thr-parent-id'], 'uid' => $item['uid']]);
+ Logger::notice('item parent was not found - ignoring item', ['uri-id' => $item['uri-id'], 'thr-parent-id' => $item['thr-parent-id'], 'uid' => $item['uid'], 'callstack' => System::callstack(20)]);
return [];
}
$toplevel_parent = Post::selectFirst($fields, $condition, $params);
if (!DBA::isResult($toplevel_parent) && $item['origin']) {
- $stored = Item::storeForUserByUriId($item['parent-uri-id'], $item['uid']);
+ $stored = Item::storeForUserByUriId($item['parent-uri-id'], $item['uid'], ['post-reason' => Item::PR_COMPLETION]);
Logger::info('Stored parent item for user', ['uri-id' => $item['parent-uri-id'], 'uid' => $item['uid'], 'stored' => $stored]);
$toplevel_parent = Post::selectFirst($fields, $condition, $params);
}
* @param array $item
* @return integer gravity
*/
- private static function getGravity(array $item)
+ private static function getGravity(array $item): int
{
$activity = DI::activity();
} elseif ($activity->match($item['verb'], Activity::ANNOUNCE)) {
return GRAVITY_ACTIVITY;
}
+
Logger::info('Unknown gravity for verb', ['verb' => $item['verb']]);
return GRAVITY_UNKNOWN; // Should not happen
}
- public static function insert(array $item, int $notify = 0, bool $post_local = true)
+ /**
+ * Inserts item record
+ *
+ * @param array $item Item array to be inserted
+ * @param int $notify Notification (type?)
+ * @param bool $post_local (???)
+ * @return int Zero means error, otherwise primary key (id) is being returned
+ */
+ public static function insert(array $item, int $notify = 0, bool $post_local = true): int
{
$orig_item = $item;
$uid = intval($item['uid']);
$item['guid'] = self::guid($item, $notify);
- $item['uri'] = substr(trim($item['uri'] ?? '') ?: self::newURI($item['uid'], $item['guid']), 0, 255);
+ $item['uri'] = substr(trim($item['uri'] ?? '') ?: self::newURI($item['guid']), 0, 255);
// Store URI data
$item['uri-id'] = ItemURI::insert(['uri' => $item['uri'], 'guid' => $item['guid']]);
// Backward compatibility: parent-uri used to be the direct parent uri.
// If it is provided without a thr-parent, it probably is the old behavior.
- $item['thr-parent'] = trim($item['thr-parent'] ?? $item['parent-uri'] ?? $item['uri']);
- $item['parent-uri'] = $item['thr-parent'];
+ if (empty($item['thr-parent']) || empty($item['parent-uri'])) {
+ $item['thr-parent'] = trim($item['thr-parent'] ?? $item['parent-uri'] ?? $item['uri']);
+ $item['parent-uri'] = $item['thr-parent'];
+ }
- $item['thr-parent-id'] = $item['parent-uri-id'] = ItemURI::getIdByURI($item['thr-parent']);
+ $item['thr-parent-id'] = ItemURI::getIdByURI($item['thr-parent']);
+ $item['parent-uri-id'] = ItemURI::getIdByURI($item['parent-uri']);
// Store conversation data
- $item = Conversation::insert($item);
+ $source = $item['source'] ?? '';
+ unset($item['conversation-uri']);
+ unset($item['conversation-href']);
+ unset($item['source']);
/*
* Do we already have this item?
$item['gravity'] = self::getGravity($item);
- $item['language'] = self::getLanguage($item);
-
$default = ['url' => $item['author-link'], 'name' => $item['author-name'],
'photo' => $item['author-avatar'], 'network' => $item['network']];
$item['author-id'] = ($item['author-id'] ?? 0) ?: Contact::getIdForURL($item['author-link'], 0, null, $default);
'photo' => $item['owner-avatar'], 'network' => $item['network']];
$item['owner-id'] = ($item['owner-id'] ?? 0) ?: Contact::getIdForURL($item['owner-link'], 0, null, $default);
- $actor = ($item['gravity'] == GRAVITY_PARENT) ? $item['owner-id'] : $item['author-id'];
- if (!$item['origin'] && ($item['uid'] != 0) && Contact::isSharing($actor, $item['uid'])) {
- $item['post-reason'] = self::PR_FOLLOWER;
- }
+ $item['post-reason'] = self::getPostReason($item);
// Ensure that there is an avatar cache
Contact::checkAvatarCache($item['author-id']);
Contact::checkAvatarCache($item['owner-id']);
- // The contact-id should be set before "self::insert" was called - but there seems to be issues sometimes
- $item["contact-id"] = self::contactId($item);
+ $item['contact-id'] = self::contactId($item);
if (!empty($item['direction']) && in_array($item['direction'], [Conversation::PUSH, Conversation::RELAY]) &&
- empty($item['origin']) &&self::isTooOld($item)) {
+ empty($item['origin']) && self::isTooOld($item)) {
Logger::info('Item is too old', ['item' => $item]);
return 0;
}
} else {
$parent_id = 0;
$parent_origin = $item['origin'];
+
+ if ($item['wall'] && empty($item['conversation'])) {
+ $item['conversation'] = $item['parent-uri'] . '#context';
+ }
}
$item['parent-uri-id'] = ItemURI::getIdByURI($item['parent-uri']);
$item['thr-parent-id'] = ItemURI::getIdByURI($item['thr-parent']);
+ if (!empty($item['conversation']) && empty($item['conversation-id'])) {
+ $item['conversation-id'] = ItemURI::getIdByURI($item['conversation']);
+ }
+
// Is this item available in the global items (with uid=0)?
- if ($item["uid"] == 0) {
- $item["global"] = true;
+ if ($item['uid'] == 0) {
+ $item['global'] = true;
// Set the global flag on all items if this was a global item entry
Post::update(['global' => true], ['uri-id' => $item['uri-id']]);
}
// ACL settings
- if (!empty($item["allow_cid"] . $item["allow_gid"] . $item["deny_cid"] . $item["deny_gid"])) {
- $item["private"] = self::PRIVATE;
+ if (!empty($item['allow_cid'] . $item['allow_gid'] . $item['deny_cid'] . $item['deny_gid'])) {
+ $item['private'] = self::PRIVATE;
}
if ($notify && $post_local) {
// Check for hashtags in the body and repair or add hashtag links
$item['body'] = self::setHashtags($item['body']);
- if (stristr($item['verb'], Activity::POKE)) {
- $notify_type = Delivery::POKE;
- } else {
- $notify_type = Delivery::POST;
- }
+ $item['language'] = self::getLanguage($item);
+
+ $notify_type = Delivery::POST;
// Filling item related side tables
if (!empty($item['attach'])) {
}
if ($transmit) {
+ if (!empty($source)) {
+ Post\Activity::insert($item['uri-id'], $source);
+ }
Worker::add(['priority' => $priority, 'dont_fork' => true], 'Notifier', $notify_type, (int)$posted_item['uri-id'], (int)$posted_item['uid']);
}
self::updateDisplayCache($posted_item['uri-id']);
}
- if ($posted_item['origin'] && ($posted_item['uid'] != 0) && in_array($posted_item['gravity'], [GRAVITY_PARENT, GRAVITY_COMMENT])) {
- DI::cache()->delete(ActivityPub\Transmitter::CACHEKEY_OUTBOX . $posted_item['uid']);
+ return $post_user_id;
+ }
+
+ /**
+ * Fetch the post reason for a given item array
+ *
+ * @param array $item
+ *
+ * @return integer
+ */
+ public static function getPostReason(array $item): int
+ {
+ $actor = ($item['gravity'] == GRAVITY_PARENT) ? $item['owner-id'] : $item['author-id'];
+ if (empty($item['origin']) && ($item['uid'] != 0) && Contact::isSharing($actor, $item['uid'])) {
+ return self::PR_FOLLOWER;
+ }
+
+ if (!empty($item['origin']) && empty($item['post-reason'])) {
+ return self::PR_LOCAL;
}
- return $post_user_id;
+ return $item['post-reason'] ?? self::PR_NONE;
}
/**
$uids = Tag::getUIDListByURIId($item['uri-id']);
foreach ($uids as $uid) {
- if (Contact::isSharing($item['author-id'], $uid)) {
- $fields = [];
- } else {
- $fields = ['post-reason' => self::PR_TAG];
- }
-
- $stored = self::storeForUserByUriId($item['uri-id'], $uid, $fields);
- Logger::info('Stored item for users', ['uri-id' => $item['uri-id'], 'uid' => $uid, 'fields' => $fields, 'stored' => $stored]);
+ $stored = self::storeForUserByUriId($item['uri-id'], $uid, ['post-reason' => self::PR_TAG]);
+ Logger::info('Stored item for users', ['uri-id' => $item['uri-id'], 'uid' => $uid, 'stored' => $stored]);
}
}
* @param string $signed_text Original text (for Diaspora signatures), JSON encoded.
* @throws \Exception
*/
- public static function distribute($itemid, $signed_text = '')
+ public static function distribute(int $itemid, string $signed_text = '')
{
$condition = ["`id` IN (SELECT `parent` FROM `post-user-view` WHERE `id` = ?)", $itemid];
$parent = Post::selectFirst(['owner-id'], $condition);
$condition = ['id' => $itemid, 'uid' => 0,
'network' => array_merge(Protocol::FEDERATED ,['']),
'visible' => true, 'deleted' => false, 'private' => [self::PUBLIC, self::UNLISTED]];
- $item = Post::selectFirst(self::ITEM_FIELDLIST, $condition);
+ $item = Post::selectFirst(array_merge(self::ITEM_FIELDLIST, ['protocol']), $condition);
if (!DBA::isResult($item)) {
Logger::warning('Item not found', ['condition' => $condition]);
return;
if ($origin_uid == $uid) {
$item['diaspora_signed_text'] = $signed_text;
}
+ $item['post-reason'] = self::PR_DISTRIBUTE;
self::storeForUser($item, $uid);
}
}
* @param integer $source_uid User id of the source post
* @return integer stored item id
*/
- public static function storeForUserByUriId(int $uri_id, int $uid, array $fields = [], int $source_uid = 0)
+ public static function storeForUserByUriId(int $uri_id, int $uid, array $fields = [], int $source_uid = 0): int
{
if ($uid == $source_uid) {
Logger::warning('target UID must not be be equal to the source UID', ['uri-id' => $uri_id, 'uid' => $uid]);
return 0;
}
- $item = Post::selectFirst(self::ITEM_FIELDLIST, ['uri-id' => $uri_id, 'uid' => $source_uid]);
+ $item = Post::selectFirst(array_merge(self::ITEM_FIELDLIST, ['protocol']), ['uri-id' => $uri_id, 'uid' => $source_uid]);
if (!DBA::isResult($item)) {
Logger::warning('Item could not be fetched', ['uri-id' => $uri_id, 'uid' => $source_uid]);
return 0;
}
+ if (($uid != 0) && ($item['gravity'] == GRAVITY_PARENT)) {
+ $owner = User::getOwnerDataById($uid);
+ if (($owner['contact-type'] == User::ACCOUNT_TYPE_COMMUNITY) && !Tag::isMentioned($uri_id, $owner['url'])) {
+ Logger::info('Target user is a forum but is not mentioned here, thread will not be stored', ['uid' => $uid, 'uri-id' => $uri_id]);
+ return 0;
+ }
+ }
+
if (($source_uid == 0) && (($item['private'] == self::PRIVATE) || !in_array($item['network'], Protocol::FEDERATED))) {
Logger::notice('Item is private or not from a federated network. It will not be stored for the user.', ['uri-id' => $uri_id, 'uid' => $uid, 'private' => $item['private'], 'network' => $item['network']]);
return 0;
$item = array_merge($item, $fields);
+ $item['post-reason'] = self::getPostReason($item);
+
$is_reshare = ($item['gravity'] == GRAVITY_ACTIVITY) && ($item['verb'] == Activity::ANNOUNCE);
- if ((($item['gravity'] == GRAVITY_PARENT) || $is_reshare) &&
+ if (($uid != 0) && (($item['gravity'] == GRAVITY_PARENT) || $is_reshare) &&
DI::pConfig()->get($uid, 'system', 'accept_only_sharer') == self::COMPLETION_NONE &&
- !Contact::isSharingByURL($item['author-link'], $uid) &&
- !Contact::isSharingByURL($item['owner-link'], $uid)) {
- Logger::info('Contact is not a follower, thread will not be stored', ['author' => $item['author-link'], 'uid' => $uid]);
+ !in_array($item['post-reason'], [self::PR_FOLLOWER, self::PR_TAG, self::PR_TO, self::PR_CC])) {
+ Logger::info('Contact is not a follower, thread will not be stored', ['author' => $item['author-link'], 'uid' => $uid, 'uri-id' => $uri_id]);
return 0;
}
- if (($uri_id != $item['thr-parent-id']) && (($item['gravity'] == GRAVITY_COMMENT) || $is_reshare) && !Post::exists(['uri-id' => $item['thr-parent-id'], 'uid' => $uid])) {
- // Fetch the origin user for the post
- $origin_uid = self::GetOriginUidForUriId($item['thr-parent-id'], $uid);
- if (is_null($origin_uid)) {
- Logger::info('Origin item was not found', ['uid' => $uid, 'uri-id' => $item['thr-parent-id']]);
+ $causer = $item['causer-id'] ?: $item['author-id'];
+
+ if (($uri_id != $item['parent-uri-id']) && ($item['gravity'] == GRAVITY_COMMENT) && !Post::exists(['uri-id' => $item['parent-uri-id'], 'uid' => $uid])) {
+ if (!self::fetchParent($item['parent-uri-id'], $uid, $causer)) {
+ Logger::info('Parent post had not been added', ['uri-id' => $item['parent-uri-id'], 'uid' => $uid, 'causer' => $causer]);
return 0;
}
-
- $causer = $item['causer-id'] ?: $item['author-id'];
- $result = self::storeForUserByUriId($item['thr-parent-id'], $uid, ['causer-id' => $causer, 'post-reason' => self::PR_FETCHED], $origin_uid);
- Logger::info('Fetched thread parent', ['uri-id' => $item['thr-parent-id'], 'uid' => $uid, 'causer' => $causer, 'result' => $result]);
+ Logger::info('Fetched parent post', ['uri-id' => $item['parent-uri-id'], 'uid' => $uid, 'causer' => $causer]);
+ } elseif (($uri_id != $item['thr-parent-id']) && $is_reshare && !Post::exists(['uri-id' => $item['thr-parent-id'], 'uid' => $uid])) {
+ if (!self::fetchParent($item['thr-parent-id'], $uid, $causer)) {
+ Logger::info('Thread parent had not been added', ['uri-id' => $item['thr-parent-id'], 'uid' => $uid, 'causer' => $causer]);
+ return 0;
+ }
+ Logger::info('Fetched thread parent', ['uri-id' => $item['thr-parent-id'], 'uid' => $uid, 'causer' => $causer]);
}
$stored = self::storeForUser($item, $uid);
- Logger::info('Item stored for user', ['uri-id' => $item['uri-id'], 'uid' => $uid, 'source-uid' => $source_uid, 'stored' => $stored]);
+ Logger::info('Item stored for user', ['uri-id' => $item['uri-id'], 'uid' => $uid, 'causer' => $causer, 'source-uid' => $source_uid, 'stored' => $stored]);
return $stored;
}
+ /**
+ * Fetch the parent with the given uri-id
+ *
+ * @param integer $uri_id
+ * @param integer $uid
+ * @param integer $causer
+ *
+ * @return integer
+ */
+ private static function fetchParent(int $uri_id, int $uid, int $causer): int
+ {
+ // Fetch the origin user for the post
+ $origin_uid = self::GetOriginUidForUriId($uri_id, $uid);
+ if (is_null($origin_uid)) {
+ Logger::info('Origin item was not found', ['uid' => $uid, 'uri-id' => $uri_id]);
+ return 0;
+ }
+
+ return self::storeForUserByUriId($uri_id, $uid, ['causer-id' => $causer, 'post-reason' => self::PR_FETCHED], $origin_uid);
+ }
+
/**
* Returns the origin uid of a post if the given user is allowed to see it.
*
* @return integer stored item id
* @throws \Exception
*/
- private static function storeForUser(array $item, int $uid)
+ private static function storeForUser(array $item, int $uid): int
{
- if (Post::exists(['uri-id' => $item['uri-id'], 'uid' => $uid])) {
+ $post = Post::selectFirst(['id'], ['uri-id' => $item['uri-id'], 'uid' => $uid]);
+ if (!empty($post['id'])) {
if (!empty($item['event-id'])) {
- $post = Post::selectFirst(['event-id'], ['uri-id' => $item['uri-id'], 'uid' => $uid]);
- if (!empty($post['event-id'])) {
+ $event_post = Post::selectFirst(['event-id'], ['uri-id' => $item['uri-id'], 'uid' => $uid]);
+ if (!empty($event_post['event-id'])) {
$event = DBA::selectFirst('event', ['edited', 'start', 'finish', 'summary', 'desc', 'location', 'nofinish', 'adjust'], ['id' => $item['event-id']]);
if (!empty($event)) {
// We aren't using "Event::store" here, since we don't want to trigger any further action
- $ret = DBA::update('event', $event, ['id' => $post['event-id']]);
- Logger::info('Event updated', ['uid' => $uid, 'source-event' => $item['event-id'], 'target-event' => $post['event-id'], 'ret' => $ret]);
+ $ret = DBA::update('event', $event, ['id' => $event_post['event-id']]);
+ Logger::info('Event updated', ['uid' => $uid, 'source-event' => $item['event-id'], 'target-event' => $event_post['event-id'], 'ret' => $ret]);
}
}
}
- Logger::info('Item already exists', ['uri-id' => $item['uri-id'], 'uid' => $uid]);
- return 0;
+ Logger::info('Item already exists', ['uri-id' => $item['uri-id'], 'uid' => $uid, 'id' => $post['id']]);
+ return $post['id'];
}
// Data from the "post-user" table
unset($item['event-id']);
unset($item['hidden']);
unset($item['notification-type']);
- unset($item['post-reason']);
// Data from the "post-delivery-data" table
unset($item['postopts']);
$item['origin'] = 0;
$item['wall'] = 0;
- if ($item['gravity'] == GRAVITY_PARENT) {
- $contact = Contact::getByURLForUser($item['owner-link'], $uid, false, ['id']);
- } else {
- $contact = Contact::getByURLForUser($item['author-link'], $uid, false, ['id']);
- }
-
- if (!empty($contact['id'])) {
- $item['contact-id'] = $contact['id'];
- } else {
- // Shouldn't happen at all
- Logger::warning('contact-id could not be fetched', ['uid' => $uid, 'item' => $item]);
- $self = DBA::selectFirst('contact', ['id'], ['self' => true, 'uid' => $uid]);
- if (!DBA::isResult($self)) {
- // Shouldn't happen even less
- Logger::warning('self contact could not be fetched', ['uid' => $uid, 'item' => $item]);
- return 0;
- }
- $item['contact-id'] = $self['id'];
- }
+ $item['contact-id'] = self::contactId($item);
$notify = false;
if ($item['gravity'] == GRAVITY_PARENT) {
* @param integer $itemid Item ID that should be added
* @throws \Exception
*/
- private static function addShadow($itemid)
+ private static function addShadow(int $itemid)
{
$fields = ['uid', 'private', 'visible', 'deleted', 'network', 'uri-id'];
$condition = ['id' => $itemid, 'gravity' => GRAVITY_PARENT];
return;
}
- $item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $itemid]);
+ $item = Post::selectFirst(array_merge(self::ITEM_FIELDLIST, ['protocol']), ['id' => $itemid]);
if (DBA::isResult($item)) {
// Preparing public shadow (removing user specific data)
* @param integer $itemid Item ID that should be added
* @throws \Exception
*/
- private static function addShadowPost($itemid)
+ private static function addShadowPost(int $itemid)
{
- $item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $itemid]);
+ $item = Post::selectFirst(array_merge(self::ITEM_FIELDLIST, ['protocol']), ['id' => $itemid]);
if (!DBA::isResult($item)) {
return;
}
* @return string detected language
* @throws \Text_LanguageDetect_Exception
*/
- private static function getLanguage(array $item)
+ private static function getLanguage(array $item): string
{
if (!empty($item['language'])) {
return $item['language'];
return '';
}
+ $naked_body = self::getDominantLanguage($naked_body);
+
$availableLanguages = DI::l10n()->getAvailableLanguages();
// See https://github.com/friendica/friendica/issues/10511
// Persian is manually added to language detection until a persian translation is provided for the interface, at
return '';
}
- public static function getLanguageMessage(array $item)
+ /**
+ * Check if latin or non latin are dominant in the body and only return the dominant one
+ *
+ * @param string $body
+ * @return string
+ */
+ private static function getDominantLanguage(string $body): string
+ {
+ $latin = '';
+ $non_latin = '';
+ for ($i = 0; $i < mb_strlen($body); $i++) {
+ $character = mb_substr($body, $i, 1);
+ $ord = mb_ord($character);
+
+ // We add the most common characters to both strings.
+ if (($ord <= 64) || ($ord >= 91 && $ord <= 96) || ($ord >= 123 && $ord <= 191) || in_array($ord, [215, 247]) || ($ord >= 697 && $ord <= 735) || ($ord > 65535)) {
+ $latin .= $character;
+ $non_latin .= $character;
+ } elseif ($ord < 768) {
+ $latin .= $character;
+ } else {
+ $non_latin .= $character;
+ }
+ }
+ return (mb_strlen($latin) > mb_strlen($non_latin)) ? $latin : $non_latin;
+ }
+
+ public static function getLanguageMessage(array $item): string
{
$iso639 = new \Matriphe\ISO639\ISO639;
* Posts that are created on this system are using System::createUUID.
* Received ActivityPub posts are using Processor::getGUIDByURL.
*
- * @param string $uri uri of an item entry
- * @param string $host hostname for the GUID prefix
- * @return string unique guid
+ * @param string $uri uri of an item entry
+ * @param string|null $host hostname for the GUID prefix
+ * @return string Unique guid
*/
- public static function guidFromUri($uri, $host)
+ public static function guidFromUri(string $uri, string $host = null): string
{
// Our regular guid routine is using this kind of prefix as well
// We have to avoid that different routines could accidentally create the same value
$parsed = parse_url($uri);
// Remove the scheme to make sure that "https" and "http" doesn't make a difference
- unset($parsed["scheme"]);
+ unset($parsed['scheme']);
// Glue it together to be able to make a hash from it
- $host_id = implode("/", $parsed);
+ $host_id = implode('/', $parsed);
// Use a mixture of several hashes to provide some GUID like experience
- return hash("crc32", $host) . '-'. hash('joaat', $host_id) . '-'. hash('fnv164', $host_id);
+ return hash('crc32', $host) . '-'. hash('joaat', $host_id) . '-'. hash('fnv164', $host_id);
}
/**
* generate an unique URI
*
- * @param integer $uid User id
- * @param string $guid An existing GUID (Otherwise it will be generated)
+ * @param string $guid An existing GUID (Otherwise it will be generated)
*
* @return string
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function newURI($uid, $guid = "")
+ public static function newURI(string $guid = ''): string
{
- if ($guid == "") {
+ if ($guid == '') {
$guid = System::createUUID();
}
* @param array $arr Contains the just posted item record
* @throws \Exception
*/
- private static function updateContact($arr)
+ private static function updateContact(array $arr)
{
// Unarchive the author
$contact = DBA::selectFirst('contact', [], ['id' => $arr["author-id"]]);
} else {
$condition = ['id' => $arr['contact-id'], 'self' => false];
}
- Contact::update(['failed' => false, 'success_update' => $arr['received'], 'last-item' => $arr['received']], $condition);
+ Contact::update(['failed' => false, 'local-data' => true, 'success_update' => $arr['received'], 'last-item' => $arr['received']], $condition);
}
// Now do the same for the system wide contacts with uid=0
if ($arr['private'] != self::PRIVATE) {
- Contact::update(['failed' => false, 'success_update' => $arr['received'], 'last-item' => $arr['received']],
+ Contact::update(['failed' => false, 'local-data' => true, 'success_update' => $arr['received'], 'last-item' => $arr['received']],
['id' => $arr['owner-id']]);
if ($arr['owner-id'] != $arr['author-id']) {
- Contact::update(['failed' => false, 'success_update' => $arr['received'], 'last-item' => $arr['received']],
+ Contact::update(['failed' => false, 'local-data' => true, 'success_update' => $arr['received'], 'last-item' => $arr['received']],
['id' => $arr['author-id']]);
}
}
}
- public static function setHashtags($body)
+ public static function setHashtags(string $body): string
{
$body = BBCode::performWithEscapedTags($body, ['noparse', 'pre', 'code', 'img'], function ($body) {
$tags = BBCode::getTags($body);
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
*/
- private static function tagDeliver($uid, $item_id)
+ private static function tagDeliver(int $uid, int $item_id): bool
{
$mention = false;
}
if ($item['gravity'] == GRAVITY_PARENT) {
- $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
- foreach ($tags as $tag) {
- if (Strings::compareLink($owner['url'], $tag['url'])) {
- $mention = true;
- Logger::info('Mention found in tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- }
- }
-
- if (!$mention) {
+ if (Tag::isMentioned($item['uri-id'], $owner['url'])) {
+ Logger::info('Mention found in tag.', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ } else {
Logger::info('Top-level post without mention is deleted.', ['uri' => $item['uri'], $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
return true;
Hook::callAll('tagged', $arr);
} else {
- $tags = Tag::getByURIId($item['parent-uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
- foreach ($tags as $tag) {
- if (Strings::compareLink($owner['url'], $tag['url'])) {
- $mention = true;
- Logger::info('Mention found in parent tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- }
- }
-
- if (!$mention) {
+ if (Tag::isMentioned($item['parent-uri-id'], $owner['url'])) {
+ Logger::info('Mention found in parent tag.', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ } else {
Logger::debug('No mentions found in parent, quitting here.', ['id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
return false;
}
self::performActivity($item['id'], 'announce', $item['uid']);
}
- public static function isRemoteSelf($contact, &$datarray)
+ public static function isRemoteSelf(array $contact, array &$datarray): bool
{
if (!$contact['remote_self']) {
return false;
$old_uri_id = $datarray["uri-id"] ?? 0;
$datarray["guid"] = System::createUUID();
unset($datarray["plink"]);
- $datarray["uri"] = self::newURI($contact['uid'], $datarray["guid"]);
+ $datarray["uri"] = self::newURI($datarray["guid"]);
$datarray["uri-id"] = ItemURI::getIdByURI($datarray["uri"]);
$datarray["extid"] = Protocol::DFRN;
$urlpart = parse_url($datarray2['author-link']);
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
*/
- public static function fixPrivatePhotos($s, $uid, $item = null, $cid = 0)
+ public static function fixPrivatePhotos(string $s, int $uid, array $item = null, int $cid = 0): string
{
if (DI::config()->get('system', 'disable_embedded')) {
return $s;
return $new_body;
}
- private static function hasPermissions($obj)
+ private static function hasPermissions(array $obj)
{
return !empty($obj['allow_cid']) || !empty($obj['allow_gid']) ||
!empty($obj['deny_cid']) || !empty($obj['deny_gid']);
}
- private static function samePermissions($uid, $obj1, $obj2)
+ // @TODO $uid is unused parameter
+ private static function samePermissions($uid, array $obj1, array $obj2): bool
{
// first part is easy. Check that these are exactly the same.
if (($obj1['allow_cid'] == $obj2['allow_cid'])
* @return array
* @throws \Exception
*/
- public static function enumeratePermissions(array $obj, bool $check_dead = false)
+ public static function enumeratePermissions(array $obj, bool $check_dead = false): array
{
$aclFormater = DI::aclFormatter();
Logger::notice('User ' . $uid . ": expired $expired items; expire items: $expire_items, expire notes: $expire_notes, expire starred: $expire_starred, expire photos: $expire_photos");
}
- public static function firstPostDate($uid, $wall = false)
+ public static function firstPostDate(int $uid, bool $wall = false)
{
$user = User::getById($uid, ['register_date']);
if (empty($user)) {
* array $arr
* 'post_id' => ID of posted item
*/
- public static function performActivity(int $item_id, string $verb, int $uid, string $allow_cid = null, string $allow_gid = null, string $deny_cid = null, string $deny_gid = null)
+ public static function performActivity(int $item_id, string $verb, int $uid, string $allow_cid = null, string $allow_gid = null, string $deny_cid = null, string $deny_gid = null): bool
{
if (empty($uid)) {
return false;
$item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id]);
if (!DBA::isResult($item)) {
- Logger::notice('like: unknown item', ['id' => $item_id]);
+ Logger::warning('Post had not been fetched', ['id' => $item_id]);
return false;
}
}
if (!Post::exists(['uri-id' => $item['parent-uri-id'], 'uid' => $uid])) {
- $stored = self::storeForUserByUriId($item['parent-uri-id'], $uid);
+ $stored = self::storeForUserByUriId($item['parent-uri-id'], $uid, ['post-reason' => Item::PR_ACTIVITY]);
if (($item['parent-uri-id'] == $item['uri-id']) && !empty($stored)) {
$item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $stored]);
if (!DBA::isResult($item)) {
}
// Retrieve the current logged in user's public contact
- $author_id = Contact::getIdForURL($owner['url']);
+ $author_id = Contact::getPublicIdByUserId($uid);
if (empty($author_id)) {
Logger::info('Empty public contact');
return false;
$activity = Activity::ANNOUNCE;
break;
default:
- Logger::notice('unknown verb', ['verb' => $verb, 'item' => $item_id]);
+ Logger::warning('unknown verb', ['verb' => $verb, 'item' => $item_id]);
return false;
}
$new_item = [
'guid' => System::createUUID(),
- 'uri' => self::newURI($item['uid']),
- 'uid' => $item['uid'],
+ 'uri' => self::newURI(),
+ 'uid' => $uid,
'contact-id' => $owner['id'],
'wall' => $item['wall'],
'origin' => 1,
'unseen' => 1,
];
- $signed = Diaspora::createLikeSignature($uid, $new_item);
- if (!empty($signed)) {
- $new_item['diaspora_signed_text'] = json_encode($signed);
+ if (in_array($activity, [Activity::LIKE, Activity::DISLIKE])) {
+ $signed = Diaspora::createLikeSignature($uid, $new_item);
+ if (!empty($signed)) {
+ $new_item['diaspora_signed_text'] = json_encode($signed);
+ }
}
- $new_item_id = self::insert($new_item);
+ self::insert($new_item, true);
// If the parent item isn't visible then set it to visible
+ // @todo Check if this is still needed
if (!$item['visible']) {
self::update(['visible' => true], ['id' => $item['id']]);
}
-
- $new_item['id'] = $new_item_id;
-
- Hook::callAll('post_local_end', $new_item);
-
return true;
}
* @param integer $owner_id User ID for which the permissions should be fetched
* @return array condition
*/
- public static function getPermissionsConditionArrayByUserId(int $owner_id)
+ public static function getPermissionsConditionArrayByUserId(int $owner_id): array
{
$local_user = local_user();
$remote_user = Session::getRemoteContactID($owner_id);
* @param string $table
* @return string
*/
- public static function getPermissionsSQLByUserId(int $owner_id, string $table = '')
+ public static function getPermissionsSQLByUserId(int $owner_id, string $table = ''): string
{
$local_user = local_user();
$remote_user = Session::getRemoteContactID($owner_id);
* @param \Friendica\Core\L10n $l10n
* @return string
*/
- public static function postType(array $item, \Friendica\Core\L10n $l10n)
+ public static function postType(array $item, \Friendica\Core\L10n $l10n): string
{
if (!empty($item['event-id'])) {
return $l10n->t('event');
* Given an item array, convert the body element from bbcode to html and add smilie icons.
* If attach is true, also add icons for item attachments.
*
- * @param array $item
- * @param boolean $attach
- * @param boolean $is_preview
- * @param boolean $only_cache
+ * @param array $item Record from item table
+ * @param boolean $attach If true, add icons for item attachments as well
+ * @param boolean $is_preview Whether this is a preview
+ * @param boolean $only_cache Whether only cached HTML should be updated
* @return string item body html
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
$shared_uri_id = 0;
$shared_links = [];
}
- $attachments = Post\Media::splitAttachments($item['uri-id'], $item['guid'] ?? '', $shared_links, $item['has-media']);
+
+ $attachments = Post\Media::splitAttachments($item['uri-id'], $item['guid'] ?? '', $shared_links, $item['has-media'] ?? false);
$item['body'] = self::replaceVisualAttachments($attachments, $item['body'] ?? '');
$item['body'] = preg_replace("/\s*\[attachment .*?\].*?\[\/attachment\]\s*/ism", "\n", $item['body']);
$s = $item["rendered-html"];
if ($only_cache) {
- return;
+ return '';
}
// Compile eventual content filter reasons
{
// Make sure that for example site parameters aren't used when testing if the link is contained in the body
$urlparts = parse_url($url);
- unset($urlparts['query']);
- unset($urlparts['fragment']);
- $url = Network::unparseURL($urlparts);
+ if (!empty($urlparts)) {
+ unset($urlparts['query']);
+ unset($urlparts['fragment']);
+ $url = (string)Uri::fromParts($urlparts);
+ } else {
+ return false;
+ }
// Remove media links to only search in embedded content
// @todo Check images for image link, audio for audio links, ...
return $content;
}
- private static function addQuestions(array $item, string $content)
+ private static function addQuestions(array $item, string $content): string
{
DI::profiler()->startRecording('rendering');
if (!empty($item['question-id'])) {
$options = Post\QuestionOption::getByURIId($item['uri-id']);
foreach ($options as $key => $option) {
- $percent = $question['voters'] ? ($option['replies'] / $question['voters'] * 100) : 0;
-
- $options[$key]['percent'] = $percent;
-
if ($question['voters'] > 0) {
- $options[$key]['vote'] = DI::l10n()->t('%s (%d%s, %d votes)', $option['name'], round($percent, 1), '%', $option['replies']);
+ $percent = $option['replies'] / $question['voters'] * 100;
+ $options[$key]['vote'] = DI::l10n()->tt('%2$s (%3$d%%, %1$d vote)', '%2$s (%3$d%%, %1$d votes)', $option['replies'], $option['name'], round($percent, 1));
} else {
- $options[$key]['vote'] = DI::l10n()->t('%s (%d votes)', $option['name'], $option['replies']);
+ $options[$key]['vote'] = DI::l10n()->tt('%2$s (%1$d vote)', '%2$s (%1$d votes)', $option['replies'], $option['name'], );
}
}
if (!empty($question['voters']) && !empty($question['endtime'])) {
- $summary = DI::l10n()->t('%d voters. Poll end: %s', $question['voters'], Temporal::getRelativeDate($question['endtime']));
+ $summary = DI::l10n()->tt('%d voter. Poll end: %s', '%d voters. Poll end: %s', $question['voters'], Temporal::getRelativeDate($question['endtime']));
} elseif (!empty($question['voters'])) {
- $summary = DI::l10n()->t('%d voters.', $question['voters']);
+ $summary = DI::l10n()->tt('%d voter.', '%d voters.', $question['voters']);
} elseif (!empty($question['endtime'])) {
$summary = DI::l10n()->t('Poll end: %s', Temporal::getRelativeDate($question['endtime']));
} else {
*
* @return string URI
*/
- public static function getURIByLink(string $uri)
+ public static function getURIByLink(string $uri): string
{
$ssl_uri = str_replace('http://', 'https://', $uri);
$uris = [$uri, $ssl_uri, Strings::normaliseLink($uri)];
return is_numeric($hookData['item_id']) ? $hookData['item_id'] : 0;
}
- if ($fetched_uri = ActivityPub\Processor::fetchMissingActivity($uri)) {
+ $fetched_uri = ActivityPub\Processor::fetchMissingActivity($uri);
+
+ if ($fetched_uri) {
$item_id = self::searchByLink($fetched_uri, $uid);
} else {
$item_id = Diaspora::fetchByURL($uri);
*/
public static function getShareArray(array $item): array
{
- if (!preg_match("/(.*?)\[share(.*?)\]\s?(.*?)\s?\[\/share\]\s?/ism", $item['body'], $matches)) {
- return [];
- }
-
- $attribute_string = $matches[2];
- $attributes = ['comment' => trim($matches[1]), 'shared' => trim($matches[3])];
- foreach (['author', 'profile', 'avatar', 'guid', 'posted', 'link'] as $field) {
- if (preg_match("/$field=(['\"])(.+?)\\1/ism", $attribute_string, $matches)) {
- $attributes[$field] = trim(html_entity_decode($matches[2] ?? '', ENT_QUOTES, 'UTF-8'));
- }
- }
- return $attributes;
+ return BBCode::fetchShareAttributes($item['body']);
}
/**
* @param array $item
* @return string body
*/
- public static function improveSharedDataInBody(array $item)
+ public static function improveSharedDataInBody(array $item): string
{
$shared = BBCode::fetchShareAttributes($item['body']);
if (empty($shared['link'])) {