<?php
/**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2022, the Friendica project
*
* @license GNU AGPL version 3 or any later version
*
const PT_VIDEO = 18;
const PT_DOCUMENT = 19;
const PT_EVENT = 32;
+ const PT_POLL = 33;
const PT_PERSONAL_NOTE = 128;
// Posting reasons (Why had a post been stored for a user?)
'commented', 'created', 'edited', 'received', 'verb', 'object-type', 'postopts', 'plink',
'wall', 'private', 'starred', 'origin', 'parent-origin', 'title', 'body', 'language',
'content-warning', 'location', 'coord', 'app', 'rendered-hash', 'rendered-html', 'object',
- 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'mention',
+ 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'mention', 'global',
'author-id', 'author-link', 'author-name', 'author-avatar', 'author-network',
'owner-id', 'owner-link', 'owner-name', 'owner-avatar', 'owner-network', 'owner-contact-type',
'causer-id', 'causer-link', 'causer-name', 'causer-avatar', 'causer-contact-type', 'causer-network',
'inform', 'deleted', 'extid', 'post-type', 'post-reason', 'gravity',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid',
'author-id', 'author-link', 'author-name', 'author-avatar', 'owner-id', 'owner-link', 'contact-uid',
- 'signed_text', 'network', 'wall', 'contact-id', 'plink', 'forum_mode', 'origin',
+ 'signed_text', 'network', 'wall', 'contact-id', 'plink', 'origin',
'thr-parent-id', 'parent-uri-id', 'postopts', 'pubmail',
'event-created', 'event-edited', 'event-start', 'event-finish',
'event-summary', 'event-desc', 'event-location', 'event-type',
'postopts', 'plink', 'resource-id', 'event-id', 'inform',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'post-type', 'post-reason',
'private', 'pubmail', 'visible', 'starred',
- 'unseen', 'deleted', 'origin', 'forum_mode', 'mention', 'global', 'network',
+ 'unseen', 'deleted', 'origin', 'mention', 'global', 'network',
'title', 'content-warning', 'body', 'location', 'coord', 'app',
'rendered-hash', 'rendered-html', 'object-type', 'object', 'target-type', 'target',
'author-id', 'author-link', 'author-name', 'author-avatar', 'author-network',
public static function guid($item, $notify)
{
if (!empty($item['guid'])) {
- return Strings::escapeTags(trim($item['guid']));
+ return trim($item['guid']);
}
if ($notify) {
$fields = ['uid', 'uri', 'parent-uri', 'id', 'deleted',
'uri-id', 'parent-uri-id',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid',
- 'wall', 'private', 'forum_mode', 'origin', 'author-id'];
+ 'wall', 'private', 'origin', 'author-id'];
$condition = ['uri-id' => $item['thr-parent-id'], 'uid' => $item['uid']];
$params = ['order' => ['id' => false]];
$parent = Post::selectFirst($fields, $condition, $params);
$item['inform'] = trim($item['inform'] ?? '');
$item['file'] = trim($item['file'] ?? '');
+ // Communities aren't working with the Diaspora protoccol
+ if (($uid != 0) && ($item['network'] == Protocol::DIASPORA)) {
+ $user = User::getById($uid, ['account-type']);
+ if ($user['account-type'] == Contact::TYPE_COMMUNITY) {
+ Logger::info('Community posts are not supported via Diaspora');
+ return 0;
+ }
+ }
+
// Items cannot be stored before they happen ...
if ($item['created'] > DateTimeFormat::utcNow()) {
$item['created'] = DateTimeFormat::utcNow();
$item['parent-uri'] = $toplevel_parent['uri'];
$item['parent-uri-id'] = $toplevel_parent['uri-id'];
$item['deleted'] = $toplevel_parent['deleted'];
- $item['allow_cid'] = $toplevel_parent['allow_cid'];
- $item['allow_gid'] = $toplevel_parent['allow_gid'];
- $item['deny_cid'] = $toplevel_parent['deny_cid'];
- $item['deny_gid'] = $toplevel_parent['deny_gid'];
+
+ // Reshares have to keep their permissions to allow forums to work
+ if (!$item['origin'] || ($item['verb'] != Activity::ANNOUNCE)) {
+ $item['allow_cid'] = $toplevel_parent['allow_cid'];
+ $item['allow_gid'] = $toplevel_parent['allow_gid'];
+ $item['deny_cid'] = $toplevel_parent['deny_cid'];
+ $item['deny_gid'] = $toplevel_parent['deny_gid'];
+ }
+
$parent_origin = $toplevel_parent['origin'];
// Don't federate received participation messages
$item['private'] = $toplevel_parent['private'];
}
- /*
- * Edge case. We host a public forum that was originally posted to privately.
- * The original author commented, but as this is a comment, the permissions
- * weren't fixed up so it will still show the comment as private unless we fix it here.
- */
- if ((intval($toplevel_parent['forum_mode']) == 1) && ($toplevel_parent['private'] != self::PUBLIC)) {
- $item['private'] = self::PUBLIC;
- }
-
// If its a post that originated here then tag the thread as "mention"
if ($item['origin'] && $item['uid']) {
DBA::update('post-thread-user', ['mention' => true], ['uri-id' => $item['parent-uri-id'], 'uid' => $item['uid']]);
$item['parent'] = $parent_id;
// Trigger automatic reactions for addons
- $item['api_source'] = true;
+ if (!isset($item['api_source'])) {
+ $item['api_source'] = true;
+ }
// We have to tell the hooks who we are - this really should be improved
if (!local_user()) {
}
if ((($item['gravity'] == GRAVITY_COMMENT) || $is_reshare) && !Post::exists(['uri-id' => $item['thr-parent-id'], 'uid' => $uid])) {
- // Only do an auto complete with the source uid "0" to prevent privavy problems
+ // Fetch the origin user for the post
+ $origin_uid = self::GetOriginUidForUriId($item['thr-parent-id'], $uid);
+ if (is_null($origin_uid)) {
+ Logger::info('Origin item was not found', ['uid' => $uid, 'uri-id' => $item['thr-parent-id']]);
+ return 0;
+ }
+
$causer = $item['causer-id'] ?: $item['author-id'];
- $result = self::storeForUserByUriId($item['thr-parent-id'], $uid, ['causer-id' => $causer, 'post-reason' => self::PR_FETCHED]);
+ $result = self::storeForUserByUriId($item['thr-parent-id'], $uid, ['causer-id' => $causer, 'post-reason' => self::PR_FETCHED], $origin_uid);
Logger::info('Fetched thread parent', ['uri-id' => $item['thr-parent-id'], 'uid' => $uid, 'causer' => $causer, 'result' => $result]);
}
return $stored;
}
+ /**
+ * Returns the origin uid of a post if the given user is allowed to see it.
+ *
+ * @param int $uriid
+ * @param int $uid
+ * @return int
+ */
+ private static function GetOriginUidForUriId(int $uriid, int $uid)
+ {
+ if (Post::exists(['uri-id' => $uriid, 'uid' => $uid])) {
+ return $uid;
+ }
+
+ $post = Post::selectFirst(['uid', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'private'], ['uri-id' => $uriid, 'origin' => true]);
+ if (empty($post)) {
+ if (Post::exists(['uri-id' => $uriid, 'uid' => 0])) {
+ return 0;
+ } else {
+ return null;
+ }
+ }
+
+ if (in_array($post['private'], [Item::PUBLIC, Item::UNLISTED])) {
+ return $post['uid'];
+ }
+
+ $pcid = Contact::getPublicIdByUserId($uid);
+ if (empty($pcid)) {
+ return null;
+ }
+
+ foreach (Item::enumeratePermissions($post, true) as $receiver) {
+ if ($receiver == $pcid) {
+ return $post['uid'];
+ }
+ }
+
+ return null;
+ }
+
/**
* Store a public item array for the given users
*
private static function storeForUser(array $item, int $uid)
{
if (Post::exists(['uri-id' => $item['uri-id'], 'uid' => $uid])) {
+ if (!empty($item['event-id'])) {
+ $post = Post::selectFirst(['event-id'], ['uri-id' => $item['uri-id'], 'uid' => $uid]);
+ if (!empty($post['event-id'])) {
+ $event = DBA::selectFirst('event', ['edited', 'start', 'finish', 'summary', 'desc', 'location', 'nofinish', 'adjust'], ['id' => $item['event-id']]);
+ if (!empty($event)) {
+ // We aren't using "Event::store" here, since we don't want to trigger any further action
+ $ret = DBA::update('event', $event, ['id' => $post['event-id']]);
+ Logger::info('Event updated', ['uid' => $uid, 'source-event' => $item['event-id'], 'target-event' => $post['event-id'], 'ret' => $ret]);
+ }
+ }
+ }
Logger::info('Item already exists', ['uri-id' => $item['uri-id'], 'uid' => $uid]);
return 0;
}
+ // Data from the "post-user" table
unset($item['id']);
unset($item['mention']);
unset($item['starred']);
unset($item['pinned']);
unset($item['ignored']);
unset($item['pubmail']);
- unset($item['forum_mode']);
-
unset($item['event-id']);
unset($item['hidden']);
unset($item['notification-type']);
+ unset($item['post-reason']);
+
+ // Data from the "post-delivery-data" table
+ unset($item['postopts']);
+ unset($item['inform']);
$item['uid'] = $uid;
$item['origin'] = 0;
{
$mention = false;
- $user = DBA::selectFirst('user', [], ['uid' => $uid]);
- if (!DBA::isResult($user)) {
+ $owner = User::getOwnerDataById($uid);
+ if (!DBA::isResult($owner)) {
+ Logger::warning('User not found, quitting.', ['uid' => $uid]);
return false;
}
- $community_page = (($user['page-flags'] == User::PAGE_FLAGS_COMMUNITY) ? true : false);
- $prvgroup = (($user['page-flags'] == User::PAGE_FLAGS_PRVGROUP) ? true : false);
+ if ($owner['contact-type'] != User::ACCOUNT_TYPE_COMMUNITY) {
+ Logger::debug('Owner is no community, quitting here.', ['uid' => $uid, 'id' => $item_id]);
+ return false;
+ }
$item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id]);
if (!DBA::isResult($item)) {
+ Logger::warning('Post not found, quitting.', ['id' => $item_id]);
return false;
}
- $link = Strings::normaliseLink(DI::baseUrl() . '/profile/' . $user['nickname']);
-
- /*
- * Diaspora uses their own hardwired link URL in @-tags
- * instead of the one we supply with webfinger
- */
- $dlink = Strings::normaliseLink(DI::baseUrl() . '/u/' . $user['nickname']);
+ if ($item['wall'] || $item['origin'] || ($item['gravity'] != GRAVITY_PARENT)) {
+ Logger::debug('Wall item, origin item or no parent post, quitting here.', ['wall' => $item['wall'], 'origin' => $item['origin'], 'gravity' => $item['gravity'], 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ return false;
+ }
- $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER);
- if ($cnt) {
- foreach ($matches as $mtch) {
- if (Strings::compareLink($link, $mtch[1]) || Strings::compareLink($dlink, $mtch[1])) {
- $mention = true;
- Logger::notice('mention found', ['mention' => $mtch[2]]);
- }
+ $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
+ foreach ($tags as $tag) {
+ if (Strings::compareLink($owner['url'], $tag['url'])) {
+ $mention = true;
+ Logger::info('Mention found in tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
}
}
+ // This check can most likely be removed since we always are having the tags
if (!$mention) {
- $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
- foreach ($tags as $tag) {
- if (Strings::compareLink($link, $tag['url']) || Strings::compareLink($dlink, $tag['url'])) {
- $mention = true;
- DI::logger()->info('mention found in tag.', ['url' => $tag['url']]);
+ $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER);
+ if ($cnt) {
+ foreach ($matches as $mtch) {
+ if (Strings::compareLink($owner['url'], $mtch[1])) {
+ $mention = true;
+ Logger::notice('Mention found in body.', ['mention' => $mtch[2], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ }
}
}
}
if (!$mention) {
- if (($community_page || $prvgroup) &&
- !$item['wall'] && !$item['origin'] && ($item['gravity'] == GRAVITY_PARENT)) {
- Logger::info('Delete private group/communiy top-level item without mention', ['id' => $item['id'], 'guid'=> $item['guid']]);
- Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
- return true;
- }
- return false;
+ Logger::info('Top-level post without mention is deleted.', ['uri' => $item['uri'], $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
+ return true;
}
- $arr = ['item' => $item, 'user' => $user];
+ $arr = ['item' => $item, 'user' => $owner];
Hook::callAll('tagged', $arr);
- if (!$community_page && !$prvgroup) {
- return false;
- }
-
- /*
- * tgroup delivery - setup a second delivery chain
- * prevent delivery looping - only proceed
- * if the message originated elsewhere and is a top-level post
- */
- if ($item['wall'] || $item['origin'] || ($item['id'] != $item['parent'])) {
- return false;
- }
-
- self::performActivity($item['id'], 'announce', $uid);
+ Logger::info('Community post will be distributed', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- /**
- * All the following lines are only needed for private forums and compatibility to older systems without AP support.
- * A possible way would be that the followers list of a forum would always be readable by all followers.
- * So this would mean that the comment distribution could be done exactly for the intended audience.
- * Or possibly we could store the receivers that had been in the "announce" message above and use this.
- */
+ if ($owner['page-flags'] == User::PAGE_FLAGS_PRVGROUP) {
+ Group::getMembersForForum($owner['id']);
- // now change this copy of the post to a forum head message and deliver to all the tgroup members
- $self = DBA::selectFirst('contact', ['id', 'name', 'url', 'thumb'], ['uid' => $uid, 'self' => true]);
- if (!DBA::isResult($self)) {
- return false;
- }
-
- $owner_id = Contact::getIdForURL($self['url']);
-
- // also reset all the privacy bits to the forum default permissions
- if ($user['allow_cid'] || $user['allow_gid'] || $user['deny_cid'] || $user['deny_gid']) {
- $private = self::PRIVATE;
- } elseif (DI::pConfig()->get($user['uid'], 'system', 'unlisted')) {
- $private = self::UNLISTED;
+ $allow_cid = '<' . $owner['id'] . '>';
+ $allow_gid = '<' . Group::getIdForForum($owner['id']) . '>';
+ $deny_cid = '';
+ $deny_gid = '';
+ self::performActivity($item['id'], 'announce', $uid, $allow_cid, $allow_gid, $deny_cid, $deny_gid);
} else {
- $private = self::PUBLIC;
+ self::performActivity($item['id'], 'announce', $uid);
}
- $permissionSet = DI::permissionSet()->selectOrCreate(
- DI::permissionSetFactory()->createFromString(
- $user['uid'],
- $user['allow_cid'],
- $user['allow_gid'],
- $user['deny_cid'],
- $user['deny_gid']
- ));
-
- $forum_mode = ($prvgroup ? 2 : 1);
-
- $fields = ['wall' => true, 'origin' => true, 'forum_mode' => $forum_mode, 'contact-id' => $self['id'],
- 'owner-id' => $owner_id, 'private' => $private, 'psid' => $permissionSet->id];
- self::update($fields, ['id' => $item['id']]);
-
- Worker::add(['priority' => PRIORITY_HIGH, 'dont_fork' => true], 'Notifier', Delivery::POST, (int)$item['uri-id'], (int)$item['uid']);
-
+ Logger::info('Community post had been distributed', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
return false;
}
$condition[] = $network;
}
- $condition[0] .= " AND `received` < UTC_TIMESTAMP() - INTERVAL ? DAY";
- $condition[] = $days;
+ $condition[0] .= " AND `received` < ?";
+ $condition[] = DateTimeFormat::utc('now - ' . $days . ' day');
$items = Post::select(['resource-id', 'starred', 'id', 'post-type', 'uid', 'uri-id'], $condition);
*
* Toggle activities as like,dislike,attend of an item
*
- * @param int $item_id
+ * @param int $item_id
* @param string $verb
* Activity verb. One of
* like, unlike, dislike, undislike, attendyes, unattendyes,
* attendno, unattendno, attendmaybe, unattendmaybe,
* announce, unannouce
+ * @param int $uid
+ * @param string $allow_cid
+ * @param string $allow_gid
+ * @param string $deny_cid
+ * @param string $deny_gid
* @return bool
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
* array $arr
* 'post_id' => ID of posted item
*/
- public static function performActivity(int $item_id, string $verb, int $uid)
+ public static function performActivity(int $item_id, string $verb, int $uid, string $allow_cid = null, string $allow_gid = null, string $deny_cid = null, string $deny_gid = null)
{
if (empty($uid)) {
return false;
return true;
}
+ $allow_cid = $allow_cid ?? $item['allow_cid'];
+ $allow_gid = $allow_gid ?? $item['allow_gid'];
+ $deny_cid = $deny_cid ?? $item['deny_cid'];
+ $deny_gid = $deny_gid ?? $item['deny_gid'];
+
$objtype = $item['resource-id'] ? Activity\ObjectType::IMAGE : Activity\ObjectType::NOTE;
$new_item = [
'body' => $activity,
'verb' => $activity,
'object-type' => $objtype,
- 'allow_cid' => $item['allow_cid'],
- 'allow_gid' => $item['allow_gid'],
- 'deny_cid' => $item['deny_cid'],
- 'deny_gid' => $item['deny_gid'],
+ 'allow_cid' => $allow_cid,
+ 'allow_gid' => $allow_gid,
+ 'deny_cid' => $deny_cid,
+ 'deny_gid' => $deny_gid,
'visible' => 1,
'unseen' => 1,
];
private static function addLinkAttachment(int $uriid, array $attachments, string $body, string $content, bool $shared, array $ignore_links)
{
DI::profiler()->startRecording('rendering');
- // @ToDo Check only for audio and video
- $preview = empty($attachments['visual']);
+ // Don't show a preview when there is a visual attachment (audio or video)
+ $types = array_column($attachments['visual'], 'type');
+ $preview = !in_array(Post\Media::IMAGE, $types) && !in_array(Post\Media::VIDEO, $types);
if (!empty($attachments['link'])) {
foreach ($attachments['link'] as $link) {
return $item_id;
}
+ $hookData = [
+ 'uri' => $uri,
+ 'uid' => $uid,
+ 'item_id' => null,
+ ];
+
+ Hook::callAll('item_by_link', $hookData);
+
+ if (isset($hookData['item_id'])) {
+ return is_numeric($hookData['item_id']) ? $hookData['item_id'] : 0;
+ }
+
if ($fetched_uri = ActivityPub\Processor::fetchMissingActivity($uri)) {
$item_id = self::searchByLink($fetched_uri, $uid);
} else {
$body = $shared_item['body'];
}
- $item['body'] = preg_replace("/\[share ([^\[\]]*)\].*\[\/share\]/ism", '[share $1]' . $body . '[/share]', $item['body']);
+ $item['body'] = preg_replace("/\[share ([^\[\]]*)\].*\[\/share\]/ism", '[share $1]' . str_replace('$', '\$', $body) . '[/share]', $item['body']);
unset($shared_item['body']);
return array_merge($item, $shared_item);
projects / friendica.git / blobdiff