Item model, fix deletion of all attachments

[friendica.git] / src / Model / Item.php

diff --git a/src/Model/Item.php b/src/Model/Item.php
index a6e378034b09cf508442d601c7e9a5078655e80d..b71db999d037d5f4c7f4a22bedf16a99840a5edd 100644 (file)
--- a/src/Model/Item.php
+++ b/src/Model/Item.php
@@ -1028,6 +1028,7 @@ class Item extends BaseObject
                 * This only applies to photos uploaded from the photos page. Photos inserted into a post do not
                 * generate a resource-id and therefore aren't intimately linked to the item.
                 */
+               /// @TODO: this should first check if photo is used elsewhere
                if (strlen($item['resource-id'])) {
                        Photo::delete(['resource-id' => $item['resource-id'], 'uid' => $item['uid']]);
                }
@@ -1038,7 +1039,8 @@ class Item extends BaseObject
                }
 
                // If item has attachments, drop them
-               foreach (explode(", ", $item['attach']) as $attach) {
+               /// @TODO: this should first check if attachment is used elsewhere
+               foreach (explode(",", $item['attach']) as $attach) {
                        preg_match("|attach/(\d+)|", $attach, $matches);
                        if (is_array($matches) && count($matches) > 1) {
                                Attach::delete(['id' => $matches[1], 'uid' => $item['uid']]);