]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/Item.php
Merge pull request #11041 from tobiasd/2021.12-CHANGELOG
[friendica.git] / src / Model / Item.php
index 285187e5fbe70c6db44de2c32b8394917f8b2209..bf1f2585a1511392116f6c10a2a41d7c4450d8d1 100644 (file)
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2022, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -56,6 +56,7 @@ class Item
        const PT_VIDEO = 18;
        const PT_DOCUMENT = 19;
        const PT_EVENT = 32;
+       const PT_POLL = 33;
        const PT_PERSONAL_NOTE = 128;
 
        // Posting reasons (Why had a post been stored for a user?)
@@ -80,7 +81,7 @@ class Item
                'commented', 'created', 'edited', 'received', 'verb', 'object-type', 'postopts', 'plink',
                'wall', 'private', 'starred', 'origin', 'parent-origin', 'title', 'body', 'language',
                'content-warning', 'location', 'coord', 'app', 'rendered-hash', 'rendered-html', 'object',
-               'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'mention',
+               'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'mention', 'global',
                'author-id', 'author-link', 'author-name', 'author-avatar', 'author-network',
                'owner-id', 'owner-link', 'owner-name', 'owner-avatar', 'owner-network', 'owner-contact-type',
                'causer-id', 'causer-link', 'causer-name', 'causer-avatar', 'causer-contact-type', 'causer-network',
@@ -366,7 +367,7 @@ class Item
        public static function guid($item, $notify)
        {
                if (!empty($item['guid'])) {
-                       return Strings::escapeTags(trim($item['guid']));
+                       return trim($item['guid']);
                }
 
                if ($notify) {
@@ -448,7 +449,7 @@ class Item
                // We use "microtime" to keep the arrival order and "mt_rand" to avoid duplicates
                $file = 'item-' . round(microtime(true) * 10000) . '-' . mt_rand() . '.msg';
 
-               $spoolpath = get_spoolpath();
+               $spoolpath = System::getSpoolPath();
                if ($spoolpath != "") {
                        $spool = $spoolpath . '/' . $file;
 
@@ -949,7 +950,9 @@ class Item
                        $item['parent'] = $parent_id;
 
                        // Trigger automatic reactions for addons
-                       $item['api_source'] = true;
+                       if (!isset($item['api_source'])) {
+                               $item['api_source'] = true;
+                       }
 
                        // We have to tell the hooks who we are - this really should be improved
                        if (!local_user()) {
@@ -971,7 +974,7 @@ class Item
                }
 
                if (!empty($item['cancel'])) {
-                       Logger::log('post cancelled by addon.');
+                       Logger::notice('post cancelled by addon.');
                        return 0;
                }
 
@@ -1425,6 +1428,17 @@ class Item
        private static function storeForUser(array $item, int $uid)
        {
                if (Post::exists(['uri-id' => $item['uri-id'], 'uid' => $uid])) {
+                       if (!empty($item['event-id'])) {
+                               $post = Post::selectFirst(['event-id'], ['uri-id' => $item['uri-id'], 'uid' => $uid]);
+                               if (!empty($post['event-id'])) {
+                                       $event = DBA::selectFirst('event', ['edited', 'start', 'finish', 'summary', 'desc', 'location', 'nofinish', 'adjust'], ['id' => $item['event-id']]);
+                                       if (!empty($event)) {
+                                               // We aren't using "Event::store" here, since we don't want to trigger any further action
+                                               $ret = DBA::update('event', $event, ['id' => $post['event-id']]);
+                                               Logger::info('Event updated', ['uid' => $uid, 'source-event' => $item['event-id'], 'target-event' => $post['event-id'], 'ret' => $ret]);
+                                       }
+                               }
+                       }
                        Logger::info('Item already exists', ['uri-id' => $item['uri-id'], 'uid' => $uid]);
                        return 0;
                }
@@ -1859,73 +1873,60 @@ class Item
        {
                $mention = false;
 
-               $user = DBA::selectFirst('user', [], ['uid' => $uid]);
-               if (!DBA::isResult($user)) {
+               $owner = User::getOwnerDataById($uid);
+               if (!DBA::isResult($owner)) {
+                       Logger::warning('User not found, quitting.', ['uid' => $uid]);
                        return false;
                }
 
-               $community_page = (($user['page-flags'] == User::PAGE_FLAGS_COMMUNITY) ? true : false);
-               $prvgroup = (($user['page-flags'] == User::PAGE_FLAGS_PRVGROUP) ? true : false);
+               if ($owner['contact-type'] != User::ACCOUNT_TYPE_COMMUNITY) {
+                       Logger::debug('Owner is no community, quitting here.', ['uid' => $uid, 'id' => $item_id]);
+                       return false;
+               }
 
                $item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id]);
                if (!DBA::isResult($item)) {
+                       Logger::warning('Post not found, quitting.', ['id' => $item_id]);
                        return false;
                }
 
-               $link = Strings::normaliseLink(DI::baseUrl() . '/profile/' . $user['nickname']);
-
-               /*
-                * Diaspora uses their own hardwired link URL in @-tags
-                * instead of the one we supply with webfinger
-                */
-               $dlink = Strings::normaliseLink(DI::baseUrl() . '/u/' . $user['nickname']);
+               if ($item['wall'] || $item['origin'] || ($item['gravity'] != GRAVITY_PARENT)) {
+                       Logger::debug('Wall item, origin item or no parent post, quitting here.', ['wall' => $item['wall'], 'origin' => $item['origin'], 'gravity' => $item['gravity'], 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+                       return false;
+               }
 
-               $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER);
-               if ($cnt) {
-                       foreach ($matches as $mtch) {
-                               if (Strings::compareLink($link, $mtch[1]) || Strings::compareLink($dlink, $mtch[1])) {
-                                       $mention = true;
-                                       Logger::log('mention found: ' . $mtch[2]);
-                               }
+               $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
+               foreach ($tags as $tag) {
+                       if (Strings::compareLink($owner['url'], $tag['url'])) {
+                               $mention = true;
+                               Logger::info('Mention found in tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
                        }
                }
 
+               // This check can most likely be removed since we always are having the tags
                if (!$mention) {
-                       $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
-                       foreach ($tags as $tag) {
-                               if (Strings::compareLink($link, $tag['url']) || Strings::compareLink($dlink, $tag['url'])) {
-                                       $mention = true;
-                                       DI::logger()->info('mention found in tag.', ['url' => $tag['url']]);
+                       $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER);
+                       if ($cnt) {
+                               foreach ($matches as $mtch) {
+                                       if (Strings::compareLink($owner['url'], $mtch[1])) {
+                                               $mention = true;
+                                               Logger::notice('Mention found in body.', ['mention' => $mtch[2], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+                                       }
                                }
                        }
                }
 
                if (!$mention) {
-                       if (($community_page || $prvgroup) &&
-                                 !$item['wall'] && !$item['origin'] && ($item['gravity'] == GRAVITY_PARENT)) {
-                               Logger::info('Delete private group/communiy top-level item without mention', ['id' => $item['id'], 'guid'=> $item['guid']]);
-                               Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
-                               return true;
-                       }
-                       return false;
+                       Logger::info('Top-level post without mention is deleted.', ['uri' => $item['uri'], $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+                       Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
+                       return true;
                }
 
-               $arr = ['item' => $item, 'user' => $user];
+               $arr = ['item' => $item, 'user' => $owner];
 
                Hook::callAll('tagged', $arr);
 
-               if (!$community_page && !$prvgroup) {
-                       return false;
-               }
-
-               /*
-                * tgroup delivery - setup a second delivery chain
-                * prevent delivery looping - only proceed
-                * if the message originated elsewhere and is a top-level post
-                */
-               if ($item['wall'] || $item['origin'] || ($item['id'] != $item['parent'])) {
-                       return false;
-               }
+               Logger::info('Community post will be distributed', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
 
                self::performActivity($item['id'], 'announce', $uid);
 
@@ -1936,18 +1937,10 @@ class Item
                 * Or possibly we could store the receivers that had been in the "announce" message above and use this.
                 */
 
-               // now change this copy of the post to a forum head message and deliver to all the tgroup members
-               $self = DBA::selectFirst('contact', ['id', 'name', 'url', 'thumb'], ['uid' => $uid, 'self' => true]);
-               if (!DBA::isResult($self)) {
-                       return false;
-               }
-
-               $owner_id = Contact::getIdForURL($self['url']);
-
                // also reset all the privacy bits to the forum default permissions
-               if ($user['allow_cid'] || $user['allow_gid'] || $user['deny_cid'] || $user['deny_gid']) {
+               if ($owner['allow_cid'] || $owner['allow_gid'] || $owner['deny_cid'] || $owner['deny_gid']) {
                        $private = self::PRIVATE;
-               } elseif (DI::pConfig()->get($user['uid'], 'system', 'unlisted')) {
+               } elseif (DI::pConfig()->get($owner['uid'], 'system', 'unlisted')) {
                        $private = self::UNLISTED;
                } else {
                        $private = self::PUBLIC;
@@ -1955,21 +1948,22 @@ class Item
 
                $permissionSet = DI::permissionSet()->selectOrCreate(
                        DI::permissionSetFactory()->createFromString(
-                               $user['uid'],
-                               $user['allow_cid'],
-                               $user['allow_gid'],
-                               $user['deny_cid'],
-                               $user['deny_gid']
+                               $owner['uid'],
+                               $owner['allow_cid'],
+                               $owner['allow_gid'],
+                               $owner['deny_cid'],
+                               $owner['deny_gid']
                        ));
 
-               $forum_mode = ($prvgroup ? 2 : 1);
+               $forum_mode = ($owner['page-flags'] == User::PAGE_FLAGS_PRVGROUP) ? 2 : 1;
 
-               $fields = ['wall' => true, 'origin' => true, 'forum_mode' => $forum_mode, 'contact-id' => $self['id'],
-                       'owner-id' => $owner_id, 'private' => $private, 'psid' => $permissionSet->id];
+               $fields = ['wall' => true, 'origin' => true, 'forum_mode' => $forum_mode, 'contact-id' => $owner['id'],
+                       'owner-id' => Contact::getPublicIdByUserId($uid), 'private' => $private, 'psid' => $permissionSet->id];
                self::update($fields, ['id' => $item['id']]);
 
                Worker::add(['priority' => PRIORITY_HIGH, 'dont_fork' => true], 'Notifier', Delivery::POST, (int)$item['uri-id'], (int)$item['uid']);
 
+               Logger::info('Community post had been distributed', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
                return false;
        }
 
@@ -2258,8 +2252,8 @@ class Item
                        $condition[] = $network;
                }
 
-               $condition[0] .= " AND `received` < UTC_TIMESTAMP() - INTERVAL ? DAY";
-               $condition[] = $days;
+               $condition[0] .= " AND `received` < ?";
+               $condition[] = DateTimeFormat::utc('now - ' . $days . ' day');
 
                $items = Post::select(['resource-id', 'starred', 'id', 'post-type', 'uid', 'uri-id'], $condition);
 
@@ -2305,7 +2299,7 @@ class Item
                        ++$expired;
                }
                DBA::close($items);
-               Logger::log('User ' . $uid . ": expired $expired items; expire items: $expire_items, expire notes: $expire_notes, expire starred: $expire_starred, expire photos: $expire_photos");
+               Logger::notice('User ' . $uid . ": expired $expired items; expire items: $expire_items, expire notes: $expire_notes, expire starred: $expire_starred, expire photos: $expire_photos");
        }
 
        public static function firstPostDate($uid, $wall = false)
@@ -2354,7 +2348,7 @@ class Item
 
                $item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id]);
                if (!DBA::isResult($item)) {
-                       Logger::log('like: unknown item ' . $item_id);
+                       Logger::notice('like: unknown item', ['id' => $item_id]);
                        return false;
                }
 
@@ -2990,8 +2984,9 @@ class Item
        private static function addLinkAttachment(int $uriid, array $attachments, string $body, string $content, bool $shared, array $ignore_links)
        {
                DI::profiler()->startRecording('rendering');
-               // @ToDo Check only for audio and video
-               $preview = empty($attachments['visual']);
+               // Don't show a preview when there is a visual attachment (audio or video)
+               $types = array_column($attachments['visual'], 'type');
+               $preview = !in_array(Post\Media::IMAGE, $types) && !in_array(Post\Media::VIDEO, $types);
 
                if (!empty($attachments['link'])) {
                        foreach ($attachments['link'] as $link) {
@@ -3262,6 +3257,18 @@ class Item
                        return $item_id;
                }
 
+               $hookData = [
+                       'uri'     => $uri,
+                       'uid'     => $uid,
+                       'item_id' => null,
+               ];
+
+               Hook::callAll('item_by_link', $hookData);
+
+               if (isset($hookData['item_id'])) {
+                       return is_numeric($hookData['item_id']) ? $hookData['item_id'] : 0;
+               }
+
                if ($fetched_uri = ActivityPub\Processor::fetchMissingActivity($uri)) {
                        $item_id = self::searchByLink($fetched_uri, $uid);
                } else {
@@ -3354,7 +3361,7 @@ class Item
                        $body = $shared_item['body'];
                }
 
-               $item['body'] = preg_replace("/\[share ([^\[\]]*)\].*\[\/share\]/ism", '[share $1]' . $body . '[/share]', $item['body']);
+               $item['body'] = preg_replace("/\[share ([^\[\]]*)\].*\[\/share\]/ism", '[share $1]' . str_replace('$', '\$', $body) . '[/share]', $item['body']);
                unset($shared_item['body']);
 
                return array_merge($item, $shared_item);