use Friendica\Util\Network;
use Friendica\Util\Proxy;
use Friendica\Util\Strings;
+use Friendica\Util\Temporal;
use Friendica\Worker\Delivery;
use LanguageDetection\Language;
const PR_RELAY = 74;
const PR_FETCHED = 75;
+ // system.accept_only_sharer setting values
+ const COMPLETION_NONE = 1;
+ const COMPLETION_COMMENT = 0;
+ const COMPLETION_LIKE = 2;
+
// Field list that is used to display the items
const DISPLAY_FIELDLIST = [
'uid', 'id', 'parent', 'guid', 'network', 'gravity',
'wall', 'private', 'starred', 'origin', 'parent-origin', 'title', 'body', 'language',
'content-warning', 'location', 'coord', 'app', 'rendered-hash', 'rendered-html', 'object',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'mention', 'global',
- 'author-id', 'author-link', 'author-name', 'author-avatar', 'author-network',
- 'owner-id', 'owner-link', 'owner-name', 'owner-avatar', 'owner-network', 'owner-contact-type',
+ 'author-id', 'author-link', 'author-name', 'author-avatar', 'author-network', 'author-updated', 'author-gsid', 'author-addr', 'author-uri-id',
+ 'owner-id', 'owner-link', 'owner-name', 'owner-avatar', 'owner-network', 'owner-contact-type', 'owner-updated',
'causer-id', 'causer-link', 'causer-name', 'causer-avatar', 'causer-contact-type', 'causer-network',
'contact-id', 'contact-uid', 'contact-link', 'contact-name', 'contact-avatar',
'writable', 'self', 'cid', 'alias',
'event-created', 'event-edited', 'event-start', 'event-finish',
'event-summary', 'event-desc', 'event-location', 'event-type',
'event-nofinish', 'event-ignore', 'event-id',
+ 'question-id', 'question-multiple', 'question-voters', 'question-end-time',
+ 'has-categories', 'has-media',
'delivery_queue_count', 'delivery_queue_done', 'delivery_queue_failed'
];
'inform', 'deleted', 'extid', 'post-type', 'post-reason', 'gravity',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid',
'author-id', 'author-link', 'author-name', 'author-avatar', 'owner-id', 'owner-link', 'contact-uid',
- 'signed_text', 'network', 'wall', 'contact-id', 'plink', 'forum_mode', 'origin',
+ 'signed_text', 'network', 'wall', 'contact-id', 'plink', 'origin',
'thr-parent-id', 'parent-uri-id', 'postopts', 'pubmail',
'event-created', 'event-edited', 'event-start', 'event-finish',
'event-summary', 'event-desc', 'event-location', 'event-type',
'postopts', 'plink', 'resource-id', 'event-id', 'inform',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'post-type', 'post-reason',
'private', 'pubmail', 'visible', 'starred',
- 'unseen', 'deleted', 'origin', 'forum_mode', 'mention', 'global', 'network',
+ 'unseen', 'deleted', 'origin', 'mention', 'global', 'network',
'title', 'content-warning', 'body', 'location', 'coord', 'app',
'rendered-hash', 'rendered-html', 'object-type', 'object', 'target-type', 'target',
'author-id', 'author-link', 'author-name', 'author-avatar', 'author-network',
foreach ($notify_items as $notify_item) {
$post = Post::selectFirst(['uri-id', 'uid'], ['id' => $notify_item]);
- Worker::add(PRIORITY_HIGH, "Notifier", Delivery::POST, (int)$post['uri-id'], (int)$post['uid']);
+ Worker::add(PRIORITY_HIGH, 'Notifier', Delivery::POST, (int)$post['uri-id'], (int)$post['uid']);
}
return $rows;
*
* @param array $condition The condition for finding the item entries
* @param integer $priority Priority for the notification
+ * @return void
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function markForDeletion($condition, $priority = PRIORITY_HIGH)
+ public static function markForDeletion(array $condition, int $priority = PRIORITY_HIGH)
{
$items = Post::select(['id'], $condition);
while ($item = Post::fetch($items)) {
*
* @param array $condition The condition for finding the item entries
* @param integer $uid User who wants to delete this item
+ * @return void
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function deleteForUser($condition, $uid)
+ public static function deleteForUser(array $condition, int $uid)
{
if ($uid == 0) {
return;
*
* @param integer $item_id
* @param integer $priority Priority for the notification
- *
* @return boolean success
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function markForDeletionById($item_id, $priority = PRIORITY_HIGH)
+ public static function markForDeletionById(int $item_id, int $priority = PRIORITY_HIGH): bool
{
Logger::info('Mark item for deletion by id', ['id' => $item_id, 'callstack' => System::callstack()]);
// locate item to be deleted
// If item has attachments, drop them
$attachments = Post\Media::getByURIId($item['uri-id'], [Post\Media::DOCUMENT]);
foreach($attachments as $attachment) {
- if (preg_match("|attach/(\d+)|", $attachment['url'], $matches)) {
+ if (preg_match('|attach/(\d+)|', $attachment['url'], $matches)) {
Attach::delete(['id' => $matches[1], 'uid' => $item['uid']]);
}
}
// send the notification upstream/downstream
if ($priority) {
- Worker::add(['priority' => $priority, 'dont_fork' => true], "Notifier", Delivery::DELETION, (int)$item['uri-id'], (int)$item['uid']);
+ Worker::add(['priority' => $priority, 'dont_fork' => true], 'Notifier', Delivery::DELETION, (int)$item['uri-id'], (int)$item['uid']);
}
} elseif ($item['uid'] != 0) {
Post\User::update($item['uri-id'], $item['uid'], ['hidden' => true]);
return true;
}
- public static function guid($item, $notify)
+ /**
+ * Get guid from given item record
+ *
+ * @param array $item Item record
+ * @param bool Whether to notify (?)
+ * @return string Guid
+ */
+ public static function guid(array $item, bool $notify): string
{
if (!empty($item['guid'])) {
return trim($item['guid']);
return $guid;
}
- private static function contactId($item)
+ /**
+ * Returns contact id from given item record
+ *
+ * @param array $item Item record
+ * @return int Contact id
+ */
+ private static function contactId(array $item): int
{
if (!empty($item['contact-id']) && DBA::exists('contact', ['self' => true, 'id' => $item['contact-id']])) {
return $item['contact-id'];
* @param array $item The item fields that are to be inserted
* @throws \Exception
*/
- private static function spool($orig_item)
+ private static function spool(array $item)
{
// Now we store the data in the spool directory
// We use "microtime" to keep the arrival order and "mt_rand" to avoid duplicates
$file = 'item-' . round(microtime(true) * 10000) . '-' . mt_rand() . '.msg';
$spoolpath = System::getSpoolPath();
- if ($spoolpath != "") {
+ if ($spoolpath != '') {
$spool = $spoolpath . '/' . $file;
- file_put_contents($spool, json_encode($orig_item));
+ file_put_contents($spool, json_encode($item));
Logger::warning("Item wasn't stored - Item was spooled into file", ['file' => $file]);
}
}
/**
* Check if the item array is a duplicate
*
- * @param array $item
+ * @param array $item Item record
* @return boolean is it a duplicate?
*/
- private static function isDuplicate(array $item)
+ private static function isDuplicate(array $item): bool
{
// Checking if there is already an item with the same guid
$condition = ['guid' => $item['guid'], 'network' => $item['network'], 'uid' => $item['uid']];
/**
* Check if the item array is valid
*
- * @param array $item
+ * @param array $item Item record
* @return boolean item is valid
*/
- public static function isValid(array $item)
+ public static function isValid(array $item): bool
{
// When there is no content then we don't post it
if (($item['body'] . $item['title'] == '') && (empty($item['uri-id']) || !Post\Media::existsByURIId($item['uri-id']))) {
/**
* Check if the item array is too old
*
- * @param array $item
+ * @param array $item Item record
* @return boolean item is too old
*/
- public static function isTooOld(array $item)
+ public static function isTooOld(array $item): bool
{
// check for create date and expire time
$expire_interval = DI::config()->get('system', 'dbclean-expire-days', 0);
/**
* Return the id of the given item array if it has been stored before
*
- * @param array $item
- * @return integer item id
+ * @param array $item Item record
+ * @return integer Item id or zero on error
*/
- private static function getDuplicateID(array $item)
+ private static function getDuplicateID(array $item): int
{
if (empty($item['network']) || in_array($item['network'], Protocol::FEDERATED)) {
- $condition = ["`uri-id` = ? AND `uid` = ? AND `network` IN (?, ?, ?, ?)",
- $item['uri-id'], $item['uid'],
- Protocol::ACTIVITYPUB, Protocol::DIASPORA, Protocol::DFRN, Protocol::OSTATUS];
+ $condition = ['`uri-id` = ? AND `uid` = ? AND `network` IN (?, ?, ?, ?)',
+ $item['uri-id'],
+ $item['uid'],
+ Protocol::ACTIVITYPUB,
+ Protocol::DIASPORA,
+ Protocol::DFRN,
+ Protocol::OSTATUS
+ ];
$existing = Post::selectFirst(['id', 'network'], $condition);
if (DBA::isResult($existing)) {
// We only log the entries with a different user id than 0. Otherwise we would have too many false positives
'uri-id' => $item['uri-id'],
'uid' => $item['uid'],
'network' => $item['network'],
- 'existing_id' => $existing["id"],
- 'existing_network' => $existing["network"]
+ 'existing_id' => $existing['id'],
+ 'existing_network' => $existing['network']
]);
}
- return $existing["id"];
+ return $existing['id'];
}
}
return 0;
* @return array item array with parent data
* @throws \Exception
*/
- private static function getTopLevelParent(array $item)
+ private static function getTopLevelParent(array $item): array
{
$fields = ['uid', 'uri', 'parent-uri', 'id', 'deleted',
'uri-id', 'parent-uri-id',
'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid',
- 'wall', 'private', 'forum_mode', 'origin', 'author-id'];
+ 'wall', 'private', 'origin', 'author-id'];
$condition = ['uri-id' => $item['thr-parent-id'], 'uid' => $item['uid']];
$params = ['order' => ['id' => false]];
$parent = Post::selectFirst($fields, $condition, $params);
* @param array $item
* @return integer gravity
*/
- private static function getGravity(array $item)
+ private static function getGravity(array $item): int
{
$activity = DI::activity();
} elseif ($activity->match($item['verb'], Activity::ANNOUNCE)) {
return GRAVITY_ACTIVITY;
}
+
Logger::info('Unknown gravity for verb', ['verb' => $item['verb']]);
return GRAVITY_UNKNOWN; // Should not happen
}
- public static function insert(array $item, bool $notify = false, bool $post_local = true)
+ /**
+ * Inserts item record
+ *
+ * @param array $item Item array to be inserted
+ * @param int $notify Notification (type?)
+ * @param bool $post_local (???)
+ * @return int Zero means error, otherwise primary key (id) is being returned
+ */
+ public static function insert(array $item, int $notify = 0, bool $post_local = true): int
{
$orig_item = $item;
$item['protocol'] = Conversation::PARCEL_DIRECT;
$item['direction'] = Conversation::PUSH;
- if (in_array($notify, PRIORITIES)) {
+ if (is_int($notify) && in_array($notify, PRIORITIES)) {
$priority = $notify;
}
} else {
$item['inform'] = trim($item['inform'] ?? '');
$item['file'] = trim($item['file'] ?? '');
+ // Communities aren't working with the Diaspora protoccol
+ if (($uid != 0) && ($item['network'] == Protocol::DIASPORA)) {
+ $user = User::getById($uid, ['account-type']);
+ if ($user['account-type'] == Contact::TYPE_COMMUNITY) {
+ Logger::info('Community posts are not supported via Diaspora');
+ return 0;
+ }
+ }
+
// Items cannot be stored before they happen ...
if ($item['created'] > DateTimeFormat::utcNow()) {
$item['created'] = DateTimeFormat::utcNow();
Contact::checkAvatarCache($item['owner-id']);
// The contact-id should be set before "self::insert" was called - but there seems to be issues sometimes
- $item["contact-id"] = self::contactId($item);
+ $item['contact-id'] = self::contactId($item);
if (!empty($item['direction']) && in_array($item['direction'], [Conversation::PUSH, Conversation::RELAY]) &&
- self::isTooOld($item)) {
+ empty($item['origin']) &&self::isTooOld($item)) {
Logger::info('Item is too old', ['item' => $item]);
return 0;
}
$item['parent-uri'] = $toplevel_parent['uri'];
$item['parent-uri-id'] = $toplevel_parent['uri-id'];
$item['deleted'] = $toplevel_parent['deleted'];
- $item['allow_cid'] = $toplevel_parent['allow_cid'];
- $item['allow_gid'] = $toplevel_parent['allow_gid'];
- $item['deny_cid'] = $toplevel_parent['deny_cid'];
- $item['deny_gid'] = $toplevel_parent['deny_gid'];
+
+ // Reshares have to keep their permissions to allow forums to work
+ if (!$item['origin'] || ($item['verb'] != Activity::ANNOUNCE)) {
+ $item['allow_cid'] = $toplevel_parent['allow_cid'];
+ $item['allow_gid'] = $toplevel_parent['allow_gid'];
+ $item['deny_cid'] = $toplevel_parent['deny_cid'];
+ $item['deny_gid'] = $toplevel_parent['deny_gid'];
+ }
+
$parent_origin = $toplevel_parent['origin'];
// Don't federate received participation messages
$item['private'] = $toplevel_parent['private'];
}
- /*
- * Edge case. We host a public forum that was originally posted to privately.
- * The original author commented, but as this is a comment, the permissions
- * weren't fixed up so it will still show the comment as private unless we fix it here.
- */
- if ((intval($toplevel_parent['forum_mode']) == 1) && ($toplevel_parent['private'] != self::PUBLIC)) {
- $item['private'] = self::PUBLIC;
- }
-
// If its a post that originated here then tag the thread as "mention"
if ($item['origin'] && $item['uid']) {
DBA::update('post-thread-user', ['mention' => true], ['uri-id' => $item['parent-uri-id'], 'uid' => $item['uid']]);
$item['thr-parent-id'] = ItemURI::getIdByURI($item['thr-parent']);
// Is this item available in the global items (with uid=0)?
- if ($item["uid"] == 0) {
- $item["global"] = true;
+ if ($item['uid'] == 0) {
+ $item['global'] = true;
// Set the global flag on all items if this was a global item entry
Post::update(['global' => true], ['uri-id' => $item['uri-id']]);
}
// ACL settings
- if (!empty($item["allow_cid"] . $item["allow_gid"] . $item["deny_cid"] . $item["deny_gid"])) {
- $item["private"] = self::PRIVATE;
+ if (!empty($item['allow_cid'] . $item['allow_gid'] . $item['deny_cid'] . $item['deny_gid'])) {
+ $item['private'] = self::PRIVATE;
}
if ($notify && $post_local) {
unset($item['causer-id']);
}
+ if (in_array($item['network'], [Protocol::ACTIVITYPUB, Protocol::DFRN])) {
+ $content_warning = BBCode::getAbstract($item['body'], Protocol::ACTIVITYPUB);
+ if (!empty($content_warning) && empty($item['content-warning'])) {
+ $item['content-warning'] = BBCode::toPlaintext($content_warning);
+ }
+ }
+
Post::insert($item['uri-id'], $item);
if ($item['gravity'] == GRAVITY_PARENT) {
Worker::add(['priority' => $priority, 'dont_fork' => true], 'Notifier', $notify_type, (int)$posted_item['uri-id'], (int)$posted_item['uid']);
}
+ // Fill the cache with the rendered content.
+ if (in_array($posted_item['gravity'], [GRAVITY_PARENT, GRAVITY_COMMENT]) && ($posted_item['uid'] == 0)) {
+ self::updateDisplayCache($posted_item['uri-id']);
+ }
+
+ if ($posted_item['origin'] && ($posted_item['uid'] != 0) && in_array($posted_item['gravity'], [GRAVITY_PARENT, GRAVITY_COMMENT])) {
+ DI::cache()->delete(ActivityPub\Transmitter::CACHEKEY_OUTBOX . $posted_item['uid']);
+ }
+
return $post_user_id;
}
+ /**
+ * Update the display cache
+ *
+ * @param integer $uri_id
+ * @return void
+ */
+ public static function updateDisplayCache(int $uri_id)
+ {
+ $item = Post::selectFirst(self::DISPLAY_FIELDLIST, ['uri-id' => $uri_id]);
+ self::prepareBody($item, false, false, true);
+ }
+
/**
* Change the owner of a parent item if it had been shared by a forum
*
return;
}
+ $self_contact = Contact::selectFirst(['id'], ['uid' => $item['uid'], 'self' => true]);
+ $self = !empty($self_contact) ? $self_contact['id'] : 0;
+
$cid = Contact::getIdForURL($author['url'], $item['uid']);
- if (empty($cid) || !Contact::isSharing($cid, $item['uid'])) {
+ if (empty($cid) || (!Contact::isSharing($cid, $item['uid']) && ($cid != $self))) {
Logger::info('The resharer is not a following contact: quit', ['resharer' => $author['url'], 'uid' => $item['uid'], 'cid' => $cid]);
return;
}
* @param string $signed_text Original text (for Diaspora signatures), JSON encoded.
* @throws \Exception
*/
- public static function distribute($itemid, $signed_text = '')
+ public static function distribute(int $itemid, string $signed_text = '')
{
$condition = ["`id` IN (SELECT `parent` FROM `post-user-view` WHERE `id` = ?)", $itemid];
$parent = Post::selectFirst(['owner-id'], $condition);
* @param integer $source_uid User id of the source post
* @return integer stored item id
*/
- public static function storeForUserByUriId(int $uri_id, int $uid, array $fields = [], int $source_uid = 0)
+ public static function storeForUserByUriId(int $uri_id, int $uid, array $fields = [], int $source_uid = 0): int
{
if ($uid == $source_uid) {
Logger::warning('target UID must not be be equal to the source UID', ['uri-id' => $uri_id, 'uid' => $uid]);
$is_reshare = ($item['gravity'] == GRAVITY_ACTIVITY) && ($item['verb'] == Activity::ANNOUNCE);
if ((($item['gravity'] == GRAVITY_PARENT) || $is_reshare) &&
- DI::pConfig()->get($uid, 'system', 'accept_only_sharer') &&
+ DI::pConfig()->get($uid, 'system', 'accept_only_sharer') == self::COMPLETION_NONE &&
!Contact::isSharingByURL($item['author-link'], $uid) &&
!Contact::isSharingByURL($item['owner-link'], $uid)) {
Logger::info('Contact is not a follower, thread will not be stored', ['author' => $item['author-link'], 'uid' => $uid]);
return 0;
}
- if ((($item['gravity'] == GRAVITY_COMMENT) || $is_reshare) && !Post::exists(['uri-id' => $item['thr-parent-id'], 'uid' => $uid])) {
- // Only do an auto complete with the source uid "0" to prevent privavy problems
+ if (($uri_id != $item['thr-parent-id']) && (($item['gravity'] == GRAVITY_COMMENT) || $is_reshare) && !Post::exists(['uri-id' => $item['thr-parent-id'], 'uid' => $uid])) {
+ // Fetch the origin user for the post
+ $origin_uid = self::GetOriginUidForUriId($item['thr-parent-id'], $uid);
+ if (is_null($origin_uid)) {
+ Logger::info('Origin item was not found', ['uid' => $uid, 'uri-id' => $item['thr-parent-id']]);
+ return 0;
+ }
+
$causer = $item['causer-id'] ?: $item['author-id'];
- $result = self::storeForUserByUriId($item['thr-parent-id'], $uid, ['causer-id' => $causer, 'post-reason' => self::PR_FETCHED]);
+ $result = self::storeForUserByUriId($item['thr-parent-id'], $uid, ['causer-id' => $causer, 'post-reason' => self::PR_FETCHED], $origin_uid);
Logger::info('Fetched thread parent', ['uri-id' => $item['thr-parent-id'], 'uid' => $uid, 'causer' => $causer, 'result' => $result]);
}
return $stored;
}
+ /**
+ * Returns the origin uid of a post if the given user is allowed to see it.
+ *
+ * @param int $uriid
+ * @param int $uid
+ * @return int
+ */
+ private static function GetOriginUidForUriId(int $uriid, int $uid)
+ {
+ if (Post::exists(['uri-id' => $uriid, 'uid' => $uid])) {
+ return $uid;
+ }
+
+ $post = Post::selectFirst(['uid', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'private'], ['uri-id' => $uriid, 'origin' => true]);
+ if (!empty($post)) {
+ if (in_array($post['private'], [Item::PUBLIC, Item::UNLISTED])) {
+ return $post['uid'];
+ }
+
+ $pcid = Contact::getPublicIdByUserId($uid);
+ if (empty($pcid)) {
+ return null;
+ }
+
+ foreach (Item::enumeratePermissions($post, true) as $receiver) {
+ if ($receiver == $pcid) {
+ return $post['uid'];
+ }
+ }
+
+ return null;
+ }
+
+ if (Post::exists(['uri-id' => $uriid, 'uid' => 0])) {
+ return 0;
+ }
+
+ // When the post belongs to a a forum then all forum users are allowed to access it
+ foreach (Tag::getByURIId($uriid, [Tag::MENTION, Tag::EXCLUSIVE_MENTION]) as $tag) {
+ if (DBA::exists('contact', ['uid' => $uid, 'nurl' => Strings::normaliseLink($tag['url']), 'contact-type' => Contact::TYPE_COMMUNITY])) {
+ $target_uid = User::getIdForURL($tag['url']);
+ if (!empty($target_uid)) {
+ return $target_uid;
+ }
+ }
+ }
+
+ return null;
+ }
+
/**
* Store a public item array for the given users
*
* @return integer stored item id
* @throws \Exception
*/
- private static function storeForUser(array $item, int $uid)
+ private static function storeForUser(array $item, int $uid): int
{
if (Post::exists(['uri-id' => $item['uri-id'], 'uid' => $uid])) {
if (!empty($item['event-id'])) {
return 0;
}
+ // Data from the "post-user" table
unset($item['id']);
unset($item['mention']);
unset($item['starred']);
unset($item['pinned']);
unset($item['ignored']);
unset($item['pubmail']);
- unset($item['forum_mode']);
-
unset($item['event-id']);
unset($item['hidden']);
unset($item['notification-type']);
+ unset($item['post-reason']);
+
+ // Data from the "post-delivery-data" table
+ unset($item['postopts']);
+ unset($item['inform']);
$item['uid'] = $uid;
$item['origin'] = 0;
* @param integer $itemid Item ID that should be added
* @throws \Exception
*/
- private static function addShadow($itemid)
+ private static function addShadow(int $itemid)
{
$fields = ['uid', 'private', 'visible', 'deleted', 'network', 'uri-id'];
$condition = ['id' => $itemid, 'gravity' => GRAVITY_PARENT];
* @param integer $itemid Item ID that should be added
* @throws \Exception
*/
- private static function addShadowPost($itemid)
+ private static function addShadowPost(int $itemid)
{
$item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $itemid]);
if (!DBA::isResult($item)) {
* @return string detected language
* @throws \Text_LanguageDetect_Exception
*/
- private static function getLanguage(array $item)
+ private static function getLanguage(array $item): string
{
if (!empty($item['language'])) {
return $item['language'];
// which point it will be automatically available through `getAvailableLanguages()` and this should be removed.
$availableLanguages['fa'] = 'fa';
- $ld = new Language($availableLanguages);
+ $ld = new Language(array_keys($availableLanguages));
$languages = $ld->detect($naked_body)->limit(0, 3)->close();
if (is_array($languages)) {
return json_encode($languages);
return '';
}
- public static function getLanguageMessage(array $item)
+ public static function getLanguageMessage(array $item): string
{
$iso639 = new \Matriphe\ISO639\ISO639;
}
/**
- * Creates an unique guid out of a given uri
+ * Creates an unique guid out of a given uri.
+ * This function is used for messages outside the fediverse (Connector posts, feeds, Mails, ...)
+ * Posts that are created on this system are using System::createUUID.
+ * Received ActivityPub posts are using Processor::getGUIDByURL.
*
* @param string $uri uri of an item entry
* @param string $host hostname for the GUID prefix
* @return string unique guid
*/
- public static function guidFromUri($uri, $host)
+ public static function guidFromUri(string $uri, string $host): string
{
// Our regular guid routine is using this kind of prefix as well
// We have to avoid that different routines could accidentally create the same value
$parsed = parse_url($uri);
- // We use a hash of the hostname as prefix for the guid
- $guid_prefix = hash("crc32", $host);
-
// Remove the scheme to make sure that "https" and "http" doesn't make a difference
- unset($parsed["scheme"]);
+ unset($parsed['scheme']);
// Glue it together to be able to make a hash from it
- $host_id = implode("/", $parsed);
-
- // We could use any hash algorithm since it isn't a security issue
- $host_hash = hash("ripemd128", $host_id);
+ $host_id = implode('/', $parsed);
- return $guid_prefix.$host_hash;
+ // Use a mixture of several hashes to provide some GUID like experience
+ return hash('crc32', $host) . '-'. hash('joaat', $host_id) . '-'. hash('fnv164', $host_id);
}
/**
* @return string
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function newURI($uid, $guid = "")
+ public static function newURI(int $uid, string $guid = ''): string
{
- if ($guid == "") {
+ if ($guid == '') {
$guid = System::createUUID();
}
* @param array $arr Contains the just posted item record
* @throws \Exception
*/
- private static function updateContact($arr)
+ private static function updateContact(array $arr)
{
// Unarchive the author
$contact = DBA::selectFirst('contact', [], ['id' => $arr["author-id"]]);
}
}
- public static function setHashtags($body)
+ public static function setHashtags(string $body): string
{
$body = BBCode::performWithEscapedTags($body, ['noparse', 'pre', 'code', 'img'], function ($body) {
$tags = BBCode::getTags($body);
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
*/
- private static function tagDeliver($uid, $item_id)
+ private static function tagDeliver(int $uid, int $item_id): bool
{
$mention = false;
$owner = User::getOwnerDataById($uid);
if (!DBA::isResult($owner)) {
- Logger::warning('User not found, quitting.', ['uid' => $uid]);
+ Logger::warning('User not found, quitting here.', ['uid' => $uid]);
return false;
}
return false;
}
- $item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id]);
+ $item = Post::selectFirst(self::ITEM_FIELDLIST, ['id' => $item_id, 'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT], 'origin' => false]);
if (!DBA::isResult($item)) {
- Logger::warning('Post not found, quitting.', ['id' => $item_id]);
+ Logger::debug('Post is an activity or origin or not found at all, quitting here.', ['id' => $item_id]);
return false;
}
- if ($item['wall'] || $item['origin'] || ($item['gravity'] != GRAVITY_PARENT)) {
- Logger::debug('Wall item, origin item or no parent post, quitting here.', ['wall' => $item['wall'], 'origin' => $item['origin'], 'gravity' => $item['gravity'], 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- return false;
- }
+ if ($item['gravity'] == GRAVITY_PARENT) {
+ $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
+ foreach ($tags as $tag) {
+ if (Strings::compareLink($owner['url'], $tag['url'])) {
+ $mention = true;
+ Logger::info('Mention found in tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ }
+ }
- $tags = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
- foreach ($tags as $tag) {
- if (Strings::compareLink($owner['url'], $tag['url'])) {
- $mention = true;
- Logger::info('Mention found in tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ if (!$mention) {
+ Logger::info('Top-level post without mention is deleted.', ['uri' => $item['uri'], $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
+ return true;
}
- }
- // This check can most likely be removed since we always are having the tags
- if (!$mention) {
- $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER);
- if ($cnt) {
- foreach ($matches as $mtch) {
- if (Strings::compareLink($owner['url'], $mtch[1])) {
- $mention = true;
- Logger::notice('Mention found in body.', ['mention' => $mtch[2], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- }
+ $arr = ['item' => $item, 'user' => $owner];
+
+ Hook::callAll('tagged', $arr);
+ } else {
+ $tags = Tag::getByURIId($item['parent-uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
+ foreach ($tags as $tag) {
+ if (Strings::compareLink($owner['url'], $tag['url'])) {
+ $mention = true;
+ Logger::info('Mention found in parent tag.', ['url' => $tag['url'], 'uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
}
}
- }
- if (!$mention) {
- Logger::info('Top-level post without mention is deleted.', ['uri' => $item['uri'], $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- Post\User::delete(['uri-id' => $item['uri-id'], 'uid' => $item['uid']]);
- return true;
+ if (!$mention) {
+ Logger::debug('No mentions found in parent, quitting here.', ['id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
+ return false;
+ }
}
- $arr = ['item' => $item, 'user' => $owner];
-
- Hook::callAll('tagged', $arr);
-
Logger::info('Community post will be distributed', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
- self::performActivity($item['id'], 'announce', $uid);
-
- /**
- * All the following lines are only needed for private forums and compatibility to older systems without AP support.
- * A possible way would be that the followers list of a forum would always be readable by all followers.
- * So this would mean that the comment distribution could be done exactly for the intended audience.
- * Or possibly we could store the receivers that had been in the "announce" message above and use this.
- */
-
- // also reset all the privacy bits to the forum default permissions
- if ($owner['allow_cid'] || $owner['allow_gid'] || $owner['deny_cid'] || $owner['deny_gid']) {
- $private = self::PRIVATE;
- } elseif (DI::pConfig()->get($owner['uid'], 'system', 'unlisted')) {
- $private = self::UNLISTED;
+ if ($owner['page-flags'] == User::PAGE_FLAGS_PRVGROUP) {
+ $allow_cid = '';
+ $allow_gid = '<' . Group::FOLLOWERS . '>';
+ $deny_cid = '';
+ $deny_gid = '';
+ self::performActivity($item['id'], 'announce', $uid, $allow_cid, $allow_gid, $deny_cid, $deny_gid);
} else {
- $private = self::PUBLIC;
+ self::performActivity($item['id'], 'announce', $uid);
}
- $permissionSet = DI::permissionSet()->selectOrCreate(
- DI::permissionSetFactory()->createFromString(
- $owner['uid'],
- $owner['allow_cid'],
- $owner['allow_gid'],
- $owner['deny_cid'],
- $owner['deny_gid']
- ));
-
- $forum_mode = ($owner['page-flags'] == User::PAGE_FLAGS_PRVGROUP) ? 2 : 1;
-
- $fields = ['wall' => true, 'origin' => true, 'forum_mode' => $forum_mode, 'contact-id' => $owner['id'],
- 'owner-id' => Contact::getPublicIdByUserId($uid), 'private' => $private, 'psid' => $permissionSet->id];
- self::update($fields, ['id' => $item['id']]);
-
- Worker::add(['priority' => PRIORITY_HIGH, 'dont_fork' => true], 'Notifier', Delivery::POST, (int)$item['uri-id'], (int)$item['uid']);
-
Logger::info('Community post had been distributed', ['uri' => $item['uri'], 'uid' => $uid, 'id' => $item_id, 'uri-id' => $item['uri-id'], 'guid' => $item['guid']]);
return false;
}
self::performActivity($item['id'], 'announce', $item['uid']);
}
- public static function isRemoteSelf($contact, &$datarray)
+ public static function isRemoteSelf(array $contact, array &$datarray): bool
{
if (!$contact['remote_self']) {
return false;
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
*/
- public static function fixPrivatePhotos($s, $uid, $item = null, $cid = 0)
+ public static function fixPrivatePhotos(string $s, int $uid, array $item = null, int $cid = 0): string
{
if (DI::config()->get('system', 'disable_embedded')) {
return $s;
return $new_body;
}
- private static function hasPermissions($obj)
+ private static function hasPermissions(array $obj)
{
return !empty($obj['allow_cid']) || !empty($obj['allow_gid']) ||
!empty($obj['deny_cid']) || !empty($obj['deny_gid']);
}
- private static function samePermissions($uid, $obj1, $obj2)
+ // @TODO $uid is unused parameter
+ private static function samePermissions($uid, array $obj1, array $obj2): bool
{
// first part is easy. Check that these are exactly the same.
if (($obj1['allow_cid'] == $obj2['allow_cid'])
* @return array
* @throws \Exception
*/
- public static function enumeratePermissions(array $obj, bool $check_dead = false)
+ public static function enumeratePermissions(array $obj, bool $check_dead = false): array
{
$aclFormater = DI::aclFormatter();
Logger::notice('User ' . $uid . ": expired $expired items; expire items: $expire_items, expire notes: $expire_notes, expire starred: $expire_starred, expire photos: $expire_photos");
}
- public static function firstPostDate($uid, $wall = false)
+ public static function firstPostDate(int $uid, bool $wall = false)
{
$user = User::getById($uid, ['register_date']);
if (empty($user)) {
*
* Toggle activities as like,dislike,attend of an item
*
- * @param int $item_id
+ * @param int $item_id
* @param string $verb
* Activity verb. One of
* like, unlike, dislike, undislike, attendyes, unattendyes,
* attendno, unattendno, attendmaybe, unattendmaybe,
* announce, unannouce
+ * @param int $uid
+ * @param string $allow_cid
+ * @param string $allow_gid
+ * @param string $deny_cid
+ * @param string $deny_gid
* @return bool
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
* array $arr
* 'post_id' => ID of posted item
*/
- public static function performActivity(int $item_id, string $verb, int $uid)
+ public static function performActivity(int $item_id, string $verb, int $uid, string $allow_cid = null, string $allow_gid = null, string $deny_cid = null, string $deny_gid = null): bool
{
if (empty($uid)) {
return false;
'body' => $activity,
'verb' => $activity,
'object-type' => $objtype,
- 'allow_cid' => $item['allow_cid'],
- 'allow_gid' => $item['allow_gid'],
- 'deny_cid' => $item['deny_cid'],
- 'deny_gid' => $item['deny_gid'],
+ 'allow_cid' => $allow_cid ?? $item['allow_cid'],
+ 'allow_gid' => $allow_gid ?? $item['allow_gid'],
+ 'deny_cid' => $deny_cid ?? $item['deny_cid'],
+ 'deny_gid' => $deny_gid ?? $item['deny_gid'],
'visible' => 1,
'unseen' => 1,
];
* @param integer $owner_id User ID for which the permissions should be fetched
* @return array condition
*/
- public static function getPermissionsConditionArrayByUserId(int $owner_id)
+ public static function getPermissionsConditionArrayByUserId(int $owner_id): array
{
$local_user = local_user();
$remote_user = Session::getRemoteContactID($owner_id);
* @param string $table
* @return string
*/
- public static function getPermissionsSQLByUserId(int $owner_id, string $table = '')
+ public static function getPermissionsSQLByUserId(int $owner_id, string $table = ''): string
{
$local_user = local_user();
$remote_user = Session::getRemoteContactID($owner_id);
* @param \Friendica\Core\L10n $l10n
* @return string
*/
- public static function postType(array $item, \Friendica\Core\L10n $l10n)
+ public static function postType(array $item, \Friendica\Core\L10n $l10n): string
{
if (!empty($item['event-id'])) {
return $l10n->t('event');
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @todo Remove reference, simply return "rendered-html" and "rendered-hash"
*/
- public static function putInCache(&$item)
+ private static function putInCache(&$item)
{
// Save original body to prevent addons to modify it
$body = $item['body'];
|| $rendered_hash != hash('md5', BBCode::VERSION . '::' . $body)
|| DI::config()->get('system', 'ignore_cache')
) {
- self::addRedirToImageTags($item);
-
$item['rendered-html'] = BBCode::convertForUriId($item['uri-id'], $item['body']);
$item['rendered-hash'] = hash('md5', BBCode::VERSION . '::' . $body);
$item['body'] = $body;
}
- /**
- * Find any non-embedded images in private items and add redir links to them
- *
- * @param array &$item The field array of an item row
- */
- private static function addRedirToImageTags(array &$item)
- {
- $app = DI::app();
-
- $matches = [];
- $cnt = preg_match_all('|\[img\](http[^\[]*?/photo/[a-fA-F0-9]+?(-[0-9]\.[\w]+?)?)\[\/img\]|', $item['body'], $matches, PREG_SET_ORDER);
- if ($cnt) {
- foreach ($matches as $mtch) {
- if (strpos($mtch[1], '/redir') !== false) {
- continue;
- }
-
- if ((local_user() == $item['uid']) && ($item['private'] == self::PRIVATE) && ($item['contact-id'] != $app->getContactId()) && ($item['network'] == Protocol::DFRN)) {
- $img_url = 'redir/' . $item['contact-id'] . '?url=' . urlencode($mtch[1]);
- $item['body'] = str_replace($mtch[0], '[img]' . $img_url . '[/img]', $item['body']);
- }
- }
- }
- }
-
/**
* Given an item array, convert the body element from bbcode to html and add smilie icons.
* If attach is true, also add icons for item attachments.
*
- * @param array $item
- * @param boolean $attach
- * @param boolean $is_preview
+ * @param array $item Record from item table
+ * @param boolean $attach If true, add icons for item attachments as well
+ * @param boolean $is_preview Whether this is a preview
+ * @param boolean $only_cache Whether only cached HTML should be updated
* @return string item body html
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
* @hook prepare_body ('item'=>item array, 'html'=>body string, 'is_preview'=>boolean, 'filter_reasons'=>string array) after first bbcode to html
* @hook prepare_body_final ('item'=>item array, 'html'=>body string) after attach icons and blockquote special case handling (spoiler, author)
*/
- public static function prepareBody(array &$item, $attach = false, $is_preview = false)
+ public static function prepareBody(array &$item, bool $attach = false, bool $is_preview = false, bool $only_cache = false): string
{
$a = DI::app();
Hook::callAll('prepare_body_init', $item);
$body = $item['body'] ?? '';
$shared = BBCode::fetchShareAttributes($body);
if (!empty($shared['guid'])) {
- $shared_item = Post::selectFirst(['uri-id', 'plink'], ['guid' => $shared['guid']]);
+ $shared_item = Post::selectFirst(['uri-id', 'plink', 'has-media'], ['guid' => $shared['guid']]);
$shared_uri_id = $shared_item['uri-id'] ?? 0;
$shared_links = [strtolower($shared_item['plink'] ?? '')];
- $shared_attachments = Post\Media::splitAttachments($shared_uri_id, $shared['guid']);
+ $shared_attachments = Post\Media::splitAttachments($shared_uri_id, $shared['guid'], [], $shared_item['has-media'] ?? false);
$shared_links = array_merge($shared_links, array_column($shared_attachments['visual'], 'url'));
$shared_links = array_merge($shared_links, array_column($shared_attachments['link'], 'url'));
$shared_links = array_merge($shared_links, array_column($shared_attachments['additional'], 'url'));
$shared_uri_id = 0;
$shared_links = [];
}
- $attachments = Post\Media::splitAttachments($item['uri-id'], $item['guid'] ?? '', $shared_links);
+
+ $attachments = Post\Media::splitAttachments($item['uri-id'], $item['guid'] ?? '', $shared_links, $item['has-media'] ?? false);
$item['body'] = self::replaceVisualAttachments($attachments, $item['body'] ?? '');
$item['body'] = preg_replace("/\s*\[attachment .*?\].*?\[\/attachment\]\s*/ism", "\n", $item['body']);
$item['body'] = $body;
$s = $item["rendered-html"];
+ if ($only_cache) {
+ return '';
+ }
+
// Compile eventual content filter reasons
$filter_reasons = [];
if (!$is_preview && public_contact() != $item['author-id']) {
$s = self::addVisualAttachments($attachments, $item, $s, false);
$s = self::addLinkAttachment($item['uri-id'], $attachments, $body, $s, false, $shared_links);
$s = self::addNonVisualAttachments($attachments, $item, $s, false);
+ $s = self::addQuestions($item, $s);
// Map.
if (strpos($s, '<div class="map">') !== false && !empty($item['coord'])) {
* @param int $type
* @return bool
*/
- public static function containsLink(string $body, string $url, int $type = 0)
+ public static function containsLink(string $body, string $url, int $type = 0): bool
{
// Make sure that for example site parameters aren't used when testing if the link is contained in the body
$urlparts = parse_url($url);
* @param string $body
* @return string modified body
*/
- private static function replaceVisualAttachments(array $attachments, string $body)
+ private static function replaceVisualAttachments(array $attachments, string $body): string
{
DI::profiler()->startRecording('rendering');
foreach ($attachments['visual'] as $attachment) {
if (!empty($attachment['preview'])) {
- $body = str_replace($attachment['preview'], Post\Media::getPreviewUrlForId($attachment['id'], Proxy::SIZE_LARGE), $body);
+ $proxy = Post\Media::getPreviewUrlForId($attachment['id'], Proxy::SIZE_LARGE);
+ $search = ['[img=' . $attachment['preview'] . ']', ']' . $attachment['preview'] . '[/img]'];
+ $replace = ['[img=' . $proxy . ']', ']' . $proxy . '[/img]'];
+
+ $body = str_replace($search, $replace, $body);
} elseif ($attachment['filetype'] == 'image') {
- $body = str_replace($attachment['url'], Post\Media::getUrlForId($attachment['id']), $body);
+ $proxy = Post\Media::getUrlForId($attachment['id']);
+ $search = ['[img=' . $attachment['url'] . ']', ']' . $attachment['url'] . '[/img]'];
+ $replace = ['[img=' . $proxy . ']', ']' . $proxy . '[/img]'];
+
+ $body = str_replace($search, $replace, $body);
}
}
DI::profiler()->stopRecording();
* @param string $content
* @return string modified content
*/
- private static function addVisualAttachments(array $attachments, array $item, string $content, bool $shared)
+ private static function addVisualAttachments(array $attachments, array $item, string $content, bool $shared): string
{
DI::profiler()->startRecording('rendering');
$leading = '';
* @param array $ignore_links A list of URLs to ignore
* @return string modified content
*/
- private static function addLinkAttachment(int $uriid, array $attachments, string $body, string $content, bool $shared, array $ignore_links)
+ private static function addLinkAttachment(int $uriid, array $attachments, string $body, string $content, bool $shared, array $ignore_links): string
{
DI::profiler()->startRecording('rendering');
// Don't show a preview when there is a visual attachment (audio or video)
* @param string $content
* @return string modified content
*/
- private static function addNonVisualAttachments(array $attachments, array $item, string $content)
+ private static function addNonVisualAttachments(array $attachments, array $item, string $content): string
{
DI::profiler()->startRecording('rendering');
$trailing = '';
return $content;
}
+ private static function addQuestions(array $item, string $content): string
+ {
+ DI::profiler()->startRecording('rendering');
+ if (!empty($item['question-id'])) {
+ $question = [
+ 'id' => $item['question-id'],
+ 'multiple' => $item['question-multiple'],
+ 'voters' => $item['question-voters'],
+ 'endtime' => $item['question-end-time']
+ ];
+
+ $options = Post\QuestionOption::getByURIId($item['uri-id']);
+ foreach ($options as $key => $option) {
+ $percent = $question['voters'] ? ($option['replies'] / $question['voters'] * 100) : 0;
+
+ $options[$key]['percent'] = $percent;
+
+ if ($question['voters'] > 0) {
+ $options[$key]['vote'] = DI::l10n()->t('%s (%d%s, %d votes)', $option['name'], round($percent, 1), '%', $option['replies']);
+ } else {
+ $options[$key]['vote'] = DI::l10n()->t('%s (%d votes)', $option['name'], $option['replies']);
+ }
+ }
+
+ if (!empty($question['voters']) && !empty($question['endtime'])) {
+ $summary = DI::l10n()->t('%d voters. Poll end: %s', $question['voters'], Temporal::getRelativeDate($question['endtime']));
+ } elseif (!empty($question['voters'])) {
+ $summary = DI::l10n()->t('%d voters.', $question['voters']);
+ } elseif (!empty($question['endtime'])) {
+ $summary = DI::l10n()->t('Poll end: %s', Temporal::getRelativeDate($question['endtime']));
+ } else {
+ $summary = '';
+ }
+
+ $content .= Renderer::replaceMacros(Renderer::getMarkupTemplate('content/question.tpl'), [
+ '$question' => $question,
+ '$options' => $options,
+ '$summary' => $summary,
+ ]);
+ }
+ DI::profiler()->stopRecording();
+ return $content;
+ }
+
/**
* get private link for item
*
* @return boolean|array False if item has not plink, otherwise array('href'=>plink url, 'title'=>translated title)
* @throws \Exception
*/
- public static function getPlink($item)
+ public static function getPlink(array $item)
{
+ if (!empty($item['plink']) && Network::isValidHttpUrl($item['plink'])) {
+ $plink = $item['plink'];
+ } elseif (!empty($item['uri']) && Network::isValidHttpUrl($item['uri']) && !Network::isLocalLink($item['uri'])) {
+ $plink = $item['uri'];
+ }
+
if (local_user()) {
$ret = [
'href' => "display/" . $item['guid'],
'orig_title' => DI::l10n()->t('View on separate page'),
];
- if (!empty($item['plink'])) {
- $ret['href'] = DI::baseUrl()->remove($item['plink']);
+ if (!empty($plink) && ($item['private'] == self::PRIVATE)) {
+ $author = ['uid' => 0, 'id' => $item['author-id'],
+ 'network' => $item['author-network'], 'url' => $item['author-link']];
+ $plink = Contact::magicLinkByContact($author, $plink);
+ }
+
+ if (!empty($plink)) {
+ $ret['href'] = DI::baseUrl()->remove($plink);
$ret['title'] = DI::l10n()->t('Link to source');
}
- } elseif (!empty($item['plink']) && ($item['private'] != self::PRIVATE)) {
+ } elseif (!empty($plink) && ($item['private'] != self::PRIVATE)) {
$ret = [
- 'href' => $item['plink'],
- 'orig' => $item['plink'],
+ 'href' => $plink,
+ 'orig' => $plink,
'title' => DI::l10n()->t('Link to source'),
'orig_title' => DI::l10n()->t('Link to source'),
];
}
/**
- * Is the given item array a post that is sent as starting post to a forum?
+ * Does the given uri-id belongs to a post that is sent as starting post to a forum?
*
- * @param array $item
- * @param array $owner
+ * @param int $uri_id
*
* @return boolean "true" when it is a forum post
*/
- public static function isForumPost(array $item, array $owner = [])
+ public static function isForumPost(int $uri_id): bool
{
- if (empty($owner)) {
- $owner = User::getOwnerDataById($item['uid']);
- if (empty($owner)) {
- return false;
+ foreach (Tag::getByURIId($uri_id, [Tag::EXCLUSIVE_MENTION]) as $tag) {
+ if (DBA::exists('contact', ['uid' => 0, 'nurl' => Strings::normaliseLink($tag['url']), 'contact-type' => Contact::TYPE_COMMUNITY])) {
+ return true;
}
}
-
- if (($item['author-id'] == $item['owner-id']) ||
- ($owner['id'] == $item['contact-id']) ||
- ($item['uri-id'] != $item['parent-uri-id']) ||
- $item['origin']) {
- return false;
- }
-
- return Contact::isForum($item['contact-id']);
+ return false;
}
/**
*
* @return integer item id
*/
- public static function searchByLink($uri, $uid = 0)
+ public static function searchByLink(string $uri, int $uid = 0): int
{
$ssl_uri = str_replace('http://', 'https://', $uri);
$uris = [$uri, $ssl_uri, Strings::normaliseLink($uri)];
*
* @return string URI
*/
- public static function getURIByLink(string $uri)
+ public static function getURIByLink(string $uri): string
{
$ssl_uri = str_replace('http://', 'https://', $uri);
$uris = [$uri, $ssl_uri, Strings::normaliseLink($uri)];
*
* @return integer item id
*/
- public static function fetchByLink(string $uri, int $uid = 0)
+ public static function fetchByLink(string $uri, int $uid = 0): int
{
Logger::info('Trying to fetch link', ['uid' => $uid, 'uri' => $uri]);
$item_id = self::searchByLink($uri, $uid);
*
* @return array with share information
*/
- public static function getShareArray($item)
+ public static function getShareArray(array $item): array
{
if (!preg_match("/(.*?)\[share(.*?)\]\s?(.*?)\s?\[\/share\]\s?/ism", $item['body'], $matches)) {
return [];
*
* @return array item array with data from the original item
*/
- public static function addShareDataFromOriginal(array $item)
+ public static function addShareDataFromOriginal(array $item): array
{
$shared = self::getShareArray($item);
if (empty($shared)) {
* @return bool
* @throws \Exception
*/
- protected static function isAllowedByUser(array $item, int $user_id)
+ protected static function isAllowedByUser(array $item, int $user_id): bool
{
if (!empty($item['author-id']) && Contact\User::isBlocked($item['author-id'], $user_id)) {
Logger::notice('Author is blocked by user', ['author-link' => $item['author-link'], 'uid' => $user_id, 'item-uri' => $item['uri']]);
* @param array $item
* @return string body
*/
- public static function improveSharedDataInBody(array $item)
+ public static function improveSharedDataInBody(array $item): string
{
$shared = BBCode::fetchShareAttributes($item['body']);
if (empty($shared['link'])) {