doc/themes.md,FAQ-admin: point to live friendica-themes.com mirror

[friendica.git] / src / Model / Item.php

diff --git a/src/Model/Item.php b/src/Model/Item.php
index 09abf959975cd0b1be641d8d0dcbe8cf65938a20..d040c876de6df1ab4a1ee614102173943bfbc66a 100644 (file)
--- a/src/Model/Item.php
+++ b/src/Model/Item.php
@@ -1773,7 +1773,10 @@ class Item
        }
 
        /**
-        * Creates an unique guid out of a given uri
+        * Creates an unique guid out of a given uri.
+        * This function is used for messages outside the fediverse (Connector posts, feeds, Mails, ...)
+        * Posts that are created on this system are using System::createUUID.
+        * Received ActivityPub posts are using Processor::getGUIDByURL.
         *
         * @param string $uri uri of an item entry
         * @param string $host hostname for the GUID prefix
@@ -1785,19 +1788,14 @@ class Item
                // We have to avoid that different routines could accidentally create the same value
                $parsed = parse_url($uri);
 
-               // We use a hash of the hostname as prefix for the guid
-               $guid_prefix = hash("crc32", $host);
-
                // Remove the scheme to make sure that "https" and "http" doesn't make a difference
                unset($parsed["scheme"]);
 
                // Glue it together to be able to make a hash from it
                $host_id = implode("/", $parsed);
 
-               // We could use any hash algorithm since it isn't a security issue
-               $host_hash = hash("ripemd128", $host_id);
-
-               return $guid_prefix.$host_hash;
+               // Use a mixture of several hashes to provide some GUID like experience
+               return hash("crc32", $host) . '-'. hash('joaat', $host_id) . '-'. hash('fnv164', $host_id);
        }
 
        /**
@@ -3193,6 +3191,12 @@ class Item
         */
        public static function getPlink($item)
        {
+               if (!empty($item['plink']) && Network::isValidHttpUrl($item['plink'])) {
+                       $plink = $item['plink'];
+               } elseif (!empty($item['uri']) && Network::isValidHttpUrl($item['uri']) && !Network::isLocalLink($item['uri'])) {
+                       $plink = $item['uri'];
+               }
+
                if (local_user()) {
                        $ret = [
                                'href' => "display/" . $item['guid'],
@@ -3201,14 +3205,14 @@ class Item
                                'orig_title' => DI::l10n()->t('View on separate page'),
                        ];
 
-                       if (!empty($item['plink'])) {
-                               $ret['href'] = DI::baseUrl()->remove($item['plink']);
+                       if (!empty($plink)) {
+                               $ret['href'] = DI::baseUrl()->remove($plink);
                                $ret['title'] = DI::l10n()->t('Link to source');
                        }
-               } elseif (!empty($item['plink']) && ($item['private'] != self::PRIVATE)) {
+               } elseif (!empty($plink) && ($item['private'] != self::PRIVATE)) {
                        $ret = [
-                               'href' => $item['plink'],
-                               'orig' => $item['plink'],
+                               'href' => $plink,
+                               'orig' => $plink,
                                'title' => DI::l10n()->t('Link to source'),
                                'orig_title' => DI::l10n()->t('Link to source'),
                        ];