]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/Item.php
Issue 11875: Fetch post on activity
[friendica.git] / src / Model / Item.php
index 0390730fd8c178d9744976924b0c210d1a127afe..d9bd72d7c783d981de2d8338e5773494d698911b 100644 (file)
@@ -220,7 +220,7 @@ class Item
                                $content_fields['raw-body'] = Post\Media::insertFromBody($item['uri-id'], $content_fields['raw-body']);
                                $content_fields['raw-body'] = self::setHashtags($content_fields['raw-body']);
 
-                               Post\Media::insertFromRelevantUrl($item['uri-id'], $content_fields['raw-body']);
+                               Post\Media::insertFromRelevantUrl($item['uri-id'], $content_fields['raw-body'], $fields['body'], $item['author-network']);
                                Post\Content::update($item['uri-id'], $content_fields);
                        }
 
@@ -385,6 +385,9 @@ class Item
                        Post\ThreadUser::update($item['uri-id'], $item['uid'], ['hidden' => true]);
                }
 
+               DI::notify()->deleteForItem($item['uri-id']);
+               DI::notification()->deleteForItem($item['uri-id']);
+
                Logger::info('Item has been marked for deletion.', ['id' => $item_id]);
 
                return true;
@@ -1185,7 +1188,8 @@ class Item
                $item['raw-body'] = Post\Media::insertFromBody($item['uri-id'], $item['raw-body']);
                $item['raw-body'] = self::setHashtags($item['raw-body']);
 
-               Post\Media::insertFromRelevantUrl($item['uri-id'], $item['raw-body']);
+               $author = Contact::getById($item['author-id'], ['network']);
+               Post\Media::insertFromRelevantUrl($item['uri-id'], $item['raw-body'], $item['body'], $author['network'] ?? '');
 
                // Check for hashtags in the body and repair or add hashtag links
                $item['body'] = self::setHashtags($item['body']);
@@ -1625,7 +1629,7 @@ class Item
 
                if (($uid != 0) && (($item['gravity'] == self::GRAVITY_PARENT) || $is_reshare) &&
                        DI::pConfig()->get($uid, 'system', 'accept_only_sharer') == self::COMPLETION_NONE &&
-                       !in_array($item['post-reason'], [self::PR_FOLLOWER, self::PR_TAG, self::PR_TO, self::PR_CC])) {
+                       !in_array($item['post-reason'], [self::PR_FOLLOWER, self::PR_TAG, self::PR_TO, self::PR_CC, self::PR_ACTIVITY])) {
                        Logger::info('Contact is not a follower, thread will not be stored', ['author' => $item['author-link'], 'uid' => $uid, 'uri-id' => $uri_id, 'post-reason' => $item['post-reason']]);
                        return 0;
                }
@@ -2030,9 +2034,10 @@ class Item
         * Posts that are created on this system are using System::createUUID.
         * Received ActivityPub posts are using Processor::getGUIDByURL.
         *
-        * @param string      $uri uri of an item entry
+        * @param string      $uri  uri of an item entry
         * @param string|null $host hostname for the GUID prefix
         * @return string Unique guid
+        * @throws \Exception
         */
        public static function guidFromUri(string $uri, string $host = null): string
        {
@@ -2043,11 +2048,16 @@ class Item
                // Remove the scheme to make sure that "https" and "http" doesn't make a difference
                unset($parsed['scheme']);
 
+               $hostPart = $host ?? $parsed['host'] ?? '';
+               if (!$hostPart) {
+                       Logger::warning('Empty host GUID part', ['uri' => $uri, 'host' => $host, 'parsed' => $parsed, 'callstack' => System::callstack(10)]);
+               }
+
                // Glue it together to be able to make a hash from it
                $host_id = implode('/', $parsed);
 
                // Use a mixture of several hashes to provide some GUID like experience
-               return hash('crc32', $host) . '-'. hash('joaat', $host_id) . '-'. hash('fnv164', $host_id);
+               return hash('crc32', $hostPart) . '-' . hash('joaat', $host_id) . '-' . hash('fnv164', $host_id);
        }
 
        /**
@@ -2268,6 +2278,11 @@ class Item
                        return;
                }
 
+               $cdata = Contact::getPublicAndUserContactID($item['author-id'], $item['uid']);
+               if (empty($cdata['user']) || ($cdata['user'] != $item['contact-id'])) {
+                       return;
+               }
+
                if (!DBA::exists('contact', ['id' => $item['contact-id'], 'remote_self' => Contact::MIRROR_NATIVE_RESHARE])) {
                        return;
                }
@@ -2283,24 +2298,24 @@ class Item
 
        public static function isRemoteSelf(array $contact, array &$datarray): bool
        {
-               if (!$contact['remote_self']) {
+               if ($contact['remote_self'] != Contact::MIRROR_OWN_POST) {
                        return false;
                }
 
                // Prevent the forwarding of posts that are forwarded
-               if (!empty($datarray["extid"]) && ($datarray["extid"] == Protocol::DFRN)) {
+               if (!empty($datarray['extid']) && ($datarray['extid'] == Protocol::DFRN)) {
                        Logger::info('Already forwarded');
                        return false;
                }
 
                // Prevent to forward already forwarded posts
-               if ($datarray["app"] == DI::baseUrl()->getHostname()) {
+               if ($datarray['app'] == DI::baseUrl()->getHostname()) {
                        Logger::info('Already forwarded (second test)');
                        return false;
                }
 
                // Only forward posts
-               if ($datarray["verb"] != Activity::POST) {
+               if ($datarray['verb'] != Activity::POST) {
                        Logger::info('No post');
                        return false;
                }
@@ -2312,54 +2327,49 @@ class Item
 
                $datarray2 = $datarray;
                Logger::info('remote-self start', ['contact' => $contact['url'], 'remote_self'=> $contact['remote_self'], 'item' => $datarray]);
-               if ($contact['remote_self'] == Contact::MIRROR_OWN_POST) {
-                       $self = DBA::selectFirst('contact', ['id', 'name', 'url', 'thumb'],
-                                       ['uid' => $contact['uid'], 'self' => true]);
-                       if (DBA::isResult($self)) {
-                               $datarray['contact-id'] = $self["id"];
-
-                               $datarray['owner-name'] = $self["name"];
-                               $datarray['owner-link'] = $self["url"];
-                               $datarray['owner-avatar'] = $self["thumb"];
-
-                               $datarray['author-name']   = $datarray['owner-name'];
-                               $datarray['author-link']   = $datarray['owner-link'];
-                               $datarray['author-avatar'] = $datarray['owner-avatar'];
-
-                               unset($datarray['edited']);
-
-                               unset($datarray['network']);
-                               unset($datarray['owner-id']);
-                               unset($datarray['author-id']);
-                       }
-
-                       if ($contact['network'] != Protocol::FEED) {
-                               $old_uri_id = $datarray["uri-id"] ?? 0;
-                               $datarray["guid"] = System::createUUID();
-                               unset($datarray["plink"]);
-                               $datarray["uri"] = self::newURI($datarray["guid"]);
-                               $datarray["uri-id"] = ItemURI::getIdByURI($datarray["uri"]);
-                               $datarray["extid"] = Protocol::DFRN;
-                               $urlpart = parse_url($datarray2['author-link']);
-                               $datarray["app"] = $urlpart["host"];
-                               if (!empty($old_uri_id)) {
-                                       Post\Media::copy($old_uri_id, $datarray["uri-id"]);
-                               }
 
-                               unset($datarray["parent-uri"]);
-                               unset($datarray["thr-parent"]);
-                       } else {
-                               $datarray['private'] = self::PUBLIC;
-                       }
+               $self = DBA::selectFirst('contact', ['id', 'name', 'url', 'thumb'],
+                                       ['uid' => $contact['uid'], 'self' => true]);
+               if (!DBA::isResult($self)) {
+                       Logger::error('Self contact not found', ['uid' => $contact['uid']]);
+                       return false;
                }
 
+               $datarray['contact-id'] = $self['id'];
+
+               $datarray['author-name']   = $datarray['owner-name']   = $self['name'];
+               $datarray['author-link']   = $datarray['owner-link']   = $self['url'];
+               $datarray['author-avatar'] = $datarray['owner-avatar'] = $self['thumb'];
+
+               unset($datarray['edited']);
+
+               unset($datarray['network']);
+               unset($datarray['owner-id']);
+               unset($datarray['author-id']);
+
                if ($contact['network'] != Protocol::FEED) {
+                       $old_uri_id = $datarray['uri-id'] ?? 0;
+                       $datarray['guid'] = System::createUUID();
+                       unset($datarray['plink']);
+                       $datarray['uri'] = self::newURI($datarray['guid']);
+                       $datarray['uri-id'] = ItemURI::getIdByURI($datarray['uri']);
+                       $datarray['extid'] = Protocol::DFRN;
+                       $urlpart = parse_url($datarray2['author-link']);
+                       $datarray['app'] = $urlpart['host'];
+                       if (!empty($old_uri_id)) {
+                               Post\Media::copy($old_uri_id, $datarray['uri-id']);
+                       }
+
+                       unset($datarray['parent-uri']);
+                       unset($datarray['thr-parent']);
+
                        // Store the original post
                        $result = self::insert($datarray2);
                        Logger::info('remote-self post original item', ['contact' => $contact['url'], 'result'=> $result, 'item' => $datarray2]);
                } else {
-                       Logger::info('No valid mirroring option', ['uid' => $contact['uid'], 'id' => $contact['id'], 'network' => $contact['network'], 'remote_self' => $contact['remote_self']]);
-                       return false;
+                       $datarray['private'] = self::PUBLIC;
+                       $datarray['app'] = 'Feed';
+                       $result = true;
                }
 
                return (bool)$result;
@@ -3001,7 +3011,7 @@ class Item
                $item['hashtags'] = $tags['hashtags'];
                $item['mentions'] = $tags['mentions'];
 
-               $body = $item['body'] ?? '';
+               $body = $item['body'] = Post\Media::removeFromEndOfBody($item['body'] ?? '');
 
                $fields = ['uri-id', 'uri', 'body', 'title', 'author-name', 'author-link', 'author-avatar', 'guid', 'created', 'plink', 'network', 'has-media', 'quote-uri-id', 'post-type'];
 
@@ -3213,8 +3223,9 @@ class Item
        private static function addVisualAttachments(array $attachments, array $item, string $content, bool $shared): string
        {
                DI::profiler()->startRecording('rendering');
-               $leading = '';
+               $leading  = '';
                $trailing = '';
+               $images   = [];
 
                // @todo In the future we should make a single for the template engine with all media in it. This allows more flexibilty.
                foreach ($attachments['visual'] as $attachment) {
@@ -3269,19 +3280,19 @@ class Item
                                if (self::containsLink($item['body'], $src_url)) {
                                        continue;
                                }
-                               $media = Renderer::replaceMacros(Renderer::getMarkupTemplate('content/image.tpl'), [
-                                       '$image' => [
-                                               'src'        => $src_url,
-                                               'preview'    => $preview_url,
-                                               'attachment' => $attachment,
-                                       ],
-                               ]);
-                               // On Diaspora posts the attached pictures are leading
-                               if ($item['network'] == Protocol::DIASPORA) {
-                                       $leading .= $media;
-                               } else {
-                                       $trailing .= $media;
-                               }
+                               $images[] = ['src' => $src_url, 'preview' => $preview_url, 'attachment' => $attachment];
+                       }
+               }
+
+               foreach ($images as $image) {
+                       $media = Renderer::replaceMacros(Renderer::getMarkupTemplate('content/image.tpl'), [
+                               '$image' => $image,
+                       ]);
+                       // On Diaspora posts the attached pictures are leading
+                       if ($item['network'] == Protocol::DIASPORA) {
+                               $leading .= $media;
+                       } else {
+                               $trailing .= $media;
                        }
                }
 
@@ -3399,7 +3410,10 @@ class Item
                                }
 
                                // @todo Use a template
-                               $rendered = BBCode::convertAttachment('', BBCode::INTERNAL, false, $data, $uriid);
+                               $preview_mode =  DI::pConfig()->get(DI::userSession()->getLocalUserId(), 'system', 'preview_mode', BBCode::PREVIEW_LARGE);
+                               if ($preview_mode != BBCode::PREVIEW_NONE) {
+                                       $rendered = BBCode::convertAttachment('', BBCode::INTERNAL, false, $data, $uriid, $preview_mode);
+                               }
                        } elseif (!self::containsLink($content, $data['url'], Post\Media::HTML)) {
                                $rendered = Renderer::replaceMacros(Renderer::getMarkupTemplate('content/link.tpl'), [
                                        '$url'  => $data['url'],