]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/Post.php
Issue 9986: Improve contact search
[friendica.git] / src / Model / Post.php
index 30515d7116a293bb80f04e1fe4a14f2ef4ce5f8b..bb35f126b34a981539da2e9de81aeecb1d022d5c 100644 (file)
@@ -94,6 +94,10 @@ class Post
                        }
                }
 
+               if (array_key_exists('extid', $row) && is_null($row['extid'])) {
+                       $row['extid'] = '';
+               }
+
                return $row;
        }
 
@@ -128,7 +132,7 @@ class Post
         * @throws \Exception
         */
        public static function exists($condition) {
-               return DBA::exists('post-view', $condition);
+               return DBA::exists('post-user-view', $condition);
        }
 
        /**
@@ -149,7 +153,7 @@ class Post
         */
        public static function count(array $condition = [], array $params = [])
        {
-               return DBA::count('post-view', $condition, $params);
+               return DBA::count('post-user-view', $condition, $params);
        }
 
        /**
@@ -207,7 +211,7 @@ class Post
        /**
         * Select rows from the given view
         *
-        * @param string $view      View (post-view or post-thread-view)
+        * @param string $view      View (post-user-view or post-thread-user-view)
         * @param array  $selected  Array of selected fields, empty for all
         * @param array  $condition Array of fields for condition
         * @param array  $params    Array of several parameters
@@ -220,8 +224,8 @@ class Post
                if (empty($selected)) {
                        $selected = array_merge(Item::DISPLAY_FIELDLIST, Item::ITEM_FIELDLIST);
 
-                       if ($view == 'post-thread-view') {
-                               $selected = array_merge($selected, ['ignored', 'iid']);
+                       if ($view == 'post-thread-user-view') {
+                               $selected = array_merge($selected, ['ignored']);
                        }
                }
 
@@ -242,13 +246,7 @@ class Post
         */
        public static function select(array $selected = [], array $condition = [], $params = [])
        {
-               $timestamp = microtime(true);
-               $data = self::selectView('post-view', $selected, $condition, $params);
-               
-               $duration = microtime(true) - $timestamp;;
-               if ($duration > 0.1)
-                       Logger::info('Blubb', ['duration' => $duration, 'selected' => $selected, 'condition' => $condition, 'params' => $params, 'callstack' => System::callstack(20)]);
-               return $data;
+               return self::selectView('post-user-view', $selected, $condition, $params);
        }
 
        /**
@@ -263,13 +261,13 @@ class Post
         */
        public static function selectThread(array $selected = [], array $condition = [], $params = [])
        {
-               return self::selectView('post-thread-view', $selected, $condition, $params);
+               return self::selectView('post-thread-user-view', $selected, $condition, $params);
        }
 
        /**
         * Select rows from the given view for a given user
         *
-        * @param string  $view      View (post-view or post-thread-view)
+        * @param string  $view      View (post-user-view or post-thread-user-view)
         * @param integer $uid       User ID
         * @param array   $selected  Array of selected fields, empty for all
         * @param array   $condition Array of fields for condition
@@ -287,10 +285,10 @@ class Post
                $condition = DBA::mergeConditions($condition,
                        ["`visible` AND NOT `deleted`
                        AND NOT `author-blocked` AND NOT `owner-blocked`
-                       AND (NOT `causer-blocked` OR `causer-id` = ?) AND NOT `contact-blocked`
+                       AND (NOT `causer-blocked` OR `causer-id` = ? OR `causer-id` IS NULL) AND NOT `contact-blocked`
                        AND ((NOT `contact-readonly` AND NOT `contact-pending` AND (`contact-rel` IN (?, ?)))
                                OR `self` OR `gravity` != ? OR `contact-uid` = ?)
-                       AND NOT EXISTS (SELECT `uri-id` FROM `post-user` WHERE `hidden` AND `uri-id` = `" . $view . "`.`uri-id` AND `uid` = ?)
+                       AND NOT EXISTS (SELECT `uri-id` FROM `post-user` WHERE `uid` = ? AND `uri-id` = `" . $view . "`.`uri-id` AND `hidden`)
                        AND NOT EXISTS (SELECT `cid` FROM `user-contact` WHERE `uid` = ? AND `cid` = `author-id` AND `blocked`)
                        AND NOT EXISTS (SELECT `cid` FROM `user-contact` WHERE `uid` = ? AND `cid` = `owner-id` AND `blocked`)
                        AND NOT EXISTS (SELECT `cid` FROM `user-contact` WHERE `uid` = ? AND `cid` = `author-id` AND `ignored` AND `gravity` = ?)
@@ -331,8 +329,7 @@ class Post
         */
        public static function selectForUser($uid, array $selected = [], array $condition = [], $params = [])
        {
-               //Logger::info('Blubb', ['uid' => $uid, 'selected' => $selected, 'condition' => $condition, 'params' => $params]);
-               return self::selectViewForUser('post-view', $uid, $selected, $condition, $params);
+               return self::selectViewForUser('post-user-view', $uid, $selected, $condition, $params);
        }
 
                /**
@@ -348,7 +345,7 @@ class Post
         */
        public static function selectThreadForUser($uid, array $selected = [], array $condition = [], $params = [])
        {
-               return self::selectViewForUser('post-thread-view', $uid, $selected, $condition, $params);
+               return self::selectViewForUser('post-thread-user-view', $uid, $selected, $condition, $params);
        }
 
        /**
@@ -425,7 +422,7 @@ class Post
        {
                $affected = 0;
 
-               Logger::info('Start Update', ['fields' => $fields, 'condition' => $condition]);
+               Logger::info('Start Update', ['fields' => $fields, 'condition' => $condition, 'uid' => local_user(),'callstack' => System::callstack(10)]);
 
                // Don't allow changes to fields that are responsible for the relation between the records
                unset($fields['id']);
@@ -445,95 +442,104 @@ class Post
 
                $update_fields = DBStructure::getFieldsForTable('post-user', $fields);
                if (!empty($update_fields)) {
-                       $rows = DBA::selectToArray('post-view', ['post-user-id'], $condition);
-                       $puids = array_column($rows, 'post-user-id');
-                       if (!DBA::update('post-user', $update_fields, ['id' => $puids])) {
-                               DBA::rollback();
-                               Logger::notice('Updating post-user failed', ['fields' => $update_fields, 'condition' => $condition]);
-                               return false;
+                       $affected_count = 0;
+                       $posts = DBA::select('post-user-view', ['post-user-id'], $condition);
+                       while ($rows = DBA::toArray($posts, false, 100)) {
+                               $puids = array_column($rows, 'post-user-id');
+                               if (!DBA::update('post-user', $update_fields, ['id' => $puids])) {
+                                       DBA::rollback();
+                                       Logger::notice('Updating post-user failed', ['fields' => $update_fields, 'condition' => $condition]);
+                                       return false;
+                               }
+                               $affected_count += DBA::affectedRows();
                        }
-                       $affected = DBA::affectedRows();                        
+                       DBA::close($posts);
+                       $affected = $affected_count;
                }
 
                $update_fields = DBStructure::getFieldsForTable('post-content', $fields);
                if (!empty($update_fields)) {
-                       $rows = DBA::selectToArray('post-view', ['uri-id'], $condition, ['group_by' => ['uri-id']]);
-                       $uriids = array_column($rows, 'uri-id');
-                       if (!DBA::update('post-content', $update_fields, ['uri-id' => $uriids])) {
-                               DBA::rollback();
-                               Logger::notice('Updating post-content failed', ['fields' => $update_fields, 'condition' => $condition]);
-                               return false;
+                       $affected_count = 0;
+                       $posts = DBA::select('post-user-view', ['uri-id'], $condition, ['group_by' => ['uri-id']]);
+                       while ($rows = DBA::toArray($posts, false, 100)) {
+                               $uriids = array_column($rows, 'uri-id');
+                               if (!DBA::update('post-content', $update_fields, ['uri-id' => $uriids])) {
+                                       DBA::rollback();
+                                       Logger::notice('Updating post-content failed', ['fields' => $update_fields, 'condition' => $condition]);
+                                       return false;
+                               }
+                               $affected_count += DBA::affectedRows();
                        }
-                       $affected = max($affected, DBA::affectedRows());
+                       DBA::close($posts);
+                       $affected = max($affected, $affected_count);
                }
 
                $update_fields = DBStructure::getFieldsForTable('post', $fields);
                if (!empty($update_fields)) {
-                       if (empty($uriids)) {
-                               $rows = DBA::selectToArray('post-view', ['uri-id'], $condition, ['group_by' => ['uri-id']]);
+                       $affected_count = 0;
+                       $posts = DBA::select('post-user-view', ['uri-id'], $condition, ['group_by' => ['uri-id']]);
+                       while ($rows = DBA::toArray($posts, false, 100)) {
                                $uriids = array_column($rows, 'uri-id');
+                               if (!DBA::update('post', $update_fields, ['uri-id' => $uriids])) {
+                                       DBA::rollback();
+                                       Logger::notice('Updating post failed', ['fields' => $update_fields, 'condition' => $condition]);
+                                       return false;
+                               }
+                               $affected_count += DBA::affectedRows();
                        }
-                       if (!DBA::update('post', $update_fields, ['uri-id' => $uriids])) {
-                               DBA::rollback();
-                               Logger::notice('Updating post failed', ['fields' => $update_fields, 'condition' => $condition]);
-                               return false;
-                       }
-                       $affected = max($affected, DBA::affectedRows());
+                       DBA::close($posts);
+                       $affected = max($affected, $affected_count);
                }
 
                $update_fields = Post\DeliveryData::extractFields($fields);
                if (!empty($update_fields)) {
-                       if (empty($uriids)) {
-                               $rows = DBA::selectToArray('post-view', ['uri-id'], $condition, ['group_by' => ['uri-id']]);
+                       $affected_count = 0;
+                       $posts = DBA::select('post-user-view', ['uri-id'], $condition, ['group_by' => ['uri-id']]);
+                       while ($rows = DBA::toArray($posts, false, 100)) {
                                $uriids = array_column($rows, 'uri-id');
+                               if (!DBA::update('post-delivery-data', $update_fields, ['uri-id' => $uriids])) {
+                                       DBA::rollback();
+                                       Logger::notice('Updating post-delivery-data failed', ['fields' => $update_fields, 'condition' => $condition]);
+                                       return false;
+                               }
+                               $affected_count += DBA::affectedRows();
                        }
-                       if (!DBA::update('post-delivery-data', $update_fields, ['uri-id' => $uriids])) {
-                               DBA::rollback();
-                               Logger::notice('Updating post-delivery-data failed', ['fields' => $update_fields, 'condition' => $condition]);
-                               return false;
-                       }
-                       $affected = max($affected, DBA::affectedRows());
+                       DBA::close($posts);
+                       $affected = max($affected, $affected_count);
                }
 
                $update_fields = DBStructure::getFieldsForTable('post-thread', $fields);
                if (!empty($update_fields)) {
-                       $rows = DBA::selectToArray('post-view', ['uri-id'], $thread_condition, ['group_by' => ['uri-id']]);
-                       $uriids = array_column($rows, 'uri-id');
-                       if (!DBA::update('post-thread', $update_fields, ['uri-id' => $uriids])) {
-                               DBA::rollback();
-                               Logger::notice('Updating post-thread failed', ['fields' => $update_fields, 'condition' => $condition]);
-                               return false;
+                       $affected_count = 0;
+                       $posts = DBA::select('post-user-view', ['uri-id'], $thread_condition, ['group_by' => ['uri-id']]);
+                       while ($rows = DBA::toArray($posts, false, 100)) {
+                               $uriids = array_column($rows, 'uri-id');
+                               if (!DBA::update('post-thread', $update_fields, ['uri-id' => $uriids])) {
+                                       DBA::rollback();
+                                       Logger::notice('Updating post-thread failed', ['fields' => $update_fields, 'condition' => $condition]);
+                                       return false;
+                               }
+                               $affected_count += DBA::affectedRows();
                        }
-                       $affected = max($affected, DBA::affectedRows());
+                       DBA::close($posts);
+                       $affected = max($affected, $affected_count);
                }
 
                $update_fields = DBStructure::getFieldsForTable('post-thread-user', $fields);
                if (!empty($update_fields)) {
-                       $rows = DBA::selectToArray('post-view', ['post-user-id'], $thread_condition);
-                       $thread_puids = array_column($rows, 'post-user-id');
-                       if (!DBA::update('post-thread-user', $update_fields, ['post-user-id' => $thread_puids])) {
-                               DBA::rollback();
-                               Logger::notice('Updating post-thread-user failed', ['fields' => $update_fields, 'condition' => $condition]);
-                               return false;
-                       }
-                       $affected = max($affected, DBA::affectedRows());
-               }
-
-               $update_fields = [];
-               foreach (Item::USED_FIELDLIST as $field) {
-                       if (array_key_exists($field, $fields)) {
-                               $update_fields[$field] = $fields[$field];
-                       }
-               }
-               if (!empty($update_fields)) {
-                       $rows = DBA::selectToArray('post-view', ['id'], $condition, []);
-                       $ids = array_column($rows, 'id');
-                       if (!DBA::update('item', $update_fields, ['id' => $ids])) {
-                               DBA::rollback();
-                               Logger::notice('Updating item failed', ['fields' => $update_fields, 'condition' => $condition]);
-                               return false;
+                       $affected_count = 0;
+                       $posts = DBA::select('post-user-view', ['post-user-id'], $thread_condition);
+                       while ($rows = DBA::toArray($posts, false, 100)) {
+                               $thread_puids = array_column($rows, 'post-user-id');
+                               if (!DBA::update('post-thread-user', $update_fields, ['post-user-id' => $thread_puids])) {
+                                       DBA::rollback();
+                                       Logger::notice('Updating post-thread-user failed', ['fields' => $update_fields, 'condition' => $condition]);
+                                       return false;
+                               }
+                               $affected_count += DBA::affectedRows();
                        }
-                       $affected = max($affected, DBA::affectedRows());
+                       DBA::close($posts);
+                       $affected = max($affected, $affected_count);
                }
 
                DBA::commit();