]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/User.php
AP Bugfix: We hadn't transmitted an tag url at all ...
[friendica.git] / src / Model / User.php
index 0f397aadc2f8f5d4fca0b4c4ccc1a1f7cee506bf..2effb660fb212f9951fda59b41d34f742246b5c8 100644 (file)
@@ -9,6 +9,7 @@ use DivineOmega\PasswordExposed;
 use Exception;
 use Friendica\Core\Addon;
 use Friendica\Core\Config;
+use Friendica\Core\Hook;
 use Friendica\Core\L10n;
 use Friendica\Core\Logger;
 use Friendica\Core\PConfig;
@@ -23,10 +24,6 @@ use Friendica\Util\Network;
 use Friendica\Util\Strings;
 use LightOpenID;
 
-require_once 'boot.php';
-require_once 'include/dba.php';
-require_once 'include/enotify.php';
-require_once 'include/text.php';
 /**
  * @brief This class handles User related functions
  */
@@ -97,6 +94,19 @@ class User
                if (!DBA::isResult($r)) {
                        return false;
                }
+
+               if (empty($r['nickname'])) {
+                       return false;
+               }
+
+               // Check if the returned data is valid, otherwise fix it. See issue #6122
+               $url = System::baseUrl() . '/profile/' . $r['nickname'];
+               $addr = $r['nickname'] . '@' . substr(System::baseUrl(), strpos(System::baseUrl(), '://') + 3);
+
+               if (($addr != $r['addr']) || ($r['url'] != $url) || ($r['nurl'] != Strings::normaliseLink($r['url']))) {
+                       Contact::updateSelfFromUserID($uid);
+               }
+
                return $r;
        }
 
@@ -182,7 +192,7 @@ class User
                if (strpos($user['password'], '$') === false) {
                        //Legacy hash that has not been replaced by a new hash yet
                        if (self::hashPasswordLegacy($password) === $user['password']) {
-                               self::updatePassword($user['uid'], $password);
+                               self::updatePasswordHashed($user['uid'], self::hashPassword($password));
 
                                return $user['uid'];
                        }
@@ -190,14 +200,14 @@ class User
                        //Legacy hash that has been double-hashed and not replaced by a new hash yet
                        //Warning: `legacy_password` is not necessary in sync with the content of `password`
                        if (password_verify(self::hashPasswordLegacy($password), $user['password'])) {
-                               self::updatePassword($user['uid'], $password);
+                               self::updatePasswordHashed($user['uid'], self::hashPassword($password));
 
                                return $user['uid'];
                        }
                } elseif (password_verify($password, $user['password'])) {
                        //New password hash
                        if (password_needs_rehash($user['password'], PASSWORD_DEFAULT)) {
-                               self::updatePassword($user['uid'], $password);
+                               self::updatePasswordHashed($user['uid'], self::hashPassword($password));
                        }
 
                        return $user['uid'];
@@ -270,7 +280,7 @@ class User
         */
        public static function generateNewPassword()
        {
-               return Strings::getRandomName(6) . mt_rand(100, 9999);
+               return ucfirst(Strings::getRandomName(8)) . mt_rand(1000, 9999);
        }
 
        /**
@@ -307,6 +317,7 @@ class User
         *
         * @param string $password
         * @return string
+        * @throws Exception
         */
        public static function hashPassword($password)
        {
@@ -323,9 +334,26 @@ class User
         * @param int    $uid
         * @param string $password
         * @return bool
+        * @throws Exception
         */
        public static function updatePassword($uid, $password)
        {
+               $password = trim($password);
+
+               if (empty($password)) {
+                       throw new Exception(L10n::t('Empty passwords are not allowed.'));
+               }
+
+               if (!Config::get('system', 'disable_password_exposed', false) && self::isPasswordExposed($password)) {
+                       throw new Exception(L10n::t('The new password has been exposed in a public data dump, please choose another.'));
+               }
+
+               $allowed_characters = '!"#$%&\'()*+,-./;<=>?@[\]^_`{|}~';
+
+               if (!preg_match('/^[a-z0-9' . preg_quote($allowed_characters, '/') . ']+$/i', $password)) {
+                       throw new Exception(L10n::t('The password can\'t contain accentuated letters, white spaces or colons (:)'));
+               }
+
                return self::updatePasswordHashed($uid, self::hashPassword($password));
        }
 
@@ -390,13 +418,15 @@ class User
         * - Create self-contact
         * - Create profile image
         *
-        * @param array $data
-        * @return string
-        * @throw Exception
+        * @param  array $data
+        * @return array
+        * @throws \ErrorException
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws Exception
         */
        public static function create(array $data)
        {
-               $a = get_app();
+               $a = \get_app();
                $return = ['user' => null, 'password' => ''];
 
                $using_invites = Config::get('system', 'invitation_only');
@@ -411,12 +441,12 @@ class User
                $password   = !empty($data['password'])   ? trim($data['password'])           : '';
                $password1  = !empty($data['password1'])  ? trim($data['password1'])          : '';
                $confirm    = !empty($data['confirm'])    ? trim($data['confirm'])            : '';
-               $blocked    = !empty($data['blocked'])    ? intval($data['blocked'])          : 0;
-               $verified   = !empty($data['verified'])   ? intval($data['verified'])         : 0;
+               $blocked    = !empty($data['blocked']);
+               $verified   = !empty($data['verified']);
                $language   = !empty($data['language'])   ? Strings::escapeTags(trim($data['language']))   : 'en';
 
-               $publish = !empty($data['profile_publish_reg']) && intval($data['profile_publish_reg']) ? 1 : 0;
-               $netpublish = strlen(Config::get('system', 'directory')) ? $publish : 0;
+               $publish = !empty($data['profile_publish_reg']);
+               $netpublish = $publish && Config::get('system', 'directory');
 
                if ($password1 != $confirm) {
                        throw new Exception(L10n::t('Passwords do not match. Password unchanged.'));
@@ -732,7 +762,7 @@ class User
                        Dear %1$s,
                                Thank you for registering at %2$s. Your account has been created.
                ',
-                       $preamble, $user['username'], $sitename
+                       $user['username'], $sitename
                ));
                $body = Strings::deindent(L10n::t('
                        The login details are as follows:
@@ -761,7 +791,7 @@ class User
                        If you ever want to delete your account, you can do so at %3$s/removeme
 
                        Thank you and welcome to %2$s.',
-                       $user['email'], $sitename, $siteurl, $user['username'], $password
+                       $user['nickname'], $sitename, $siteurl, $user['username'], $password
                ));
 
                return notification([
@@ -782,37 +812,33 @@ class User
        public static function remove($uid)
        {
                if (!$uid) {
-                       return;
+                       return false;
                }
 
-               $a = get_app();
+               $a = \get_app();
 
                Logger::log('Removing user: ' . $uid);
 
                $user = DBA::selectFirst('user', [], ['uid' => $uid]);
 
-               Addon::callHooks('remove_user', $user);
+               Hook::callAll('remove_user', $user);
 
                // save username (actually the nickname as it is guaranteed
                // unique), so it cannot be re-registered in the future.
                DBA::insert('userd', ['username' => $user['nickname']]);
 
                // The user and related data will be deleted in "cron_expire_and_remove_users" (cronjobs.php)
-               DBA::update('user', ['account_removed' => true, 'account_expires_on' => DateTimeFormat::utc(DateTimeFormat::utcNow() . " + 7 day")], ['uid' => $uid]);
-               Worker::add(PRIORITY_HIGH, "Notifier", "removeme", $uid);
+               DBA::update('user', ['account_removed' => true, 'account_expires_on' => DateTimeFormat::utc('now + 7 day')], ['uid' => $uid]);
+               Worker::add(PRIORITY_HIGH, 'Notifier', 'removeme', $uid);
 
                // Send an update to the directory
                $self = DBA::selectFirst('contact', ['url'], ['uid' => $uid, 'self' => true]);
-               Worker::add(PRIORITY_LOW, "Directory", $self['url']);
+               Worker::add(PRIORITY_LOW, 'Directory', $self['url']);
 
                // Remove the user relevant data
-               Worker::add(PRIORITY_LOW, "RemoveUser", $uid);
+               Worker::add(PRIORITY_LOW, 'RemoveUser', $uid);
 
-               if ($uid == local_user()) {
-                       unset($_SESSION['authenticated']);
-                       unset($_SESSION['uid']);
-                       $a->internalRedirect();
-               }
+               return true;
        }
 
        /**