]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/User.php
Merge pull request #9374 from annando/issue-9358-b
[friendica.git] / src / Model / User.php
index fe20857b95b59350be649c0d9acf9fcf9eddb948..ee5c35af8470d4e8208b1c1ab38d4681b3a20376 100644 (file)
@@ -21,7 +21,9 @@
 
 namespace Friendica\Model;
 
+use DivineOmega\DOFileCachePSR6\CacheItemPool;
 use DivineOmega\PasswordExposed;
+use ErrorException;
 use Exception;
 use Friendica\Content\Pager;
 use Friendica\Core\Hook;
@@ -33,7 +35,7 @@ use Friendica\Core\Worker;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\TwoFactor\AppSpecificPassword;
-use Friendica\Network\HTTPException\InternalServerErrorException;
+use Friendica\Network\HTTPException;
 use Friendica\Object\Image;
 use Friendica\Util\Crypto;
 use Friendica\Util\DateTimeFormat;
@@ -41,6 +43,7 @@ use Friendica\Util\Images;
 use Friendica\Util\Network;
 use Friendica\Util\Strings;
 use Friendica\Worker\Delivery;
+use ImagickException;
 use LightOpenID;
 
 /**
@@ -102,7 +105,7 @@ class User
        /**
         * Fetch the system account
         *
-        * @return return system account
+        * @return array system account
         */
        public static function getSystemAccount()
        {
@@ -115,8 +118,8 @@ class User
                        }
                }
 
-               $system['spubkey'] = $system['uprvkey'] = $system['prvkey'];
-               $system['username'] = $system['name'];
+               $system['sprvkey'] = $system['uprvkey'] = $system['prvkey'];
+               $system['spubkey'] = $system['upubkey'] = $system['pubkey'];
                $system['nickname'] = $system['nick'];
                return $system;
        }
@@ -128,12 +131,9 @@ class User
         */
        private static function createSystemAccount()
        {
-               $system_actor_name = DI::config()->get('system', 'actor_name');
+               $system_actor_name = self::getActorName();
                if (empty($system_actor_name)) {
-                       $system_actor_name = self::getActorName();
-                       if (empty($system_actor_name)) {
-                               return;
-                       }
+                       return;
                }
 
                $keys = Crypto::newKeypair(4096);
@@ -176,6 +176,19 @@ class User
         */
        public static function getActorName()
        {
+               $system_actor_name = DI::config()->get('system', 'actor_name');
+               if (!empty($system_actor_name)) {
+                       $self = Contact::selectFirst(['nick'], ['uid' => 0, 'self' => true]);
+                       if (!empty($self['nick'])) {
+                               if ($self['nick'] != $system_actor_name) {
+                                       // Reset the actor name to the already used name
+                                       DI::config()->set('system', 'actor_name', $self['nick']);
+                                       $system_actor_name = $self['nick'];
+                               }
+                       }
+                       return $system_actor_name;
+               }
+
                // List of possible actor names
                $possible_accounts = ['friendica', 'actor', 'system', 'internal'];
                foreach ($possible_accounts as $name) {
@@ -319,6 +332,10 @@ class User
         */
        public static function getOwnerDataById(int $uid, bool $check_valid = true)
        {
+               if ($uid == 0) {
+                       return self::getSystemAccount();
+               }
+
                if (!empty(self::$owner[$uid])) {
                        return self::$owner[$uid];
                }
@@ -349,7 +366,7 @@ class User
                if (!$repair) {
                        // Check if "addr" is present and correct
                        $addr = $owner['nickname'] . '@' . substr(DI::baseUrl(), strpos(DI::baseUrl(), '://') + 3);
-                       $repair = ($addr != $owner['addr']);
+                       $repair = ($addr != $owner['addr']) || empty($owner['prvkey']) || empty($owner['pubkey']);
                }
 
                if (!$repair) {
@@ -391,11 +408,11 @@ class User
        /**
         * Returns the default group for a given user and network
         *
-        * @param int $uid User id
+        * @param int    $uid     User id
         * @param string $network network name
         *
         * @return int group id
-        * @throws InternalServerErrorException
+        * @throws Exception
         */
        public static function getDefaultGroup($uid, $network = '')
        {
@@ -447,7 +464,8 @@ class User
         * @param string $password
         * @param bool   $third_party
         * @return int User Id if authentication is successful
-        * @throws Exception
+        * @throws HTTPException\ForbiddenException
+        * @throws HTTPException\NotFoundException
         */
        public static function getIdFromPasswordAuthentication($user_info, $password, $third_party = false)
        {
@@ -482,7 +500,7 @@ class User
                        return $user['uid'];
                }
 
-               throw new Exception(DI::l10n()->t('Login failed'));
+               throw new HTTPException\ForbiddenException(DI::l10n()->t('Login failed'));
        }
 
        /**
@@ -496,7 +514,7 @@ class User
         *
         * @param mixed $user_info
         * @return array
-        * @throws Exception
+        * @throws HTTPException\NotFoundException
         */
        private static function getAuthenticationInfo($user_info)
        {
@@ -540,7 +558,7 @@ class User
                        }
 
                        if (!DBA::isResult($user)) {
-                               throw new Exception(DI::l10n()->t('User not found'));
+                               throw new HTTPException\NotFoundException(DI::l10n()->t('User not found'));
                        }
                }
 
@@ -551,6 +569,7 @@ class User
         * Generates a human-readable random password
         *
         * @return string
+        * @throws Exception
         */
        public static function generateNewPassword()
        {
@@ -566,7 +585,7 @@ class User
         */
        public static function isPasswordExposed($password)
        {
-               $cache = new \DivineOmega\DOFileCachePSR6\CacheItemPool();
+               $cache = new CacheItemPool();
                $cache->changeConfig([
                        'cacheDirectory' => get_temppath() . '/password-exposed-cache/',
                ]);
@@ -575,7 +594,7 @@ class User
                        $passwordExposedChecker = new PasswordExposed\PasswordExposedChecker(null, $cache);
 
                        return $passwordExposedChecker->passwordExposed($password) === PasswordExposed\PasswordStatus::EXPOSED;
-               } catch (\Exception $e) {
+               } catch (Exception $e) {
                        Logger::error('Password Exposed Exception: ' . $e->getMessage(), [
                                'code' => $e->getCode(),
                                'file' => $e->getFile(),
@@ -672,13 +691,11 @@ class User
         *
         * @param string $nickname The nickname that should be checked
         * @return boolean True is the nickname is blocked on the node
-        * @throws InternalServerErrorException
         */
        public static function isNicknameBlocked($nickname)
        {
                $forbidden_nicknames = DI::config()->get('system', 'forbidden_nicknames', '');
                if (!empty($forbidden_nicknames)) {
-                       // check if the nickname is in the list of blocked nicknames
                        $forbidden = explode(',', $forbidden_nicknames);
                        $forbidden = array_map('trim', $forbidden);
                } else {
@@ -686,7 +703,7 @@ class User
                }
 
                // Add the name of the internal actor to the "forbidden" list
-               $actor_name = DI::config()->get('system', 'actor_name');
+               $actor_name = self::getActorName();
                if (!empty($actor_name)) {
                        $forbidden[] = $actor_name;
                }
@@ -695,6 +712,7 @@ class User
                        return false;
                }
 
+               // check if the nickname is in the list of blocked nicknames
                if (in_array(strtolower($nickname), $forbidden)) {
                        return true;
                }
@@ -717,9 +735,9 @@ class User
         *
         * @param  array $data
         * @return array
-        * @throws \ErrorException
-        * @throws InternalServerErrorException
-        * @throws \ImagickException
+        * @throws ErrorException
+        * @throws HTTPException\InternalServerErrorException
+        * @throws ImagickException
         * @throws Exception
         */
        public static function create(array $data)
@@ -845,7 +863,7 @@ class User
 
                $nickname = $data['nickname'] = strtolower($nickname);
 
-               if (!preg_match('/^[a-z0-9][a-z0-9\_]*$/', $nickname)) {
+               if (!preg_match('/^[a-z0-9][a-z0-9_]*$/', $nickname)) {
                        throw new Exception(DI::l10n()->t('Your nickname can only contain a-z, 0-9 and _.'));
                }
 
@@ -1034,7 +1052,7 @@ class User
         *
         * @return bool True, if the allow was successful
         *
-        * @throws InternalServerErrorException
+        * @throws HTTPException\InternalServerErrorException
         * @throws Exception
         */
        public static function allow(string $hash)
@@ -1108,16 +1126,16 @@ class User
         * @param string $lang  The user's language (default is english)
         *
         * @return bool True, if the user was created successfully
-        * @throws InternalServerErrorException
-        * @throws \ErrorException
-        * @throws \ImagickException
+        * @throws HTTPException\InternalServerErrorException
+        * @throws ErrorException
+        * @throws ImagickException
         */
        public static function createMinimal(string $name, string $email, string $nick, string $lang = L10n::DEFAULT)
        {
                if (empty($name) ||
                    empty($email) ||
                    empty($nick)) {
-                       throw new InternalServerErrorException('Invalid arguments.');
+                       throw new HTTPException\InternalServerErrorException('Invalid arguments.');
                }
 
                $result = self::create([
@@ -1180,7 +1198,7 @@ class User
         * @param string $siteurl
         * @param string $password Plaintext password
         * @return NULL|boolean from notification() and email() inherited
-        * @throws InternalServerErrorException
+        * @throws HTTPException\InternalServerErrorException
         */
        public static function sendRegisterPendingEmail($user, $sitename, $siteurl, $password)
        {
@@ -1216,16 +1234,16 @@ class User
         *
         * It's here as a function because the mail is sent from different parts
         *
-        * @param \Friendica\Core\L10n $l10n     The used language
-        * @param array                $user     User record array
-        * @param string               $sitename
-        * @param string               $siteurl
-        * @param string               $password Plaintext password
+        * @param L10n   $l10n     The used language
+        * @param array  $user     User record array
+        * @param string $sitename
+        * @param string $siteurl
+        * @param string $password Plaintext password
         *
         * @return NULL|boolean from notification() and email() inherited
-        * @throws InternalServerErrorException
+        * @throws HTTPException\InternalServerErrorException
         */
-       public static function sendRegisterOpenEmail(\Friendica\Core\L10n $l10n, $user, $sitename, $siteurl, $password)
+       public static function sendRegisterOpenEmail(L10n $l10n, $user, $sitename, $siteurl, $password)
        {
                $preamble = Strings::deindent($l10n->t(
                        '
@@ -1282,7 +1300,7 @@ class User
        /**
         * @param int $uid user to remove
         * @return bool
-        * @throws InternalServerErrorException
+        * @throws HTTPException\InternalServerErrorException
         */
        public static function remove(int $uid)
        {