]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/UserItem.php
New table "post-user" and more foreign keys
[friendica.git] / src / Model / UserItem.php
index 43b0430aca1697417be3895930e2ec8be83aad06..38e9adc6ea26d451375347d144525b46ebfeebd1 100644 (file)
@@ -1,7 +1,22 @@
 <?php
-
 /**
- * @file src/Model/UserItem.php
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
  */
 
 namespace Friendica\Model;
@@ -11,6 +26,8 @@ use Friendica\Core\Hook;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Util\Strings;
+use Friendica\Model\Tag;
+use Friendica\Protocol\Activity;
 
 class UserItem
 {
@@ -34,20 +51,38 @@ class UserItem
         */
        public static function setNotification(int $iid)
        {
-               $fields = ['id', 'uid', 'body', 'parent', 'gravity', 'tag', 'contact-id', 'thr-parent', 'parent-uri', 'author-id'];
+               $fields = ['id', 'uri-id', 'parent-uri-id', 'uid', 'body', 'parent', 'gravity', 'tag',
+                       'private', 'contact-id', 'thr-parent', 'parent-uri', 'author-id', 'verb'];
                $item = Item::selectFirst($fields, ['id' => $iid, 'origin' => false]);
                if (!DBA::isResult($item)) {
                        return;
                }
 
-               // fetch all users in the thread
+               // "Activity::FOLLOW" is an automated activity, so we ignore it here
+               if ($item['verb'] == Activity::FOLLOW) {
+                       return;
+               }
+
+               if ($item['uid'] == 0) {
+                       $uids = [];
+               } else {
+                       // Always include the item user
+                       $uids = [$item['uid']];
+               }
+
+               // Add every user who participated so far in this thread
+               // This can only happen with participations on global items. (means: uid = 0) 
                $users = DBA::p("SELECT DISTINCT(`contact`.`uid`) FROM `item`
                        INNER JOIN `contact` ON `contact`.`id` = `item`.`contact-id` AND `contact`.`uid` != 0
                        WHERE `parent` IN (SELECT `parent` FROM `item` WHERE `id`=?)", $iid);
                while ($user = DBA::fetch($users)) {
-                       self::setNotificationForUser($item, $user['uid']);
+                       $uids[] = $user['uid'];
                }
                DBA::close($users);
+
+               foreach (array_unique($uids) as $uid) {
+                       self::setNotificationForUser($item, $uid);
+               }
        }
 
        /**
@@ -59,7 +94,7 @@ class UserItem
        private static function setNotificationForUser(array $item, int $uid)
        {
                $thread = Item::selectFirstThreadForUser($uid, ['ignored'], ['iid' => $item['parent'], 'deleted' => false]);
-               if ($thread['ignored']) {
+               if (!empty($thread['ignored'])) {
                        return;
                }
 
@@ -84,32 +119,35 @@ class UserItem
                        return;
                }
 
-               if (self::checkImplicitMention($item, $profiles)) {
-                       $notification_type = $notification_type | self::NOTIF_IMPLICIT_TAGGED;
-               }
+               // Only create notifications for posts and comments, not for activities
+               if (in_array($item['gravity'], [GRAVITY_PARENT, GRAVITY_COMMENT])) {
+                       if (self::checkImplicitMention($item, $profiles)) {
+                               $notification_type = $notification_type | self::NOTIF_IMPLICIT_TAGGED;
+                       }
 
-               if (self::checkExplicitMention($item, $profiles)) {
-                       $notification_type = $notification_type | self::NOTIF_EXPLICIT_TAGGED;
-               }
+                       if (self::checkExplicitMention($item, $profiles)) {
+                               $notification_type = $notification_type | self::NOTIF_EXPLICIT_TAGGED;
+                       }
 
-               if (self::checkCommentedThread($item, $contacts)) {
-                       $notification_type = $notification_type | self::NOTIF_THREAD_COMMENT;
-               }
+                       if (self::checkCommentedThread($item, $contacts)) {
+                               $notification_type = $notification_type | self::NOTIF_THREAD_COMMENT;
+                       }
 
-               if (self::checkDirectComment($item, $contacts)) {
-                       $notification_type = $notification_type | self::NOTIF_DIRECT_COMMENT;
-               }
+                       if (self::checkDirectComment($item, $contacts)) {
+                               $notification_type = $notification_type | self::NOTIF_DIRECT_COMMENT;
+                       }
 
-               if (self::checkDirectCommentedThread($item, $contacts)) {
-                       $notification_type = $notification_type | self::NOTIF_DIRECT_THREAD_COMMENT;
-               }
+                       if (self::checkDirectCommentedThread($item, $contacts)) {
+                               $notification_type = $notification_type | self::NOTIF_DIRECT_THREAD_COMMENT;
+                       }
 
-               if (self::checkCommentedParticipation($item, $contacts)) {
-                       $notification_type = $notification_type | self::NOTIF_COMMENT_PARTICIPATION;
-               }
+                       if (self::checkCommentedParticipation($item, $contacts)) {
+                               $notification_type = $notification_type | self::NOTIF_COMMENT_PARTICIPATION;
+                       }
 
-               if (self::checkActivityParticipation($item, $contacts)) {
-                       $notification_type = $notification_type | self::NOTIF_ACTIVITY_PARTICIPATION;
+                       if (self::checkActivityParticipation($item, $contacts)) {
+                               $notification_type = $notification_type | self::NOTIF_ACTIVITY_PARTICIPATION;
+                       }
                }
 
                if (empty($notification_type)) {
@@ -118,7 +156,9 @@ class UserItem
 
                Logger::info('Set notification', ['iid' => $item['id'], 'uid' => $uid, 'notification-type' => $notification_type]);
 
-               DBA::update('user-item', ['notification-type' => $notification_type], ['iid' => $item['id'], 'uid' => $uid], true);
+               $fields = ['notification-type' => $notification_type];
+               Post\User::update($item['uri-id'], $uid, $fields);
+               DBA::update('user-item', $fields, ['iid' => $item['id'], 'uid' => $uid], true);
        }
 
        /**
@@ -181,23 +221,30 @@ class UserItem
         */
        private static function checkShared(array $item, int $uid)
        {
-               if ($item['gravity'] != GRAVITY_PARENT) {
+               // Only check on original posts and reshare ("announce") activities, otherwise return
+               if (($item['gravity'] != GRAVITY_PARENT) && ($item['verb'] != Activity::ANNOUNCE)) {
                        return false;
                }
 
-               // Either the contact had posted something directly
+               // Check if the contact posted or shared something directly
                if (DBA::exists('contact', ['id' => $item['contact-id'], 'notify_new_posts' => true])) {
                        return true;
                }
 
-               // Or the contact is a mentioned forum
-               $tags = DBA::select('term', ['url'], ['otype' => TERM_OBJ_POST, 'oid' => $item['id'], 'type' => TERM_MENTION, 'uid' => $uid]);
+               // The following check doesn't make sense on activities, so quit here
+               if ($item['verb'] == Activity::ANNOUNCE) {
+                       return false;
+               }
+
+               // Check if the contact is a mentioned forum
+               $tags = DBA::select('tag-view', ['url'], ['uri-id' => $item['uri-id'], 'type' => [Tag::MENTION, Tag::EXCLUSIVE_MENTION]]);
                while ($tag = DBA::fetch($tags)) {
                        $condition = ['nurl' => Strings::normaliseLink($tag['url']), 'uid' => $uid, 'notify_new_posts' => true, 'contact-type' => Contact::TYPE_COMMUNITY];
                        if (DBA::exists('contact', $condition)) {
                                return true;
                        }
                }
+               DBA::close($tags);
 
                return false;
        }
@@ -210,9 +257,10 @@ class UserItem
         */
        private static function checkImplicitMention(array $item, array $profiles)
        {
-               foreach ($profiles AS $profile) {
-                       if (strpos($item['tag'], '=' . $profile.']') || strpos($item['body'], '=' . $profile . ']')) {
-                               if (strpos($item['body'], $profile) === false) {
+               $mentions = Tag::getByURIId($item['uri-id'], [Tag::IMPLICIT_MENTION]);
+               foreach ($mentions as $mention) {
+                       foreach ($profiles as $profile) {
+                               if (Strings::compareLink($profile, $mention['url'])) {
                                        return true;
                                }
                        }
@@ -229,9 +277,10 @@ class UserItem
         */
        private static function checkExplicitMention(array $item, array $profiles)
        {
-               foreach ($profiles AS $profile) {
-                       if (strpos($item['tag'], '=' . $profile.']') || strpos($item['body'], '=' . $profile . ']')) {
-                               if (!(strpos($item['body'], $profile) === false)) {
+               $mentions = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
+               foreach ($mentions as $mention) {
+                       foreach ($profiles as $profile) {
+                               if (Strings::compareLink($profile, $mention['url'])) {
                                        return true;
                                }
                        }