<?php
-
/**
- * @file src/Model/UserItem.php
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <https://www.gnu.org/licenses/>.
+ *
*/
namespace Friendica\Model;
use Friendica\Database\DBA;
use Friendica\DI;
use Friendica\Util\Strings;
+use Friendica\Model\Tag;
+use Friendica\Protocol\Activity;
class UserItem
{
const NOTIF_DIRECT_COMMENT = 8;
const NOTIF_COMMENT_PARTICIPATION = 16;
const NOTIF_ACTIVITY_PARTICIPATION = 32;
+ const NOTIF_DIRECT_THREAD_COMMENT = 64;
const NOTIF_SHARED = 128;
/**
* Checks an item for notifications and sets the "notification-type" field
+ * @ToDo:
+ * - Check for mentions in posts with "uid=0" where the user hadn't interacted before
*
* @param int $iid Item ID
*/
public static function setNotification(int $iid)
{
- $fields = ['id', 'uid', 'body', 'parent', 'gravity', 'tag', 'contact-id', 'thr-parent', 'parent-uri', 'author-id'];
+ $fields = ['id', 'uri-id', 'parent-uri-id', 'uid', 'body', 'parent', 'gravity', 'tag',
+ 'private', 'contact-id', 'thr-parent', 'parent-uri', 'author-id', 'verb'];
$item = Item::selectFirst($fields, ['id' => $iid, 'origin' => false]);
if (!DBA::isResult($item)) {
return;
}
+ // "Activity::FOLLOW" is an automated activity, so we ignore it here
+ if ($item['verb'] == Activity::FOLLOW) {
+ return;
+ }
+
// fetch all users in the thread
+ $uids = [];
$users = DBA::p("SELECT DISTINCT(`contact`.`uid`) FROM `item`
INNER JOIN `contact` ON `contact`.`id` = `item`.`contact-id` AND `contact`.`uid` != 0
WHERE `parent` IN (SELECT `parent` FROM `item` WHERE `id`=?)", $iid);
while ($user = DBA::fetch($users)) {
- self::setNotificationForUser($item, $user['uid']);
+ $uids[$user['uid']] = $user['uid'];
+ }
+ DBA::close($users);
+
+ // Add item users
+ $users = Item::select(['uid'], ["`parent-uri-id` = ? AND `uid` != ?", $item['parent-uri-id'], 0], ['group_by' => ['uid']]);
+ while ($user = DBA::fetch($users)) {
+ $uids[$user['uid']] = $user['uid'];
}
DBA::close($users);
+
+ // Check for mentions to local users
+ if (in_array($item['private'], [Item::PUBLIC, Item::UNLISTED])) {
+ $mentions = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::IMPLICIT_MENTION, Tag::EXCLUSIVE_MENTION]);
+ foreach ($mentions as $mention) {
+ $uid = User::getIdForURL($mention['url']);
+ if (!empty($uid)) {
+ $uids[$uid] = $uid;
+ }
+ }
+ }
+
+ foreach ($uids as $uid) {
+ self::setNotificationForUser($item, $uid);
+ }
}
/**
private static function setNotificationForUser(array $item, int $uid)
{
$thread = Item::selectFirstThreadForUser($uid, ['ignored'], ['iid' => $item['parent'], 'deleted' => false]);
- if ($thread['ignored']) {
+ if (!empty($thread['ignored'])) {
return;
}
return;
}
- if (self::checkImplicitMention($item, $profiles)) {
- $notification_type = $notification_type | self::NOTIF_IMPLICIT_TAGGED;
- }
+ // Only create notifications for posts and comments, not for activities
+ if (in_array($item['gravity'], [GRAVITY_PARENT, GRAVITY_COMMENT])) {
+ if (self::checkImplicitMention($item, $profiles)) {
+ $notification_type = $notification_type | self::NOTIF_IMPLICIT_TAGGED;
+ }
- if (self::checkExplicitMention($item, $profiles)) {
- $notification_type = $notification_type | self::NOTIF_EXPLICIT_TAGGED;
- }
+ if (self::checkExplicitMention($item, $profiles)) {
+ $notification_type = $notification_type | self::NOTIF_EXPLICIT_TAGGED;
+ }
- if (self::checkCommentedThread($item, $contacts)) {
- $notification_type = $notification_type | self::NOTIF_THREAD_COMMENT;
- }
+ if (self::checkCommentedThread($item, $contacts)) {
+ $notification_type = $notification_type | self::NOTIF_THREAD_COMMENT;
+ }
- if (self::checkDirectComment($item, $uid, $contacts)) {
- $notification_type = $notification_type | self::NOTIF_DIRECT_COMMENT;
- }
+ if (self::checkDirectComment($item, $contacts)) {
+ $notification_type = $notification_type | self::NOTIF_DIRECT_COMMENT;
+ }
- if (self::checkCommentedParticipation($item, $contacts)) {
- $notification_type = $notification_type | self::NOTIF_COMMENT_PARTICIPATION;
- }
+ if (self::checkDirectCommentedThread($item, $contacts)) {
+ $notification_type = $notification_type | self::NOTIF_DIRECT_THREAD_COMMENT;
+ }
+
+ if (self::checkCommentedParticipation($item, $contacts)) {
+ $notification_type = $notification_type | self::NOTIF_COMMENT_PARTICIPATION;
+ }
- if (self::checkActivityParticipation($item, $contacts)) {
- $notification_type = $notification_type | self::NOTIF_ACTIVITY_PARTICIPATION;
+ if (self::checkActivityParticipation($item, $contacts)) {
+ $notification_type = $notification_type | self::NOTIF_ACTIVITY_PARTICIPATION;
+ }
}
if (empty($notification_type)) {
$notification_data = ['uid' => $uid, 'profiles' => []];
Hook::callAll('check_item_notification', $notification_data);
- $raw_profiles = $notification_data['profiles'];
+ $profiles = $notification_data['profiles'];
$user = DBA::selectFirst('user', ['nickname'], ['uid' => $uid]);
if (!DBA::isResult($user)) {
return [];
}
- $owner = DBA::selectFirst('contact', ['url'], ['self' => true, 'uid' => $uid]);
+ $owner = DBA::selectFirst('contact', ['url', 'alias'], ['self' => true, 'uid' => $uid]);
if (!DBA::isResult($owner)) {
return [];
}
// This is our regular URL format
- $raw_profiles[] = $owner['url'];
+ $profiles[] = $owner['url'];
- // Notifications from Diaspora are often with an URL in the Diaspora format
- $raw_profiles[] = DI::baseUrl() . '/u/' . $user['nickname'];
+ // Now the alias
+ $profiles[] = $owner['alias'];
- $profiles = [];
+ // Notifications from Diaspora are often with an URL in the Diaspora format
+ $profiles[] = DI::baseUrl() . '/u/' . $user['nickname'];
// Validate and add profile links
- foreach ($raw_profiles AS $profile) {
- // Check for invalid profile urls. 13 should be the shortest possible profile length:
- // http://a.bc/d
- // Additionally check for invalid urls that would return the normalised value "http:"
- if ((strlen($profile) < 13) || (Strings::normaliseLink($profile) == 'http:')) {
+ foreach ($profiles AS $key => $profile) {
+ // Check for invalid profile urls (without scheme, host or path) and remove them
+ if (empty(parse_url($profile, PHP_URL_SCHEME)) || empty(parse_url($profile, PHP_URL_HOST)) || empty(parse_url($profile, PHP_URL_PATH))) {
+ unset($profiles[$key]);
continue;
}
- // Add the profile if it wasn't already added
- if (!in_array($profile, $profiles)) {
- $profiles[] = $profile;
- }
-
// Add the normalized form
$profile = Strings::normaliseLink($profile);
- if (!in_array($profile, $profiles)) {
- $profiles[] = $profile;
- }
+ $profiles[] = $profile;
// Add the SSL form
$profile = str_replace('http://', 'https://', $profile);
- if (!in_array($profile, $profiles)) {
- $profiles[] = $profile;
- }
+ $profiles[] = $profile;
}
- return $profiles;
+ return array_unique($profiles);
}
/**
*/
private static function checkShared(array $item, int $uid)
{
- if ($item['gravity'] != GRAVITY_PARENT) {
+ // Only check on original posts and reshare ("announce") activities, otherwise return
+ if (($item['gravity'] != GRAVITY_PARENT) && ($item['verb'] != Activity::ANNOUNCE)) {
return false;
}
- // Either the contact had posted something directly
+ // Check if the contact posted or shared something directly
if (DBA::exists('contact', ['id' => $item['contact-id'], 'notify_new_posts' => true])) {
return true;
}
- // Or the contact is a mentioned forum
- $tags = DBA::select('term', ['url'], ['otype' => TERM_OBJ_POST, 'oid' => $item['id'], 'type' => TERM_MENTION, 'uid' => $uid]);
+ // The following check doesn't make sense on activities, so quit here
+ if ($item['verb'] == Activity::ANNOUNCE) {
+ return false;
+ }
+
+ // Check if the contact is a mentioned forum
+ $tags = DBA::select('tag-view', ['url'], ['uri-id' => $item['uri-id'], 'type' => [Tag::MENTION, Tag::EXCLUSIVE_MENTION]]);
while ($tag = DBA::fetch($tags)) {
$condition = ['nurl' => Strings::normaliseLink($tag['url']), 'uid' => $uid, 'notify_new_posts' => true, 'contact-type' => Contact::TYPE_COMMUNITY];
if (DBA::exists('contact', $condition)) {
return true;
}
}
+ DBA::close($tags);
return false;
}
*/
private static function checkImplicitMention(array $item, array $profiles)
{
- foreach ($profiles AS $profile) {
- if (strpos($item['tag'], '=' . $profile.']') || strpos($item['body'], '=' . $profile . ']')) {
- if (strpos($item['body'], $profile) === false) {
+ $mentions = Tag::getByURIId($item['uri-id'], [Tag::IMPLICIT_MENTION]);
+ foreach ($mentions as $mention) {
+ foreach ($profiles as $profile) {
+ if (Strings::compareLink($profile, $mention['url'])) {
return true;
}
}
*/
private static function checkExplicitMention(array $item, array $profiles)
{
- foreach ($profiles AS $profile) {
- if (strpos($item['tag'], '=' . $profile.']') || strpos($item['body'], '=' . $profile . ']')) {
- if (!(strpos($item['body'], $profile) === false)) {
+ $mentions = Tag::getByURIId($item['uri-id'], [Tag::MENTION, Tag::EXCLUSIVE_MENTION]);
+ foreach ($mentions as $mention) {
+ foreach ($profiles as $profile) {
+ if (Strings::compareLink($profile, $mention['url'])) {
return true;
}
}
/**
* Check for a direct comment to a post of the given user
* @param array $item
- * @param int $uid User ID
* @param array $contacts Array of contact IDs
* @return bool The item is a direct comment to a user comment
*/
- private static function checkDirectComment(array $item, int $uid, array $contacts)
+ private static function checkDirectComment(array $item, array $contacts)
+ {
+ $condition = ['uri' => $item['thr-parent'], 'uid' => $item['uid'], 'author-id' => $contacts, 'deleted' => false, 'gravity' => GRAVITY_COMMENT];
+ return Item::exists($condition);
+ }
+
+ /**
+ * Check for a direct comment to the starting post of the given user
+ * @param array $item
+ * @param array $contacts Array of contact IDs
+ * @return bool The user had created this thread
+ */
+ private static function checkDirectCommentedThread(array $item, array $contacts)
{
- $condition = ['uri' => $item['thr-parent'], 'uid' => [0, $uid], 'author-id' => $contacts, 'deleted' => false, 'gravity' => GRAVITY_COMMENT];
+ $condition = ['uri' => $item['thr-parent'], 'uid' => $item['uid'], 'author-id' => $contacts, 'deleted' => false, 'gravity' => GRAVITY_PARENT];
return Item::exists($condition);
}
projects / friendica.git / blobdiff