Happy New Year 2023!

[friendica.git] / src / Module / Admin / Addons / Details.php

diff --git a/src/Module/Admin/Addons/Details.php b/src/Module/Admin/Addons/Details.php
index dba2f061ce058469a52caa9bd8d68a846825d1f2..9bca70a203a4a758e6e4fdab926946065dbcfd1f 100644 (file)
--- a/src/Module/Admin/Addons/Details.php
+++ b/src/Module/Admin/Addons/Details.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -30,113 +30,103 @@ use Friendica\Util\Strings;
 
 class Details extends BaseAdmin
 {
-       public static function post(array $parameters = [])
+       protected function post(array $request = [])
        {
-               parent::post($parameters);
+               self::checkAdminAccess();
 
-               $a = DI::app();
+               $addon = Strings::sanitizeFilePathItem($this->parameters['addon']);
+
+               $redirect = 'admin/addons/' . $addon;
+
+               if (is_file('addon/' . $addon . '/' . $addon . '.php')) {
+                       include_once 'addon/' . $addon . '/' . $addon . '.php';
 
-               if ($a->argc > 2) {
-                       // @TODO: Replace with parameter from router
-                       $addon = $a->argv[2];
-                       $addon = Strings::sanitizeFilePathItem($addon);
-                       if (is_file('addon/' . $addon . '/' . $addon . '.php')) {
-                               include_once 'addon/' . $addon . '/' . $addon . '.php';
-                               if (function_exists($addon . '_addon_admin_post')) {
-                                       $func = $addon . '_addon_admin_post';
-                                       $func($a);
-                               }
-
-                               DI::baseUrl()->redirect('admin/addons/' . $addon);
+                       if (function_exists($addon . '_addon_admin_post')) {
+                               self::checkFormSecurityTokenRedirectOnError($redirect, 'admin_addons_details');
+
+                               $func = $addon . '_addon_admin_post';
+                               $func(DI::app());
                        }
                }
 
-               DI::baseUrl()->redirect('admin/addons');
+               DI::baseUrl()->redirect($redirect);
        }
 
-       public static function content(array $parameters = [])
+       protected function content(array $request = []): string
        {
-               parent::content($parameters);
+               parent::content();
 
                $a = DI::app();
 
                $addons_admin = Addon::getAdminList();
 
-               if ($a->argc > 2) {
-                       // @TODO: Replace with parameter from router
-                       $addon = $a->argv[2];
-                       $addon = Strings::sanitizeFilePathItem($addon);
-                       if (!is_file("addon/$addon/$addon.php")) {
-                               notice(DI::l10n()->t('Addon not found.'));
-                               Addon::uninstall($addon);
-                               DI::baseUrl()->redirect('admin/addons');
-                       }
-
-                       if (($_GET['action'] ?? '') == 'toggle') {
-                               parent::checkFormSecurityTokenRedirectOnError('/admin/addons', 'admin_themes', 't');
-
-                               // Toggle addon status
-                               if (Addon::isEnabled($addon)) {
-                                       Addon::uninstall($addon);
-                                       info(DI::l10n()->t('Addon %s disabled.', $addon));
-                               } else {
-                                       Addon::install($addon);
-                                       info(DI::l10n()->t('Addon %s enabled.', $addon));
-                               }
-
-                               Addon::saveEnabledList();
+               $addon = Strings::sanitizeFilePathItem($this->parameters['addon']);
+               if (!is_file("addon/$addon/$addon.php")) {
+                       DI::sysmsg()->addNotice(DI::l10n()->t('Addon not found.'));
+                       Addon::uninstall($addon);
+                       DI::baseUrl()->redirect('admin/addons');
+               }
 
-                               DI::baseUrl()->redirect('admin/addons/' . $addon);
-                       }
+               if (($_GET['action'] ?? '') == 'toggle') {
+                       self::checkFormSecurityTokenRedirectOnError('/admin/addons', 'admin_addons_details', 't');
 
-                       // display addon details
+                       // Toggle addon status
                        if (Addon::isEnabled($addon)) {
-                               $status = 'on';
-                               $action = DI::l10n()->t('Disable');
+                               Addon::uninstall($addon);
+                               DI::sysmsg()->addInfo(DI::l10n()->t('Addon %s disabled.', $addon));
                        } else {
-                               $status = 'off';
-                               $action = DI::l10n()->t('Enable');
+                               Addon::install($addon);
+                               DI::sysmsg()->addInfo(DI::l10n()->t('Addon %s enabled.', $addon));
                        }
 
-                       $readme = null;
-                       if (is_file("addon/$addon/README.md")) {
-                               $readme = Markdown::convert(file_get_contents("addon/$addon/README.md"), false);
-                       } elseif (is_file("addon/$addon/README")) {
-                               $readme = '<pre>' . file_get_contents("addon/$addon/README") . '</pre>';
-                       }
+                       DI::baseUrl()->redirect('admin/addons/' . $addon);
+               }
 
-                       $admin_form = '';
-                       if (array_key_exists($addon, $addons_admin)) {
-                               require_once "addon/$addon/$addon.php";
-                               $func = $addon . '_addon_admin';
-                               $func($a, $admin_form);
-                       }
+               // display addon details
+               if (Addon::isEnabled($addon)) {
+                       $status = 'on';
+                       $action = DI::l10n()->t('Disable');
+               } else {
+                       $status = 'off';
+                       $action = DI::l10n()->t('Enable');
+               }
+
+               $readme = null;
+               if (is_file("addon/$addon/README.md")) {
+                       $readme = Markdown::convert(file_get_contents("addon/$addon/README.md"), false);
+               } elseif (is_file("addon/$addon/README")) {
+                       $readme = '<pre>' . file_get_contents("addon/$addon/README") . '</pre>';
+               }
 
-                       $t = Renderer::getMarkupTemplate('admin/addons/details.tpl');
-
-                       return Renderer::replaceMacros($t, [
-                               '$title' => DI::l10n()->t('Administration'),
-                               '$page' => DI::l10n()->t('Addons'),
-                               '$toggle' => DI::l10n()->t('Toggle'),
-                               '$settings' => DI::l10n()->t('Settings'),
-                               '$baseurl' => DI::baseUrl()->get(true),
-
-                               '$addon' => $addon,
-                               '$status' => $status,
-                               '$action' => $action,
-                               '$info' => Addon::getInfo($addon),
-                               '$str_author' => DI::l10n()->t('Author: '),
-                               '$str_maintainer' => DI::l10n()->t('Maintainer: '),
-
-                               '$admin_form' => $admin_form,
-                               '$function' => 'addons',
-                               '$screenshot' => '',
-                               '$readme' => $readme,
-
-                               '$form_security_token' => parent::getFormSecurityToken('admin_themes'),
-                       ]);
+               $admin_form = '';
+               if (array_key_exists($addon, $addons_admin)) {
+                       require_once "addon/$addon/$addon.php";
+                       $func = $addon . '_addon_admin';
+                       $func($a, $admin_form);
                }
 
-               DI::baseUrl()->redirect('admin/addons');
+               $t = Renderer::getMarkupTemplate('admin/addons/details.tpl');
+
+               return Renderer::replaceMacros($t, [
+                       '$title' => DI::l10n()->t('Administration'),
+                       '$page' => DI::l10n()->t('Addons'),
+                       '$toggle' => DI::l10n()->t('Toggle'),
+                       '$settings' => DI::l10n()->t('Settings'),
+                       '$baseurl' => DI::baseUrl()->get(true),
+
+                       '$addon' => $addon,
+                       '$status' => $status,
+                       '$action' => $action,
+                       '$info' => Addon::getInfo($addon),
+                       '$str_author' => DI::l10n()->t('Author: '),
+                       '$str_maintainer' => DI::l10n()->t('Maintainer: '),
+
+                       '$admin_form' => $admin_form,
+                       '$function' => 'addons',
+                       '$screenshot' => '',
+                       '$readme' => $readme,
+
+                       '$form_security_token' => self::getFormSecurityToken('admin_addons_details'),
+               ]);
        }
 }