]> git.mxchange.org Git - friendica.git/blobdiff - src/Module/Admin/Users.php
Fix issue 8551: Last item is now displayed again
[friendica.git] / src / Module / Admin / Users.php
index 710708087374cdfff71c6d347fa6115b40fb79be..dca8c9c2e6bd716f9a93da8ed944778d15e2fa76 100644 (file)
@@ -1,19 +1,36 @@
 <?php
+/**
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
 
 namespace Friendica\Module\Admin;
 
 use Friendica\Content\Pager;
-use Friendica\Core\Config;
 use Friendica\Core\Renderer;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\Register;
 use Friendica\Model\User;
-use Friendica\Module\BaseAdminModule;
-use Friendica\Util\Strings;
+use Friendica\Module\BaseAdmin;
 use Friendica\Util\Temporal;
 
-class Users extends BaseAdminModule
+class Users extends BaseAdmin
 {
        public static function post(array $parameters = [])
        {
@@ -24,79 +41,30 @@ class Users extends BaseAdminModule
                $nu_name     = $_POST['new_user_name']     ?? '';
                $nu_nickname = $_POST['new_user_nickname'] ?? '';
                $nu_email    = $_POST['new_user_email']    ?? '';
-               $nu_language = Config::get('system', 'language');
+               $nu_language = DI::config()->get('system', 'language');
 
                parent::checkFormSecurityTokenRedirectOnError('/admin/users', 'admin_users');
 
                if ($nu_name !== '' && $nu_email !== '' && $nu_nickname !== '') {
                        try {
-                               $result = User::create([
-                                       'username' => $nu_name,
-                                       'email' => $nu_email,
-                                       'nickname' => $nu_nickname,
-                                       'verified' => 1,
-                                       'language' => $nu_language
-                               ]);
+                               User::createMinimal($nu_name, $nu_email, $nu_nickname, $nu_language);
                        } catch (\Exception $ex) {
                                notice($ex->getMessage());
                                return;
                        }
-
-                       $user = $result['user'];
-                       $preamble = Strings::deindent(DI::l10n()->t('
-                       Dear %1$s,
-                               the administrator of %2$s has set up an account for you.'));
-                       $body = Strings::deindent(DI::l10n()->t('
-                       The login details are as follows:
-
-                       Site Location:  %1$s
-                       Login Name:             %2$s
-                       Password:               %3$s
-
-                       You may change your password from your account "Settings" page after logging
-                       in.
-
-                       Please take a few moments to review the other account settings on that page.
-
-                       You may also wish to add some basic information to your default profile
-                       (on the "Profiles" page) so that other people can easily find you.
-
-                       We recommend setting your full name, adding a profile photo,
-                       adding some profile "keywords" (very useful in making new friends) - and
-                       perhaps what country you live in; if you do not wish to be more specific
-                       than that.
-
-                       We fully respect your right to privacy, and none of these items are necessary.
-                       If you are new and do not know anybody here, they may help
-                       you to make some new and interesting friends.
-
-                       If you ever want to delete your account, you can do so at %1$s/removeme
-
-                       Thank you and welcome to %4$s.'));
-
-                       $preamble = sprintf($preamble, $user['username'], Config::get('config', 'sitename'));
-                       $body = sprintf($body, DI::baseUrl()->get(), $user['nickname'], $result['password'], Config::get('config', 'sitename'));
-
-                       notification([
-                               'type'     => SYSTEM_EMAIL,
-                               'language' => $user['language'],
-                               'to_name'  => $user['username'],
-                               'to_email' => $user['email'],
-                               'uid'      => $user['uid'],
-                               'subject'  => DI::l10n()->t('Registration details for %s', Config::get('config', 'sitename')),
-                               'preamble' => $preamble,
-                               'body'     => $body]);
                }
 
                if (!empty($_POST['page_users_block'])) {
-                       // @TODO Move this to Model\User:block($users);
-                       DBA::update('user', ['blocked' => 1], ['uid' => $users]);
+                       foreach ($users as $uid) {
+                               User::block($uid);
+                       }
                        notice(DI::l10n()->tt('%s user blocked', '%s users blocked', count($users)));
                }
 
                if (!empty($_POST['page_users_unblock'])) {
-                       // @TODO Move this to Model\User:unblock($users);
-                       DBA::update('user', ['blocked' => 0], ['uid' => $users]);
+                       foreach ($users as $uid) {
+                               User::block($uid, false);
+                       }
                        notice(DI::l10n()->tt('%s user unblocked', '%s users unblocked', count($users)));
                }
 
@@ -113,17 +81,17 @@ class Users extends BaseAdminModule
                }
 
                if (!empty($_POST['page_users_approve'])) {
-                       require_once 'mod/regmod.php';
                        foreach ($pending as $hash) {
-                               user_allow($hash);
+                               User::allow($hash);
                        }
+                       notice(DI::l10n()->tt('%s user approved', '%s users approved', count($pending)));
                }
 
                if (!empty($_POST['page_users_deny'])) {
-                       require_once 'mod/regmod.php';
                        foreach ($pending as $hash) {
-                               user_deny($hash);
+                               User::deny($hash);
                        }
+                       notice(DI::l10n()->tt('%s registration revoked', '%s registrations revoked', count($pending)));
                }
 
                DI::baseUrl()->redirect('admin/users');
@@ -160,16 +128,24 @@ class Users extends BaseAdminModule
                                        break;
                                case 'block':
                                        parent::checkFormSecurityTokenRedirectOnError('/admin/users', 'admin_users', 't');
-                                       // @TODO Move this to Model\User:block([$uid]);
-                                       DBA::update('user', ['blocked' => 1], ['uid' => $uid]);
+                                       User::block($uid);
                                        notice(DI::l10n()->t('User "%s" blocked', $user['username']));
                                        break;
                                case 'unblock':
                                        parent::checkFormSecurityTokenRedirectOnError('/admin/users', 'admin_users', 't');
-                                       // @TODO Move this to Model\User:unblock([$uid]);
-                                       DBA::update('user', ['blocked' => 0], ['uid' => $uid]);
+                                       User::block($uid, false);
                                        notice(DI::l10n()->t('User "%s" unblocked', $user['username']));
                                        break;
+                               case 'allow':
+                                       parent::checkFormSecurityTokenRedirectOnError('/admin/users', 'admin_users', 't');
+                                       User::allow(Register::getPendingForUser($uid)['hash'] ?? '');
+                                       notice(DI::l10n()->t('Account approved.'));
+                                       break;
+                               case 'deny':
+                                       parent::checkFormSecurityTokenRedirectOnError('/admin/users', 'admin_users', 't');
+                                       User::deny(Register::getPendingForUser($uid)['hash'] ?? '');
+                                       notice(DI::l10n()->t('Registration revoked'));
+                                       break;
                        }
 
                        DI::baseUrl()->redirect('admin/users');
@@ -178,19 +154,18 @@ class Users extends BaseAdminModule
                /* get pending */
                $pending = Register::getPending();
 
-               $pager = new Pager(DI::args()->getQueryString(), 100);
+               $pager = new Pager(DI::l10n(), DI::args()->getQueryString(), 100);
 
-               // @TODO Move below block to Model\User::getUsers($start, $count, $order = 'contact.name', $order_direction = '+')
                $valid_orders = [
-                       'contact.name',
-                       'user.email',
-                       'user.register_date',
-                       'user.login_date',
-                       'lastitem_date',
-                       'user.page-flags'
+                       'name',
+                       'email',
+                       'register_date',
+                       'login_date',
+                       'last-item',
+                       'page-flags'
                ];
 
-               $order = 'contact.name';
+               $order = 'name';
                $order_direction = '+';
                if (!empty($_GET['o'])) {
                        $new_order = $_GET['o'];
@@ -203,18 +178,10 @@ class Users extends BaseAdminModule
                                $order = $new_order;
                        }
                }
-               $sql_order = '`' . str_replace('.', '`.`', $order) . '`';
-               $sql_order_direction = ($order_direction === '+') ? 'ASC' : 'DESC';
-
-               $usersStmt = DBA::p("SELECT `user`.*, `contact`.`name`, `contact`.`url`, `contact`.`micro`, `user`.`account_expired`, `contact`.`last-item` AS `lastitem_date`
-                               FROM `user`
-                               INNER JOIN `contact` ON `contact`.`uid` = `user`.`uid` AND `contact`.`self`
-                               WHERE `user`.`verified`
-                               ORDER BY $sql_order $sql_order_direction LIMIT ?, ?", $pager->getStart(), $pager->getItemsPerPage()
-               );
-               $users = DBA::toArray($usersStmt);
-
-               $adminlist = explode(',', str_replace(' ', '', Config::get('config', 'admin_email')));
+
+               $users = User::getList($pager->getStart(), $pager->getItemsPerPage(), 'all', $order, ($order_direction == '-'));
+
+               $adminlist = explode(',', str_replace(' ', '', DI::config()->get('config', 'admin_email')));
                $_setup_users = function ($e) use ($adminlist) {
                        $page_types = [
                                User::PAGE_FLAGS_NORMAL    => DI::l10n()->t('Normal Account Page'),
@@ -239,7 +206,7 @@ class Users extends BaseAdminModule
 
                        $e['register_date'] = Temporal::getRelativeDate($e['register_date']);
                        $e['login_date'] = Temporal::getRelativeDate($e['login_date']);
-                       $e['lastitem_date'] = Temporal::getRelativeDate($e['lastitem_date']);
+                       $e['lastitem_date'] = Temporal::getRelativeDate($e['last-item']);
                        $e['is_admin'] = in_array($e['email'], $adminlist);
                        $e['is_deletable'] = (intval($e['uid']) != local_user());
                        $e['deleted'] = ($e['account_removed'] ? Temporal::getRelativeDate($e['account_expires_on']) : False);
@@ -267,7 +234,7 @@ class Users extends BaseAdminModule
                        }
                }
 
-               $th_users = array_map(null, [DI::l10n()->t('Name'), DI::l10n()->t('Email'), DI::l10n()->t('Register date'), DI::l10n()->t('Last login'), DI::l10n()->t('Last item'), DI::l10n()->t('Type')], $valid_orders);
+               $th_users = array_map(null, [DI::l10n()->t('Name'), DI::l10n()->t('Email'), DI::l10n()->t('Register date'), DI::l10n()->t('Last login'), DI::l10n()->t('Last public item'), DI::l10n()->t('Type')], $valid_orders);
 
                $t = Renderer::getMarkupTemplate('admin/users.tpl');
                $o = Renderer::replaceMacros($t, [
@@ -292,7 +259,7 @@ class Users extends BaseAdminModule
 
                        '$h_users' => DI::l10n()->t('Users'),
                        '$h_newuser' => DI::l10n()->t('New User'),
-                       '$th_deleted' => [DI::l10n()->t('Name'), DI::l10n()->t('Email'), DI::l10n()->t('Register date'), DI::l10n()->t('Last login'), DI::l10n()->t('Last item'), DI::l10n()->t('Permanent deletion')],
+                       '$th_deleted' => [DI::l10n()->t('Name'), DI::l10n()->t('Email'), DI::l10n()->t('Register date'), DI::l10n()->t('Last login'), DI::l10n()->t('Last public item'), DI::l10n()->t('Permanent deletion')],
                        '$th_users' => $th_users,
                        '$order_users' => $order,
                        '$order_direction_users' => $order_direction,