Catch not fetchable posts

[friendica.git] / src / Module / Api / Mastodon / Bookmarks.php

diff --git a/src/Module/Api/Mastodon/Bookmarks.php b/src/Module/Api/Mastodon/Bookmarks.php
index 8b03c40ebdfed4f93dcd77bb4bc132ab22464d82..615bfc501f5031d4d51209474e268ede80bad9e2 100644 (file)
--- a/src/Module/Api/Mastodon/Bookmarks.php
+++ b/src/Module/Api/Mastodon/Bookmarks.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -21,6 +21,7 @@
 
 namespace Friendica\Module\Api\Mastodon;
 
+use Friendica\Core\Logger;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\DI;
@@ -34,53 +35,59 @@ use Friendica\Network\HTTPException;
 class Bookmarks extends BaseApi
 {
        /**
-        * @param array $parameters
         * @throws HTTPException\InternalServerErrorException
         */
-       public static function rawContent(array $parameters = [])
+       protected function rawContent(array $request = [])
        {
-               self::login();
+               self::checkAllowedScope(self::SCOPE_READ);
                $uid = self::getCurrentUserID();
 
-               // Maximum number of results to return. Defaults to 20.
-               $limit = (int)!isset($_REQUEST['limit']) ? 20 : $_REQUEST['limit'];
-               // Return results older than id
-               $max_id = (int)!isset($_REQUEST['max_id']) ? 0 : $_REQUEST['max_id'];
-               // Return results newer than id
-               $since_id = (int)!isset($_REQUEST['since_id']) ? 0 : $_REQUEST['since_id'];
-               // Return results immediately newer than id
-               $min_id = (int)!isset($_REQUEST['min_id']) ? 0 : $_REQUEST['min_id'];
+               $request = $this->getRequest([
+                       'limit'      => 20,    // Maximum number of results to return. Defaults to 20.
+                       'max_id'     => 0,     // Return results older than id
+                       'since_id'   => 0,     // Return results newer than id
+                       'min_id'     => 0,     // Return results immediately newer than id
+                       'with_muted' => false, // Pleroma extension: return activities by muted (not by blocked!) users.
+               ], $request);
 
-               $params = ['order' => ['uri-id' => true], 'limit' => $limit];
+               $params = ['order' => ['uri-id' => true], 'limit' => $request['limit']];
 
-               $condition = ['pinned' => true, 'uid' => $uid];
+               $condition = ['starred' => true, 'uid' => $uid];
 
-               if (!empty($max_id)) {
-                       $condition = DBA::mergeConditions($condition, ["`uri-id` < ?", $max_id]);
+               if (!empty($request['max_id'])) {
+                       $condition = DBA::mergeConditions($condition, ["`uri-id` < ?", $request['max_id']]);
                }
 
-               if (!empty($since_id)) {
-                       $condition = DBA::mergeConditions($condition, ["`uri-id` > ?", $since_id]);
+               if (!empty($request['since_id'])) {
+                       $condition = DBA::mergeConditions($condition, ["`uri-id` > ?", $request['since_id']]);
                }
 
-               if (!empty($min_id)) {
-                       $condition = DBA::mergeConditions($condition, ["`uri-id` > ?", $min_id]);
+               if (!empty($request['min_id'])) {
+                       $condition = DBA::mergeConditions($condition, ["`uri-id` > ?", $request['min_id']]);
 
                        $params['order'] = ['uri-id'];
                }
 
                $items = Post::selectThreadForUser($uid, ['uri-id'], $condition, $params);
 
+               $display_quotes = self::appSupportsQuotes();
+
                $statuses = [];
                while ($item = Post::fetch($items)) {
-                       $statuses[] = DI::mstdnStatus()->createFromUriId($item['uri-id'], $uid);
+                       self::setBoundaries($item['uri-id']);
+                       try {
+                               $statuses[] = DI::mstdnStatus()->createFromUriId($item['uri-id'], $uid, $display_quotes);
+                       } catch (\Throwable $th) {
+                               Logger::info('Post not fetchable', ['uri-id' => $item['uri-id'], 'uid' => $uid, 'error' => $th]);
+                       }
                }
                DBA::close($items);
 
-               if (!empty($min_id)) {
-                       array_reverse($statuses);
+               if (!empty($request['min_id'])) {
+                       $statuses = array_reverse($statuses);
                }
 
+               self::setLinkHeader();
                System::jsonExit($statuses);
        }
 }