Move API Response methods into an own class to make them mockable

[friendica.git] / src / Module / Api / Mastodon / Lists / Accounts.php

diff --git a/src/Module/Api/Mastodon/Lists/Accounts.php b/src/Module/Api/Mastodon/Lists/Accounts.php
index cb2bd208f30f9ce1db610dcd314e032378afb4e0..e1de45b64d837e3598caaf3b18ecda2fc3f2c184 100644 (file)
--- a/src/Module/Api/Mastodon/Lists/Accounts.php
+++ b/src/Module/Api/Mastodon/Lists/Accounts.php
@@ -21,13 +21,15 @@
 
 namespace Friendica\Module\Api\Mastodon\Lists;
 
+use Friendica\App\Router;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\DI;
+use Friendica\Module\Api\ApiResponse;
 use Friendica\Module\BaseApi;
 
 /**
- * @see https://docs.joinmastodon.org/methods/timelines/lists/
+ * @see https://docs.joinmastodon.org/methods/timelines/lists/#accounts-in-a-list
  *
  * Currently the output will be unordered since we use public contact ids in the api and not user contact ids.
  */
@@ -35,12 +37,12 @@ class Accounts extends BaseApi
 {
        public static function delete(array $parameters = [])
        {
-               self::unsupported('delete');
+               ApiResponse::unsupported(Router::DELETE);
        }
 
        public static function post(array $parameters = [])
        {
-               self::unsupported('post');
+               ApiResponse::unsupported(Router::POST);
        }
 
        /**
@@ -49,7 +51,7 @@ class Accounts extends BaseApi
         */
        public static function rawContent(array $parameters = [])
        {
-               self::login();
+               self::checkAllowedScope(self::SCOPE_READ);
                $uid = self::getCurrentUserID();
 
                if (empty($parameters['id'])) {
@@ -61,30 +63,26 @@ class Accounts extends BaseApi
                        DI::mstdnError()->RecordNotFound();
                }
 
-               // Return results older than this id
-               $max_id = (int)!isset($_REQUEST['max_id']) ? 0 : $_REQUEST['max_id'];
-               // Return results newer than this id
-               $since_id = (int)!isset($_REQUEST['since_id']) ? 0 : $_REQUEST['since_id'];
-               // Maximum number of results. Defaults to 40. Max 40.
-               // Set to 0 in order to get all accounts without pagination.
-               $limit = (int)!isset($_REQUEST['limit']) ? 40 : $_REQUEST['limit'];
-
+               $request = self::getRequest([
+                       'max_id'   => 0,  // Return results older than this id
+                       'since_id' => 0,  // Return results newer than this id
+                       'limit'    => 40, // Maximum number of results. Defaults to 40. Max 40. Set to 0 in order to get all accounts without pagination.
+               ]);
 
                $params = ['order' => ['contact-id' => true]];
 
-               if ($limit != 0) {
-                       $params['limit'] = $limit;
-
+               if ($request['limit'] != 0) {
+                       $params['limit'] = min($request['limit'], 40);
                }
-       
+
                $condition = ['gid' => $id];
 
-               if (!empty($max_id)) {
-                       $condition = DBA::mergeConditions($condition, ["`contact-id` < ?", $max_id]);
+               if (!empty($request['max_id'])) {
+                       $condition = DBA::mergeConditions($condition, ["`contact-id` < ?", $request['max_id']]);
                }
 
-               if (!empty($since_id)) {
-                       $condition = DBA::mergeConditions($condition, ["`contact-id` > ?", $since_id]);
+               if (!empty($request['since_id'])) {
+                       $condition = DBA::mergeConditions($condition, ["`contact-id` > ?", $request['since_id']]);
                }
 
                if (!empty($min_id)) {
@@ -97,6 +95,7 @@ class Accounts extends BaseApi
 
                $members = DBA::select('group_member', ['contact-id'], $condition, $params);
                while ($member = DBA::fetch($members)) {
+                       self::setBoundaries($member['contact-id']);
                        $accounts[] = DI::mstdnAccount()->createFromContactId($member['contact-id'], $uid);
                }
                DBA::close($members);
@@ -105,6 +104,7 @@ class Accounts extends BaseApi
                        array_reverse($accounts);
                }
 
+               self::setLinkHeader();
                System::jsonExit($accounts);
        }
 }