Catch not fetchable posts

[friendica.git] / src / Module / Api / Mastodon / Timelines / Tag.php

diff --git a/src/Module/Api/Mastodon/Timelines/Tag.php b/src/Module/Api/Mastodon/Timelines/Tag.php
index 3571dd73335103cc757aeaa673b95ef4be614899..1d04dec6255170979e7a82bf0b1ada3e02bcf432 100644 (file)
--- a/src/Module/Api/Mastodon/Timelines/Tag.php
+++ b/src/Module/Api/Mastodon/Timelines/Tag.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -21,10 +21,12 @@
 
 namespace Friendica\Module\Api\Mastodon\Timelines;
 
+use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\DI;
+use Friendica\Model\Item;
 use Friendica\Model\Post;
 use Friendica\Module\BaseApi;
 use Friendica\Network\HTTPException;
@@ -37,7 +39,7 @@ class Tag extends BaseApi
        /**
         * @throws HTTPException\InternalServerErrorException
         */
-       public function rawContent()
+       protected function rawContent(array $request = [])
        {
                self::checkAllowedScope(self::SCOPE_READ);
                $uid = self::getCurrentUserID();
@@ -49,11 +51,11 @@ class Tag extends BaseApi
                /**
                 * @todo Respect missing parameters
                 * @see https://github.com/tootsuite/mastodon/blob/main/app/controllers/api/v1/timelines/tag_controller.rb
-                * 
+                *
                 * There seem to be the parameters "any", "all", and "none".
                 */
 
-               $request = self::getRequest([
+               $request = $this->getRequest([
                        'local'           => false, // If true, return only local statuses. Defaults to false.
                        'remote'          => false, // Show only remote statuses? Defaults to false.
                        'only_media'      => false, // If true, return only statuses with media attachments. Defaults to false.
@@ -63,7 +65,7 @@ class Tag extends BaseApi
                        'limit'           => 20,    // Maximum number of results to return. Defaults to 20.
                        'with_muted'      => false, // Pleroma extension: return activities by muted (not by blocked!) users.
                        'exclude_replies' => false, // Don't show comments
-               ]);
+               ], $request);
 
                $params = ['order' => ['uri-id' => true], 'limit' => $request['limit']];
 
@@ -76,7 +78,7 @@ class Tag extends BaseApi
                }
 
                if ($request['remote']) {
-                       $condition = DBA::mergeConditions($condition, ["NOT `uri-id` IN (SELECT `uri-id` FROM `post-user` WHERE `origin`)"]);
+                       $condition = DBA::mergeConditions($condition, ["NOT `uri-id` IN (SELECT `uri-id` FROM `post-user` WHERE `origin` AND `post-user`.`uri-id` = `tag-search-view`.`uri-id`)"]);
                }
 
                if ($request['only_media']) {
@@ -85,7 +87,7 @@ class Tag extends BaseApi
                }
 
                if ($request['exclude_replies']) {
-                       $condition = DBA::mergeConditions($condition, ['gravity' => GRAVITY_PARENT]);
+                       $condition = DBA::mergeConditions($condition, ['gravity' => Item::GRAVITY_PARENT]);
                }
 
                if (!empty($request['max_id'])) {
@@ -104,15 +106,21 @@ class Tag extends BaseApi
 
                $items = DBA::select('tag-search-view', ['uri-id'], $condition, $params);
 
+               $display_quotes = self::appSupportsQuotes();
+
                $statuses = [];
                while ($item = Post::fetch($items)) {
                        self::setBoundaries($item['uri-id']);
-                       $statuses[] = DI::mstdnStatus()->createFromUriId($item['uri-id'], $uid);
+                       try {
+                               $statuses[] = DI::mstdnStatus()->createFromUriId($item['uri-id'], $uid, $display_quotes);
+                       } catch (\Throwable $th) {
+                               Logger::info('Post not fetchable', ['uri-id' => $item['uri-id'], 'uid' => $uid, 'error' => $th]);
+                       }
                }
                DBA::close($items);
 
                if (!empty($request['min_id'])) {
-                       array_reverse($statuses);
+                       $statuses = array_reverse($statuses);
                }
 
                self::setLinkHeader();