Merge pull request #12921 from HankG/add-visibility-data-to-mastodon-status

[friendica.git] / src / Module / Api / Twitter / DirectMessagesEndpoint.php

diff --git a/src/Module/Api/Twitter/DirectMessagesEndpoint.php b/src/Module/Api/Twitter/DirectMessagesEndpoint.php
index a1f519975c1452fba04f2bf918172da907ec2e1a..fd5b1c552efc7473b940938f0913d7f070ff16ef 100644 (file)
--- a/src/Module/Api/Twitter/DirectMessagesEndpoint.php
+++ b/src/Module/Api/Twitter/DirectMessagesEndpoint.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2022, the Friendica project
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -54,15 +54,17 @@ abstract class DirectMessagesEndpoint extends BaseApi
         * @param array $request
         * @param int   $uid
         * @param array $condition
+        *
+        * @return void
         */
        protected function getMessages(array $request, int $uid, array $condition)
        {
                // params
                $count    = $this->getRequestValue($request, 'count', 20, 1, 100);
                $page     = $this->getRequestValue($request, 'page', 1, 1);
-               $since_id = $this->getRequestValue($request, 'since_id', 0, 1);
-               $max_id   = $this->getRequestValue($request, 'max_id', 0, 1);
-               $min_id   = $this->getRequestValue($request, 'min_id', 0, 1);
+               $since_id = $this->getRequestValue($request, 'since_id', 0, 0);
+               $max_id   = $this->getRequestValue($request, 'max_id', 0, 0);
+               $min_id   = $this->getRequestValue($request, 'min_id', 0, 0);
                $verbose  = $this->getRequestValue($request, 'friendica_verbose', false);
 
                // pagination
@@ -84,7 +86,7 @@ abstract class DirectMessagesEndpoint extends BaseApi
                        $params['order'] = ['id'];
                }
 
-               $cid = BaseApi::getContactIDForSearchterm($request['screen_name'] ?? '', $request['profileurl'] ?? '', $_REQUEST['user_id'] ?? 0, 0);
+               $cid = BaseApi::getContactIDForSearchterm($this->getRequestValue($request, 'screen_name', ''), $this->getRequestValue($request, 'profileurl', ''), $this->getRequestValue($request, 'user_id', 0), 0);
                if (!empty($cid)) {
                        $cdata = Contact::getPublicAndUserContactID($cid, $uid);
                        if (!empty($cdata['user'])) {
@@ -109,7 +111,7 @@ abstract class DirectMessagesEndpoint extends BaseApi
 
                $ret = [];
                foreach ($ids as $id) {
-                       $ret[] = $this->directMessage->createFromMailId($id, $uid, $request['getText'] ?? '');
+                       $ret[] = $this->directMessage->createFromMailId($id, $uid, $this->getRequestValue($request, 'getText', ''));
                }
 
                self::setLinkHeader();