Reenable Twitter/Destroy tests

[friendica.git] / src / Module / Api / Twitter / Statuses / Destroy.php

diff --git a/src/Module/Api/Twitter/Statuses/Destroy.php b/src/Module/Api/Twitter/Statuses/Destroy.php
index 0106e6ea0e922a5cf8df3d72d73974ae2c335fcb..8c2a8bf3eb6e4d3f841c2123ba4189595602d188 100644 (file)
--- a/src/Module/Api/Twitter/Statuses/Destroy.php
+++ b/src/Module/Api/Twitter/Statuses/Destroy.php
@@ -26,6 +26,7 @@ use Friendica\Module\BaseApi;
 use Friendica\DI;
 use Friendica\Model\Contact;
 use Friendica\Model\Item;
+use Friendica\Network\HTTPException\BadRequestException;
 
 /**
  * Destroys a specific status.
@@ -34,15 +35,17 @@ use Friendica\Model\Item;
  */
 class Destroy extends BaseApi
 {
-       protected function post(array $request = [], array $post = [])
+       protected function post(array $request = [])
        {
                BaseApi::checkAllowedScope(BaseApi::SCOPE_READ);
                $uid = BaseApi::getCurrentUserID();
 
-               if (empty($this->parameters['id'])) {
-                       $id = intval($request['id'] ?? 0);
-               } else {
+               if (empty($this->parameters['id']) && !empty($request['id'])) {
+                       $id = intval($request['id']);
+               } elseif (!empty($this->parameters['id'])) {
                        $id = (int)$this->parameters['id'];
+               } else {
+                       throw new BadRequestException('An id is missing.');
                }
 
                $this->logger->notice('API: api_statuses_destroy: ' . $id);
@@ -53,6 +56,6 @@ class Destroy extends BaseApi
 
                Item::deleteForUser(['id' => $id], $uid);
 
-               DI::apiResponse()->exit('status', ['status' => $ret], $this->parameters['extension'] ?? null, Contact::getPublicIdByUserId($uid));
+               $this->response->exit('status', ['status' => $ret], $this->parameters['extension'] ?? null, Contact::getPublicIdByUserId($uid));
        }
 }