Possibly Avoid database error when storing photo item

[friendica.git] / src / Module / BaseApi.php

diff --git a/src/Module/BaseApi.php b/src/Module/BaseApi.php
index b42e9462dc51d6a366584a45ad75af4cd1d46d5f..c67671954fd8979fb057042433090cf7b82c4c55 100644 (file)
--- a/src/Module/BaseApi.php
+++ b/src/Module/BaseApi.php
@@ -21,23 +21,28 @@
 
 namespace Friendica\Module;
 
+use Friendica\App;
 use Friendica\BaseModule;
+use Friendica\Core\L10n;
 use Friendica\Core\Logger;
 use Friendica\Core\System;
 use Friendica\DI;
+use Friendica\Model\Contact;
 use Friendica\Model\Post;
+use Friendica\Model\User;
+use Friendica\Module\Api\ApiResponse;
 use Friendica\Network\HTTPException;
 use Friendica\Security\BasicAuth;
 use Friendica\Security\OAuth;
-use Friendica\Util\Arrays;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\HTTPInputData;
-use Friendica\Util\XML;
-
-require_once __DIR__ . '/../../include/api.php';
+use Friendica\Util\Profiler;
+use Psr\Log\LoggerInterface;
 
 class BaseApi extends BaseModule
 {
+       const LOG_PREFIX = 'API {action} - ';
+
        const SCOPE_READ   = 'read';
        const SCOPE_WRITE  = 'write';
        const SCOPE_FOLLOW = 'follow';
@@ -53,51 +58,68 @@ class BaseApi extends BaseModule
         */
        protected static $request = [];
 
-       public static function delete()
+       /** @var App */
+       protected $app;
+
+       /** @var ApiResponse */
+       protected $response;
+
+       public function __construct(App $app, L10n $l10n, App\BaseURL $baseUrl, App\Arguments $args, LoggerInterface $logger, Profiler $profiler, ApiResponse $response, array $server, array $parameters = [])
+       {
+               parent::__construct($l10n, $baseUrl, $args, $logger, $profiler, $response, $server, $parameters);
+
+               $this->app = $app;
+       }
+
+       protected function delete()
        {
                self::checkAllowedScope(self::SCOPE_WRITE);
 
-               if (!DI::app()->isLoggedIn()) {
-                       throw new HTTPException\ForbiddenException(DI::l10n()->t('Permission denied.'));
+               if (!$this->app->isLoggedIn()) {
+                       throw new HTTPException\ForbiddenException($this->t('Permission denied.'));
                }
        }
 
-       public static function patch()
+       protected function patch()
        {
                self::checkAllowedScope(self::SCOPE_WRITE);
 
-               if (!DI::app()->isLoggedIn()) {
-                       throw new HTTPException\ForbiddenException(DI::l10n()->t('Permission denied.'));
+               if (!$this->app->isLoggedIn()) {
+                       throw new HTTPException\ForbiddenException($this->t('Permission denied.'));
                }
        }
 
-       public static function post()
+       protected function post(array $request = [], array $post = [])
        {
                self::checkAllowedScope(self::SCOPE_WRITE);
 
-               if (!DI::app()->isLoggedIn()) {
-                       throw new HTTPException\ForbiddenException(DI::l10n()->t('Permission denied.'));
+               if (!$this->app->isLoggedIn()) {
+                       throw new HTTPException\ForbiddenException($this->t('Permission denied.'));
                }
        }
 
-       public static function put()
+       public function put()
        {
                self::checkAllowedScope(self::SCOPE_WRITE);
 
-               if (!DI::app()->isLoggedIn()) {
-                       throw new HTTPException\ForbiddenException(DI::l10n()->t('Permission denied.'));
+               if (!$this->app->isLoggedIn()) {
+                       throw new HTTPException\ForbiddenException($this->t('Permission denied.'));
                }
        }
 
        /**
         * Processes data from GET requests and sets defaults
         *
+        * @param array      $defaults Associative array of expected request keys and their default typed value. A null
+        *                             value will remove the request key from the resulting value array.
+        * @param array|null $request  Custom REQUEST array, superglobal instead
         * @return array request data
+        * @throws \Exception
         */
-       public static function getRequest(array $defaults)
+       public static function getRequest(array $defaults, array $request = null): array
        {
                $httpinput = HTTPInputData::process();
-               $input = array_merge($httpinput['variables'], $httpinput['files'], $_REQUEST);
+               $input = array_merge($httpinput['variables'], $httpinput['files'], $request ?? $_REQUEST);
 
                self::$request    = $input;
                self::$boundaries = [];
@@ -188,7 +210,7 @@ class BaseApi extends BaseModule
         *
         * @return array token
         */
-       protected static function getCurrentApplication()
+       public static function getCurrentApplication()
        {
                $token = OAuth::getCurrentApplicationToken();
 
@@ -295,18 +317,31 @@ class BaseApi extends BaseModule
                }
        }
 
-       /**
-        * Get user info array.
-        *
-        * @param int|string $contact_id Contact ID or URL
-        * @return array|bool
-        * @throws HTTPException\BadRequestException
-        * @throws HTTPException\InternalServerErrorException
-        * @throws HTTPException\UnauthorizedException
-        * @throws \ImagickException
-        */
-       protected static function getUser($contact_id = null)
+       public static function getContactIDForSearchterm(string $screen_name = null, string $profileurl = null, int $cid = null, int $uid)
        {
-               return api_get_user($contact_id);
+               if (!empty($cid)) {
+                       return $cid;
+               }
+
+               if (!empty($profileurl)) {
+                       return Contact::getIdForURL($profileurl);
+               }
+
+               if (empty($cid) && !empty($screen_name)) {
+                       if (strpos($screen_name, '@') !== false) {
+                               return Contact::getIdForURL($screen_name, 0, false);
+                       }
+
+                       $user = User::getByNickname($screen_name, ['uid']);
+                       if (!empty($user['uid'])) {
+                               return Contact::getPublicIdByUserId($user['uid']);
+                       }
+               }
+
+               if ($uid != 0) {
+                       return Contact::getPublicIdByUserId($uid);
+               }
+
+               return null;
        }
 }