]> git.mxchange.org Git - friendica.git/blobdiff - src/Module/Contact.php
Issue-9358 (now for real) commenting and updating on contact now work
[friendica.git] / src / Module / Contact.php
index bf22470ed4babce42aaa88cc81e171da1335db95..cc4f4d9abedda01c6bca64dfee34eb96dff3c7fc 100644 (file)
@@ -32,6 +32,7 @@ use Friendica\Core\ACL;
 use Friendica\Core\Hook;
 use Friendica\Core\Protocol;
 use Friendica\Core\Renderer;
+use Friendica\Core\Theme;
 use Friendica\Core\Worker;
 use Friendica\Database\DBA;
 use Friendica\DI;
@@ -47,6 +48,12 @@ use Friendica\Util\Strings;
  */
 class Contact extends BaseModule
 {
+       const TAB_CONVERSATIONS = 1;
+       const TAB_POSTS = 2;
+       const TAB_PROFILE = 3;
+       const TAB_CONTACTS = 4;
+       const TAB_ADVANCED = 5;
+
        private static function batchActions()
        {
                if (empty($_POST['contact_batch']) || !is_array($_POST['contact_batch'])) {
@@ -179,13 +186,13 @@ class Contact extends BaseModule
 
        private static function updateContactFromProbe($contact_id)
        {
-               $contact = DBA::selectFirst('contact', ['url'], ['id' => $contact_id, 'uid' => local_user(), 'deleted' => false]);
+               $contact = DBA::selectFirst('contact', ['url'], ['id' => $contact_id, 'uid' => [0, local_user()], 'deleted' => false]);
                if (!DBA::isResult($contact)) {
                        return;
                }
 
                // Update the entry in the contact table
-               Model\Contact::updateFromProbe($contact_id, '', true);
+               Model\Contact::updateFromProbe($contact_id);
        }
 
        /**
@@ -196,8 +203,8 @@ class Contact extends BaseModule
         */
        private static function blockContact($contact_id)
        {
-               $blocked = !Model\Contact::isBlockedByUser($contact_id, local_user());
-               Model\Contact::setBlockedForUser($contact_id, local_user(), $blocked);
+               $blocked = !Model\Contact\User::isBlocked($contact_id, local_user());
+               Model\Contact\User::setBlocked($contact_id, local_user(), $blocked);
        }
 
        /**
@@ -208,8 +215,8 @@ class Contact extends BaseModule
         */
        private static function ignoreContact($contact_id)
        {
-               $ignored = !Model\Contact::isIgnoredByUser($contact_id, local_user());
-               Model\Contact::setIgnoredForUser($contact_id, local_user(), $ignored);
+               $ignored = !Model\Contact\User::isIgnored($contact_id, local_user());
+               Model\Contact\User::setIgnored($contact_id, local_user(), $ignored);
        }
 
        /**
@@ -253,23 +260,28 @@ class Contact extends BaseModule
                $rel    = Strings::escapeTags(trim($_GET['rel']    ?? ''));
                $group  = Strings::escapeTags(trim($_GET['group']  ?? ''));
 
-               if (empty(DI::page()['aside'])) {
-                       DI::page()['aside'] = '';
-               }
+               $page = DI::page();
+
+               $page->registerFooterScript(Theme::getPathForFile('asset/typeahead.js/dist/typeahead.bundle.js'));
+               $page->registerFooterScript(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput.js'));
+               $page->registerStylesheet(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput.css'));
+               $page->registerStylesheet(Theme::getPathForFile('js/friendica-tagsinput/friendica-tagsinput-typeahead.css'));
 
-               $contact_id = null;
                $contact = null;
                // @TODO: Replace with parameter from router
                if ($a->argc == 2 && intval($a->argv[1])
                        || $a->argc == 3 && intval($a->argv[1]) && in_array($a->argv[2], ['posts', 'conversations'])
                ) {
                        $contact_id = intval($a->argv[1]);
-                       $contact = DBA::selectFirst('contact', [], ['id' => $contact_id, 'uid' => local_user(), 'deleted' => false]);
 
-                       if (!DBA::isResult($contact)) {
-                               $contact = DBA::selectFirst('contact', [], ['id' => $contact_id, 'uid' => 0, 'deleted' => false]);
+                       // Ensure to use the user contact when the public contact was provided
+                       $data = Model\Contact::getPublicAndUserContacID($contact_id, local_user());
+                       if (!empty($data['user']) && ($contact_id == $data['public'])) {
+                               $contact_id = $data['user'];
                        }
 
+                       $contact = DBA::selectFirst('contact', [], ['id' => $contact_id, 'uid' => [0, local_user()], 'deleted' => false]);
+
                        // Don't display contacts that are about to be deleted
                        if ($contact['network'] == Protocol::PHANTOM) {
                                $contact = false;
@@ -384,16 +396,16 @@ class Contact extends BaseModule
                                // NOTREACHED
                        }
 
-                       if ($cmd === 'updateprofile' && ($orig_record['uid'] != 0)) {
+                       if ($cmd === 'updateprofile') {
                                self::updateContactFromProbe($contact_id);
-                               DI::baseUrl()->redirect('contact/' . $contact_id . '/advanced/');
+                               DI::baseUrl()->redirect('contact/' . $contact_id);
                                // NOTREACHED
                        }
 
                        if ($cmd === 'block') {
                                self::blockContact($contact_id);
 
-                               $blocked = Model\Contact::isBlockedByUser($contact_id, local_user());
+                               $blocked = Model\Contact\User::isBlocked($contact_id, local_user());
                                info(($blocked ? DI::l10n()->t('Contact has been blocked') : DI::l10n()->t('Contact has been unblocked')));
 
                                DI::baseUrl()->redirect('contact/' . $contact_id);
@@ -403,7 +415,7 @@ class Contact extends BaseModule
                        if ($cmd === 'ignore') {
                                self::ignoreContact($contact_id);
 
-                               $ignored = Model\Contact::isIgnoredByUser($contact_id, local_user());
+                               $ignored = Model\Contact\User::isIgnored($contact_id, local_user());
                                info(($ignored ? DI::l10n()->t('Contact has been ignored') : DI::l10n()->t('Contact has been unignored')));
 
                                DI::baseUrl()->redirect('contact/' . $contact_id);
@@ -424,17 +436,6 @@ class Contact extends BaseModule
                        if ($cmd === 'drop' && ($orig_record['uid'] != 0)) {
                                // Check if we should do HTML-based delete confirmation
                                if (!empty($_REQUEST['confirm'])) {
-                                       // <form> can't take arguments in its 'action' parameter
-                                       // so add any arguments as hidden inputs
-                                       $query = explode_querystring(DI::args()->getQueryString());
-                                       $inputs = [];
-                                       foreach ($query['args'] as $arg) {
-                                               if (strpos($arg, 'confirm=') === false) {
-                                                       $arg_parts = explode('=', $arg);
-                                                       $inputs[] = ['name' => $arg_parts[0], 'value' => $arg_parts[1]];
-                                               }
-                                       }
-
                                        DI::page()['aside'] = '';
 
                                        return Renderer::replaceMacros(Renderer::getMarkupTemplate('contact_drop_confirm.tpl'), [
@@ -442,9 +443,8 @@ class Contact extends BaseModule
                                                '$contact' => self::getContactTemplateVars($orig_record),
                                                '$method' => 'get',
                                                '$message' => DI::l10n()->t('Do you really want to delete this contact?'),
-                                               '$extra_inputs' => $inputs,
                                                '$confirm' => DI::l10n()->t('Yes'),
-                                               '$confirm_url' => $query['base'],
+                                               '$confirm_url' => DI::args()->getCommand(),
                                                '$confirm_name' => 'confirmed',
                                                '$cancel' => DI::l10n()->t('Cancel'),
                                        ]);
@@ -477,8 +477,8 @@ class Contact extends BaseModule
                                '$baseurl' => DI::baseUrl()->get(true),
                        ]);
 
-                       $contact['blocked']  = Model\Contact::isBlockedByUser($contact['id'], local_user());
-                       $contact['readonly'] = Model\Contact::isIgnoredByUser($contact['id'], local_user());
+                       $contact['blocked']  = Model\Contact\User::isBlocked($contact['id'], local_user());
+                       $contact['readonly'] = Model\Contact\User::isIgnored($contact['id'], local_user());
 
                        $relation_text = '';
                        switch ($contact['rel']) {
@@ -529,7 +529,7 @@ class Contact extends BaseModule
                        $nettype = DI::l10n()->t('Network type: %s', ContactSelector::networkToName($contact['network'], $contact['url'], $contact['protocol']));
 
                        // tabs
-                       $tab_str = self::getTabsHTML($a, $contact, 3);
+                       $tab_str = self::getTabsHTML($contact, self::TAB_PROFILE);
 
                        $lost_contact = (($contact['archive'] && $contact['term-date'] > DBA::NULL_DATETIME && $contact['term-date'] < DateTimeFormat::utcNow()) ? DI::l10n()->t('Communications lost with this contact!') : '');
 
@@ -550,7 +550,7 @@ class Contact extends BaseModule
                        }
 
                        $poll_interval = null;
-                       if (in_array($contact['network'], [Protocol::FEED, Protocol::MAIL])) {
+                       if ((($contact['network'] == Protocol::FEED) && !DI::config()->get('system', 'adjust_poll_frequency')) || ($contact['network']== Protocol::MAIL)) {
                                $poll_interval = ContactSelector::pollInterval($contact['priority'], !$poll_enabled);
                        }
 
@@ -574,7 +574,7 @@ class Contact extends BaseModule
                                '$lbl_info2'      => DI::l10n()->t('Their personal note'),
                                '$reason'         => trim(Strings::escapeTags($contact['reason'])),
                                '$infedit'        => DI::l10n()->t('Edit contact notes'),
-                               '$common_link'    => 'common/loc/' . local_user() . '/' . $contact['id'],
+                               '$common_link'    => 'contact/' . $contact['id'] . '/contacts/common',
                                '$relation_text'  => $relation_text,
                                '$visit'          => DI::l10n()->t('Visit %s\'s profile [%s]', $contact['name'], $contact['url']),
                                '$blockunblock'   => DI::l10n()->t('Block/Unblock contact'),
@@ -736,8 +736,8 @@ class Contact extends BaseModule
                        $sql_values
                );
                while ($contact = DBA::fetch($stmt)) {
-                       $contact['blocked'] = Model\Contact::isBlockedByUser($contact['id'], local_user());
-                       $contact['readonly'] = Model\Contact::isIgnoredByUser($contact['id'], local_user());
+                       $contact['blocked'] = Model\Contact\User::isBlocked($contact['id'], local_user());
+                       $contact['readonly'] = Model\Contact\User::isIgnored($contact['id'], local_user());
                        $contacts[] = self::getContactTemplateVars($contact);
                }
                DBA::close($stmt);
@@ -853,70 +853,62 @@ class Contact extends BaseModule
         *
         * Available Pages are 'Status', 'Profile', 'Contacts' and 'Common Friends'
         *
-        * @param App   $a
         * @param array $contact    The contact array
         * @param int   $active_tab 1 if tab should be marked as active
         *
         * @return string HTML string of the contact page tabs buttons.
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
-       public static function getTabsHTML($a, $contact, $active_tab)
+       public static function getTabsHTML(array $contact, int $active_tab)
        {
+               $cid = $pcid = $contact['id'];
+               $data = Model\Contact::getPublicAndUserContacID($contact['id'], local_user());
+               if (!empty($data['user']) && ($contact['id'] == $data['public'])) {
+                       $cid = $data['user'];
+               } elseif (!empty($data['public'])) {
+                       $pcid = $data['public'];
+               }
+
                // tabs
                $tabs = [
                        [
                                'label' => DI::l10n()->t('Status'),
-                               'url'   => "contact/" . $contact['id'] . "/conversations",
-                               'sel'   => (($active_tab == 1) ? 'active' : ''),
+                               'url'   => 'contact/' . $pcid . '/conversations',
+                               'sel'   => (($active_tab == self::TAB_CONVERSATIONS) ? 'active' : ''),
                                'title' => DI::l10n()->t('Conversations started by this contact'),
                                'id'    => 'status-tab',
                                'accesskey' => 'm',
                        ],
                        [
                                'label' => DI::l10n()->t('Posts and Comments'),
-                               'url'   => "contact/" . $contact['id'] . "/posts",
-                               'sel'   => (($active_tab == 2) ? 'active' : ''),
+                               'url'   => 'contact/' . $pcid . '/posts',
+                               'sel'   => (($active_tab == self::TAB_POSTS) ? 'active' : ''),
                                'title' => DI::l10n()->t('Status Messages and Posts'),
                                'id'    => 'posts-tab',
                                'accesskey' => 'p',
                        ],
                        [
                                'label' => DI::l10n()->t('Profile'),
-                               'url'   => "contact/" . $contact['id'],
-                               'sel'   => (($active_tab == 3) ? 'active' : ''),
+                               'url'   => 'contact/' . $cid,
+                               'sel'   => (($active_tab == self::TAB_PROFILE) ? 'active' : ''),
                                'title' => DI::l10n()->t('Profile Details'),
                                'id'    => 'profile-tab',
                                'accesskey' => 'o',
-                       ]
+                       ],
+                       ['label' => DI::l10n()->t('Contacts'),
+                               'url'   => 'contact/' . $pcid . '/contacts',
+                               'sel'   => (($active_tab == self::TAB_CONTACTS) ? 'active' : ''),
+                               'title' => DI::l10n()->t('View all known contacts'),
+                               'id'    => 'contacts-tab',
+                               'accesskey' => 't'
+                       ],
                ];
 
-               // Show this tab only if there is visible friend list
-               $x = Model\GContact::countAllFriends(local_user(), $contact['id']);
-               if ($x) {
-                       $tabs[] = ['label' => DI::l10n()->t('Contacts'),
-                               'url'   => "allfriends/" . $contact['id'],
-                               'sel'   => (($active_tab == 4) ? 'active' : ''),
-                               'title' => DI::l10n()->t('View all contacts'),
-                               'id'    => 'allfriends-tab',
-                               'accesskey' => 't'];
-               }
-
-               // Show this tab only if there is visible common friend list
-               $common = Model\GContact::countCommonFriends(local_user(), $contact['id']);
-               if ($common) {
-                       $tabs[] = ['label' => DI::l10n()->t('Common Friends'),
-                               'url'   => "common/loc/" . local_user() . "/" . $contact['id'],
-                               'sel'   => (($active_tab == 5) ? 'active' : ''),
-                               'title' => DI::l10n()->t('View all common friends'),
-                               'id'    => 'common-loc-tab',
-                               'accesskey' => 'd'
-                       ];
-               }
-
-               if (!empty($contact['uid'])) {
+               if ($cid != $pcid) {
                        $tabs[] = ['label' => DI::l10n()->t('Advanced'),
-                               'url'   => 'contact/' . $contact['id'] . '/advanced/',
-                               'sel'   => (($active_tab == 6) ? 'active' : ''),
+                               'url'   => 'contact/' . $cid . '/advanced/',
+                               'sel'   => (($active_tab == self::TAB_ADVANCED) ? 'active' : ''),
                                'title' => DI::l10n()->t('Advanced Contact Settings'),
                                'id'    => 'advanced-tab',
                                'accesskey' => 'r'
@@ -929,7 +921,7 @@ class Contact extends BaseModule
                return $tab_str;
        }
 
-       private static function getConversationsHMTL($a, $contact_id, $update)
+       public static function getConversationsHMTL($a, $contact_id, $update, $parent = 0)
        {
                $o = '';
 
@@ -954,20 +946,21 @@ class Contact extends BaseModule
                $contact = DBA::selectFirst('contact', ['uid', 'url', 'id'], ['id' => $contact_id, 'deleted' => false]);
 
                if (!$update) {
-                       $o .= self::getTabsHTML($a, $contact, 1);
+                       $o .= self::getTabsHTML($contact, self::TAB_CONVERSATIONS);
                }
 
                if (DBA::isResult($contact)) {
                        DI::page()['aside'] = '';
 
-                       $profiledata = Model\Contact::getByURL($contact['url'], false);
-
-                       Model\Profile::load($a, '', $profiledata, true);
+                       if (!$update) {
+                               $profiledata = Model\Contact::getByURLForUser($contact['url'], local_user());
+                               Model\Profile::load($a, '', $profiledata, true);
+                       }
 
                        if ($contact['uid'] == 0) {
-                               $o .= Model\Contact::getPostsFromId($contact['id'], true, $update);
+                               $o .= Model\Contact::getPostsFromId($contact['id'], true, $update, $parent);
                        } else {
-                               $o .= Model\Contact::getPostsFromUrl($contact['url'], true, $update);
+                               $o .= Model\Contact::getPostsFromUrl($contact['url'], true, $update, $parent);
                        }
                }
 
@@ -978,12 +971,12 @@ class Contact extends BaseModule
        {
                $contact = DBA::selectFirst('contact', ['uid', 'url', 'id'], ['id' => $contact_id, 'deleted' => false]);
 
-               $o = self::getTabsHTML($a, $contact, 2);
+               $o = self::getTabsHTML($contact, self::TAB_POSTS);
 
                if (DBA::isResult($contact)) {
                        DI::page()['aside'] = '';
 
-                       $profiledata = Model\Contact::getByURL($contact['url'], false);
+                       $profiledata = Model\Contact::getByURLForUser($contact['url'], local_user());
 
                        if (local_user() && in_array($profiledata['network'], Protocol::FEDERATED)) {
                                $profiledata['remoteconnect'] = DI::baseUrl() . '/follow?url=' . urlencode($profiledata['url']);
@@ -1011,7 +1004,16 @@ class Contact extends BaseModule
        {
                $alt_text = '';
 
-               if (!empty($contact['uid']) && !empty($contact['rel'])) {
+               if (!empty($contact['url']) && isset($contact['uid']) && ($contact['uid'] == 0) && local_user()) {
+                       $personal = Model\Contact::getByURL($contact['url'], false, ['uid', 'rel', 'self'], local_user());
+                       if (!empty($personal)) {
+                               $contact['uid'] = $personal['uid'];
+                               $contact['rel'] = $personal['rel'];
+                               $contact['self'] = $personal['self'];
+                       }
+               }
+
+               if (!empty($contact['uid']) && !empty($contact['rel']) && local_user() == $contact['uid']) {
                        switch ($contact['rel']) {
                                case Model\Contact::FRIEND:
                                        $alt_text = DI::l10n()->t('Mutual Friendship');
@@ -1105,6 +1107,16 @@ class Contact extends BaseModule
                        ];
                }
 
+               if (in_array($contact['network'], Protocol::FEDERATED)) {
+                       $contact_actions['updateprofile'] = [
+                               'label' => DI::l10n()->t('Refetch contact data'),
+                               'url'   => 'contact/' . $contact['id'] . '/updateprofile',
+                               'title' => '',
+                               'sel'   => '',
+                               'id'    => 'updateprofile',
+                       ];
+               }
+
                $contact_actions['block'] = [
                        'label' => (intval($contact['blocked']) ? DI::l10n()->t('Unblock') : DI::l10n()->t('Block')),
                        'url'   => 'contact/' . $contact['id'] . '/block',