]> git.mxchange.org Git - friendica.git/blobdiff - src/Module/Conversation/Community.php
Merge pull request #12518 from annando/reporter
[friendica.git] / src / Module / Conversation / Community.php
index ae108dd918d719f3b769caf1c5789920cea1f7d5..7e6730f8334b07620afbecbf97b8ddb36b6d5f83 100644 (file)
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2022, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -29,40 +29,59 @@ use Friendica\Content\Nav;
 use Friendica\Content\Text\HTML;
 use Friendica\Content\Widget;
 use Friendica\Content\Widget\TrendingTags;
-use Friendica\Core\ACL;
 use Friendica\Core\Renderer;
-use Friendica\Core\Session;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\Item;
+use Friendica\Model\Post;
 use Friendica\Model\User;
 use Friendica\Network\HTTPException;
 
 class Community extends BaseModule
 {
+       /**
+        * Type of the community page
+        * @{
+        */
+       const DISABLED         = -2;
+       const DISABLED_VISITOR = -1;
+       const LOCAL            = 0;
+       const GLOBAL           = 1;
+       const LOCAL_AND_GLOBAL = 2;
+       /**
+        * @}
+        */
+
        protected static $page_style;
        protected static $content;
-       protected static $accounttype;
+       protected static $accountTypeString;
+       protected static $accountType;
        protected static $itemsPerPage;
-       protected static $since_id;
+       protected static $min_id;
        protected static $max_id;
        protected static $item_id;
 
-       public static function content(array $parameters = [])
+       protected function content(array $request = []): string
        {
-               self::parseRequest($parameters);
+               $this->parseRequest();
 
-               if (DI::pConfig()->get(local_user(), 'system', 'infinite_scroll')) {
+               $t = Renderer::getMarkupTemplate("community.tpl");
+               $o = Renderer::replaceMacros($t, [
+                       '$content' => '',
+                       '$header' => '',
+                       '$show_global_community_hint' => (self::$content == 'global') && DI::config()->get('system', 'show_global_community_hint'),
+                       '$global_community_hint' => DI::l10n()->t("This community stream shows all public posts received by this node. They may not reflect the opinions of this node’s users.")
+               ]);
+
+               if (DI::pConfig()->get(DI::userSession()->getLocalUserId(), 'system', 'infinite_scroll')) {
                        $tpl = Renderer::getMarkupTemplate('infinite_scroll_head.tpl');
-                       $o = Renderer::replaceMacros($tpl, ['$reload_uri' => DI::args()->getQueryString()]);
-               } else {
-                       $o = '';
+                       $o .= Renderer::replaceMacros($tpl, ['$reload_uri' => DI::args()->getQueryString()]);
                }
 
                if (empty($_GET['mode']) || ($_GET['mode'] != 'raw')) {
                        $tabs = [];
 
-                       if ((Session::isAuthenticated() || in_array(self::$page_style, [CP_USERS_AND_GLOBAL, CP_USERS_ON_SERVER])) && empty(DI::config()->get('system', 'singleuser'))) {
+                       if ((DI::userSession()->isAuthenticated() || in_array(self::$page_style, [self::LOCAL_AND_GLOBAL, self::LOCAL])) && empty(DI::config()->get('system', 'singleuser'))) {
                                $tabs[] = [
                                        'label' => DI::l10n()->t('Local Community'),
                                        'url' => 'community/local',
@@ -73,7 +92,7 @@ class Community extends BaseModule
                                ];
                        }
        
-                       if (Session::isAuthenticated() || in_array(self::$page_style, [CP_USERS_AND_GLOBAL, CP_GLOBAL_COMMUNITY])) {
+                       if (DI::userSession()->isAuthenticated() || in_array(self::$page_style, [self::LOCAL_AND_GLOBAL, self::GLOBAL])) {
                                $tabs[] = [
                                        'label' => DI::l10n()->t('Global Community'),
                                        'url' => 'community/global',
@@ -89,17 +108,17 @@ class Community extends BaseModule
 
                        Nav::setSelected('community');
 
-                       DI::page()['aside'] .= Widget::accounts('community/' . self::$content, $parameters['accounttype'] ?? '');
+                       DI::page()['aside'] .= Widget::accountTypes('community/' . self::$content, self::$accountTypeString);
        
-                       if (local_user() && DI::config()->get('system', 'community_no_sharer')) {
+                       if (DI::userSession()->getLocalUserId() && DI::config()->get('system', 'community_no_sharer')) {
                                $path = self::$content;
-                               if (!empty($parameters['accounttype'])) {
-                                       $path .= '/' . $parameters['accounttype'];
+                               if (!empty($this->parameters['accounttype'])) {
+                                       $path .= '/' . $this->parameters['accounttype'];
                                }
                                $query_parameters = [];
                
-                               if (!empty($_GET['since_id'])) {
-                                       $query_parameters['since_id'] = $_GET['since_id'];
+                               if (!empty($_GET['min_id'])) {
+                                       $query_parameters['min_id'] = $_GET['min_id'];
                                }
                                if (!empty($_GET['max_id'])) {
                                        $query_parameters['max_id'] = $_GET['max_id'];
@@ -120,35 +139,24 @@ class Community extends BaseModule
                                ]);
                        }
        
-                       if (Feature::isEnabled(local_user(), 'trending_tags')) {
+                       if (Feature::isEnabled(DI::userSession()->getLocalUserId(), 'trending_tags')) {
                                DI::page()['aside'] .= TrendingTags::getHTML(self::$content);
                        }
 
                        // We need the editor here to be able to reshare an item.
-                       if (Session::isAuthenticated()) {
-                               $x = [
-                                       'is_owner' => true,
-                                       'allow_location' => DI::app()->user['allow_location'],
-                                       'default_location' => DI::app()->user['default-location'],
-                                       'nickname' => DI::app()->user['nickname'],
-                                       'lockstate' => (is_array(DI::app()->user) && (strlen(DI::app()->user['allow_cid']) || strlen(DI::app()->user['allow_gid']) || strlen(DI::app()->user['deny_cid']) || strlen(DI::app()->user['deny_gid'])) ? 'lock' : 'unlock'),
-                                       'acl' => ACL::getFullSelectorHTML(DI::page(), DI::app()->user, true),
-                                       'bang' => '',
-                                       'visitor' => 'block',
-                                       'profile_uid' => local_user(),
-                               ];
-                               $o .= status_editor(DI::app(), $x, 0, true);
+                       if (DI::userSession()->isAuthenticated()) {
+                               $o .= DI::conversation()->statusEditor([], 0, true);
                        }
                }
 
                $items = self::getItems();
 
                if (!DBA::isResult($items)) {
-                       notice(DI::l10n()->t('No results.'));
+                       DI::sysmsg()->addNotice(DI::l10n()->t('No results.'));
                        return $o;
                }
 
-               $o .= conversation(DI::app(), $items, 'community', false, false, 'commented', local_user());
+               $o .= DI::conversation()->create($items, 'community', false, false, 'commented', DI::userSession()->getLocalUserId());
 
                $pager = new BoundariesPager(
                        DI::l10n(),
@@ -158,66 +166,44 @@ class Community extends BaseModule
                        self::$itemsPerPage
                );
 
-               if (DI::pConfig()->get(local_user(), 'system', 'infinite_scroll')) {
+               if (DI::pConfig()->get(DI::userSession()->getLocalUserId(), 'system', 'infinite_scroll')) {
                        $o .= HTML::scrollLoader();
                } else {
                        $o .= $pager->renderMinimal(count($items));
                }
 
-               $t = Renderer::getMarkupTemplate("community.tpl");
-               return Renderer::replaceMacros($t, [
-                       '$content' => $o,
-                       '$header' => '',
-                       '$show_global_community_hint' => (self::$content == 'global') && DI::config()->get('system', 'show_global_community_hint'),
-                       '$global_community_hint' => DI::l10n()->t("This community stream shows all public posts received by this node. They may not reflect the opinions of this node’s users.")
-               ]);
+               return $o;
        }
 
        /**
         * Computes module parameters from the request and local configuration
         *
-        * @param array $parameters
         * @throws HTTPException\BadRequestException
         * @throws HTTPException\ForbiddenException
         */
-       protected static function parseRequest(array $parameters)
+       protected function parseRequest()
        {
-               if (DI::config()->get('system', 'block_public') && !Session::isAuthenticated()) {
+               if (DI::config()->get('system', 'block_public') && !DI::userSession()->isAuthenticated()) {
                        throw new HTTPException\ForbiddenException(DI::l10n()->t('Public access denied.'));
                }
 
                self::$page_style = DI::config()->get('system', 'community_page_style');
 
-               if (self::$page_style == CP_NO_INTERNAL_COMMUNITY) {
+               if (self::$page_style == self::DISABLED) {
                        throw new HTTPException\ForbiddenException(DI::l10n()->t('Access denied.'));
                }
 
-               switch ($parameters['accounttype'] ?? '') {
-                       case 'person':
-                               self::$accounttype = User::ACCOUNT_TYPE_PERSON;
-                               break;
-                       case 'organisation':
-                               self::$accounttype = User::ACCOUNT_TYPE_ORGANISATION;
-                               break;
-                       case 'news':
-                               self::$accounttype = User::ACCOUNT_TYPE_NEWS;
-                               break;
-                       case 'community':
-                               self::$accounttype = User::ACCOUNT_TYPE_COMMUNITY;
-                               break;
-                       default:
-                               self::$accounttype = null;
-                               break;
-               }
+               self::$accountTypeString = $_GET['accounttype'] ?? $this->parameters['accounttype'] ?? '';
+               self::$accountType = User::getAccountTypeByString(self::$accountTypeString);
 
-               self::$content = $parameters['content'] ?? '';
+               self::$content = $this->parameters['content'] ?? '';
                if (!self::$content) {
                        if (!empty(DI::config()->get('system', 'singleuser'))) {
                                // On single user systems only the global page does make sense
                                self::$content = 'global';
                        } else {
                                // When only the global community is allowed, we use this as default
-                               self::$content = self::$page_style == CP_GLOBAL_COMMUNITY ? 'global' : 'local';
+                               self::$content = self::$page_style == self::GLOBAL ? 'global' : 'local';
                        }
                }
 
@@ -226,15 +212,15 @@ class Community extends BaseModule
                }
 
                // Check if we are allowed to display the content to visitors
-               if (!Session::isAuthenticated()) {
-                       $available = self::$page_style == CP_USERS_AND_GLOBAL;
+               if (!DI::userSession()->isAuthenticated()) {
+                       $available = self::$page_style == self::LOCAL_AND_GLOBAL;
 
                        if (!$available) {
-                               $available = (self::$page_style == CP_USERS_ON_SERVER) && (self::$content == 'local');
+                               $available = (self::$page_style == self::LOCAL) && (self::$content == 'local');
                        }
 
                        if (!$available) {
-                               $available = (self::$page_style == CP_GLOBAL_COMMUNITY) && (self::$content == 'global');
+                               $available = (self::$page_style == self::GLOBAL) && (self::$content == 'global');
                        }
 
                        if (!$available) {
@@ -243,27 +229,21 @@ class Community extends BaseModule
                }
 
                if (DI::mode()->isMobile()) {
-                       self::$itemsPerPage = DI::pConfig()->get(local_user(), 'system', 'itemspage_mobile_network',
+                       self::$itemsPerPage = DI::pConfig()->get(DI::userSession()->getLocalUserId(), 'system', 'itemspage_mobile_network',
                                DI::config()->get('system', 'itemspage_network_mobile'));
                } else {
-                       self::$itemsPerPage = DI::pConfig()->get(local_user(), 'system', 'itemspage_network',
+                       self::$itemsPerPage = DI::pConfig()->get(DI::userSession()->getLocalUserId(), 'system', 'itemspage_network',
                                DI::config()->get('system', 'itemspage_network'));
                }
 
-               // now that we have the user settings, see if the theme forces
-               // a maximum item number which is lower then the user choice
-               if ((DI::app()->force_max_items > 0) && (DI::app()->force_max_items < self::$itemsPerPage)) {
-                       self::$itemsPerPage = DI::app()->force_max_items;
-               }
-
                if (!empty($_GET['item'])) {
-                       $item = Item::selectFirst(['parent'], ['id' => $_GET['item']]);
+                       $item = Post::selectFirst(['parent'], ['id' => $_GET['item']]);
                        self::$item_id = $item['parent'] ?? 0;
                } else {
                        self::$item_id = 0;
                }
 
-               self::$since_id = $_GET['since_id'] ?? null;
+               self::$min_id = $_GET['min_id'] ?? null;
                self::$max_id   = $_GET['max_id']   ?? null;
                self::$max_id   = $_GET['last_commented'] ?? self::$max_id;
        }
@@ -279,7 +259,7 @@ class Community extends BaseModule
         */
        protected static function getItems()
        {
-               $items = self::selectItems(self::$since_id, self::$max_id, self::$item_id, self::$itemsPerPage);
+               $items = self::selectItems(self::$min_id, self::$max_id, self::$item_id, self::$itemsPerPage);
 
                $maxpostperauthor = (int) DI::config()->get('system', 'max_author_posts_community_page');
                if ($maxpostperauthor != 0 && self::$content == 'local') {
@@ -304,14 +284,14 @@ class Community extends BaseModule
 
                                // If we're looking at a "previous page", the lookup continues forward in time because the list is
                                // sorted in chronologically decreasing order
-                               if (isset(self::$since_id)) {
-                                       self::$since_id = $items[0]['commented'];
+                               if (isset(self::$min_id)) {
+                                       self::$min_id = $items[0]['commented'];
                                } else {
                                        // In any other case, the lookup continues backwards in time
                                        self::$max_id = $items[count($items) - 1]['commented'];
                                }
 
-                               $items = self::selectItems(self::$since_id, self::$max_id, self::$item_id, self::$itemsPerPage);
+                               $items = self::selectItems(self::$min_id, self::$max_id, self::$item_id, self::$itemsPerPage);
                        }
                } else {
                        $selected_items = $items;
@@ -323,26 +303,24 @@ class Community extends BaseModule
        /**
         * Database query for the comunity page
         *
-        * @param $since_id
+        * @param $min_id
         * @param $max_id
         * @param $itemspage
         * @return array
         * @throws \Exception
         * @TODO Move to repository/factory
         */
-       private static function selectItems($since_id, $max_id, $item_id, $itemspage)
+       private static function selectItems($min_id, $max_id, $item_id, $itemspage)
        {
-               $r = false;
-
                if (self::$content == 'local') {
-                       if (!is_null(self::$accounttype)) {
-                               $condition = ["`wall` AND `origin` AND `private` = ? AND `owner`.`contact-type` = ?", Item::PUBLIC, self::$accounttype];
+                       if (!is_null(self::$accountType)) {
+                               $condition = ["`wall` AND `origin` AND `private` = ? AND `owner-contact-type` = ?", Item::PUBLIC, self::$accountType];
                        } else {
                                $condition = ["`wall` AND `origin` AND `private` = ?", Item::PUBLIC];
                        }
                } elseif (self::$content == 'global') {
-                       if (!is_null(self::$accounttype)) {
-                               $condition = ["`uid` = ? AND `private` = ? AND `owner`.`contact-type` = ?", 0, Item::PUBLIC, self::$accounttype];
+                       if (!is_null(self::$accountType)) {
+                               $condition = ["`uid` = ? AND `private` = ? AND `owner-contact-type` = ?", 0, Item::PUBLIC, self::$accountType];
                        } else {
                                $condition = ["`uid` = ? AND `private` = ?", 0, Item::PUBLIC];
                        }
@@ -350,13 +328,15 @@ class Community extends BaseModule
                        return [];
                }
 
+               $params = ['order' => ['commented' => true], 'limit' => $itemspage];
+
                if (!empty($item_id)) {
-                       $condition[0] .= " AND `iid` = ?";
+                       $condition[0] .= " AND `id` = ?";
                        $condition[] = $item_id;
                } else {
-                       if (local_user() && !empty($_REQUEST['no_sharer'])) {
-                               $condition[0] .= " AND NOT EXISTS (SELECT `uri-id` FROM `thread` AS t1 WHERE `t1`.`uri-id` = `thread`.`uri-id` AND `t1`.`uid` = ?)";
-                               $condition[] = local_user();
+                       if (DI::userSession()->getLocalUserId() && !empty($_REQUEST['no_sharer'])) {
+                               $condition[0] .= " AND NOT `uri-id` IN (SELECT `uri-id` FROM `post-user` WHERE `post-user`.`uid` = ? AND `post-user`.`uri-id` = `post-thread-user-view`.`uri-id`)";
+                               $condition[] = DI::userSession()->getLocalUserId();
                        }
        
                        if (isset($max_id)) {
@@ -364,14 +344,29 @@ class Community extends BaseModule
                                $condition[] = $max_id;
                        }
 
-                       if (isset($since_id)) {
+                       if (isset($min_id)) {
                                $condition[0] .= " AND `commented` > ?";
-                               $condition[] = $since_id;
+                               $condition[] = $min_id;
+
+                               // Previous page case: we want the items closest to min_id but for that we need to reverse the query order
+                               if (!isset($max_id)) {
+                                       $params['order']['commented'] = false;
+                               }
                        }
                }
 
-               $r = Item::selectThreadForUser(0, ['uri', 'commented', 'author-link'], $condition, ['order' => ['commented' => true], 'limit' => $itemspage]);
+               $r = Post::selectThreadForUser(0, ['uri-id', 'commented', 'author-link'], $condition, $params);
+
+               $items = Post::toArray($r);
+               if (empty($items)) {
+                       return [];
+               }
+
+               // Previous page case: once we get the relevant items closest to min_id, we need to restore the expected display order
+               if (empty($item_id) && isset($min_id) && !isset($max_id)) {
+                       $items = array_reverse($items);
+               }
 
-               return DBA::toArray($r);
+               return $items;
        }
 }