Improve performance of asynchronous like/update

[friendica.git] / src / Module / Like.php

diff --git a/src/Module/Like.php b/src/Module/Like.php
index f57cbadfd357516abe30977c63f3d6faf4a74484..ca382475082c6871bcb4305e3e62a00020d07cdf 100644 (file)
--- a/src/Module/Like.php
+++ b/src/Module/Like.php
@@ -1,9 +1,31 @@
 <?php
+/**
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
 
 namespace Friendica\Module;
 
 use Friendica\BaseModule;
+use Friendica\Core\System;
+use Friendica\DI;
 use Friendica\Model\Item;
+use Friendica\Core\Session;
 use Friendica\Network\HTTPException;
 use Friendica\Util\Strings;
 
@@ -12,9 +34,9 @@ use Friendica\Util\Strings;
  */
 class Like extends BaseModule
 {
-       public static function rawContent()
+       public static function rawContent(array $parameters = [])
        {
-               if (!local_user() && !remote_user()) {
+               if (!Session::isAuthenticated()) {
                        throw new HTTPException\ForbiddenException();
                }
 
@@ -24,18 +46,18 @@ class Like extends BaseModule
                        $verb = 'like';
                }
 
-               $app = self::getApp();
+               $app = DI::app();
 
                // @TODO: Replace with parameter from router
                $itemId = (($app->argc > 1) ? Strings::escapeTags(trim($app->argv[1])) : 0);
 
-               if (!Item::performLike($itemId, $verb)) {
+               if (!Item::performActivity($itemId, $verb)) {
                        throw new HTTPException\BadRequestException();
                }
 
                // Decide how to return. If we were called with a 'return' argument,
                // then redirect back to the calling page. If not, just quietly end
-               $returnPath = defaults($_REQUEST, 'return', '');
+               $returnPath = $_REQUEST['return'] ?? '';
 
                if (!empty($returnPath)) {
                        $rand = '_=' . time();
@@ -45,7 +67,9 @@ class Like extends BaseModule
                                $rand = "?$rand";
                        }
 
-                       $app->internalRedirect($returnPath . $rand);
+                       DI::baseUrl()->redirect($returnPath . $rand);
                }
+
+               System::jsonExit(['status' => 'OK']);
        }
 }