]> git.mxchange.org Git - friendica.git/blobdiff - src/Module/Login.php
Merge pull request #6225 from annando/http-error
[friendica.git] / src / Module / Login.php
index 92b0daed13d2c40abc77f1bccd6227f76728d0ac..82d70498281fc6547a6e7a79520c6bca96793c8b 100644 (file)
@@ -10,11 +10,14 @@ use Friendica\Core\Addon;
 use Friendica\Core\Authentication;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
+use Friendica\Core\Logger;
+use Friendica\Core\Renderer;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\Model\User;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
+use Friendica\Util\Strings;
 use LightOpenID;
 
 require_once 'boot.php';
@@ -31,26 +34,26 @@ class Login extends BaseModule
        {
                $a = self::getApp();
 
-               if (x($_SESSION, 'theme')) {
+               if (!empty($_SESSION['theme'])) {
                        unset($_SESSION['theme']);
                }
 
-               if (x($_SESSION, 'mobile-theme')) {
+               if (!empty($_SESSION['mobile-theme'])) {
                        unset($_SESSION['mobile-theme']);
                }
 
                if (local_user()) {
-                       $a->redirect();
+                       $a->internalRedirect();
                }
 
-               return self::form($_SESSION['return_url'], intval(Config::get('config', 'register_policy')) !== REGISTER_CLOSED);
+               return self::form(defaults($_SESSION, 'return_path', null), intval(Config::get('config', 'register_policy')) !== REGISTER_CLOSED);
        }
 
        public static function post()
        {
-               $return_url = $_SESSION['return_url'];
+               $return_path = $_SESSION['return_path'];
                session_unset();
-               $_SESSION['return_url'] = $return_url;
+               $_SESSION['return_path'] = $return_path;
                
                // OpenId Login
                if (
@@ -65,7 +68,7 @@ class Login extends BaseModule
                        self::openIdAuthentication($openid_url, !empty($_POST['remember']));
                }
 
-               if (x($_POST, 'auth-params') && $_POST['auth-params'] === 'login') {
+               if (!empty($_POST['auth-params']) && $_POST['auth-params'] === 'login') {
                        self::passwordAuthentication(
                                trim($_POST['username']),
                                trim($_POST['password']),
@@ -89,19 +92,18 @@ class Login extends BaseModule
                // if it's an email address or doesn't resolve to a URL, fail.
                if ($noid || strpos($openid_url, '@') || !Network::isUrlValid($openid_url)) {
                        notice(L10n::t('Login failed.') . EOL);
-                       $a->redirect();
+                       $a->internalRedirect();
                        // NOTREACHED
                }
 
                // Otherwise it's probably an openid.
                try {
-                       $a = get_app();
                        $openid = new LightOpenID($a->getHostName());
                        $openid->identity = $openid_url;
                        $_SESSION['openid'] = $openid_url;
                        $_SESSION['remember'] = $remember;
-                       $openid->returnUrl = self::getApp()->getBaseURL(true) . '/openid';
-                       $a->redirect($openid->authUrl());
+                       $openid->returnUrl = $a->getBaseURL(true) . '/openid';
+                       System::externalRedirect($openid->authUrl());
                } catch (Exception $e) {
                        notice(L10n::t('We encountered a problem while logging in with the OpenID you provided. Please check the correct spelling of the ID.') . '<br /><br >' . L10n::t('The error message was:') . ' ' . $e->getMessage());
                }
@@ -147,9 +149,9 @@ class Login extends BaseModule
                                );
                        }
                } catch (Exception $e) {
-                       logger('authenticate: failed login attempt: ' . notags($username) . ' from IP ' . $_SERVER['REMOTE_ADDR']);
+                       Logger::log('authenticate: failed login attempt: ' . Strings::escapeTags($username) . ' from IP ' . $_SERVER['REMOTE_ADDR']);
                        info('Login failed. Please check your credentials.' . EOL);
-                       $a->redirect();
+                       $a->internalRedirect();
                }
 
                if (!$remember) {
@@ -161,14 +163,14 @@ class Login extends BaseModule
                $_SESSION['last_login_date'] = DateTimeFormat::utcNow();
                Authentication::setAuthenticatedSessionForUser($record, true, true);
 
-               if (x($_SESSION, 'return_url')) {
-                       $return_url = $_SESSION['return_url'];
-                       unset($_SESSION['return_url']);
+               if (!empty($_SESSION['return_path'])) {
+                       $return_path = $_SESSION['return_path'];
+                       unset($_SESSION['return_path']);
                } else {
-                       $return_url = '';
+                       $return_path = '';
                }
 
-               $a->redirect($return_url);
+               $a->internalRedirect($return_path);
        }
 
        /**
@@ -196,9 +198,9 @@ class Login extends BaseModule
                                );
                                if (DBA::isResult($user)) {
                                        if ($data->hash != Authentication::getCookieHashForUser($user)) {
-                                               logger("Hash for user " . $data->uid . " doesn't fit.");
+                                               Logger::log("Hash for user " . $data->uid . " doesn't fit.");
                                                Authentication::deleteSession();
-                                               $a->redirect();
+                                               $a->internalRedirect();
                                        }
 
                                        // Renew the cookie
@@ -219,23 +221,23 @@ class Login extends BaseModule
                        }
                }
 
-               if (isset($_SESSION) && x($_SESSION, 'authenticated')) {
-                       if (x($_SESSION, 'visitor_id') && !x($_SESSION, 'uid')) {
+               if (!empty($_SESSION['authenticated'])) {
+                       if (!empty($_SESSION['visitor_id']) && empty($_SESSION['uid'])) {
                                $contact = DBA::selectFirst('contact', [], ['id' => $_SESSION['visitor_id']]);
                                if (DBA::isResult($contact)) {
                                        self::getApp()->contact = $contact;
                                }
                        }
 
-                       if (x($_SESSION, 'uid')) {
+                       if (!empty($_SESSION['uid'])) {
                                // already logged in user returning
                                $check = Config::get('system', 'paranoia');
                                // extra paranoia - if the IP changed, log them out
                                if ($check && ($_SESSION['addr'] != $_SERVER['REMOTE_ADDR'])) {
-                                       logger('Session address changed. Paranoid setting in effect, blocking session. ' .
+                                       Logger::log('Session address changed. Paranoid setting in effect, blocking session. ' .
                                                $_SESSION['addr'] . ' != ' . $_SERVER['REMOTE_ADDR']);
                                        Authentication::deleteSession();
-                                       $a->redirect();
+                                       $a->internalRedirect();
                                }
 
                                $user = DBA::selectFirst('user', [],
@@ -249,7 +251,7 @@ class Login extends BaseModule
                                );
                                if (!DBA::isResult($user)) {
                                        Authentication::deleteSession();
-                                       $a->redirect();
+                                       $a->internalRedirect();
                                }
 
                                // Make sure to refresh the last login time for the user if the user
@@ -270,7 +272,7 @@ class Login extends BaseModule
        /**
         * @brief Wrapper for adding a login box.
         *
-        * @param string $return_url The url relative to the base the user should be sent
+        * @param string $return_path The path relative to the base the user should be sent
         *                                                       back to after login completes
         * @param bool $register If $register == true provide a registration link.
         *                                               This will most always depend on the value of config.register_policy.
@@ -280,7 +282,7 @@ class Login extends BaseModule
         *
         * @hooks 'login_hook' string $o
         */
-       public static function form($return_url = null, $register = false, $hiddens = [])
+       public static function form($return_path = null, $register = false, $hiddens = [])
        {
                $a = self::getApp();
                $o = '';
@@ -294,25 +296,25 @@ class Login extends BaseModule
 
                $noid = Config::get('system', 'no_openid');
 
-               if (is_null($return_url)) {
-                       $return_url = $a->query_string;
+               if (is_null($return_path)) {
+                       $return_path = $a->query_string;
                }
 
                if (local_user()) {
-                       $tpl = get_markup_template('logout.tpl');
+                       $tpl = Renderer::getMarkupTemplate('logout.tpl');
                } else {
-                       $a->page['htmlhead'] .= replace_macros(
-                               get_markup_template('login_head.tpl'),
+                       $a->page['htmlhead'] .= Renderer::replaceMacros(
+                               Renderer::getMarkupTemplate('login_head.tpl'),
                                [
                                        '$baseurl' => $a->getBaseURL(true)
                                ]
                        );
 
-                       $tpl = get_markup_template('login.tpl');
-                       $_SESSION['return_url'] = $return_url;
+                       $tpl = Renderer::getMarkupTemplate('login.tpl');
+                       $_SESSION['return_path'] = $return_path;
                }
 
-               $o .= replace_macros(
+               $o .= Renderer::replaceMacros(
                        $tpl,
                        [
                                '$dest_url'     => self::getApp()->getBaseURL(true) . '/login',