Issue 8860: Activities weren't fetchable all the time

[friendica.git] / src / Module / Objects.php

diff --git a/src/Module/Objects.php b/src/Module/Objects.php
index 2104e8042fd98e3c2cc9f7bc57eb9782a7627826..8080289f15866143a2207209d56d3666df448964 100644 (file)
--- a/src/Module/Objects.php
+++ b/src/Module/Objects.php
@@ -1,51 +1,97 @@
 <?php
 /**
- * @file src/Module/Objects.php
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
  */
+
 namespace Friendica\Module;
 
 use Friendica\BaseModule;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
+use Friendica\DI;
 use Friendica\Model\Item;
+use Friendica\Network\HTTPException;
 use Friendica\Protocol\ActivityPub;
+use Friendica\Util\Network;
 
 /**
  * ActivityPub Objects
  */
 class Objects extends BaseModule
 {
-       public static function rawContent()
+       public static function rawContent(array $parameters = [])
        {
-               $a = self::getApp();
-
-               if (empty($a->argv[1])) {
-                       throw new \Friendica\Network\HTTPException\NotFoundException();
+               if (empty($parameters['guid'])) {
+                       throw new HTTPException\BadRequestException();
                }
 
                if (!ActivityPub::isRequest()) {
-                       $a->internalRedirect(str_replace('objects/', 'display/', $a->query_string));
+                       DI::baseUrl()->redirect(str_replace('objects/', 'display/', DI::args()->getQueryString()));
                }
 
                /// @todo Add Authentication to enable fetching of non public content
                // $requester = HTTPSignature::getSigner('', $_SERVER);
 
-               // At first we try the original post with that guid
-               // @TODO: Replace with parameter from router
-               $item = Item::selectFirst(['id'], ['guid' => $a->argv[1], 'origin' => true, 'private' => false]);
-               if (!DBA::isResult($item)) {
-                       // If no original post could be found, it could possibly be a forum post, there we remove the "origin" field.
-                       // @TODO: Replace with parameter from router
-                       $item = Item::selectFirst(['id', 'author-link'], ['guid' => $a->argv[1], 'private' => false]);
-                       if (!DBA::isResult($item) || !strstr($item['author-link'], System::baseUrl())) {
-                               throw new \Friendica\Network\HTTPException\NotFoundException();
-                       }
+               $item = Item::selectFirst(
+                       ['id', 'origin', 'author-link', 'changed'],
+                       [
+                               'guid' => $parameters['guid'],
+                               'private' => [Item::PUBLIC, Item::UNLISTED]
+                       ],
+                       ['order' => ['origin' => true]]
+               );
+               // Valid items are original post or posted from this node (including in the case of a forum)
+               if (!DBA::isResult($item) || !$item['origin'] && (parse_url($item['author-link'], PHP_URL_HOST) != parse_url(DI::baseUrl()->get(), PHP_URL_HOST))) {
+                       throw new HTTPException\NotFoundException();
                }
 
-               $data = ActivityPub\Transmitter::createObjectFromItemID($item['id']);
+               $etag          = md5($parameters['guid'] . '-' . $item['changed']);
+               $last_modified = $item['changed'];
+               Network::checkEtagModified($etag, $last_modified);
+
+               if (empty($parameters['activity'])) {
+                       $activity = ActivityPub\Transmitter::createActivityFromItem($item['id'], true);
+                       $activity['type'] = $activity['type'] == 'Update' ? 'Create' : $activity['type'];
+
+                       // Only display "Create" activity objects here, no reshares or anything else
+                       if (empty($activity['object']) || ($activity['type'] != 'Create')) {
+                               throw new HTTPException\NotFoundException();
+                       }
+
+                       $data = ['@context' => ActivityPub::CONTEXT];
+                       $data = array_merge($data, $activity['object']);
+               } elseif (in_array($parameters['activity'], ['Create', 'Announce', 'Update', 
+                       'Like', 'Dislike', 'Accept', 'Reject', 'TentativeAccept', 'Follow', 'Add'])) {
+                       $data = ActivityPub\Transmitter::createActivityFromItem($item['id']);
+                       if (empty($data)) {
+                               throw new HTTPException\NotFoundException();
+                       }
+                       if ($parameters['activity'] != 'Create') {
+                               $data['type'] = $parameters['activity'];
+                               $data['id'] = str_replace('/Create', '/' . $parameters['activity'], $data['id']);
+                       }
+               } else {
+                       throw new HTTPException\NotFoundException();
+               }
 
-               header('Content-Type: application/activity+json');
-               echo json_encode($data);
-               exit();
+               // Relaxed CORS header for public items
+               header('Access-Control-Allow-Origin: *');
+               System::jsonExit($data, 'application/activity+json');
        }
 }