Merge pull request #9364 from annando/issue-9363

[friendica.git] / src / Module / Objects.php

diff --git a/src/Module/Objects.php b/src/Module/Objects.php
index 9c57665ffa1cf4fe7493b44ba9e222fcfaf9c596..bb68adeb3bb8cf7b35563e05ca03f840f835fc78 100644 (file)
--- a/src/Module/Objects.php
+++ b/src/Module/Objects.php
@@ -22,10 +22,15 @@
 namespace Friendica\Module;
 
 use Friendica\BaseModule;
+use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\DI;
+use Friendica\Model\Contact;
 use Friendica\Model\Item;
+use Friendica\Network\HTTPException;
 use Friendica\Protocol\ActivityPub;
+use Friendica\Util\HTTPSignature;
+use Friendica\Util\Network;
 
 /**
  * ActivityPub Objects
@@ -34,42 +39,75 @@ class Objects extends BaseModule
 {
        public static function rawContent(array $parameters = [])
        {
-               $a = DI::app();
-
-               if (empty($a->argv[1])) {
-                       throw new \Friendica\Network\HTTPException\NotFoundException();
+               if (empty($parameters['guid'])) {
+                       throw new HTTPException\BadRequestException();
                }
 
                if (!ActivityPub::isRequest()) {
                        DI::baseUrl()->redirect(str_replace('objects/', 'display/', DI::args()->getQueryString()));
                }
 
-               /// @todo Add Authentication to enable fetching of non public content
-               // $requester = HTTPSignature::getSigner('', $_SERVER);
+               $item = Item::selectFirst(['id', 'uid', 'origin', 'author-link', 'changed', 'private', 'psid', 'gravity'],
+                       ['guid' => $parameters['guid']], ['order' => ['origin' => true]]);
 
-               // At first we try the original post with that guid
-               // @TODO: Replace with parameter from router
-               $item = Item::selectFirst(['id'], ['guid' => $a->argv[1], 'origin' => true, 'private' => false]);
                if (!DBA::isResult($item)) {
-                       // If no original post could be found, it could possibly be a forum post, there we remove the "origin" field.
-                       // @TODO: Replace with parameter from router
-                       $item = Item::selectFirst(['id', 'author-link'], ['guid' => $a->argv[1], 'private' => false]);
-                       if (!DBA::isResult($item) || !strstr($item['author-link'], DI::baseUrl()->get())) {
-                               throw new \Friendica\Network\HTTPException\NotFoundException();
+                       throw new HTTPException\NotFoundException();
+               }
+
+               $validated = in_array($item['private'], [Item::PUBLIC, Item::UNLISTED]);
+
+               if (!$validated) {
+                       $requester = HTTPSignature::getSigner('', $_SERVER);
+                       if (!empty($requester) && $item['origin']) {
+                               $requester_id = Contact::getIdForURL($requester, $item['uid']);
+                               if (!empty($requester_id)) {
+                                       $permissionSets = DI::permissionSet()->selectByContactId($requester_id, $item['uid']);
+                                       if (!empty($permissionSets)) {
+                                               $psid = array_merge($permissionSets->column('id'),
+                                                       [DI::permissionSet()->getIdFromACL($item['uid'], '', '', '', '')]);
+                                               $validated = in_array($item['psid'], $psid);
+                                       }
+                               }
                        }
                }
 
-               $activity = ActivityPub\Transmitter::createActivityFromItem($item['id'], true);
-               // Only display "Create" activity objects here, no reshares or anything else
-               if (!is_array($activity['object']) || ($activity['type'] != 'Create')) {
-                       throw new \Friendica\Network\HTTPException\NotFoundException();
+               // Valid items are original post or posted from this node (including in the case of a forum)
+               if (!$validated || !$item['origin'] && (parse_url($item['author-link'], PHP_URL_HOST) != parse_url(DI::baseUrl()->get(), PHP_URL_HOST))) {
+                       throw new HTTPException\NotFoundException();
                }
 
-               $data = ['@context' => ActivityPub::CONTEXT];
-               $data = array_merge($data, $activity['object']);
+               $etag          = md5($parameters['guid'] . '-' . $item['changed']);
+               $last_modified = $item['changed'];
+               Network::checkEtagModified($etag, $last_modified);
+
+               if (empty($parameters['activity']) && ($item['gravity'] != GRAVITY_ACTIVITY)) {
+                       $activity = ActivityPub\Transmitter::createActivityFromItem($item['id'], true);
+                       $activity['type'] = $activity['type'] == 'Update' ? 'Create' : $activity['type'];
+
+                       // Only display "Create" activity objects here, no reshares or anything else
+                       if (empty($activity['object']) || ($activity['type'] != 'Create')) {
+                               throw new HTTPException\NotFoundException();
+                       }
+
+                       $data = ['@context' => ActivityPub::CONTEXT];
+                       $data = array_merge($data, $activity['object']);
+               } elseif (empty($parameters['activity']) || in_array($parameters['activity'],
+                       ['Create', 'Announce', 'Update', 'Like', 'Dislike', 'Accept', 'Reject',
+                       'TentativeAccept', 'Follow', 'Add'])) {
+                       $data = ActivityPub\Transmitter::createActivityFromItem($item['id']);
+                       if (empty($data)) {
+                               throw new HTTPException\NotFoundException();
+                       }
+                       if (!empty($parameters['activity']) && ($parameters['activity'] != 'Create')) {
+                               $data['type'] = $parameters['activity'];
+                               $data['id'] = str_replace('/Create', '/' . $parameters['activity'], $data['id']);
+                       }
+               } else {
+                       throw new HTTPException\NotFoundException();
+               }
 
-               header('Content-Type: application/activity+json');
-               echo json_encode($data);
-               exit();
+               // Relaxed CORS header for public items
+               header('Access-Control-Allow-Origin: *');
+               System::jsonExit($data, 'application/activity+json');
        }
 }