Add suggestions

[friendica.git] / src / Module / Photo.php

diff --git a/src/Module/Photo.php b/src/Module/Photo.php
index e5042fad4e8b1d2b5747c913fe04f4509e9edfb9..9d2d31b45da02b6958f1956ab5714bda454d583d 100644 (file)
--- a/src/Module/Photo.php
+++ b/src/Module/Photo.php
@@ -28,10 +28,17 @@ use Friendica\DI;
 use Friendica\Model\Contact;
 use Friendica\Model\Photo as MPhoto;
 use Friendica\Model\Post;
+use Friendica\Model\Profile;
 use Friendica\Model\Storage\ExternalResource;
+use Friendica\Model\Storage\ReferenceStorageException;
+use Friendica\Model\Storage\StorageException;
+use Friendica\Model\Storage\SystemResource;
+use Friendica\Network\HTTPException\InternalServerErrorException;
+use Friendica\Network\HTTPException\NotFoundException;
 use Friendica\Util\Proxy;
 use Friendica\Object\Image;
 use Friendica\Util\Images;
+use Friendica\Util\Network;
 
 /**
  * Photo Module
@@ -64,6 +71,8 @@ class Photo extends BaseModule
                        exit;
                }
 
+               Profile::addVisitorCookieForHTTPSigner();
+
                $customsize = 0;
                $square_resize = true;
                $photo = false;
@@ -100,10 +109,14 @@ class Photo extends BaseModule
                $cacheable = ($photo["allow_cid"] . $photo["allow_gid"] . $photo["deny_cid"] . $photo["deny_gid"] === "") && (isset($photo["cacheable"]) ? $photo["cacheable"] : true);
 
                $stamp = microtime(true);
+
                $imgdata = MPhoto::getImageDataForPhoto($photo);
+               if (empty($imgdata)) {
+                       throw new NotFoundException();
+               }
 
-               // The mimetype for an external resource can only be known after it had been fetched
-               if ($photo['backend-class'] == ExternalResource::NAME) {
+               // The mimetype for an external or system resource can only be known reliably after it had been fetched
+               if (in_array($photo['backend-class'], [ExternalResource::NAME, SystemResource::NAME])) {
                        $mimetype = Images::getMimeTypeByData($imgdata);
                        if (!empty($mimetype)) {
                                $photo['type'] = $mimetype;
@@ -113,8 +126,14 @@ class Photo extends BaseModule
                $data = microtime(true) - $stamp;
 
                if (empty($imgdata)) {
-                       Logger::warning("Invalid photo with id {$photo["id"]}.");
-                       throw new \Friendica\Network\HTTPException\InternalServerErrorException(DI::l10n()->t('Invalid photo with id %s.', $photo["id"]));
+                       Logger::warning('Invalid photo', ['id' => $photo['id']]);
+                       if (in_array($photo['backend-class'], [ExternalResource::NAME])) {
+                               $reference = json_decode($photo['backend-ref'], true);
+                               $error = DI::l10n()->t('Invalid external resource with url %s.', $reference['url']);
+                       } else {
+                               $error = DI::l10n()->t('Invalid photo with id %s.', $photo['id']);
+                       }
+                       throw new \Friendica\Network\HTTPException\InternalServerErrorException($error);
                }
 
                // if customsize is set and image is not a gif, resize it
@@ -171,7 +190,7 @@ class Photo extends BaseModule
        {
                switch($type) {
                        case "preview":
-                               $media = DBA::selectFirst('post-media', ['preview', 'url', 'type', 'uri-id'], ['id' => $uid]);
+                               $media = DBA::selectFirst('post-media', ['preview', 'url', 'mimetype', 'type', 'uri-id'], ['id' => $uid]);
                                if (empty($media)) {
                                        return false;
                                }
@@ -185,14 +204,29 @@ class Photo extends BaseModule
                                        return false;
                                }
 
-                               return MPhoto::createPhotoForExternalResource($url, (int)local_user());
+                               if (Network::isLocalLink($url) && preg_match('|.*?/photo/(.*[a-fA-F0-9])\-(.*[0-9])\..*[\w]|', $url, $matches)) {
+                                       return MPhoto::getPhoto($matches[1], $matches[2]);
+                               }
+               
+                               return MPhoto::createPhotoForExternalResource($url, (int)local_user(), $media['mimetype']);
                        case "media":
-                               $media = DBA::selectFirst('post-media', ['url', 'uri-id'], ['id' => $uid, 'type' => Post\Media::IMAGE]);
+                               $media = DBA::selectFirst('post-media', ['url', 'mimetype', 'uri-id'], ['id' => $uid, 'type' => Post\Media::IMAGE]);
                                if (empty($media)) {
                                        return false;
                                }
 
-                               return MPhoto::createPhotoForExternalResource($media['url'], (int)local_user());
+                               if (Network::isLocalLink($media['url']) && preg_match('|.*?/photo/(.*[a-fA-F0-9])\-(.*[0-9])\..*[\w]|', $media['url'], $matches)) {
+                                       return MPhoto::getPhoto($matches[1], $matches[2]);
+                               }
+
+                               return MPhoto::createPhotoForExternalResource($media['url'], (int)local_user(), $media['mimetype']);
+                       case "link":
+                               $link = DBA::selectFirst('post-link', ['url', 'mimetype'], ['id' => $uid]);
+                               if (empty($link)) {
+                                       return false;
+                               }
+
+                               return MPhoto::createPhotoForExternalResource($link['url'], (int)local_user(), $link['mimetype']);
                        case "contact":
                                $contact = Contact::getById($uid, ['uid', 'url', 'avatar', 'photo', 'xmpp', 'addr']);
                                if (empty($contact)) {
@@ -201,7 +235,7 @@ class Photo extends BaseModule
                                If (($contact['uid'] != 0) && empty($contact['photo']) && empty($contact['avatar'])) {
                                        $contact = Contact::getByURL($contact['url'], false, ['avatar', 'photo', 'xmpp', 'addr']);
                                }
-                               if (!empty($contact['photo'])) {
+                               if (!empty($contact['photo']) && !empty($contact['avatar'])) {
                                        // Fetch photo directly
                                        $resourceid = MPhoto::ridFromURI($contact['photo']);
                                        if (!empty($resourceid)) {
@@ -210,7 +244,8 @@ class Photo extends BaseModule
                                                        return $photo;
                                                }
                                        }
-                                       $url = $contact['photo'];
+                                       // We continue with the avatar link when the photo link is invalid
+                                       $url = $contact['avatar'];
                                } elseif (!empty($contact['avatar'])) {
                                        $url = $contact['avatar'];
                                } elseif ($customsize <= Proxy::PIXEL_MICRO) {