]> git.mxchange.org Git - friendica.git/blobdiff - src/Module/Search/Index.php
Improve log message language in Module/Search/Index.php
[friendica.git] / src / Module / Search / Index.php
index 4e8a4c63c550b6f3a95420f1b64bb79302c09f14..7f5c7ab87b049098ce8915561a2d26846489c44b 100644 (file)
@@ -1,75 +1,88 @@
 <?php
+/**
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
 
 namespace Friendica\Module\Search;
 
-use Friendica\App\Arguments;
-use Friendica\App\BaseURL;
 use Friendica\Content\Nav;
 use Friendica\Content\Pager;
 use Friendica\Content\Text\HTML;
 use Friendica\Content\Widget;
-use Friendica\Core\Cache;
-use Friendica\Core\Cache\Cache as CacheClass;
-use Friendica\Core\Config;
-use Friendica\Core\L10n;
+use Friendica\Core\Cache\Duration;
 use Friendica\Core\Logger;
 use Friendica\Core\Renderer;
+use Friendica\Core\Search;
 use Friendica\Core\Session;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\Contact;
 use Friendica\Model\Item;
-use Friendica\Model\Term;
-use Friendica\Module\BaseSearchModule;
+use Friendica\Model\ItemContent;
+use Friendica\Model\Tag;
+use Friendica\Module\BaseSearch;
 use Friendica\Network\HTTPException;
 use Friendica\Util\Strings;
 
-class Index extends BaseSearchModule
+class Index extends BaseSearch
 {
        public static function content(array $parameters = [])
        {
                $search = (!empty($_GET['q']) ? Strings::escapeTags(trim(rawurldecode($_GET['q']))) : '');
 
-               if (Config::get('system', 'block_public') && !Session::isAuthenticated()) {
-                       throw new HTTPException\ForbiddenException(L10n::t('Public access denied.'));
+               if (DI::config()->get('system', 'block_public') && !Session::isAuthenticated()) {
+                       throw new HTTPException\ForbiddenException(DI::l10n()->t('Public access denied.'));
                }
 
-               if (Config::get('system', 'local_search') && !Session::isAuthenticated()) {
-                       $e = new HTTPException\ForbiddenException(L10n::t('Only logged in users are permitted to perform a search.'));
-                       $e->httpdesc = L10n::t('Public access denied.');
+               if (DI::config()->get('system', 'local_search') && !Session::isAuthenticated()) {
+                       $e = new HTTPException\ForbiddenException(DI::l10n()->t('Only logged in users are permitted to perform a search.'));
+                       $e->httpdesc = DI::l10n()->t('Public access denied.');
                        throw $e;
                }
 
-               /** @var BaseURL $baseURL */
-               $baseURL = self::getClass(BaseURL::class);
-
-               if (Config::get('system', 'permit_crawling') && !Session::isAuthenticated()) {
+               if (DI::config()->get('system', 'permit_crawling') && !Session::isAuthenticated()) {
                        // Default values:
                        // 10 requests are "free", after the 11th only a call per minute is allowed
 
-                       $free_crawls = intval(Config::get('system', 'free_crawls'));
+                       $free_crawls = intval(DI::config()->get('system', 'free_crawls'));
                        if ($free_crawls == 0)
                                $free_crawls = 10;
 
-                       $crawl_permit_period = intval(Config::get('system', 'crawl_permit_period'));
+                       $crawl_permit_period = intval(DI::config()->get('system', 'crawl_permit_period'));
                        if ($crawl_permit_period == 0)
                                $crawl_permit_period = 10;
 
                        $remote = $_SERVER['REMOTE_ADDR'];
-                       $result = Cache::get('remote_search:' . $remote);
+                       $result = DI::cache()->get('remote_search:' . $remote);
                        if (!is_null($result)) {
                                $resultdata = json_decode($result);
                                if (($resultdata->time > (time() - $crawl_permit_period)) && ($resultdata->accesses > $free_crawls)) {
-                                       throw new HTTPException\TooManyRequestsException(L10n::t('Only one search per minute is permitted for not logged in users.'));
+                                       throw new HTTPException\TooManyRequestsException(DI::l10n()->t('Only one search per minute is permitted for not logged in users.'));
                                }
-                               Cache::set('remote_search:' . $remote, json_encode(['time' => time(), 'accesses' => $resultdata->accesses + 1]), CacheClass::HOUR);
+                               DI::cache()->set('remote_search:' . $remote, json_encode(['time' => time(), 'accesses' => $resultdata->accesses + 1]), Duration::HOUR);
                        } else {
-                               Cache::set('remote_search:' . $remote, json_encode(['time' => time(), 'accesses' => 1]), CacheClass::HOUR);
+                               DI::cache()->set('remote_search:' . $remote, json_encode(['time' => time(), 'accesses' => 1]), Duration::HOUR);
                        }
                }
 
                if (local_user()) {
-                       DI::app()->page['aside'] .= Widget\SavedSearches::getHTML('search?q=' . urlencode($search), $search);
+                       DI::page()['aside'] .= Widget\SavedSearches::getHTML(Search::getSearchPath($search), $search);
                }
 
                Nav::setSelected('search');
@@ -83,7 +96,7 @@ class Index extends BaseSearchModule
                // contruct a wrapper for the search header
                $o = Renderer::replaceMacros(Renderer::getMarkupTemplate('content_wrapper.tpl'), [
                        'name' => 'search-header',
-                       '$title' => L10n::t('Search'),
+                       '$title' => DI::l10n()->t('Search'),
                        '$title_size' => 3,
                        '$content' => HTML::search($search, 'search-box', false)
                ]);
@@ -97,13 +110,13 @@ class Index extends BaseSearchModule
                        $search = substr($search, 1);
                }
 
-               self::tryRedirectToProfile($baseURL, $search);
+               self::tryRedirectToProfile($search);
 
                if (strpos($search, '@') === 0 || strpos($search, '!') === 0) {
                        return self::performContactSearch($search);
                }
 
-               self::tryRedirectToPost($baseURL, $search);
+               self::tryRedirectToPost($search);
 
                if (!empty($_GET['search-option'])) {
                        switch ($_GET['search-option']) {
@@ -119,70 +132,55 @@ class Index extends BaseSearchModule
                        }
                }
 
-               $tag = $tag || Config::get('system', 'only_tag_search');
+               // Don't perform a fulltext or tag search on search results that look like an URL
+               // Tags don't look like an URL and the fulltext search does only work with natural words
+               if (parse_url($search, PHP_URL_SCHEME) && parse_url($search, PHP_URL_HOST)) {
+                       Logger::info('Skipping tag and fulltext search since the search looks like a URL.', ['q' => $search]);
+                       notice(DI::l10n()->t('No results.'));
+                       return $o;
+               }
+
+               $tag = $tag || DI::config()->get('system', 'only_tag_search');
 
                // Here is the way permissions work in the search module...
                // Only public posts can be shown
                // OR your own posts if you are a logged in member
                // No items will be shown if the member has a blocked profile wall.
 
-               /** @var Arguments $args */
-               $args = self::getClass(Arguments::class);
-               $pager = new Pager($args->getQueryString());
+               if (DI::mode()->isMobile()) {
+                       $itemsPerPage = DI::pConfig()->get(local_user(), 'system', 'itemspage_mobile_network',
+                               DI::config()->get('system', 'itemspage_network_mobile'));
+               } else {
+                       $itemsPerPage = DI::pConfig()->get(local_user(), 'system', 'itemspage_network',
+                               DI::config()->get('system', 'itemspage_network'));
+               }
+
+               $pager = new Pager(DI::l10n(), DI::args()->getQueryString(), $itemsPerPage);
 
                if ($tag) {
                        Logger::info('Start tag search.', ['q' => $search]);
-
-                       $condition = [
-                               "(`uid` = 0 OR (`uid` = ? AND NOT `global`))
-                               AND `otype` = ? AND `type` = ? AND `term` = ?",
-                               local_user(), Term::OBJECT_TYPE_POST, Term::HASHTAG, $search
-                       ];
-                       $params = [
-                               'order' => ['received' => true],
-                               'limit' => [$pager->getStart(), $pager->getItemsPerPage()]
-                       ];
-                       $terms = DBA::select('term', ['oid'], $condition, $params);
-
-                       $itemids = [];
-                       while ($term = DBA::fetch($terms)) {
-                               $itemids[] = $term['oid'];
-                       }
-
-                       DBA::close($terms);
-
-                       if (!empty($itemids)) {
-                               $params = ['order' => ['id' => true]];
-                               $items = Item::selectForUser(local_user(), [], ['id' => $itemids], $params);
-                               $r = Item::inArray($items);
-                       } else {
-                               $r = [];
-                       }
+                       $uriids = Tag::getURIIdListByTag($search, local_user(), $pager->getStart(), $pager->getItemsPerPage());
+                       $count = Tag::countByTag($search, local_user());
                } else {
                        Logger::info('Start fulltext search.', ['q' => $search]);
+                       $uriids = ItemContent::getURIIdListBySearch($search, local_user(), $pager->getStart(), $pager->getItemsPerPage());
+                       $count = ItemContent::countBySearch($search, local_user());
+               }
 
-                       $condition = [
-                               "(`uid` = 0 OR (`uid` = ? AND NOT `global`))
-                               AND `body` LIKE CONCAT('%',?,'%')",
-                               local_user(), $search
-                       ];
-                       $params = [
-                               'order' => ['id' => true],
-                               'limit' => [$pager->getStart(), $pager->getItemsPerPage()]
-                       ];
-                       $items = Item::selectForUser(local_user(), [], $condition, $params);
-                       $r = Item::inArray($items);
+               if (!empty($uriids)) {
+                       $params = ['order' => ['id' => true], 'group_by' => ['uri-id']];
+                       $items = Item::inArray(Item::selectForUser(local_user(), [], ['uri-id' => $uriids], $params));
                }
 
-               if (!DBA::isResult($r)) {
-                       info(L10n::t('No results.'));
+               if (empty($items)) {
+                       notice(DI::l10n()->t('No results.'));
                        return $o;
                }
 
                if ($tag) {
-                       $title = L10n::t('Items tagged with: %s', $search);
+                       $title = DI::l10n()->t('Items tagged with: %s', $search);
                } else {
-                       $title = L10n::t('Results for: %s', $search);
+                       $title = DI::l10n()->t('Results for: %s', $search);
                }
 
                $o .= Renderer::replaceMacros(Renderer::getMarkupTemplate('section_title.tpl'), [
@@ -191,9 +189,9 @@ class Index extends BaseSearchModule
 
                Logger::info('Start Conversation.', ['q' => $search]);
 
-               $o .= conversation(DI::app(), $r, $pager, 'search', false, false, 'commented', local_user());
+               $o .= conversation(DI::app(), $items, 'search', false, false, 'commented', local_user());
 
-               $o .= $pager->renderMinimal(count($r));
+               $o .= $pager->renderMinimal($count);
 
                return $o;
        }
@@ -209,12 +207,11 @@ class Index extends BaseSearchModule
         * - user@domain
         * - Any fully-formed URL
         *
-        * @param BaseURL $baseURL
         * @param string  $search
         * @throws HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
-       private static function tryRedirectToProfile(BaseURL $baseURL, string $search)
+       private static function tryRedirectToProfile(string $search)
        {
                $isUrl = !empty(parse_url($search, PHP_URL_SCHEME));
                $isAddr = (bool)preg_match('/^@?([a-z0-9.-_]+@[a-z0-9.-_:]+)$/i', trim($search), $matches);
@@ -237,29 +234,28 @@ class Index extends BaseSearchModule
                } else {
                        // Cheaper local lookup for anonymous users, no probe
                        if ($isAddr) {
-                               $contact = Contact::selectFirst(['id' => 'cid'], ['addr' => $search, 'uid' => 0]);
+                               $contact = Contact::selectFirst(['id'], ['addr' => $search, 'uid' => 0]);
                        } else {
-                               $contact = Contact::getDetailsByURL($search, 0, ['cid' => 0]);
+                               $contact = Contact::getByURL($search, null, ['id']) ?: ['id' => 0];
                        }
 
                        if (DBA::isResult($contact)) {
-                               $contact_id = $contact['cid'];
+                               $contact_id = $contact['id'];
                        }
                }
 
                if (!empty($contact_id)) {
-                       $baseURL->redirect('contact/' . $contact_id);
+                       DI::baseUrl()->redirect('contact/' . $contact_id);
                }
        }
 
        /**
         * Fetch/search a post by URL and redirects to its local representation if it was found.
         *
-        * @param BaseURL $baseURL
         * @param string  $search
         * @throws HTTPException\InternalServerErrorException
         */
-       private static function tryRedirectToPost(BaseURL $baseURL, string $search)
+       private static function tryRedirectToPost(string $search)
        {
                if (parse_url($search, PHP_URL_SCHEME) == '') {
                        return;
@@ -280,7 +276,7 @@ class Index extends BaseSearchModule
                if (!empty($item_id)) {
                        $item = Item::selectFirst(['guid'], ['id' => $item_id]);
                        if (DBA::isResult($item)) {
-                               $baseURL->redirect('display/' . $item['guid']);
+                               DI::baseUrl()->redirect('display/' . $item['guid']);
                        }
                }
        }