]> git.mxchange.org Git - friendica.git/blobdiff - src/Module/Security/Login.php
Allow colon in password
[friendica.git] / src / Module / Security / Login.php
index 431781758bccb52dddde9dc4ffc3da5a4ffc75a5..d1da83b2c9fa76f39e71a814c1d4519d678bff8b 100644 (file)
@@ -1,58 +1,96 @@
 <?php
-
 /**
- * @file src/Module/Login.php
+ * @copyright Copyright (C) 2010-2023, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
  */
 
 namespace Friendica\Module\Security;
 
+use Friendica\App;
 use Friendica\BaseModule;
+use Friendica\Core\Config\Capability\IManageConfigValues;
 use Friendica\Core\Hook;
+use Friendica\Core\L10n;
 use Friendica\Core\Renderer;
-use Friendica\Core\Session;
+use Friendica\Core\Session\Capability\IHandleUserSessions;
 use Friendica\DI;
 use Friendica\Module\Register;
-use Friendica\Util\Strings;
+use Friendica\Module\Response;
+use Friendica\Security\Authentication;
+use Friendica\Util\Profiler;
+use Psr\Log\LoggerInterface;
 
 /**
  * Login module
- *
- * @author Hypolite Petovan <hypolite@mrpetovan.com>
  */
 class Login extends BaseModule
 {
-       public static function content(array $parameters = [])
+       /** @var Authentication */
+       private $auth;
+
+       /** @var IManageConfigValues */
+       private $config;
+
+       /** @var IHandleUserSessions */
+       private $session;
+
+       public function __construct(Authentication $auth, IManageConfigValues $config, IHandleUserSessions $session, L10n $l10n, App\BaseURL $baseUrl, App\Arguments $args, LoggerInterface $logger, Profiler $profiler, Response $response, array $server, array $parameters = [])
+       {
+               parent::__construct($l10n, $baseUrl, $args, $logger, $profiler, $response, $server, $parameters);
+
+               $this->auth    = $auth;
+               $this->config  = $config;
+               $this->session = $session;
+       }
+
+       protected function content(array $request = []): string
        {
-               if (local_user()) {
-                       DI::baseUrl()->redirect();
+               $return_path = $request['return_path'] ?? $this->session->pop('return_path', '') ;
+
+               if ($this->session->getLocalUserId()) {
+                       $this->baseUrl->redirect($return_path);
                }
 
-               return self::form(Session::get('return_path'), intval(DI::config()->get('config', 'register_policy')) !== \Friendica\Module\Register::CLOSED);
+               return self::form($return_path, intval($this->config->get('config', 'register_policy')) !== \Friendica\Module\Register::CLOSED);
        }
 
-       public static function post(array $parameters = [])
+       protected function post(array $request = [])
        {
-               $return_path = Session::get('return_path');
-               Session::clear();
-               Session::set('return_path', $return_path);
+               $this->session->clear();
 
                // OpenId Login
                if (
-                       empty($_POST['password'])
-                       && (!empty($_POST['openid_url'])
-                               || !empty($_POST['username']))
+                       empty($request['password'])
+                       && (!empty($request['openid_url'])
+                               || !empty($request['username']))
                ) {
-                       $openid_url = trim(($_POST['openid_url'] ?? '') ?: $_POST['username']);
+                       $openid_url = trim(($request['openid_url'] ?? '') ?: $request['username']);
 
-                       DI::auth()->withOpenId($openid_url, !empty($_POST['remember']));
+                       $this->auth->withOpenId($openid_url, !empty($request['remember']));
                }
 
-               if (!empty($_POST['auth-params']) && $_POST['auth-params'] === 'login') {
-                       DI::auth()->withPassword(
+               if (!empty($request['auth-params']) && $request['auth-params'] === 'login') {
+                       $this->auth->withPassword(
                                DI::app(),
-                               trim($_POST['username']),
-                               trim($_POST['password']),
-                               !empty($_POST['remember'])
+                               trim($request['username']),
+                               trim($request['password']),
+                               !empty($request['remember']),
+                               $request['return_path'] ?? ''
                        );
                }
        }
@@ -60,26 +98,23 @@ class Login extends BaseModule
        /**
         * Wrapper for adding a login box.
         *
-        * @param string $return_path  The path relative to the base the user should be sent
-        *                             back to after login completes
-        * @param bool   $register     If $register == true provide a registration link.
-        *                             This will most always depend on the value of config.register_policy.
-        * @param array  $hiddens      optional
+        * @param string|null $return_path The path relative to the base the user should be sent back to after login completes.
+        * @param bool        $register    If $register == true provide a registration link.
+        *                                 This will almost always depend on the value of config.register_policy.
         *
         * @return string Returns the complete html for inserting into the page
         *
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \Friendica\Network\HTTPException\ServiceUnavailableException
         * @hooks 'login_hook' string $o
         */
-       public static function form($return_path = null, $register = false, $hiddens = [])
+       public static function form(string $return_path = null, bool $register = false): string
        {
-               $o = '';
-
                $noid = DI::config()->get('system', 'no_openid');
 
                if ($noid) {
-                       Session::remove('openid_identity');
-                       Session::remove('openid_attributes');
+                       DI::session()->remove('openid_identity');
+                       DI::session()->remove('openid_attributes');
                }
 
                $reg = false;
@@ -91,11 +126,7 @@ class Login extends BaseModule
                        ];
                }
 
-               if (is_null($return_path)) {
-                       $return_path = DI::args()->getQueryString();
-               }
-
-               if (local_user()) {
+               if (DI::userSession()->getLocalUserId()) {
                        $tpl = Renderer::getMarkupTemplate('logout.tpl');
                } else {
                        DI::page()['htmlhead'] .= Renderer::replaceMacros(
@@ -106,13 +137,12 @@ class Login extends BaseModule
                        );
 
                        $tpl = Renderer::getMarkupTemplate('login.tpl');
-                       $_SESSION['return_path'] = $return_path;
                }
 
-               if (!empty(Session::get('openid_identity'))) {
+               if (!empty(DI::session()->get('openid_identity'))) {
                        $openid_title = DI::l10n()->t('Your OpenID: ');
                        $openid_readonly = true;
-                       $identity = Session::get('openid_identity');
+                       $identity = DI::session()->get('openid_identity');
                        $username_desc = DI::l10n()->t('Please enter your username and password to add the OpenID to your existing account.');
                } else {
                        $openid_title = DI::l10n()->t('Or login using OpenID: ');
@@ -121,7 +151,7 @@ class Login extends BaseModule
                        $username_desc = '';
                }
 
-               $o .= Renderer::replaceMacros(
+               $o = Renderer::replaceMacros(
                        $tpl,
                        [
                                '$dest_url'     => DI::baseUrl()->get(true) . '/login',
@@ -135,7 +165,7 @@ class Login extends BaseModule
                                '$openid'       => !$noid,
                                '$lopenid'      => ['openid_url', $openid_title, $identity, '', $openid_readonly],
 
-                               '$hiddens'      => $hiddens,
+                               '$hiddens'      => ['return_path' => $return_path ?? DI::args()->getQueryString()],
 
                                '$register'     => $reg,
 
@@ -158,28 +188,28 @@ class Login extends BaseModule
        /**
         * Get the URL to the register page and add OpenID parameters to it
         */
-       private static function getRegisterURL()
+       private static function getRegisterURL(): string
        {
-               if (empty(Session::get('openid_identity'))) {
+               if (empty(DI::session()->get('openid_identity'))) {
                        return 'register';
                }
 
                $args = [];
-               $attr = Session::get('openid_attributes', []);
+               $attr = DI::session()->get('openid_attributes', []);
 
                if (is_array($attr) && count($attr)) {
                        foreach ($attr as $k => $v) {
                                if ($k === 'namePerson/friendly') {
-                                       $nick = Strings::escapeTags(trim($v));
+                                       $nick = trim($v);
                                }
                                if ($k === 'namePerson/first') {
-                                       $first = Strings::escapeTags(trim($v));
+                                       $first = trim($v);
                                }
                                if ($k === 'namePerson') {
-                                       $args['username'] = Strings::escapeTags(trim($v));
+                                       $args['username'] = trim($v);
                                }
                                if ($k === 'contact/email') {
-                                       $args['email'] = Strings::escapeTags(trim($v));
+                                       $args['email'] = trim($v);
                                }
                                if ($k === 'media/image/aspect11') {
                                        $photosq = bin2hex(trim($v));
@@ -202,7 +232,7 @@ class Login extends BaseModule
                        $args['photo'] = $photo;
                }
 
-               $args['openid_url'] = Strings::escapeTags(trim(Session::get('openid_identity')));
+               $args['openid_url'] = trim(DI::session()->get('openid_identity'));
 
                return 'register?' . http_build_query($args);
        }