Merge pull request #10575 from MrPetovan/bug/10019-peertube-embed

[friendica.git] / src / Network / Probe.php

diff --git a/src/Network/Probe.php b/src/Network/Probe.php
index 23eaf299ca47e266de2bc85ddb6cdeedc1316dc1..c07cc7e605c38dd64b8b28e9a795667ce16517e9 100644 (file)
--- a/src/Network/Probe.php
+++ b/src/Network/Probe.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2021, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -23,6 +23,7 @@ namespace Friendica\Network;
 
 use DOMDocument;
 use DomXPath;
+use Exception;
 use Friendica\Core\Hook;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
@@ -87,8 +88,8 @@ class Probe
         */
        private static function rearrangeData($data)
        {
-               $fields = ["name", "nick", "guid", "url", "addr", "alias", "photo", "account-type",
-                               "community", "keywords", "location", "about", "hide",
+               $fields = ["name", "nick", "guid", "url", "addr", "alias", "photo", "header",
+                               "account-type", "community", "keywords", "location", "about", "hide",
                                "batch", "notify", "poll", "request", "confirm", "subscribe", "poco",
                                "following", "followers", "inbox", "outbox", "sharedinbox",
                                "priority", "network", "pubkey", "manually-approve", "baseurl", "gsid"];
@@ -333,7 +334,7 @@ class Probe
        public static function uri($uri, $network = '', $uid = -1)
        {
                // Local profiles aren't probed via network
-               if (empty($network) && strpos($uri, DI::baseUrl()->getHostname())) {
+               if (empty($network) && Contact::isLocal($uri)) {
                        $data = self::localProbe($uri);
                        if (!empty($data)) {
                                return $data;
@@ -439,6 +440,9 @@ class Probe
                }
 
                $body = $curlResult->getBody();
+               if (empty($body)) {
+                       return false;
+               }
 
                $doc = new DOMDocument();
                @$doc->loadHTML($body);
@@ -1013,18 +1017,18 @@ class Probe
                $curlResult = DI::httpRequest()->get($noscrape_url);
                if ($curlResult->isTimeout()) {
                        self::$istimeout = true;
-                       return [];
+                       return $data;
                }
                $content = $curlResult->getBody();
                if (!$content) {
                        Logger::info('Empty body', ['url' => $noscrape_url]);
-                       return [];
+                       return $data;
                }
 
                $json = json_decode($content, true);
                if (!is_array($json)) {
                        Logger::info('No json data', ['url' => $noscrape_url]);
-                       return [];
+                       return $data;
                }
 
                if (!empty($json["fn"])) {
@@ -1274,7 +1278,7 @@ class Probe
                        return [];
                }
                $content = $curlResult->getBody();
-               if (!$content) {
+               if (empty($content)) {
                        return [];
                }
 
@@ -1408,6 +1412,8 @@ class Probe
                                $data["guid"] = $link["href"];
                        } elseif (($link["rel"] == "http://webfinger.net/rel/profile-page") && (($link["type"] ?? "") == "text/html") && !empty($link["href"])) {
                                $data["url"] = $link["href"];
+                       } elseif (($link["rel"] == "http://webfinger.net/rel/profile-page") && empty($link["type"]) && !empty($link["href"])) {
+                               $profile_url = $link["href"];
                        } elseif (($link["rel"] == ActivityNamespace::FEED) && !empty($link["href"])) {
                                $data["poll"] = $link["href"];
                        } elseif (($link["rel"] == ActivityNamespace::POCO) && !empty($link["href"])) {
@@ -1424,6 +1430,10 @@ class Probe
                        }
                }
 
+               if (empty($data["url"]) && !empty($profile_url)) {
+                       $data["url"] = $profile_url;
+               }
+
                if (empty($data["url"]) || empty($hcard_url)) {
                        return [];
                }
@@ -1610,7 +1620,7 @@ class Probe
        private static function pumpioProfileData($profile_link)
        {
                $curlResult = DI::httpRequest()->get($profile_link);
-               if (!$curlResult->isSuccess()) {
+               if (!$curlResult->isSuccess() || empty($curlResult->getBody())) {
                        return [];
                }
 
@@ -2195,41 +2205,48 @@ class Probe
         *
         * @param string $url
         * @return array probed data
+        * @throws HTTPException\InternalServerErrorException
+        * @throws HTTPException\NotFoundException
         */
-       private static function localProbe(string $url)
+       private static function localProbe(string $url): array
        {
-               $uid = User::getIdForURL($url);
-               if (empty($uid)) {
-                       return [];
+               try {
+                       $uid = User::getIdForURL($url);
+                       if (!$uid) {
+                               throw new HTTPException\NotFoundException('User not found.');
+                       }
+
+                       $profile   = User::getOwnerDataById($uid);
+                       $approfile = ActivityPub\Transmitter::getProfile($uid);
+
+                       if (empty($profile['gsid'])) {
+                               $profile['gsid'] = GServer::getID($approfile['generator']['url']);
+                       }
+
+                       $data = [
+                               'name' => $profile['name'], 'nick' => $profile['nick'], 'guid' => $approfile['diaspora:guid'] ?? '',
+                               'url' => $profile['url'], 'addr' => $profile['addr'], 'alias' => $profile['alias'],
+                               'photo' => Contact::getAvatarUrlForId($profile['id'], '', $profile['updated']),
+                               'header' => $profile['header'] ? Contact::getHeaderUrlForId($profile['id'], $profile['updated']) : '',
+                               'account-type' => $profile['contact-type'], 'community' => ($profile['contact-type'] == User::ACCOUNT_TYPE_COMMUNITY),
+                               'keywords' => $profile['keywords'], 'location' => $profile['location'], 'about' => $profile['about'],
+                               'hide' => !$profile['net-publish'], 'batch' => '', 'notify' => $profile['notify'],
+                               'poll' => $profile['poll'], 'request' => $profile['request'], 'confirm' => $profile['confirm'],
+                               'subscribe' => $approfile['generator']['url'] . '/follow?url={uri}', 'poco' => $profile['poco'],
+                               'following' => $approfile['following'], 'followers' => $approfile['followers'],
+                               'inbox' => $approfile['inbox'], 'outbox' => $approfile['outbox'],
+                               'sharedinbox' => $approfile['endpoints']['sharedInbox'], 'network' => Protocol::DFRN,
+                               'pubkey' => $profile['upubkey'], 'baseurl' => $approfile['generator']['url'], 'gsid' => $profile['gsid'],
+                               'manually-approve' => in_array($profile['page-flags'], [User::PAGE_FLAGS_NORMAL, User::PAGE_FLAGS_PRVGROUP])
+                       ];
+               } catch (Exception $e) {
+                       // Default values for non existing targets
+                       $data = [
+                               'name' => $url, 'nick' => $url, 'url' => $url, 'network' => Protocol::PHANTOM,
+                               'photo' => DI::baseUrl() . Contact::DEFAULT_AVATAR_PHOTO
+                       ];
                }
 
-               $profile = User::getOwnerDataById($uid);
-               if (empty($profile)) {
-                       return [];
-               }
-
-               $approfile = ActivityPub\Transmitter::getProfile($uid);
-               if (empty($approfile)) {
-                       return [];
-               }
-
-               if (empty($profile['gsid'])) {
-                       $profile['gsid'] = GServer::getID($approfile['generator']['url']);
-               }
-
-               $data = ['name' => $profile['name'], 'nick' => $profile['nick'], 'guid' => $approfile['diaspora:guid'] ?? '',
-                       'url' => $profile['url'], 'addr' => $profile['addr'], 'alias' => $profile['alias'],
-                       'photo' => $profile['photo'], 'account-type' => $profile['contact-type'],
-                       'community' => ($profile['contact-type'] == User::ACCOUNT_TYPE_COMMUNITY),
-                       'keywords' => $profile['keywords'], 'location' => $profile['location'], 'about' => $profile['about'], 
-                       'hide' => !$profile['net-publish'], 'batch' => '', 'notify' => $profile['notify'],
-                       'poll' => $profile['poll'], 'request' => $profile['request'], 'confirm' => $profile['confirm'],
-                       'subscribe' => $approfile['generator']['url'] . '/follow?url={uri}', 'poco' => $profile['poco'], 
-                       'following' => $approfile['following'], 'followers' => $approfile['followers'],
-                       'inbox' => $approfile['inbox'], 'outbox' => $approfile['outbox'],
-                       'sharedinbox' => $approfile['endpoints']['sharedInbox'], 'network' => Protocol::DFRN, 
-                       'pubkey' => $profile['upubkey'], 'baseurl' => $approfile['generator']['url'], 'gsid' => $profile['gsid'],
-                       'manually-approve' => in_array($profile['page-flags'], [User::PAGE_FLAGS_NORMAL, User::PAGE_FLAGS_PRVGROUP])];
-               return self::rearrangeData($data);              
+               return self::rearrangeData($data);
        }
 }