Decouple conversation creation from rendering

[friendica.git] / src / Object / Thread.php

diff --git a/src/Object/Thread.php b/src/Object/Thread.php
index 4eda1f8f7eedd2c730b36f26c9613b2d3774c2a6..adc822b6ad456af419fffe6b7a5da09fe26234b7 100644 (file)
--- a/src/Object/Thread.php
+++ b/src/Object/Thread.php
@@ -1,22 +1,40 @@
 <?php
 /**
- * @file src/Object/Thread.php
+ * @copyright Copyright (C) 2010-2023, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
  */
+
 namespace Friendica\Object;
 
-use Friendica\BaseObject;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
+use Friendica\DI;
 use Friendica\Protocol\Activity;
-use Friendica\Util\Security;
+use Friendica\Security\Security;
 
 /**
  * A list of threads
  *
  * We should think about making this a SPL Iterator
  */
-class Thread extends BaseObject
+class Thread
 {
+       /** @var Post[] */
        private $parents = [];
        private $mode = null;
        private $writable = false;
@@ -52,20 +70,20 @@ class Thread extends BaseObject
                        return;
                }
 
-               $a = self::getApp();
+               $a = DI::app();
 
                switch ($mode) {
                        case 'network':
                        case 'notes':
-                               $this->profile_owner = local_user();
+                               $this->profile_owner = DI::userSession()->getLocalUserId();
                                $this->writable = true;
                                break;
                        case 'profile':
-                               $this->profile_owner = $a->profile['profile_uid'];
-                               $this->writable = Security::canWriteToUserWall($this->profile_owner);
+                               $this->profile_owner = $a->getProfileOwner();
+                               $this->writable = Security::canWriteToUserWall($this->profile_owner) || $writable;
                                break;
                        case 'display':
-                               $this->profile_owner = $a->profile['uid'];
+                               $this->profile_owner = $a->getProfileOwner();
                                $this->writable = Security::canWriteToUserWall($this->profile_owner) || $writable;
                                break;
                        case 'community':
@@ -77,7 +95,7 @@ class Thread extends BaseObject
                                $this->writable = $writable;
                                break;
                        default:
-                               Logger::log('[ERROR] Conversation::setMode : Unhandled mode ('. $mode .').', Logger::DEBUG);
+                               Logger::info('[ERROR] Conversation::setMode : Unhandled mode ('. $mode .').');
                                return false;
                                break;
                }
@@ -138,25 +156,25 @@ class Thread extends BaseObject
                $item_id = $item->getId();
 
                if (!$item_id) {
-                       Logger::log('[ERROR] Conversation::addThread : Item has no ID!!', Logger::DEBUG);
+                       Logger::info('[ERROR] Conversation::addThread : Item has no ID!!');
                        return false;
                }
 
                if ($this->getParent($item->getId())) {
-                       Logger::log('[WARN] Conversation::addThread : Thread already exists ('. $item->getId() .').', Logger::DEBUG);
+                       Logger::info('[WARN] Conversation::addThread : Thread already exists ('. $item->getId() .').');
                        return false;
                }
 
                /*
                 * Only add will be displayed
                 */
-               if ($item->getDataValue('network') === Protocol::MAIL && local_user() != $item->getDataValue('uid')) {
-                       Logger::log('[WARN] Conversation::addThread : Thread is a mail ('. $item->getId() .').', Logger::DEBUG);
+               if ($item->getDataValue('network') === Protocol::MAIL && DI::userSession()->getLocalUserId() != $item->getDataValue('uid')) {
+                       Logger::info('[WARN] Conversation::addThread : Thread is a mail ('. $item->getId() .').');
                        return false;
                }
 
                if ($item->getDataValue('verb') === Activity::LIKE || $item->getDataValue('verb') === Activity::DISLIKE) {
-                       Logger::log('[WARN] Conversation::addThread : Thread is a (dis)like ('. $item->getId() .').', Logger::DEBUG);
+                       Logger::info('[WARN] Conversation::addThread : Thread is a (dis)like ('. $item->getId() .').');
                        return false;
                }
 
@@ -172,24 +190,25 @@ class Thread extends BaseObject
         * We should find a way to avoid using those arguments (at least most of them)
         *
         * @param array $conv_responses data
+        * @param string $formSecurityToken A 'contact_action' form security token
         *
         * @return mixed The data requested on success
         *               false on failure
         * @throws \Exception
         */
-       public function getTemplateData($conv_responses)
+       public function getTemplateData(array $conv_responses, string $formSecurityToken)
        {
                $result = [];
 
                foreach ($this->parents as $item) {
-                       if ($item->getDataValue('network') === Protocol::MAIL && local_user() != $item->getDataValue('uid')) {
+                       if ($item->getDataValue('network') === Protocol::MAIL && DI::userSession()->getLocalUserId() != $item->getDataValue('uid')) {
                                continue;
                        }
 
-                       $item_data = $item->getTemplateData($conv_responses);
+                       $item_data = $item->getTemplateData($conv_responses, $formSecurityToken);
 
                        if (!$item_data) {
-                               Logger::log('[ERROR] Conversation::getTemplateData : Failed to get item template data ('. $item->getId() .').', Logger::DEBUG);
+                               Logger::info('[ERROR] Conversation::getTemplateData : Failed to get item template data ('. $item->getId() .').');
                                return false;
                        }
                        $result[] = $item_data;