]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/ActivityPub/Processor.php
Escape url tags before attempting to add missing mention links in Protocol\ActivityPu...
[friendica.git] / src / Protocol / ActivityPub / Processor.php
index 66aedf65b06d39f69a8e2e567026870ff3bc4fc8..47a5300352d03ee73104ad05290d4f134c4035b8 100644 (file)
@@ -21,7 +21,6 @@
 
 namespace Friendica\Protocol\ActivityPub;
 
-use Friendica\Content\PageInfo;
 use Friendica\Content\Text\BBCode;
 use Friendica\Content\Text\HTML;
 use Friendica\Content\Text\Markdown;
@@ -53,18 +52,14 @@ use Friendica\Util\Strings;
 class Processor
 {
        /**
-        * Converts mentions from Pleroma into the Friendica format
+        * Extracts the tag character (#, @, !) from mention links
         *
         * @param string $body
-        *
-        * @return string converted body
+        * @return string
         */
-       private static function convertMentions($body)
+       protected static function normalizeMentionLinks(string $body): string
        {
-               $URLSearchString = "^\[\]";
-               $body = preg_replace("/\[url\=([$URLSearchString]*)\]([#@!])(.*?)\[\/url\]/ism", '$2[url=$1]$3[/url]', $body);
-
-               return $body;
+               return preg_replace('%\[url=([^\[\]]*)]([#@!])(.*?)\[/url]%ism', '$2[url=$1]$3[/url]', $body);
        }
 
        /**
@@ -123,24 +118,11 @@ class Processor
                }
 
                $data = ['uri-id' => $uriid];
-
-               $filetype = strtolower(substr($attachment['mediaType'], 0, strpos($attachment['mediaType'], '/')));
-               if ($filetype == 'image') {
-                       $data['type'] = Post\Media::IMAGE;
-               } elseif ($filetype == 'video') {
-                       $data['type'] = Post\Media::VIDEO;
-               } elseif ($filetype == 'audio') {
-                       $data['type'] = Post\Media::AUDIO;
-               } elseif (in_array($attachment['mediaType'], ['application/x-bittorrent', 'application/x-bittorrent;x-scheme-handler/magnet'])) {
-                       $data['type'] = Post\Media::TORRENT;
-               } else {
-                       Logger::info('Unknown type', ['attachment' => $attachment]);
-                       return;
-               }
-
+               $data['type'] = Post\Media::UNKNOWN;
                $data['url'] = $attachment['url'];
                $data['mimetype'] = $attachment['mediaType'];
                $data['height'] = $attachment['height'] ?? null;
+               $data['width'] = $attachment['width'] ?? null;
                $data['size'] = $attachment['size'] ?? null;
                $data['preview'] = $attachment['image'] ?? null;
                $data['description'] = $attachment['name'] ?? null;
@@ -149,113 +131,20 @@ class Processor
        }
 
        /**
-        * Add attachment data to the item array
+        * Stire attachment data
         *
         * @param array   $activity
         * @param array   $item
-        *
-        * @return array array
         */
-       private static function constructAttachList($activity, $item)
+       private static function storeAttachments($activity, $item)
        {
                if (empty($activity['attachments'])) {
-                       return $item;
+                       return;
                }
 
-               $leading = '';
-               $trailing = '';
-
                foreach ($activity['attachments'] as $attach) {
-                       switch ($attach['type']) {
-                               case 'link':
-                                       $data = [
-                                               'url'      => $attach['url'],
-                                               'type'     => $attach['type'],
-                                               'title'    => $attach['title'] ?? '',
-                                               'text'     => $attach['desc']  ?? '',
-                                               'image'    => $attach['image'] ?? '',
-                                               'images'   => [],
-                                               'keywords' => [],
-                                       ];
-                                       $item['body'] = PageInfo::appendDataToBody($item['body'], $data);
-                                       break;
-                               default:
-                                       self::storeAttachmentAsMedia($item['uri-id'], $attach);
-
-                                       $filetype = strtolower(substr($attach['mediaType'], 0, strpos($attach['mediaType'], '/')));
-                                       if ($filetype == 'image') {
-                                               if (!empty($activity['source'])) {
-                                                       foreach ([0, 1, 2] as $size) {
-                                                               if (preg_match('#/photo/.*-' . $size . '\.#ism', $attach['url']) && 
-                                                                       strpos(preg_replace('#(/photo/.*)-[012]\.#ism', '$1-' . $size . '.', $activity['source']), $attach['url'])) {
-                                                                       continue 3;
-                                                               }
-                                                       }
-                                                       if (strpos($activity['source'], $attach['url'])) {
-                                                               continue 2;
-                                                       }
-                                               }
-
-                                               // image is the preview/thumbnail URL
-                                               if (!empty($attach['image'])) {
-                                                       $media = '[url=' . $attach['url'] . ']';
-                                                       $attach['url'] = $attach['image'];
-                                               } else {
-                                                       $media = '';
-                                               }
-
-                                               if (empty($attach['name'])) {
-                                                       $media .= '[img]' . $attach['url'] . '[/img]';
-                                               } else {
-                                                       $media .= '[img=' . $attach['url'] . ']' . $attach['name'] . '[/img]';
-                                               }
-
-                                               if (!empty($attach['image'])) {
-                                                       $media .= '[/url]';
-                                               }
-
-                                               if ($item['post-type'] == Item::PT_IMAGE) {
-                                                       $leading .= $media;
-                                               } else {
-                                                       $trailing .= $media;
-                                               }               
-                                       } elseif ($filetype == 'audio') {
-                                               if (!empty($activity['source']) && strpos($activity['source'], $attach['url'])) {
-                                                       continue 2;
-                                               }
-
-                                               if ($item['post-type'] == Item::PT_AUDIO) {
-                                                       $leading .= '[audio]' . $attach['url'] . "[/audio]\n";
-                                               } else {
-                                                       $trailing .= '[audio]' . $attach['url'] . "[/audio]\n";
-                                               }
-                                       } elseif ($filetype == 'video') {
-                                               if (!empty($activity['source']) && strpos($activity['source'], $attach['url'])) {
-                                                       continue 2;
-                                               }
-
-                                               if ($item['post-type'] == Item::PT_VIDEO) {
-                                                       $leading .= '[video]' . $attach['url'] . "[/video]\n";
-                                               } else {
-                                                       $trailing .= '[video]' . $attach['url'] . "[/video]\n";
-                                               }
-                                       }
-                       }
-               }
-
-               if (!empty($leading) && !empty(trim($item['body']))) {
-                       $item['body'] = $leading . "[hr]\n" . $item['body'];
-               } elseif (!empty($leading)) {
-                       $item['body'] = $leading;
+                       self::storeAttachmentAsMedia($item['uri-id'], $attach);
                }
-
-               if (!empty($trailing) && !empty(trim($item['body']))) {
-                       $item['body'] = $item['body'] . "\n[hr]" . $trailing;
-               } elseif (!empty($trailing)) {
-                       $item['body'] = $trailing;
-               }
-
-               return $item;
        }
 
        /**
@@ -279,7 +168,7 @@ class Processor
 
                $item = self::processContent($activity, $item);
 
-               $item = self::constructAttachList($activity, $item);
+               self::storeAttachments($activity, $item);
 
                if (empty($item)) {
                        return;
@@ -413,7 +302,7 @@ class Processor
 
                $item['plink'] = $activity['alternate-url'] ?? $item['uri'];
 
-               $item = self::constructAttachList($activity, $item);
+               self::storeAttachments($activity, $item);
 
                // We received the post via AP, so we set the protocol of the server to AP
                $contact = Contact::getById($item['author-id'], ['gsid']);
@@ -503,6 +392,8 @@ class Processor
         *
         * @param array $activity Activity array
         * @param array $item
+        * 
+        * @return int event id
         * @throws \Exception
         */
        public static function createEvent($activity, $item)
@@ -526,14 +417,16 @@ class Processor
                $event['direction'] = $item['direction'];
                $event['source']    = $item['source'];
 
-               $condition = ['uri' => $item['uri'], 'uid' => $item['uid']];
-               $ev = DBA::selectFirst('event', ['id'], $condition);
+               $ev = DBA::selectFirst('event', ['id'], ['uri' => $item['uri'], 'uid' => $item['uid']]);
                if (DBA::isResult($ev)) {
                        $event['id'] = $ev['id'];
                }
 
                $event_id = Event::store($event);
+
                Logger::info('Event was stored', ['id' => $event_id]);
+
+               return $event_id;
        }
 
        /**
@@ -566,11 +459,12 @@ class Processor
                        $content = self::replaceEmojis($content, $activity['emojis']);
                }
 
-               $content = self::convertMentions($content);
+               $content = self::addMentionLinks($content, $activity['tags']);
 
                if (!empty($activity['source'])) {
                        $item['body'] = $activity['source'];
                        $item['raw-body'] = $content;
+                       $item['body'] = Item::improveSharedDataInBody($item);
                } else {
                        if (empty($activity['directmessage']) && ($item['thr-parent'] != $item['uri']) && ($item['gravity'] == GRAVITY_COMMENT)) {
                                $item_private = !in_array(0, $activity['item_receiver']);
@@ -709,6 +603,12 @@ class Processor
                                continue;
                        }
 
+                       if (!($item['isForum'] ?? false) && ($receiver != 0) && ($item['gravity'] == GRAVITY_PARENT) &&
+                               ($item['post-reason'] == Item::PR_BCC) && !Contact::isSharingByURL($activity['author'], $receiver)) {
+                               Logger::info('Top level post via BCC from a non sharer, ignoring', ['uid' => $receiver, 'contact' => $item['contact-id']]);
+                               continue;
+                       }
+
                        if (DI::pConfig()->get($receiver, 'system', 'accept_only_sharer', false) && ($receiver != 0) && ($item['gravity'] == GRAVITY_PARENT)) {
                                $skip = !Contact::isSharingByURL($activity['author'], $receiver);
 
@@ -725,7 +625,9 @@ class Processor
                        }
 
                        if (($item['gravity'] != GRAVITY_ACTIVITY) && ($activity['object_type'] == 'as:Event')) {
-                               self::createEvent($activity, $item);
+                               $event_id = self::createEvent($activity, $item);
+
+                               $item = Event::getItemArrayForImportedId($event_id, $item);
                        }
 
                        $item_id = Item::insert($item);
@@ -844,7 +746,7 @@ class Processor
                                        $title = $matches[3];
                                }
 
-                               $title = trim(HTML::toPlaintext(BBCode::convert($title, false, BBCode::API, true), 0));
+                               $title = trim(BBCode::toPlaintext($title));
 
                                if (strlen($title) > 20) {
                                        $title = substr($title, 0, 20) . '...';
@@ -877,12 +779,12 @@ class Processor
 
                $object = ActivityPub::fetchContent($url, $uid);
                if (empty($object)) {
-                       Logger::log('Activity ' . $url . ' was not fetchable, aborting.');
+                       Logger::notice('Activity was not fetchable, aborting.', ['url' => $url]);
                        return '';
                }
 
                if (empty($object['id'])) {
-                       Logger::log('Activity ' . $url . ' has got not id, aborting. ' . json_encode($object));
+                       Logger::notice('Activity has got not id, aborting. ', ['url' => $url, 'object' => $object]);
                        return '';
                }
 
@@ -1033,7 +935,7 @@ class Processor
                        DBA::update('contact', ['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
                }
 
-               Logger::log('Follow user ' . $uid . ' from contact ' . $cid . ' with id ' . $activity['id']);
+               Logger::notice('Follow user ' . $uid . ' from contact ' . $cid . ' with id ' . $activity['id']);
        }
 
        /**
@@ -1292,4 +1194,38 @@ class Processor
 
                return implode('', $kept_mentions);
        }
+
+       /**
+        * Adds links to string mentions
+        *
+        * @param string $body
+        * @param array  $tags
+        * @return string
+        */
+       protected static function addMentionLinks(string $body, array $tags): string
+       {
+               // This prevents links to be added again to Pleroma-style mention links
+               $body = self::normalizeMentionLinks($body);
+
+               $body = BBCode::performWithEscapedTags($body, ['url'], function ($body) use ($tags) {
+                       foreach ($tags as $tag) {
+                               if (empty($tag['name']) || empty($tag['type']) || empty($tag['href']) || !in_array($tag['type'], ['Mention', 'Hashtag'])) {
+                                       continue;
+                               }
+
+                               $hash = substr($tag['name'], 0, 1);
+                               $name = substr($tag['name'], 1);
+                               if (!in_array($hash, Tag::TAG_CHARACTER)) {
+                                       $hash = '';
+                                       $name = $tag['name'];
+                               }
+
+                               $body = str_replace($tag['name'], $hash . '[url=' . $tag['href'] . ']' . $name . '[/url]', $body);
+                       }
+
+                       return $body;
+               });
+
+               return $body;
+       }
 }