use Friendica\Content\Text\BBCode;
use Friendica\Content\Text\HTML;
use Friendica\Core\Config;
+use Friendica\Core\PConfig;
use Friendica\Core\Logger;
use Friendica\Core\Protocol;
use Friendica\Model\Contact;
$tag_text = '';
foreach ($tags as $tag) {
- if (in_array(defaults($tag, 'type', ''), ['Mention', 'Hashtag'])) {
+ if (in_array($tag['type'] ?? '', ['Mention', 'Hashtag'])) {
if (!empty($tag_text)) {
$tag_text .= ',';
}
continue;
}
- $item['body'] .= "\n[img]" . $attach['url'] . '[/img]';
+ if (empty($attach['name'])) {
+ $item['body'] .= "\n[img]" . $attach['url'] . '[/img]';
+ } else {
+ $item['body'] .= "\n[img=" . $attach['url'] . ']' . $attach['name'] . '[/img]';
+ }
} else {
if (!empty($item["attach"])) {
$item["attach"] .= ',';
if (!isset($attach['length'])) {
$attach['length'] = "0";
}
- $item["attach"] .= '[attach]href="'.$attach['url'].'" length="'.$attach['length'].'" type="'.$attach['mediaType'].'" title="'.defaults($attach, 'name', '').'"[/attach]';
+ $item["attach"] .= '[attach]href="'.$attach['url'].'" length="'.$attach['length'].'" type="'.$attach['mediaType'].'" title="'.($attach['name'] ?? '') .'"[/attach]';
}
}
}
$item['changed'] = DateTimeFormat::utcNow();
- $item['edited'] = $activity['updated'];
+ $item['edited'] = DateTimeFormat::utc($activity['updated']);
$item = self::processContent($activity, $item);
if (empty($item)) {
self::fetchMissingActivity($activity['reply-to-id'], $activity);
}
- $item['diaspora_signed_text'] = defaults($activity, 'diaspora:comment', '');
+ $item['diaspora_signed_text'] = $activity['diaspora:comment'] ?? '';
self::postItem($activity, $item);
}
$item['gravity'] = GRAVITY_ACTIVITY;
$item['object-type'] = ACTIVITY_OBJ_NOTE;
- $item['diaspora_signed_text'] = defaults($activity, 'diaspora:like', '');
+ $item['diaspora_signed_text'] = $activity['diaspora:like'] ?? '';
self::postItem($activity, $item);
}
$item['private'] = !in_array(0, $activity['receiver']);
$item['author-link'] = $activity['author'];
$item['author-id'] = Contact::getIdForURL($activity['author'], 0, true);
+ $item['owner-link'] = $activity['actor'];
+ $item['owner-id'] = Contact::getIdForURL($activity['actor'], 0, true);
- if (empty($activity['thread-completion'])) {
- $item['owner-link'] = $activity['actor'];
- $item['owner-id'] = Contact::getIdForURL($activity['actor'], 0, true);
- } else {
- Logger::info('Ignoring actor because of thread completion.');
+ $isForum = false;
+
+ if (!empty($activity['thread-completion'])) {
+ // Store the original actor in the "causer" fields to enable the check for ignored or blocked contacts
+ $item['causer-link'] = $item['owner-link'];
+ $item['causer-id'] = $item['owner-id'];
+
+ Logger::info('Ignoring actor because of thread completion.', ['actor' => $item['owner-link']]);
$item['owner-link'] = $item['author-link'];
$item['owner-id'] = $item['author-id'];
+ } else {
+ $actor = APContact::getByURL($item['owner-link'], false);
+ $isForum = ($actor['type'] == 'Group');
}
$item['uri'] = $activity['id'];
- $item['created'] = $activity['published'];
- $item['edited'] = $activity['updated'];
+ $item['created'] = DateTimeFormat::utc($activity['published']);
+ $item['edited'] = DateTimeFormat::utc($activity['updated']);
$item['guid'] = $activity['diaspora:guid'];
$item = self::processContent($activity, $item);
return;
}
- $item['plink'] = defaults($activity, 'alternate-url', $item['uri']);
+ $item['plink'] = $activity['alternate-url'] ?? $item['uri'];
$item = self::constructAttachList($activity['attachments'], $item, !empty($activity['source']));
foreach ($activity['receiver'] as $receiver) {
$item['uid'] = $receiver;
- $item['contact-id'] = Contact::getIdForURL($activity['author'], $receiver, true);
+
+ if ($isForum) {
+ $item['contact-id'] = Contact::getIdForURL($activity['actor'], $receiver, true);
+ } else {
+ $item['contact-id'] = Contact::getIdForURL($activity['author'], $receiver, true);
+ }
if (($receiver != 0) && empty($item['contact-id'])) {
$item['contact-id'] = Contact::getIdForURL($activity['author'], 0, true);
continue;
}
+ if (PConfig::get($receiver, 'system', 'accept_only_sharer', false) && ($receiver != 0) && ($item['gravity'] == GRAVITY_PARENT)) {
+ $skip = !Contact::isSharingByURL($activity['author'], $receiver);
+
+ if ($skip && (($activity['type'] == 'as:Announce') || $isForum)) {
+ $skip = !Contact::isSharingByURL($activity['actor'], $receiver);
+ }
+
+ if ($skip) {
+ Logger::info('Skipping post', ['uid' => $receiver, 'url' => $item['uri']]);
+ continue;
+ }
+
+ Logger::info('Accepting post', ['uid' => $receiver, 'url' => $item['uri']]);
+ }
+
if ($activity['object_type'] == 'as:Event') {
self::createEvent($activity, $item);
}
*
* @param array $activity Activity data
* @param array $item item array
+ * @return int|bool New mail table row id or false on error
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
- * @throws \ImagickException
*/
private static function postMail($activity, $item)
{
}
$msg['body'] = $item['body'];
- Mail::insert($msg);
+ return Mail::insert($msg);
}
/**
* Fetches missing posts
*
- * @param $url
- * @param $child
+ * @param string $url message URL
+ * @param array $child activity array with the child of this message
+ * @return boolean success
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- private static function fetchMissingActivity($url, $child)
+ public static function fetchMissingActivity($url, $child = [])
{
- if (Config::get('system', 'ostatus_full_threads')) {
- return;
+ if (!empty($child['receiver'])) {
+ $uid = ActivityPub\Receiver::getFirstUserFromReceivers($child['receiver']);
+ } else {
+ $uid = 0;
}
- $uid = ActivityPub\Receiver::getFirstUserFromReceivers($child['receiver']);
-
$object = ActivityPub::fetchContent($url, $uid);
if (empty($object)) {
Logger::log('Activity ' . $url . ' was not fetchable, aborting.');
- return;
+ return false;
}
if (empty($object['id'])) {
Logger::log('Activity ' . $url . ' has got not id, aborting. ' . json_encode($object));
- return;
+ return false;
+ }
+
+ if (!empty($child['author'])) {
+ $actor = $child['author'];
+ } elseif (!empty($object['actor'])) {
+ $actor = $object['actor'];
+ } elseif (!empty($object['attributedTo'])) {
+ $actor = $object['attributedTo'];
+ } else {
+ // Shouldn't happen
+ $actor = '';
+ }
+
+ if (!empty($object['published'])) {
+ $published = $object['published'];
+ } elseif (!empty($child['published'])) {
+ $published = $child['published'];
+ } else {
+ $published = DateTimeFormat::utcNow();
}
$activity = [];
$activity['@context'] = $object['@context'];
unset($object['@context']);
$activity['id'] = $object['id'];
- $activity['to'] = defaults($object, 'to', []);
- $activity['cc'] = defaults($object, 'cc', []);
- $activity['actor'] = $child['author'];
+ $activity['to'] = $object['to'] ?? [];
+ $activity['cc'] = $object['cc'] ?? [];
+ $activity['actor'] = $actor;
$activity['object'] = $object;
- $activity['published'] = defaults($object, 'published', $child['published']);
+ $activity['published'] = $published;
$activity['type'] = 'Create';
$ldactivity = JsonLD::compact($activity);
ActivityPub\Receiver::processActivity($ldactivity);
Logger::log('Activity ' . $url . ' had been fetched and processed.');
+
+ return true;
}
/**
DBA::update('contact', ['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
$contact = DBA::selectFirst('contact', [], ['id' => $cid, 'network' => Protocol::NATIVE_SUPPORT]);
} else {
- $contact = false;
+ $contact = [];
}
$item = ['author-id' => Contact::getIdForURL($activity['actor']),
'author-link' => $activity['actor']];
- $note = Strings::escapeTags(trim(defaults($activity, 'content', '')));
+ $note = Strings::escapeTags(trim($activity['content'] ?? ''));
// Ensure that the contact has got the right network type
self::switchContact($item['author-id']);
- Contact::addRelationship($owner, $contact, $item, '', false, $note);
+ $result = Contact::addRelationship($owner, $contact, $item, false, $note);
+ if ($result === true) {
+ ActivityPub\Transmitter::sendContactAccept($item['author-link'], $item['author-id'], $owner['uid']);
+ }
+
$cid = Contact::getIdForURL($activity['actor'], $uid);
if (empty($cid)) {
return;
}
Logger::log('Updating profile for ' . $activity['object_id'], Logger::DEBUG);
- APContact::getByURL($activity['object_id'], true);
+ Contact::updateFromProbeByURL($activity['object_id'], true);
}
/**
// Extract one prepended mention at a time from the body
while(preg_match('#^(@\[url=([^\]]+)].*?\[\/url]\s)(.*)#is', $body, $matches)) {
- if (!in_array($matches[2], $potential_mentions) ) {
+ if (!in_array($matches[2], $potential_mentions)) {
$kept_mentions[] = $matches[1];
}