]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/ActivityPub/Processor.php
Rename system.disable_mentions_removal config key to system.disable_implicit_mentions
[friendica.git] / src / Protocol / ActivityPub / Processor.php
index d2f5b3b2d5bc44b2cd08c29eb3232158caabf16f..68697381b2e8699a18789a7fa70bda04d677e75d 100644 (file)
@@ -9,11 +9,11 @@ use Friendica\Content\Text\HTML;
 use Friendica\Core\Config;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
-use Friendica\Model\Conversation;
 use Friendica\Model\Contact;
 use Friendica\Model\APContact;
 use Friendica\Model\Item;
 use Friendica\Model\Event;
+use Friendica\Model\Term;
 use Friendica\Model\User;
 use Friendica\Protocol\ActivityPub;
 use Friendica\Util\DateTimeFormat;
@@ -30,7 +30,7 @@ class Processor
         *
         * @param string $body
         *
-        * @return converted body
+        * @return string converted body
         */
        private static function convertMentions($body)
        {
@@ -48,7 +48,7 @@ class Processor
         *
         * @return string with replaced emojis
         */
-       public static function replaceEmojis($emojis, $body)
+       public static function replaceEmojis($body, array $emojis)
        {
                foreach ($emojis as $emoji) {
                        $replace = '[class=emoji mastodon][img=' . $emoji['href'] . ']' . $emoji['name'] . '[/img][/class]';
@@ -60,12 +60,12 @@ class Processor
        /**
         * Constructs a string with tags for a given tag array
         *
-        * @param array $tags
+        * @param array   $tags
         * @param boolean $sensitive
-        *
+        * @param array   $implicit_mentions List of profile URLs to skip
         * @return string with tags
         */
-       private static function constructTagList($tags, $sensitive)
+       private static function constructTagString($tags, $sensitive, array $implicit_mentions)
        {
                if (empty($tags)) {
                        return '';
@@ -73,7 +73,7 @@ class Processor
 
                $tag_text = '';
                foreach ($tags as $tag) {
-                       if (in_array(defaults($tag, 'type', ''), ['Mention', 'Hashtag'])) {
+                       if (in_array(defaults($tag, 'type', ''), ['Mention', 'Hashtag']) && !in_array($tag['href'], $implicit_mentions)) {
                                if (!empty($tag_text)) {
                                        $tag_text .= ',';
                                }
@@ -93,7 +93,7 @@ class Processor
         * @param array $attachments
         * @param array $item
         *
-        * @return item array
+        * @return array array
         */
        private static function constructAttachList($attachments, $item)
        {
@@ -124,18 +124,40 @@ class Processor
        /**
         * Updates a message
         *
-        * @param array  $activity Activity array
+        * @param array $activity Activity array
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        public static function updateItem($activity)
        {
-               $item = [];
+               $item = Item::selectFirst(['uri', 'parent-uri', 'gravity'], ['uri' => $activity['id']]);
+               if (!DBA::isResult($item)) {
+                       Logger::warning('Unknown item', ['uri' => $activity['id']]);
+                       return;
+               }
+
                $item['changed'] = DateTimeFormat::utcNow();
                $item['edited'] = $activity['updated'];
                $item['title'] = HTML::toBBCode($activity['name']);
                $item['content-warning'] = HTML::toBBCode($activity['summary']);
-               $content = self::replaceEmojis($activity['emojis'], HTML::toBBCode($activity['content']));
-               $item['body'] = self::convertMentions($content);
-               $item['tag'] = self::constructTagList($activity['tags'], $activity['sensitive']);
+
+               $content = HTML::toBBCode($activity['content']);
+               $content = self::replaceEmojis($content, $activity['emojis']);
+               $content = self::convertMentions($content);
+
+               $implicit_mentions = [];
+               if (($item['parent-uri'] != $item['uri']) && ($item['gravity'] == GRAVITY_COMMENT)) {
+                       $parent = Item::selectFirst(['id', 'author-link', 'alias'], ['uri' => $item['parent-uri']]);
+                       if (!DBA::isResult($parent)) {
+                               Logger::warning('Unknown parent item.', ['uri' => $item['parent-uri']]);
+                               return;
+                       }
+
+                       $implicit_mentions = self::getImplicitMentionList($parent);
+                       $content = self::removeImplicitMentionsFromBody($content, $implicit_mentions);
+               }
+
+               $item['body'] = $content;
+               $item['tag'] = self::constructTagString($activity['tags'], $activity['sensitive'], $implicit_mentions);
 
                Item::update($item, ['uri' => $activity['id']]);
        }
@@ -143,7 +165,9 @@ class Processor
        /**
         * Prepares data for a message
         *
-        * @param array  $activity Activity array
+        * @param array $activity Activity array
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function createItem($activity)
        {
@@ -173,6 +197,8 @@ class Processor
         * Delete items
         *
         * @param array $activity
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function deleteItem($activity)
        {
@@ -187,6 +213,8 @@ class Processor
         *
         * @param array  $activity Activity array
         * @param string $verb     Activity verb
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function createActivity($activity, $verb)
        {
@@ -206,6 +234,7 @@ class Processor
         *
         * @param array $activity Activity array
         * @param array $item
+        * @throws \Exception
         */
        public static function createEvent($activity, $item)
        {
@@ -237,8 +266,10 @@ class Processor
        /**
         * Creates an item post
         *
-        * @param array  $activity Activity data
-        * @param array  $item     item array
+        * @param array $activity Activity data
+        * @param array $item     item array
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        private static function postItem($activity, $item)
        {
@@ -258,19 +289,39 @@ class Processor
                        $item['owner-link'] = $activity['actor'];
                        $item['owner-id'] = Contact::getIdForURL($activity['actor'], 0, true);
                } else {
-                       Logger::log('Ignoring actor because of thread completion.', Logger::DEBUG);
+                       Logger::info('Ignoring actor because of thread completion.');
                        $item['owner-link'] = $item['author-link'];
                        $item['owner-id'] = $item['author-id'];
                }
 
                $item['uri'] = $activity['id'];
+               $content = HTML::toBBCode($activity['content']);
+               $content = self::replaceEmojis($content, $activity['emojis']);
+               $content = self::convertMentions($content);
+
+               $implicit_mentions = [];
+
+               if (($item['parent-uri'] != $item['uri']) && ($item['gravity'] == GRAVITY_COMMENT)) {
+                       $item_private = !in_array(0, $activity['item_receiver']);
+                       $parent = Item::selectFirst(['id', 'private', 'author-link', 'alias'], ['uri' => $item['parent-uri']]);
+                       if (!DBA::isResult($parent)) {
+                               return;
+                       }
+                       if ($item_private && !$parent['private']) {
+                               Logger::log('Item ' . $item['uri'] . ' is private but the parent ' . $item['parent-uri'] . ' is not. So we drop it.');
+                               return;
+                       }
+
+                       $implicit_mentions = self::getImplicitMentionList($parent);
+                       $content = self::removeImplicitMentionsFromBody($content, $implicit_mentions);
+               }
+
                $item['created'] = $activity['published'];
                $item['edited'] = $activity['updated'];
                $item['guid'] = $activity['diaspora:guid'];
                $item['title'] = HTML::toBBCode($activity['name']);
                $item['content-warning'] = HTML::toBBCode($activity['summary']);
-               $content = self::replaceEmojis($activity['emojis'], HTML::toBBCode($activity['content']));
-               $item['body'] = self::convertMentions($content);
+               $item['body'] = $content;
 
                if (($activity['object_type'] == 'as:Video') && !empty($activity['alternate-url'])) {
                        $item['body'] .= "\n[video]" . $activity['alternate-url'] . '[/video]';
@@ -282,7 +333,7 @@ class Processor
                        $item['coord'] = $item['latitude'] . ' ' . $item['longitude'];
                }
 
-               $item['tag'] = self::constructTagList($activity['tags'], $activity['sensitive']);
+               $item['tag'] = self::constructTagString($activity['tags'], $activity['sensitive'], $implicit_mentions);
                $item['app'] = $activity['generator'];
                $item['plink'] = defaults($activity, 'alternate-url', $item['uri']);
 
@@ -292,6 +343,8 @@ class Processor
                        $item['body'] = $activity['source'];
                }
 
+               $stored = false;
+
                foreach ($activity['receiver'] as $receiver) {
                        $item['uid'] = $receiver;
                        $item['contact-id'] = Contact::getIdForURL($activity['author'], $receiver, true);
@@ -305,7 +358,25 @@ class Processor
                        }
 
                        $item_id = Item::insert($item);
-                       Logger::log('Storing for user ' . $item['uid'] . ': ' . $item_id);
+                       if ($item_id) {
+                               Logger::info('Item insertion successful', ['user' => $item['uid'], 'item_id' => $item_id]);
+                       } else {
+                               Logger::notice('Item insertion aborted', ['user' => $item['uid']]);
+                       }
+
+                       if ($item['uid'] == 0) {
+                               $stored = $item_id;
+                       }
+               }
+
+               // Store send a follow request for every reshare - but only when the item had been stored
+               if ($stored && !$item['private'] && ($item['gravity'] == GRAVITY_PARENT) && ($item['author-link'] != $item['owner-link'])) {
+                       $author = APContact::getByURL($item['owner-link'], false);
+                       // We send automatic follow requests for reshared messages. (We don't need though for forum posts)
+                       if ($author['type'] != 'Group') {
+                               Logger::log('Send follow request for ' . $item['uri'] . ' (' . $stored . ') to ' . $item['author-link'], Logger::DEBUG);
+                               ActivityPub\Transmitter::sendFollowObject($item['uri'], $item['author-link']);
+                       }
                }
        }
 
@@ -314,6 +385,7 @@ class Processor
         *
         * @param $url
         * @param $child
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        private static function fetchMissingActivity($url, $child)
        {
@@ -329,6 +401,11 @@ class Processor
                        return;
                }
 
+               if (empty($object['id'])) {
+                       Logger::log('Activity ' . $url . ' has got not id, aborting. ' . json_encode($object));
+                       return;
+               }
+
                $activity = [];
                $activity['@context'] = $object['@context'];
                unset($object['@context']);
@@ -352,6 +429,8 @@ class Processor
         * perform a "follow" request
         *
         * @param array $activity
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function followUser($activity)
        {
@@ -365,6 +444,7 @@ class Processor
                $cid = Contact::getIdForURL($activity['actor'], $uid);
                if (!empty($cid)) {
                        self::switchContact($cid);
+                       DBA::update('contact', ['hub-verify' => $activity['id']], ['id' => $cid]);
                        $contact = DBA::selectFirst('contact', [], ['id' => $cid, 'network' => Protocol::NATIVE_SUPPORT]);
                } else {
                        $contact = false;
@@ -382,7 +462,10 @@ class Processor
                        return;
                }
 
-               DBA::update('contact', ['hub-verify' => $activity['id']], ['id' => $cid]);
+               if (empty($contact)) {
+                       DBA::update('contact', ['hub-verify' => $activity['id']], ['id' => $cid]);
+               }
+
                Logger::log('Follow user ' . $uid . ' from contact ' . $cid . ' with id ' . $activity['id']);
        }
 
@@ -390,6 +473,7 @@ class Processor
         * Update the given profile
         *
         * @param array $activity
+        * @throws \Exception
         */
        public static function updatePerson($activity)
        {
@@ -405,6 +489,7 @@ class Processor
         * Delete the given profile
         *
         * @param array $activity
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        public static function deletePerson($activity)
        {
@@ -431,6 +516,8 @@ class Processor
         * Accept a follow request
         *
         * @param array $activity
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function acceptFollowUser($activity)
        {
@@ -439,8 +526,6 @@ class Processor
                        return;
                }
 
-               $owner = User::getOwnerDataById($uid);
-
                $cid = Contact::getIdForURL($activity['actor'], $uid);
                if (empty($cid)) {
                        Logger::log('No contact found for ' . $activity['actor'], Logger::DEBUG);
@@ -465,6 +550,8 @@ class Processor
         * Reject a follow request
         *
         * @param array $activity
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function rejectFollowUser($activity)
        {
@@ -473,8 +560,6 @@ class Processor
                        return;
                }
 
-               $owner = User::getOwnerDataById($uid);
-
                $cid = Contact::getIdForURL($activity['actor'], $uid);
                if (empty($cid)) {
                        Logger::log('No contact found for ' . $activity['actor'], Logger::DEBUG);
@@ -495,6 +580,8 @@ class Processor
         * Undo activity like "like" or "dislike"
         *
         * @param array $activity
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function undoActivity($activity)
        {
@@ -518,6 +605,8 @@ class Processor
         * Activity to remove a follower
         *
         * @param array $activity
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function undoFollowUser($activity)
        {
@@ -549,6 +638,7 @@ class Processor
         * Switches a contact to AP if needed
         *
         * @param integer $cid Contact ID
+        * @throws \Exception
         */
        private static function switchContact($cid)
        {
@@ -560,4 +650,67 @@ class Processor
                Logger::log('Change existing contact ' . $cid . ' from ' . $contact['network'] . ' to ActivityPub.');
                Contact::updateFromProbe($cid, Protocol::ACTIVITYPUB);
        }
+
+       /**
+        * Collects implicit mentions like:
+        * - the author of the parent item
+        * - all the mentioned conversants in the parent item
+        *
+        * @param array $parent Item array with at least ['id', 'author-link', 'alias']
+        * @return array
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        */
+       private static function getImplicitMentionList(array $parent)
+       {
+               $parent_terms = Term::tagArrayFromItemId($parent['id'], [TERM_MENTION]);
+
+               $implicit_mentions = [
+                       $parent['author-link']
+               ];
+
+               if ($parent['alias']) {
+                       $implicit_mentions[] = $parent['alias'];
+               }
+
+               foreach ($parent_terms as $term) {
+                       $contact = Contact::getDetailsByURL($term['url'], 0);
+                       if (!empty($contact)) {
+                               $implicit_mentions[] = $contact['url'];
+                               $implicit_mentions[] = $contact['nurl'];
+                               $implicit_mentions[] = $contact['alias'];
+                       }
+               }
+
+               return $implicit_mentions;
+       }
+
+       /**
+        * Strips from the body prepended implicit mentions
+        *
+        * @param string $body
+        * @param array  $implicit_mentions List of profile URLs
+        * @return string
+        */
+       private static function removeImplicitMentionsFromBody($body, array $implicit_mentions)
+       {
+               if (Config::get('system', 'disable_implicit_mentions')) {
+                       return $body;
+               }
+
+               $kept_mentions = [];
+
+               // Extract one prepended mention at a time from the body
+               while(preg_match('#^(@\[url=([^\]]+)].*?\[\/url]\s)(.*)#mis', $body, $matches)) {
+                       if (!in_array($matches[2], $implicit_mentions) ) {
+                               $kept_mentions[] = $matches[1];
+                       }
+
+                       $body = $matches[3];
+               }
+
+               // Re-appending the kept mentions to the body after extraction
+               $kept_mentions[] = $body;
+
+               return implode('', $kept_mentions);
+       }
 }