Issue 10365: Event updates are now processed

[friendica.git] / src / Protocol / ActivityPub / Processor.php

diff --git a/src/Protocol/ActivityPub/Processor.php b/src/Protocol/ActivityPub/Processor.php
index 51a7ede2f2bbf7b12acbc9c98e32fa407a915a47..948a3983bc1d6bde8d9ff02a3792af0c715b3bb9 100644 (file)
--- a/src/Protocol/ActivityPub/Processor.php
+++ b/src/Protocol/ActivityPub/Processor.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2022, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -26,6 +26,7 @@ use Friendica\Content\Text\HTML;
 use Friendica\Content\Text\Markdown;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
+use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\APContact;
@@ -96,7 +97,7 @@ class Processor
                        array_combine(
                                array_column($emojis, 'name'),
                                array_map(function ($emoji) {
-                                       return '[class=emoji mastodon][img=' . $emoji['href'] . ']' . $emoji['name'] . '[/img][/class]';
+                                       return '[emoji=' . $emoji['href'] . ']' . $emoji['name'] . '[/emoji]';
                                }, $emojis)
                        )
                );
@@ -124,7 +125,7 @@ class Processor
                $data = ['uri-id' => $uriid];
                $data['type'] = Post\Media::UNKNOWN;
                $data['url'] = $attachment['url'];
-               $data['mimetype'] = $attachment['mediaType'];
+               $data['mimetype'] = $attachment['mediaType'] ?? null;
                $data['height'] = $attachment['height'] ?? null;
                $data['width'] = $attachment['width'] ?? null;
                $data['size'] = $attachment['size'] ?? null;
@@ -179,6 +180,38 @@ class Processor
                }
 
                Item::update($item, ['uri' => $activity['id']]);
+
+               if ($activity['object_type'] == 'as:Event') {
+                       $posts = Post::select(['event-id', 'uid'], ['uri' => $activity['id']]);
+                       while ($post = DBA::fetch($posts)) {
+                               if (empty($post['event-id'])) {
+                                       continue;
+                               }
+                               self::updateEvent($post['event-id'], $activity);
+                       }
+               }
+       }
+
+       /**
+        * Update an existing event
+        *
+        * @param int $event_id 
+        * @param array $activity 
+        */
+       private static function updateEvent(int $event_id, array $activity)
+       {
+               $event = DBA::selectFirst('event', [], ['id' => $event_id]);
+
+               $event['edited']   = DateTimeFormat::utc($activity['updated']);
+               $event['summary']  = HTML::toBBCode($activity['name']);
+               $event['desc']     = HTML::toBBCode($activity['content']);
+               $event['start']    = $activity['start-time'];
+               $event['finish']   = $activity['end-time'];
+               $event['nofinish'] = empty($event['finish']);
+               $event['location'] = $activity['location'];
+
+               Logger::info('Updating event', ['uri' => $activity['id'], 'id' => $event_id]);
+               Event::store($event);
        }
 
        /**
@@ -257,6 +290,8 @@ class Processor
                        $item['post-type'] = Item::PT_IMAGE;
                } elseif ($activity['object_type'] == 'as:Page') {
                        $item['post-type'] = Item::PT_PAGE;
+               } elseif ($activity['object_type'] == 'as:Question') {
+                       $item['post-type'] = Item::PT_POLL;
                } elseif ($activity['object_type'] == 'as:Video') {
                        $item['post-type'] = Item::PT_VIDEO;
                } else {
@@ -287,8 +322,12 @@ class Processor
 
                $item['uri'] = $activity['id'];
 
-               $item['created'] = DateTimeFormat::utc($activity['published']);
-               $item['edited'] = DateTimeFormat::utc($activity['updated']);
+               if (empty($activity['published']) || empty($activity['updated'])) {
+                       DI::logger()->notice('published or updated keys are empty for activity', ['activity' => $activity, 'callstack' => System::callstack(10)]);
+               }
+
+               $item['created'] = DateTimeFormat::utc($activity['published'] ?? 'now');
+               $item['edited'] = DateTimeFormat::utc($activity['updated'] ?? 'now');
                $guid = $activity['sc:identifier'] ?: self::getGUIDByURL($item['uri']);
                $item['guid'] = $activity['diaspora:guid'] ?: $guid;
 
@@ -612,7 +651,16 @@ class Processor
                                continue;
                        }
 
-                       if (DI::pConfig()->get($receiver, 'system', 'accept_only_sharer', false) && ($receiver != 0) && ($item['gravity'] == GRAVITY_PARENT)) {
+                       $is_forum = false;
+
+                       if ($receiver != 0) {
+                               $user = User::getById($receiver, ['account-type']);
+                               if (!empty($user['account-type'])) {
+                                       $is_forum = ($user['account-type'] == User::ACCOUNT_TYPE_COMMUNITY);
+                               }
+                       }
+
+                       if (!$is_forum && DI::pConfig()->get($receiver, 'system', 'accept_only_sharer', false) && ($receiver != 0) && ($item['gravity'] == GRAVITY_PARENT)) {
                                $skip = !Contact::isSharingByURL($activity['author'], $receiver);
 
                                if ($skip && (($activity['type'] == 'as:Announce') || ($item['isForum'] ?? false))) {