use Friendica\Protocol\ActivityPub;
use Friendica\Protocol\Relay;
use Friendica\Util\DateTimeFormat;
+use Friendica\Util\HTTPSignature;
use Friendica\Util\JsonLD;
+use Friendica\Util\Network;
use Friendica\Util\Strings;
use Friendica\Worker\Delivery;
/**
* Updates a message
*
- * @param array $activity Activity array
+ * @param array $activity Activity array
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
+ * @throws \ImagickException
*/
public static function updateItem(array $activity)
{
Post\History::add($item['uri-id'], $item);
Item::update($item, ['uri' => $activity['id']]);
+ Queue::remove($activity);
+
if ($activity['object_type'] == 'as:Event') {
$posts = Post::select(['event-id', 'uid'], ["`uri` = ? AND `event-id` > ?", $activity['id'], 0]);
while ($post = DBA::fetch($posts)) {
/**
* Prepares data for a message
*
- * @param array $activity Activity array
+ * @param array $activity Activity array
* @return array Internal item
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
$item['object-type'] = Activity\ObjectType::COMMENT;
}
+ if (!empty($activity['context'])) {
+ $item['conversation'] = $activity['context'];
+ } elseif (!empty($activity['conversation'])) {
+ $item['conversation'] = $activity['conversation'];
+ }
+
+ if (!empty($item['conversation'])) {
+ $conversation = Post::selectFirstThread(['uri'], ['conversation' => $item['conversation']]);
+ if (!empty($conversation)) {
+ Logger::debug('Got conversation', ['conversation' => $item['conversation'], 'parent' => $conversation]);
+ $item['parent-uri'] = $conversation['uri'];
+ }
+ } else {
+ $conversation = [];
+ }
+
if (empty($activity['directmessage']) && ($activity['id'] != $activity['reply-to-id']) && !Post::exists(['uri' => $activity['reply-to-id']])) {
- Logger::notice('Parent not found. Try to refetch it.', ['parent' => $activity['reply-to-id']]);
- self::fetchMissingActivity($activity['reply-to-id'], $activity, '', Receiver::COMPLETION_AUTO);
+ $recursion_depth = $activity['recursion-depth'] ?? 0;
+ Logger::notice('Parent not found. Try to refetch it.', ['parent' => $activity['reply-to-id'], 'recursion-depth' => $recursion_depth]);
+ if ($recursion_depth < 10) {
+ $result = self::fetchMissingActivity($activity['reply-to-id'], $activity, '', Receiver::COMPLETION_AUTO);
+ if (empty($result) && self::ActivityIsGone($activity['reply-to-id'])) {
+ // Recursively delete this and all depending entries
+ Queue::deleteById($activity['entry-id']);
+ return [];
+ }
+ $fetch_by_worker = empty($result);
+ } else {
+ Logger::notice('Recursion level is too high.', ['parent' => $activity['reply-to-id'], 'recursion-depth' => $recursion_depth]);
+ $fetch_by_worker = true;
+ }
+
+ if ($fetch_by_worker && Queue::hasWorker($activity)) {
+ Logger::notice('There is already a worker task to fetch the post.', ['id' => $activity['id'], 'parent' => $activity['reply-to-id']]);
+ $fetch_by_worker = false;
+ if (!empty($conversation)) {
+ return [];
+ }
+ }
+
+ if ($fetch_by_worker) {
+ Logger::notice('Fetching is done by worker.', ['parent' => $activity['reply-to-id'], 'recursion-depth' => $recursion_depth]);
+ $activity['recursion-depth'] = 0;
+ $wid = Worker::add(PRIORITY_HIGH, 'FetchMissingActivity', $activity['reply-to-id'], $activity, '', Receiver::COMPLETION_AUTO);
+ Queue::setWorkerId($activity, $wid);
+ if (!empty($conversation)) {
+ return [];
+ }
+ } elseif (!empty($result)) {
+ if (($item['thr-parent'] != $result) && Post::exists(['uri' => $result])) {
+ $item['thr-parent'] = $result;
+ }
+ }
}
$item['diaspora_signed_text'] = $activity['diaspora:comment'] ?? '';
- /// @todo What to do with $activity['context']?
- if (empty($activity['directmessage']) && ($item['gravity'] != GRAVITY_PARENT) && !Post::exists(['uri' => $item['thr-parent']])) {
+ if (empty($conversation) && empty($activity['directmessage']) && ($item['gravity'] != GRAVITY_PARENT) && !Post::exists(['uri' => $item['thr-parent']])) {
Logger::info('Parent not found, message will be discarded.', ['thr-parent' => $item['thr-parent']]);
return [];
}
return $item;
}
+ /**
+ * Check if a given activity is no longer available
+ *
+ * @param string $url
+ *
+ * @return boolean
+ */
+ private static function ActivityIsGone(string $url): bool
+ {
+ $curlResult = HTTPSignature::fetchRaw($url, 0);
+
+ if (Network::isUrlBlocked($url)) {
+ return true;
+ }
+
+ // @todo To ensure that the remote system is working correctly, we can check if the "Content-Type" contains JSON
+ return in_array($curlResult->getReturnCode(), [404]);
+ }
/**
* Delete items
*
Logger::info('Deleting item', ['object' => $activity['object_id'], 'owner' => $owner]);
Item::markForDeletion(['uri' => $activity['object_id'], 'owner-id' => $owner]);
+ Queue::remove($activity);
}
/**
/**
* Prepare the item array for an activity
*
- * @param array $activity Activity array
- * @param string $verb Activity verb
+ * @param array $activity Activity array
+ * @param string $verb Activity verb
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
*/
public static function createActivity(array $activity, string $verb)
{
+ $activity['reply-to-id'] = $activity['object_id'];
$item = self::createItem($activity);
if (empty($item)) {
return;
}
}
- if ($activity['target_id'] != $actor['featured']) {
- return null;
- }
-
- $id = Contact::getIdForURL($activity['actor']);
- if (empty($id)) {
- return null;
+ $parent = Post::selectFirst(['uri-id'], ['uri' => $activity['object_id']]);
+ if (empty($parent['uri-id'])) {
+ if (self::fetchMissingActivity($activity['object_id'], $activity, '', Receiver::COMPLETION_AUTO)) {
+ $parent = Post::selectFirst(['uri-id'], ['uri' => $activity['object_id']]);
+ }
}
- $parent = Post::selectFirst(['uri-id'], ['uri' => $activity['object_id'], 'author-id' => $id]);
if (!empty($parent['uri-id'])) {
return $parent['uri-id'];
}
Logger::debug('Add post to featured collection', ['uri-id' => $uriid]);
Post\Collection::add($uriid, Post\Collection::FEATURED);
+ Queue::remove($activity);
}
/**
Logger::debug('Remove post from featured collection', ['uri-id' => $uriid]);
Post\Collection::remove($uriid, Post\Collection::FEATURED);
+ Queue::remove($activity);
}
/**
$item['raw-body'] = $content;
$item['body'] = Item::improveSharedDataInBody($item);
} else {
- if (empty($activity['directmessage']) && ($item['thr-parent'] != $item['uri']) && ($item['gravity'] == GRAVITY_COMMENT)) {
- $item_private = !in_array(0, $activity['item_receiver']);
- $parent = Post::selectFirst(['id', 'uri-id', 'private', 'author-link', 'alias'], ['uri' => $item['thr-parent']]);
+ $parent_uri = $item['parent-uri'] ?? $item['thr-parent'];
+ if (empty($activity['directmessage']) && ($parent_uri != $item['uri']) && ($item['gravity'] == GRAVITY_COMMENT)) {
+ $parent = Post::selectFirst(['id', 'uri-id', 'private', 'author-link', 'alias'], ['uri' => $parent_uri]);
if (!DBA::isResult($parent)) {
- Logger::warning('Unknown parent item.', ['uri' => $item['thr-parent']]);
+ Logger::warning('Unknown parent item.', ['uri' => $parent_uri]);
return false;
}
- if ($item_private && ($parent['private'] != Item::PRIVATE)) {
+ if (($item['private'] == Item::PRIVATE) && ($parent['private'] != Item::PRIVATE)) {
Logger::warning('Item is private but the parent is not. Dropping.', ['item-uri' => $item['uri'], 'thr-parent' => $item['thr-parent']]);
return false;
}
}
$stored = false;
+ $success = false;
ksort($activity['receiver']);
if (!self::isSolicitedMessage($activity, $item)) {
$item_id = Item::insert($item);
if ($item_id) {
Logger::info('Item insertion successful', ['user' => $item['uid'], 'item_id' => $item_id]);
+ $success = true;
} else {
- Logger::notice('Item insertion aborted', ['user' => $item['uid']]);
+ Logger::notice('Item insertion aborted', ['uri' => $item['uri'], 'uid' => $item['uid']]);
+ if (Item::isTooOld($item) || !Item::isValid($item)) {
+ Queue::remove($activity);
+ }
}
if ($item['uid'] == 0) {
}
}
+ if ($success) {
+ Queue::remove($activity);
+ Queue::processReplyByUri($item['uri']);
+ }
+
// Store send a follow request for every reshare - but only when the item had been stored
- if ($stored && ($item['private'] != Item::PRIVATE) && ($item['gravity'] == GRAVITY_PARENT) && ($item['author-link'] != $item['owner-link'])) {
+ if ($stored && ($item['private'] != Item::PRIVATE) && ($item['gravity'] == GRAVITY_PARENT) && !empty($item['author-link']) && ($item['author-link'] != $item['owner-link'])) {
$author = APContact::getByURL($item['owner-link'], false);
// We send automatic follow requests for reshared messages. (We don't need though for forum posts)
if ($author['type'] != 'Group') {
/**
* Fetches missing posts
*
- * @param string $url message URL
- * @param array $child activity array with the child of this message
- * @param string $relay_actor Relay actor
- * @param int $completion Completion mode, see Receiver::COMPLETION_*
+ * @param string $url message URL
+ * @param array $child activity array with the child of this message
+ * @param string $relay_actor Relay actor
+ * @param int $completion Completion mode, see Receiver::COMPLETION_*
* @return string fetched message URL
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
+ * @throws \ImagickException
*/
public static function fetchMissingActivity(string $url, array $child = [], string $relay_actor = '', int $completion = Receiver::COMPLETION_MANUAL): string
{
$object = ActivityPub::fetchContent($url, $uid);
if (empty($object)) {
- Logger::notice('Activity was not fetchable, aborting.', ['url' => $url]);
+ Logger::notice('Activity was not fetchable, aborting.', ['url' => $url, 'uid' => $uid]);
return '';
}
return '';
}
- if (!empty($object['actor'])) {
- $object_actor = $object['actor'];
- } elseif (!empty($object['attributedTo'])) {
- $object_actor = $object['attributedTo'];
- if (is_array($object_actor)) {
+ $signer = [];
+
+ if (!empty($object['attributedTo'])) {
+ $attributed_to = $object['attributedTo'];
+ if (is_array($attributed_to)) {
$compacted = JsonLD::compact($object);
- $object_actor = JsonLD::fetchElement($compacted, 'as:attributedTo', '@id');
+ $attributed_to = JsonLD::fetchElement($compacted, 'as:attributedTo', '@id');
}
+ $signer[] = $attributed_to;
+ }
+
+ if (!empty($object['actor'])) {
+ $object_actor = $object['actor'];
+ } elseif (!empty($attributed_to)) {
+ $object_actor = $attributed_to;
} else {
// Shouldn't happen
$object_actor = '';
}
- $signer = [$object_actor];
+ $signer[] = $object_actor;
if (!empty($child['author'])) {
$actor = $child['author'];
$ldactivity = JsonLD::compact($activity);
+ $ldactivity['recursion-depth'] = !empty($child['recursion-depth']) ? $child['recursion-depth'] + 1 : 1;
+
if (!empty($relay_actor)) {
$ldactivity['thread-completion'] = $ldactivity['from-relay'] = Contact::getIdForURL($relay_actor);
$ldactivity['completion-mode'] = Receiver::COMPLETION_RELAY;
Contact::update(['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
}
- $item = ['author-id' => Contact::getIdForURL($activity['actor']),
- 'author-link' => $activity['actor']];
+ $item = [
+ 'author-id' => Contact::getIdForURL($activity['actor']),
+ 'author-link' => $activity['actor'],
+ ];
// Ensure that the contact has got the right network type
self::switchContact($item['author-id']);
if (empty($contact)) {
Contact::update(['hub-verify' => $activity['id'], 'protocol' => Protocol::ACTIVITYPUB], ['id' => $cid]);
}
-
Logger::notice('Follow user ' . $uid . ' from contact ' . $cid . ' with id ' . $activity['id']);
+ Queue::remove($activity);
}
/**
Logger::info('Updating profile', ['object' => $activity['object_id']]);
Contact::updateFromProbeByURL($activity['object_id']);
+ Queue::remove($activity);
}
/**
DBA::close($contacts);
Logger::info('Deleted contact', ['object' => $activity['object_id']]);
+ Queue::remove($activity);
}
/**
Contact\User::setIsBlocked($cid, $uid, true);
Logger::info('Contact blocked user', ['contact' => $cid, 'user' => $uid]);
+ Queue::remove($activity);
}
/**
Contact\User::setIsBlocked($cid, $uid, false);
Logger::info('Contact unblocked user', ['contact' => $cid, 'user' => $uid]);
+ Queue::remove($activity);
}
/**
$condition = ['id' => $cid];
Contact::update($fields, $condition);
Logger::info('Accept contact request', ['contact' => $cid, 'user' => $uid]);
+ Queue::remove($activity);
}
/**
} else {
Logger::info('Rejected contact request', ['contact' => $cid, 'user' => $uid]);
}
+ Queue::remove($activity);
}
/**
}
Item::markForDeletion(['uri' => $activity['object_id'], 'author-id' => $author_id, 'gravity' => GRAVITY_ACTIVITY]);
+ Queue::remove($activity);
}
/**
Contact::removeFollower($contact);
Logger::info('Undo following request', ['contact' => $cid, 'user' => $uid]);
+ Queue::remove($activity);
}
/**
* Switches a contact to AP if needed
*
* @param integer $cid Contact ID
+ * @return void
* @throws \Exception
*/
private static function switchContact(int $cid)
projects / friendica.git / blobdiff