<?php
/**
- * @copyright Copyright (C) 2010-2022, the Friendica project
+ * @copyright Copyright (C) 2010-2023, the Friendica project
*
* @license GNU AGPL version 3 or any later version
*
namespace Friendica\Protocol\ActivityPub;
use Friendica\Core\Logger;
+use Friendica\Core\System;
use Friendica\Database\Database;
use Friendica\Database\DBA;
use Friendica\DI;
+use Friendica\Model\ItemURI;
+use Friendica\Model\Post;
use Friendica\Util\DateTimeFormat;
use Friendica\Util\JsonLD;
return $activity;
}
+ /**
+ * Checks if an entry for a given url and type already exists
+ *
+ * @param string $url
+ * @param string $type
+ * @return boolean
+ */
+ public static function exists(string $url, string $type): bool
+ {
+ return DBA::exists('inbox-entry', ['type' => $type, 'object-id' => $url]);
+ }
+
/**
* Remove activity from the queue
*
return;
}
+ Logger::debug('Delete inbox-entry', ['id' => $entry['id']]);
+
+ DBA::delete('inbox-entry', ['id' => $entry['id']]);
+
$children = DBA::select('inbox-entry', ['id'], ['in-reply-to-id' => $entry['object-id']]);
while ($child = DBA::fetch($children)) {
self::deleteById($child['id']);
}
DBA::close($children);
- DBA::delete('inbox-entry', ['id' => $entry['id']]);
}
/**
* Set the worker id for the queue entry
*
- * @param array $activity
- * @param int $wid
+ * @param int $entry_id
+ * @param int $wid
* @return void
*/
- public static function setWorkerId(array $activity, int $wid)
+ public static function setWorkerId(int $entry_id, int $wid)
{
- if (empty($activity['entry-id']) || empty($wid)) {
+ if (empty($entry_id) || empty($wid)) {
return;
}
- DBA::update('inbox-entry', ['wid' => $wid], ['id' => $activity['entry-id']]);
+ DBA::update('inbox-entry', ['wid' => $wid], ['id' => $entry_id]);
}
/**
* Check if there is an assigned worker task
*
- * @param array $activity
+ * @param int $wid
+ *
* @return bool
*/
- public static function hasWorker(array $activity = []): bool
+ public static function hasWorker(int $wid): bool
{
- if (empty($activity['worker-id'])) {
+ if (empty($wid)) {
return false;
}
- return DBA::exists('workerqueue', ['id' => $activity['worker-id'], 'done' => false]);
+ return DBA::exists('workerqueue', ['id' => $wid, 'done' => false]);
}
/**
* Process the activity with the given id
*
* @param integer $id
+ * @param bool $fetch_parents
*
* @return bool
*/
- public static function process(int $id): bool
+ public static function process(int $id, bool $fetch_parents = true): bool
{
$entry = DBA::selectFirst('inbox-entry', [], ['id' => $id]);
if (empty($entry)) {
return false;
}
- Logger::debug('Processing queue entry', ['id' => $entry['id'], 'type' => $entry['type'], 'object-type' => $entry['object-type'], 'uri' => $entry['object-id'], 'in-reply-to' => $entry['in-reply-to-id']]);
+ if (!self::isProcessable($id)) {
+ Logger::debug('Other queue entries need to be processed first.', ['id' => $id]);
+ return false;
+ }
+
+ if (!empty($entry['wid'])) {
+ $worker = DI::app()->getQueue();
+ $wid = $worker['id'] ?? 0;
+ if ($entry['wid'] != $wid) {
+ $workerqueue = DBA::selectFirst('workerqueue', ['pid'], ['id' => $entry['wid'], 'done' => false]);
+ if (!empty($workerqueue['pid']) && posix_kill($workerqueue['pid'], 0)) {
+ Logger::notice('Entry is already processed via another process.', ['current' => $wid, 'processor' => $entry['wid']]);
+ return false;
+ }
+ }
+ }
+
+ Logger::debug('Processing queue entry', ['id' => $entry['id'], 'type' => $entry['type'], 'object-type' => $entry['object-type'], 'uri' => $entry['object-id'], 'in-reply-to' => $entry['in-reply-to-id'], 'callstack' => System::callstack(20)]);
$activity = json_decode($entry['activity'], true);
$type = $entry['type'];
$activity['worker-id'] = $entry['wid'];
$activity['recursion-depth'] = 0;
- $receivers = DBA::select('inbox-entry-receiver', ['uid'], ['queue-id' => $entry['id']]);
+ if (empty($activity['thread-children-type'])) {
+ $activity['thread-children-type'] = $type;
+ }
+
+ $receivers = DBA::select('inbox-entry-receiver', ['uid'], ["`queue-id` = ? AND `uid` != ?", $entry['id'], 0]);
while ($receiver = DBA::fetch($receivers)) {
if (!in_array($receiver['uid'], $activity['receiver'])) {
$activity['receiver'][] = $receiver['uid'];
}
DBA::close($receivers);
- if (!Receiver::routeActivities($activity, $type, $push)) {
+ if (!Receiver::routeActivities($activity, $type, $push, $fetch_parents, $activity['receiver'][0] ?? 0)) {
self::remove($activity);
}
{
$entries = DBA::select('inbox-entry', ['id', 'type', 'object-type', 'object-id', 'in-reply-to-id'], ["`trust` AND `wid` IS NULL"], ['order' => ['id' => true]]);
while ($entry = DBA::fetch($entries)) {
+ // Don't process entries of items that are answer to nonexistent posts
+ if (!empty($entry['in-reply-to-id']) && !Post::exists(['uri' => $entry['in-reply-to-id']])) {
+ continue;
+ }
// We don't need to process entries that depend on already existing entries.
if (!empty($entry['in-reply-to-id']) && DBA::exists('inbox-entry', ["`id` != ? AND `object-id` = ?", $entry['id'], $entry['in-reply-to-id']])) {
continue;
}
Logger::debug('Process leftover entry', $entry);
- self::process($entry['id']);
+ self::process($entry['id'], false);
}
DBA::close($entries);
}
+ public static function isProcessable(int $id): bool
+ {
+ $entry = DBA::selectFirst('inbox-entry', [], ['id' => $id]);
+ if (empty($entry)) {
+ return false;
+ }
+
+ if (!empty($entry['object-id']) && Post::exists(['uri' => $entry['object-id']])) {
+ // The object already exists, so processing can be done
+ return true;
+ }
+
+ if (!empty($entry['conversation'])) {
+ $conv_id = ItemURI::getIdByURI($entry['conversation'], false);
+ if (DBA::exists('post-thread', ['conversation-id' => $conv_id])) {
+ // We have got the conversation in the system, so the post can be processed
+ return true;
+ }
+ }
+
+ if (!empty($entry['object-id']) && !empty($entry['in-reply-to-id']) && ($entry['object-id'] != $entry['in-reply-to-id']) && DBA::exists('inbox-entry', ['object-id' => $entry['in-reply-to-id']])) {
+ // This entry belongs to some other entry that should be processed first
+ return false;
+ }
+
+ return true;
+ }
+
/**
* Clear old activities
*
{
// We delete all entries that aren't associated with a worker entry after seven days.
// The other entries are deleted when the worker deferred for too long.
- DBA::delete('inbox-entry', ["`wid` IS NULL AND `received` < ?", DateTimeFormat::utc('now - 7 days')]);
+ $entries = DBA::select('inbox-entry', ['id'], ["`wid` IS NULL AND `received` < ?", DateTimeFormat::utc('now - 7 days')]);
+ while ($entry = DBA::fetch($entries)) {
+ self::deleteById($entry['id']);
+ }
+ DBA::close($entries);
// Optimizing this table only last seconds
if (DI::config()->get('system', 'optimize_tables')) {
$entries = DBA::select('inbox-entry', ['id'], ["`in-reply-to-id` = ? AND `object-id` != ?", $uri, $uri]);
while ($entry = DBA::fetch($entries)) {
$count += 1;
- self::process($entry['id']);
+ self::process($entry['id'], false);
}
DBA::close($entries);
return $count;
}
}
DBA::close($entries);
-
}
}
projects / friendica.git / blobdiff