<?php
/**
- * @copyright Copyright (C) 2010-2022, the Friendica project
+ * @copyright Copyright (C) 2010-2023, the Friendica project
*
* @license GNU AGPL version 3 or any later version
*
use Friendica\Core\Protocol;
use Friendica\Core\System;
use Friendica\Core\Worker;
+use Friendica\Database\Database;
use Friendica\DI;
use Friendica\Model\Contact;
use Friendica\Model\APContact;
const PUBLIC_COLLECTION = 'as:Public';
const ACCOUNT_TYPES = ['as:Person', 'as:Organization', 'as:Service', 'as:Group', 'as:Application'];
const CONTENT_TYPES = ['as:Note', 'as:Article', 'as:Video', 'as:Image', 'as:Event', 'as:Audio', 'as:Page', 'as:Question'];
- const ACTIVITY_TYPES = ['as:Like', 'as:Dislike', 'as:Accept', 'as:Reject', 'as:TentativeAccept'];
+ const ACTIVITY_TYPES = ['as:Like', 'as:Dislike', 'as:Accept', 'as:Reject', 'as:TentativeAccept', 'as:View', 'as:Read', 'litepub:EmojiReact'];
const TARGET_UNKNOWN = 0;
const TARGET_TO = 1;
APContact::unmarkForArchival($apcontact);
}
+ $sig_contact = HTTPSignature::getKeyIdContact($header);
+ if (APContact::isRelay($sig_contact)) {
+ Logger::info('Message from a relay', ['url' => $sig_contact['url']]);
+ self::processRelayPost($ldactivity, $sig_contact['url']);
+ return;
+ }
+
$http_signer = HTTPSignature::getSigner($body, $header);
if ($http_signer === false) {
- Logger::warning('Invalid HTTP signature, message will be discarded.');
- return;
+ Logger::notice('Invalid HTTP signature, message will not be trusted.', ['uid' => $uid, 'actor' => $actor, 'header' => $header, 'body' => $body]);
+ $signer = [];
} elseif (empty($http_signer)) {
Logger::info('Signer is a tombstone. The message will be discarded, the signer account is deleted.');
return;
} else {
Logger::info('Valid HTTP signature', ['signer' => $http_signer]);
+ $signer = [$http_signer];
}
- $signer = [$http_signer];
-
Logger::info('Message for user ' . $uid . ' is from actor ' . $actor);
- if (LDSignature::isSigned($activity)) {
+ if ($http_signer === false) {
+ $trust_source = false;
+ } elseif (LDSignature::isSigned($activity)) {
$ld_signer = LDSignature::getSigner($activity);
if (empty($ld_signer)) {
Logger::info('Invalid JSON-LD signature from ' . $actor);
{
$type = JsonLD::fetchElement($activity, '@type');
if (!$type) {
- Logger::info('Empty type', ['activity' => $activity, 'actor' => $actor]);
+ Logger::notice('Empty type', ['activity' => $activity, 'actor' => $actor]);
return;
}
- if ($type != 'as:Announce') {
- Logger::info('Not an announcement', ['activity' => $activity, 'actor' => $actor]);
- return;
- }
+ $object_type = JsonLD::fetchElement($activity, 'as:object', '@type') ?? '';
$object_id = JsonLD::fetchElement($activity, 'as:object', '@id');
if (empty($object_id)) {
- Logger::info('No object id found', ['activity' => $activity, 'actor' => $actor]);
+ Logger::notice('No object id found', ['type' => $type, 'object_type' => $object_type, 'actor' => $actor, 'activity' => $activity]);
+ return;
+ }
+
+ $handle = ($type == 'as:Announce');
+
+ if (!$handle && in_array($type, ['as:Create', 'as:Update'])) {
+ $handle = in_array($object_type, self::CONTENT_TYPES);
+ }
+
+ if (!$handle) {
+ $trust_source = false;
+ $object_data = self::prepareObjectData($activity, 0, false, $trust_source);
+
+ if (!$trust_source) {
+ Logger::notice('Activity trust could not be achieved.', ['type' => $type, 'object_type' => $object_type, 'object_id' => $object_id, 'actor' => $actor, 'activity' => $activity]);
+ return;
+ }
+
+ if (empty($object_data)) {
+ Logger::notice('No object data found', ['type' => $type, 'object_type' => $object_type, 'object_id' => $object_id, 'actor' => $actor, 'activity' => $activity]);
+ return;
+ }
+
+ if (self::routeActivities($object_data, $type, true)) {
+ Logger::debug('Handled activity', ['type' => $type, 'object_type' => $object_type, 'object_id' => $object_id, 'actor' => $actor]);
+ } else {
+ Logger::info('Unhandled activity', ['type' => $type, 'object_type' => $object_type, 'object_id' => $object_id, 'actor' => $actor, 'activity' => $activity]);
+ }
return;
}
return;
}
- Logger::info('Got relayed message id', ['id' => $object_id, 'actor' => $actor]);
+ Logger::debug('Got relayed message id', ['id' => $object_id, 'actor' => $actor]);
$item_id = Item::searchByLink($object_id);
if ($item_id) {
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
*/
- private static function fetchObjectType(array $activity, string $object_id, int $uid = 0)
+ public static function fetchObjectType(array $activity, string $object_id, int $uid = 0)
{
if (!empty($activity['as:object'])) {
$object_type = JsonLD::fetchElement($activity['as:object'], '@type');
}
}
- if (Post::exists(['uri' => $object_id, 'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT]])) {
+ if (Post::exists(['uri' => $object_id, 'gravity' => [Item::GRAVITY_PARENT, Item::GRAVITY_COMMENT]])) {
// We just assume "note" since it doesn't make a difference for the further processing
return 'as:Note';
}
$object_type = JsonLD::fetchElement($activity['as:object'], '@type');
}
+ $fetched = false;
+
if (!empty($id) && !$trust_source) {
$fetch_uid = $uid ?: self::getBestUserForActivity($activity);
$fetched_activity = Processor::fetchCachedActivity($fetch_id, $fetch_uid);
if (!empty($fetched_activity)) {
- $object = JsonLD::compact($fetched_activity);
+ $fetched = true;
+ $object = JsonLD::compact($fetched_activity);
$fetched_id = JsonLD::fetchElement($object, '@id');
$fetched_type = JsonLD::fetchElement($object, '@type');
$type = JsonLD::fetchElement($activity, '@type');
// Fetch all receivers from to, cc, bto and bcc
- $receiverdata = self::getReceivers($activity, $actor);
+ $receiverdata = self::getReceivers($activity, $actor, [], false, $push || $fetched);
$receivers = $reception_types = [];
foreach ($receiverdata as $key => $data) {
$receivers[$key] = $data['uid'];
// Fetch the activity on Lemmy "Announce" messages (announces of activities)
if (($type == 'as:Announce') && in_array($object_type, array_merge(self::ACTIVITY_TYPES, ['as:Delete', 'as:Undo', 'as:Update']))) {
+ Logger::debug('Fetch announced activity', ['object' => $object_id]);
$data = Processor::fetchCachedActivity($object_id, $fetch_uid);
if (!empty($data)) {
$type = $object_type;
}
// Any activities on account types must not be altered
- if (in_array($object_type, self::ACCOUNT_TYPES)) {
+ if (in_array($type, ['as:Flag'])) {
+ $object_data = [];
+ $object_data['id'] = JsonLD::fetchElement($activity, '@id');
+ $object_data['object_id'] = JsonLD::fetchElement($activity, 'as:object', '@id');
+ $object_data['object_ids'] = JsonLD::fetchElementArray($activity, 'as:object', '@id');
+ $object_data['content'] = JsonLD::fetchElement($activity, 'as:content', '@type');
+ } elseif (in_array($object_type, self::ACCOUNT_TYPES)) {
$object_data = [];
$object_data['id'] = JsonLD::fetchElement($activity, '@id');
$object_data['object_id'] = JsonLD::fetchElement($activity, 'as:object', '@id');
$object_data['object_actor'] = JsonLD::fetchElement($activity['as:object'], 'as:actor', '@id');
$object_data['object_object'] = JsonLD::fetchElement($activity['as:object'], 'as:object');
$object_data['object_type'] = JsonLD::fetchElement($activity['as:object'], '@type');
- $object_data['push'] = $push;
if (!$trust_source && ($type == 'as:Delete')) {
$apcontact = APContact::getByURL($object_data['object_id'], true);
$trust_source = empty($apcontact) || ($apcontact['type'] == 'Tombstone') || $apcontact['suspended'];
}
- } elseif (in_array($type, ['as:Create', 'as:Update', 'as:Announce', 'as:Invite']) || strpos($type, '#emojiReaction')) {
+ } elseif (in_array($type, ['as:Create', 'as:Update', 'as:Invite']) || strpos($type, '#emojiReaction')) {
// Fetch the content only on activities where this matters
// We can receive "#emojiReaction" when fetching content from Hubzilla systems
- // Always fetch on "Announce"
- $object_data = self::fetchObject($object_id, $activity['as:object'], $trust_source && ($type != 'as:Announce'), $fetch_uid);
+ $object_data = self::fetchObject($object_id, $activity['as:object'], $trust_source, $fetch_uid);
if (empty($object_data)) {
Logger::info("Object data couldn't be processed");
return [];
$object_data['object_id'] = $object_id;
- if ($type == 'as:Announce') {
- $object_data['push'] = false;
- } else {
- $object_data['push'] = $push;
- }
-
// Test if it is an answer to a mail
if (DBA::exists('mail', ['uri' => $object_data['reply-to-id']])) {
$object_data['directmessage'] = true;
} else {
$object_data['directmessage'] = JsonLD::fetchElement($activity, 'litepub:directMessage');
}
- } elseif (in_array($type, array_merge(self::ACTIVITY_TYPES, ['as:Follow', 'litepub:EmojiReact', 'as:View'])) && in_array($object_type, self::CONTENT_TYPES)) {
+ } elseif (in_array($type, array_merge(self::ACTIVITY_TYPES, ['as:Announce', 'as:Follow'])) && in_array($object_type, self::CONTENT_TYPES)) {
// Create a mostly empty array out of the activity data (instead of the object).
// This way we later don't have to check for the existence of each individual array element.
$object_data = self::processObject($activity);
$object_data['author'] = JsonLD::fetchElement($activity, 'as:actor', '@id');
$object_data['object_id'] = $object_id;
$object_data['object_type'] = ''; // Since we don't fetch the object, we don't know the type
- $object_data['push'] = $push;
- } elseif (in_array($type, ['as:Add', 'as:Remove'])) {
+ } elseif (in_array($type, ['as:Add', 'as:Remove', 'as:Move'])) {
$object_data = [];
$object_data['id'] = JsonLD::fetchElement($activity, '@id');
$object_data['target_id'] = JsonLD::fetchElement($activity, 'as:target', '@id');
$object_data['object_id'] = JsonLD::fetchElement($activity, 'as:object', '@id');
$object_data['object_type'] = JsonLD::fetchElement($activity['as:object'], '@type');
$object_data['object_content'] = JsonLD::fetchElement($activity['as:object'], 'as:content', '@type');
- $object_data['push'] = $push;
} else {
$object_data = [];
$object_data['id'] = JsonLD::fetchElement($activity, '@id');
$object_data['object_actor'] = JsonLD::fetchElement($activity['as:object'], 'as:actor', '@id');
$object_data['object_object'] = JsonLD::fetchElement($activity['as:object'], 'as:object');
$object_data['object_type'] = JsonLD::fetchElement($activity['as:object'], '@type');
- $object_data['push'] = $push;
// An Undo is done on the object of an object, so we need that type as well
if (($type == 'as:Undo') && !empty($object_data['object_object'])) {
}
}
+ $object_data['push'] = $push;
+
$object_data = self::addActivityFields($object_data, $activity);
if (empty($object_data['object_type'])) {
// }
// }
- Logger::info('Processing ' . $object_data['type'] . ' ' . $object_data['object_type'] . ' ' . $object_data['id']);
+ $account = Contact::selectFirstAccount(['platform'], ['nurl' => Strings::normaliseLink($actor)]);
+ $platform = $account['platform'] ?? '';
+
+ Logger::info('Processing', ['type' => $object_data['type'], 'object_type' => $object_data['object_type'], 'id' => $object_data['id'], 'actor' => $actor, 'platform' => $platform]);
return $object_data;
}
* @param boolean $trust_source Do we trust the source?
* @param boolean $push Message had been pushed to our system
* @param array $signer The signer of the post
+ *
+ * @return bool
+ *
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \ImagickException
*/
- public static function processActivity(array $activity, string $body = '', int $uid = null, bool $trust_source = false, bool $push = false, array $signer = [], string $http_signer = '')
+ public static function processActivity(array $activity, string $body = '', int $uid = null, bool $trust_source = false, bool $push = false, array $signer = [], string $http_signer = '', int $completion = Receiver::COMPLETION_AUTO): bool
{
$type = JsonLD::fetchElement($activity, '@type');
if (!$type) {
Logger::info('Empty type', ['activity' => $activity]);
- return;
+ return true;
+ }
+
+ if ($type == 'as:View') {
+ Logger::info('View activities are ignored.', ['signer' => $signer, 'http_signer' => $http_signer]);
+ return true;
}
if (!JsonLD::fetchElement($activity, 'as:object', '@id')) {
Logger::info('Empty object', ['activity' => $activity]);
- return;
+ return true;
}
$actor = JsonLD::fetchElement($activity, 'as:actor', '@id');
if (empty($actor)) {
Logger::info('Empty actor', ['activity' => $activity]);
- return;
+ return true;
}
if (is_array($activity['as:object'])) {
$object_data = self::prepareObjectData($activity, $uid, $push, $trust_source);
if (empty($object_data)) {
Logger::info('No object data found', ['activity' => $activity]);
- return;
+ return true;
}
// Lemmy is announcing activities.
// We are changing the announces into regular activities.
if (($type == 'as:Announce') && in_array($object_data['type'] ?? '', array_merge(self::ACTIVITY_TYPES, ['as:Delete', 'as:Undo', 'as:Update']))) {
+ Logger::debug('Change type of announce to activity', ['type' => $object_data['type']]);
$type = $object_data['type'];
}
$object_data['object_activity'] = $activity;
}
- if ($trust_source || DI::config()->get('debug', 'ap_inbox_store_untrusted')) {
+ if (($type == 'as:Create') && $trust_source) {
+ if (self::hasArrived($object_data['object_id'])) {
+ Logger::info('The activity already arrived.', ['id' => $object_data['object_id']]);
+ return true;
+ }
+ self::addArrivedId($object_data['object_id']);
+
+ if (Queue::exists($object_data['object_id'], $type)) {
+ Logger::info('The activity is already added.', ['id' => $object_data['object_id']]);
+ return true;
+ }
+ }
+
+ $decouple = DI::config()->get('system', 'decoupled_receiver') && !in_array($completion, [self::COMPLETION_MANUAL, self::COMPLETION_ANNOUCE]);
+
+ if ($decouple && ($trust_source || DI::config()->get('debug', 'ap_inbox_store_untrusted'))) {
$object_data = Queue::add($object_data, $type, $uid, $http_signer, $push, $trust_source);
}
if (!$trust_source) {
Logger::info('Activity trust could not be achieved.', ['id' => $object_data['object_id'], 'type' => $type, 'signer' => $signer, 'actor' => $actor, 'attributedTo' => $attributed_to]);
- return;
+ return true;
}
- if (!empty($object_data['entry-id']) && DI::config()->get('system', 'decoupled_receiver') && ($push || ($activity['completion-mode'] == self::COMPLETION_RELAY))) {
- // We delay by 5 seconds to allow to accumulate all receivers
- $delayed = date(DateTimeFormat::MYSQL, time() + 5);
- Logger::debug('Initiate processing', ['id' => $object_data['entry-id'], 'uri' => $object_data['object_id']]);
- Worker::add(['priority' => PRIORITY_HIGH, 'delayed' => $delayed], 'ProcessQueue', $object_data['entry-id']);
- return;
+ if (!empty($object_data['entry-id']) && $decouple && ($push || ($completion == self::COMPLETION_RELAY))) {
+ if (Queue::isProcessable($object_data['entry-id'])) {
+ // We delay by 5 seconds to allow to accumulate all receivers
+ $delayed = date(DateTimeFormat::MYSQL, time() + 5);
+ Logger::debug('Initiate processing', ['id' => $object_data['entry-id'], 'uri' => $object_data['object_id']]);
+ $wid = Worker::add(['priority' => Worker::PRIORITY_HIGH, 'delayed' => $delayed], 'ProcessQueue', $object_data['entry-id']);
+ Queue::setWorkerId($object_data['entry-id'], $wid);
+ } else {
+ Logger::debug('Other queue entries need to be processed first.', ['id' => $object_data['entry-id']]);
+ }
+ return false;
}
if (!empty($activity['recursion-depth'])) {
$object_data['recursion-depth'] = $activity['recursion-depth'];
}
- if (in_array('as:Question', [$object_data['object_type'] ?? '', $object_data['object_object_type'] ?? ''])) {
- self::storeUnhandledActivity(false, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
- }
-
- if (!self::routeActivities($object_data, $type, $push)) {
+ if (!self::routeActivities($object_data, $type, $push, true, $uid)) {
self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
Queue::remove($object_data);
}
+ return true;
}
/**
* Route activities
*
- * @param array $object_data
- * @param string $type
- * @param boolean $push
+ * @param array $object_data
+ * @param string $type
+ * @param bool $push
+ * @param bool $fetch_parents
+ * @param int $uid
*
* @return boolean Could the activity be routed?
*/
- public static function routeActivities(array $object_data, string $type, bool $push): bool
+ public static function routeActivities(array $object_data, string $type, bool $push, bool $fetch_parents = true, int $uid = 0): bool
{
- $activity = $object_data['object_activity'] ?? [];
-
switch ($type) {
case 'as:Create':
if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
- $item = ActivityPub\Processor::createItem($object_data);
+ $item = ActivityPub\Processor::createItem($object_data, $fetch_parents);
ActivityPub\Processor::postItem($object_data, $item);
} elseif (in_array($object_data['object_type'], ['pt:CacheFile'])) {
// Unhandled Peertube activity
Queue::remove($object_data);
+ } elseif (in_array($object_data['object_type'], self::ACCOUNT_TYPES)) {
+ ActivityPub\Processor::updatePerson($object_data);
} else {
return false;
}
case 'as:Invite':
if (in_array($object_data['object_type'], ['as:Event'])) {
- $item = ActivityPub\Processor::createItem($object_data);
+ $item = ActivityPub\Processor::createItem($object_data, $fetch_parents);
ActivityPub\Processor::postItem($object_data, $item);
} else {
return false;
ActivityPub\Processor::addTag($object_data);
} elseif (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
ActivityPub\Processor::addToFeaturedCollection($object_data);
- } elseif ($object_data['object_type'] == '') {
- // The object type couldn't be determined. We don't have it and we can't fetch it. We ignore this activity.
+ } elseif (in_array($object_data['object_type'], ['as:Tombstone', ''])) {
+ // We don't have the object here or it is deleted. We ignore this activity.
Queue::remove($object_data);
} else {
return false;
case 'as:Announce':
if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
- $actor = JsonLD::fetchElement($activity, 'as:actor', '@id');
- $object_data['thread-completion'] = Contact::getIdForURL($actor);
- $object_data['completion-mode'] = self::COMPLETION_ANNOUCE;
-
- $item = ActivityPub\Processor::createItem($object_data);
- if (empty($item)) {
- return false;
- }
-
- $item['post-reason'] = Item::PR_ANNOUNCEMENT;
- ActivityPub\Processor::postItem($object_data, $item);
-
- if (!empty($activity)) {
- $announce_object_data = self::processObject($activity);
- $announce_object_data['name'] = $type;
- $announce_object_data['author'] = $actor;
- $announce_object_data['object_id'] = $object_data['object_id'];
- $announce_object_data['object_type'] = $object_data['object_type'];
- $announce_object_data['push'] = $push;
-
- if (!empty($object_data['raw'])) {
- $announce_object_data['raw'] = $object_data['raw'];
- }
- if (!empty($object_data['raw-object'])) {
- $announce_object_data['raw-object'] = $object_data['raw-object'];
+ if (!Item::searchByLink($object_data['object_id'], $uid)) {
+ if (ActivityPub\Processor::fetchMissingActivity($object_data['object_id'], [], $object_data['actor'], self::COMPLETION_ANNOUCE, $uid)) {
+ Logger::debug('Created announced id', ['uid' => $uid, 'id' => $object_data['object_id']]);
+ Queue::remove($object_data);
+ } else {
+ Logger::debug('Announced id was not created', ['uid' => $uid, 'id' => $object_data['object_id']]);
+ Queue::remove($object_data);
+ return true;
}
- ActivityPub\Processor::createActivity($announce_object_data, Activity::ANNOUNCE);
+ } else {
+ Logger::info('Announced id already exists', ['uid' => $uid, 'id' => $object_data['object_id']]);
+ Queue::remove($object_data);
}
+
+ ActivityPub\Processor::createActivity($object_data, Activity::ANNOUNCE);
+ } elseif (in_array($object_data['object_type'], ['as:Tombstone', ''])) {
+ // We don't have the object here or it is deleted. We ignore this activity.
+ Queue::remove($object_data);
} else {
return false;
}
case 'as:Like':
if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
ActivityPub\Processor::createActivity($object_data, Activity::LIKE);
- } elseif ($object_data['object_type'] == '') {
- // The object type couldn't be determined. We don't have it and we can't fetch it. We ignore this activity.
+ } elseif (in_array($object_data['object_type'], ['as:Tombstone', ''])) {
+ // We don't have the object here or it is deleted. We ignore this activity.
Queue::remove($object_data);
} else {
return false;
case 'as:Dislike':
if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
ActivityPub\Processor::createActivity($object_data, Activity::DISLIKE);
- } elseif ($object_data['object_type'] == '') {
- // The object type couldn't be determined. We don't have it and we can't fetch it. We ignore this activity.
+ } elseif (in_array($object_data['object_type'], ['as:Tombstone', ''])) {
+ // We don't have the object here or it is deleted. We ignore this activity.
Queue::remove($object_data);
} else {
return false;
}
break;
+ case 'as:Move':
+ if (in_array($object_data['object_type'], self::ACCOUNT_TYPES)) {
+ ActivityPub\Processor::movePerson($object_data);
+ } else {
+ return false;
+ }
+ break;
+
case 'as:Block':
if (in_array($object_data['object_type'], self::ACCOUNT_TYPES)) {
ActivityPub\Processor::blockAccount($object_data);
}
break;
+ case 'as:Flag':
+ if (in_array($object_data['object_type'], self::ACCOUNT_TYPES)) {
+ ActivityPub\Processor::ReportAccount($object_data);
+ } else {
+ return false;
+ }
+ break;
+
case 'as:Remove':
if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
ActivityPub\Processor::removeFromFeaturedCollection($object_data);
- } elseif ($object_data['object_type'] == '') {
- // The object type couldn't be determined. We don't have it and we can't fetch it. We ignore this activity.
+ } elseif (in_array($object_data['object_type'], ['as:Tombstone', ''])) {
+ // We don't have the object here or it is deleted. We ignore this activity.
Queue::remove($object_data);
} else {
return false;
case 'as:Accept':
if ($object_data['object_type'] == 'as:Follow') {
- ActivityPub\Processor::acceptFollowUser($object_data);
+ if (!empty($object_data['object_actor'])) {
+ ActivityPub\Processor::acceptFollowUser($object_data);
+ } else {
+ Logger::notice('Unhandled "accept follow" message.', ['object_data' => $object_data]);
+ }
} elseif (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
ActivityPub\Processor::createActivity($object_data, Activity::ATTEND);
+ } elseif (!empty($object_data['object_id']) && empty($object_data['object_actor']) && empty($object_data['object_type'])) {
+ // Follow acceptances from gup.pe only contain the object id
+ ActivityPub\Processor::acceptFollowUser($object_data);
} else {
return false;
}
} elseif (($object_data['object_type'] == 'as:Block') &&
in_array($object_data['object_object_type'], self::ACCOUNT_TYPES)) {
ActivityPub\Processor::unblockAccount($object_data);
- } elseif (in_array($object_data['object_type'], array_merge(self::ACTIVITY_TYPES, ['as:Announce'])) &&
- in_array($object_data['object_object_type'], array_merge(['as:Tombstone'], self::CONTENT_TYPES))) {
- ActivityPub\Processor::undoActivity($object_data);
} elseif (in_array($object_data['object_type'], array_merge(self::ACTIVITY_TYPES, ['as:Announce', 'as:Create', ''])) &&
empty($object_data['object_object_type'])) {
// We cannot detect the target object. So we can ignore it.
Queue::remove($object_data);
+ } elseif (in_array($object_data['object_type'], array_merge(self::ACTIVITY_TYPES, ['as:Announce'])) &&
+ in_array($object_data['object_object_type'], array_merge(['as:Tombstone'], self::CONTENT_TYPES))) {
+ ActivityPub\Processor::undoActivity($object_data);
} elseif (in_array($object_data['object_type'], ['as:Create']) &&
in_array($object_data['object_object_type'], ['pt:CacheFile'])) {
// Unhandled Peertube activity
Queue::remove($object_data);
+ } elseif (in_array($object_data['object_type'], ['as:Delete'])) {
+ // We cannot undo deletions, so we just ignore this
+ Queue::remove($object_data);
+ } elseif (in_array($object_data['object_object_type'], ['as:Tombstone'])) {
+ // The object is a tombstone, we ignore any actions on it.
+ Queue::remove($object_data);
} else {
return false;
}
case 'as:View':
if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
ActivityPub\Processor::createActivity($object_data, Activity::VIEW);
- } elseif ($object_data['object_type'] == '') {
- // The object type couldn't be determined. Most likely we don't have it here. We ignore this activity.
+ } elseif (in_array($object_data['object_type'], ['as:Tombstone', ''])) {
+ // We don't have the object here or it is deleted. We ignore this activity.
+ Queue::remove($object_data);
+ } else {
+ return false;
+ }
+ break;
+ case 'as:Read':
+ if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
+ ActivityPub\Processor::createActivity($object_data, Activity::READ);
+ } elseif (in_array($object_data['object_type'], ['as:Tombstone', ''])) {
+ // We don't have the object here or it is deleted. We ignore this activity.
Queue::remove($object_data);
} else {
return false;
case 'litepub:EmojiReact':
if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
ActivityPub\Processor::createActivity($object_data, Activity::EMOJIREACT);
- } elseif ($object_data['object_type'] == '') {
- // The object type couldn't be determined. We don't have it and we can't fetch it. We ignore this activity.
+ } elseif (in_array($object_data['object_type'], ['as:Tombstone', ''])) {
+ // We don't have the object here or it is deleted. We ignore this activity.
Queue::remove($object_data);
} else {
return false;
$tempfile = tempnam(System::getTempPath(), $file);
file_put_contents($tempfile, json_encode(['activity' => $activity, 'body' => $body, 'uid' => $uid, 'trust_source' => $trust_source, 'push' => $push, 'signer' => $signer, 'object_data' => $object_data], JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE | JSON_PRETTY_PRINT));
- Logger::notice('Unknown activity stored', ['type' => $type, 'object_type' => $object_data['object_type'], $object_data['object_object_type'] ?? '', 'file' => $tempfile]);
+ Logger::notice('Unknown activity stored', ['type' => $type, 'object_type' => $object_data['object_type'], 'object_object_type' => $object_data['object_object_type'] ?? '', 'file' => $tempfile]);
}
/**
$uid = 0;
$actor = JsonLD::fetchElement($activity, 'as:actor', '@id') ?? '';
- $receivers = self::getReceivers($activity, $actor);
+ $receivers = self::getReceivers($activity, $actor, [], false, false);
foreach ($receivers as $receiver) {
if ($receiver['type'] == self::TARGET_GLOBAL) {
return 0;
}
foreach ($receiver_list as $receiver) {
+ if ($receiver == 'Public') {
+ Logger::warning('Not compacted public collection found', ['activity' => $activity, 'callstack' => System::callstack(20)]);
+ $receiver = ActivityPub::PUBLIC_COLLECTION;
+ }
if ($receiver == self::PUBLIC_COLLECTION) {
$receiver = ActivityPub::PUBLIC_COLLECTION;
}
* Fetch the receiver list from an activity array
*
* @param array $activity
- * @param string $actor
- * @param array $tags
- * @param boolean $fetch_unlisted
+ * @param string $actor
+ * @param array $tags
+ * @param bool $fetch_unlisted
+ * @param bool $push
*
* @return array with receivers (user id)
* @throws \Exception
*/
- private static function getReceivers(array $activity, string $actor, array $tags = [], bool $fetch_unlisted = false): array
+ private static function getReceivers(array $activity, string $actor, array $tags, bool $fetch_unlisted, bool $push): array
{
$reply = $receivers = $profile = [];
$profile = APContact::getByURL($actor);
$followers = $profile['followers'] ?? '';
$is_forum = ($actor['type'] ?? '') == 'Group';
+ if ($push) {
+ Contact::updateByUrlIfNeeded($actor);
+ }
Logger::info('Got actor and followers', ['actor' => $actor, 'followers' => $followers]);
} else {
Logger::info('Empty actor', ['activity' => $activity]);
self::switchContacts($receivers, $actor);
+ // "birdsitelive" is a service that mirrors tweets into the fediverse
+ // These posts can be fetched without authentification, but are not marked as public
+ // We treat them as unlisted posts to be able to handle them.
+ if (empty($receivers) && $fetch_unlisted && Contact::isPlatform($actor, 'birdsitelive')) {
+ $receivers[0] = ['uid' => 0, 'type' => self::TARGET_GLOBAL];
+ $receivers[-1] = ['uid' => -1, 'type' => self::TARGET_GLOBAL];
+ Logger::notice('Post from "birdsitelive" is set to "unlisted"', ['id' => JsonLD::fetchElement($activity, '@id')]);
+ } elseif (empty($receivers)) {
+ Logger::notice('Post has got no receivers', ['fetch_unlisted' => $fetch_unlisted, 'actor' => $actor, 'id' => JsonLD::fetchElement($activity, '@id'), 'type' => JsonLD::fetchElement($activity, '@type')]);
+ }
+
return $receivers;
}
return $object_data;
}
- if ($type == 'as:Announce') {
- $object_id = JsonLD::fetchElement($object, 'object', '@id');
- if (empty($object_id) || !is_string($object_id)) {
- return false;
- }
- return self::fetchObject($object_id, [], false, $uid);
- }
-
Logger::info('Unhandled object type: ' . $type);
return false;
}
continue;
}
- $element = ['type' => str_replace('as:', '', JsonLD::fetchElement($tag, '@type')),
+ $element = ['type' => str_replace('as:', '', JsonLD::fetchElement($tag, '@type') ?? ''),
'href' => JsonLD::fetchElement($tag, 'as:href', '@id'),
'name' => JsonLD::fetchElement($tag, 'as:name', '@value')];
return false;
}
+ $object_data = self::getObjectDataFromActivity($object);
+
+ $receiverdata = self::getReceivers($object, $object_data['actor'] ?? '', $object_data['tags'], true, false);
+ $receivers = $reception_types = [];
+ foreach ($receiverdata as $key => $data) {
+ $receivers[$key] = $data['uid'];
+ $reception_types[$data['uid']] = $data['type'] ?? 0;
+ }
+
+ $object_data['receiver_urls'] = self::getReceiverURL($object);
+ $object_data['receiver'] = $receivers;
+ $object_data['reception_type'] = $reception_types;
+
+ $object_data['unlisted'] = in_array(-1, $object_data['receiver']);
+ unset($object_data['receiver'][-1]);
+ unset($object_data['reception_type'][-1]);
+
+ return $object_data;
+ }
+
+ /**
+ * Create an object data array from a given activity
+ *
+ * @param array $object
+ *
+ * @return array Object data
+ */
+ public static function getObjectDataFromActivity(array $object): array
+ {
$object_data = [];
$object_data['object_type'] = JsonLD::fetchElement($object, '@type');
$object_data['id'] = JsonLD::fetchElement($object, '@id');
$object_data['reply-to-id'] = $object_data['id'];
// On activities the "reply to" is the id of the object it refers to
- if (in_array($object_data['object_type'], self::ACTIVITY_TYPES)) {
+ if (in_array($object_data['object_type'], array_merge(self::ACTIVITY_TYPES, ['as:Announce']))) {
$object_id = JsonLD::fetchElement($object, 'as:object', '@id');
if (!empty($object_id)) {
$object_data['reply-to-id'] = $object_id;
$object_data['diaspora:comment'] = JsonLD::fetchElement($object, 'diaspora:comment', '@value');
$object_data['diaspora:like'] = JsonLD::fetchElement($object, 'diaspora:like', '@value');
$object_data['actor'] = $object_data['author'] = $actor;
- $object_data['context'] = JsonLD::fetchElement($object, 'as:context', '@id');
- $object_data['conversation'] = JsonLD::fetchElement($object, 'ostatus:conversation', '@id');
+ $element = JsonLD::fetchElement($object, 'as:context', '@id');
+ $object_data['context'] = $element != './' ? $element : null;
+ $element = JsonLD::fetchElement($object, 'ostatus:conversation', '@id');
+ $object_data['conversation'] = $element != './' ? $element : null;
$object_data['sensitive'] = JsonLD::fetchElement($object, 'as:sensitive');
$object_data['name'] = JsonLD::fetchElement($object, 'as:name', '@value');
$object_data['summary'] = JsonLD::fetchElement($object, 'as:summary', '@value');
$object_data['attachments'] = array_merge($object_data['attachments'], self::processAttachmentUrls($object['as:url'] ?? []));
}
+ // Support for quoted posts (Pleroma, Fedibird and Misskey)
+ $object_data['quote-url'] = JsonLD::fetchElement($object, 'as:quoteUrl', '@value');
+ if (empty($object_data['quote-url'])) {
+ $object_data['quote-url'] = JsonLD::fetchElement($object, 'fedibird:quoteUri', '@value');
+ }
+ if (empty($object_data['quote-url'])) {
+ $object_data['quote-url'] = JsonLD::fetchElement($object, 'misskey:_misskey_quote', '@value');
+ }
+
+ // Misskey adds some data to the standard "content" value for quoted posts for backwards compatibility.
+ // Their own "_misskey_content" value does then contain the content without this extra data.
+ if (!empty($object_data['quote-url'])) {
+ $misskey_content = JsonLD::fetchElement($object, 'misskey:_misskey_content', '@value');
+ if (!empty($misskey_content)) {
+ $object_data['content'] = $misskey_content;
+ }
+ }
+
// For page types we expect that the alternate url posts to some page.
// So we add this to the attachments if it differs from the id.
// Currently only Lemmy is using the page type.
$object_data['question'] = self::processQuestion($object);
}
- $receiverdata = self::getReceivers($object, $object_data['actor'] ?? '', $object_data['tags'], true);
- $receivers = $reception_types = [];
- foreach ($receiverdata as $key => $data) {
- $receivers[$key] = $data['uid'];
- $reception_types[$data['uid']] = $data['type'] ?? 0;
- }
-
- $object_data['receiver_urls'] = self::getReceiverURL($object);
- $object_data['receiver'] = $receivers;
- $object_data['reception_type'] = $reception_types;
+ return $object_data;
+ }
- $object_data['unlisted'] = in_array(-1, $object_data['receiver']);
- unset($object_data['receiver'][-1]);
- unset($object_data['reception_type'][-1]);
+ /**
+ * Add an object id to the list of arrived activities
+ *
+ * @param string $id
+ *
+ * @return void
+ */
+ private static function addArrivedId(string $id)
+ {
+ DBA::delete('arrived-activity', ["`received` < ?", DateTimeFormat::utc('now - 5 minutes')]);
+ DBA::insert('arrived-activity', ['object-id' => $id, 'received' => DateTimeFormat::utcNow()], Database::INSERT_IGNORE);
+ }
- return $object_data;
+ /**
+ * Checks if the given object already arrived before
+ *
+ * @param string $id
+ *
+ * @return boolean
+ */
+ private static function hasArrived(string $id): bool
+ {
+ return DBA::exists('arrived-activity', ['object-id' => $id]);
}
}
projects / friendica.git / blobdiff