]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/ActivityPub/Receiver.php
Merge remote-tracking branch 'upstream/2022.05-rc' into bulk-delivery
[friendica.git] / src / Protocol / ActivityPub / Receiver.php
index e82745b7556731fa4341e43319cb67a29104f02b..4a138729830d6c01fbad755482a8d89614ef95b1 100644 (file)
@@ -27,6 +27,8 @@ use Friendica\Content\Text\HTML;
 use Friendica\Content\Text\Markdown;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
+use Friendica\Core\System;
+use Friendica\DI;
 use Friendica\Model\Contact;
 use Friendica\Model\APContact;
 use Friendica\Model\Item;
@@ -37,6 +39,7 @@ use Friendica\Protocol\ActivityPub;
 use Friendica\Util\HTTPSignature;
 use Friendica\Util\JsonLD;
 use Friendica\Util\LDSignature;
+use Friendica\Util\Network;
 use Friendica\Util\Strings;
 
 /**
@@ -68,6 +71,12 @@ class Receiver
        const TARGET_ANSWER = 6;
        const TARGET_GLOBAL = 7;
 
+       const COMPLETION_NONE    = 0;
+       const COMPLETION_ANNOUCE = 1;
+       const COMPLETION_RELAY   = 2;
+       const COMPLETION_MANUAL  = 3;
+       const COMPLETION_AUTO    = 4;
+
        /**
         * Checks incoming message from the inbox
         *
@@ -190,7 +199,7 @@ class Receiver
                        return;
                }
 
-               $id = Processor::fetchMissingActivity($object_id, [], $actor);
+               $id = Processor::fetchMissingActivity($object_id, [], $actor, self::COMPLETION_RELAY);
                if (empty($id)) {
                        Logger::notice('Relayed message had not been fetched', ['id' => $object_id]);
                        return;
@@ -352,9 +361,9 @@ class Receiver
                        $object_data['object_object'] = JsonLD::fetchElement($activity['as:object'], 'as:object');
                        $object_data['object_type'] = JsonLD::fetchElement($activity['as:object'], '@type');
                        $object_data['push'] = $push;
-               } elseif (in_array($type, ['as:Create', 'as:Update', 'as:Announce']) || strpos($type, '#emojiReaction')) {
-               // Fetch the content only on activities where this matters
-               // We can receive "#emojiReaction" when fetching content from Hubzilla systems
+               } elseif (in_array($type, ['as:Create', 'as:Update', 'as:Announce', 'as:Invite']) || strpos($type, '#emojiReaction')) {
+                       // Fetch the content only on activities where this matters
+                       // We can receive "#emojiReaction" when fetching content from Hubzilla systems
                        // Always fetch on "Announce"
                        $object_data = self::fetchObject($object_id, $activity['as:object'], $trust_source && ($type != 'as:Announce'), $fetch_uid);
                        if (empty($object_data)) {
@@ -376,7 +385,7 @@ class Receiver
                        } else {
                                $object_data['directmessage'] = JsonLD::fetchElement($activity, 'litepub:directMessage');
                        }
-               } elseif (in_array($type, array_merge(self::ACTIVITY_TYPES, ['as:Follow'])) && in_array($object_type, self::CONTENT_TYPES)) {
+               } elseif (in_array($type, array_merge(self::ACTIVITY_TYPES, ['as:Follow', 'litepub:EmojiReact', 'as:View'])) && in_array($object_type, self::CONTENT_TYPES)) {
                        // Create a mostly empty array out of the activity data (instead of the object).
                        // This way we later don't have to check for the existence of each individual array element.
                        $object_data = self::processObject($activity);
@@ -385,7 +394,7 @@ class Receiver
                        $object_data['object_id'] = $object_id;
                        $object_data['object_type'] = ''; // Since we don't fetch the object, we don't know the type
                        $object_data['push'] = $push;
-               } elseif (in_array($type, ['as:Add'])) {
+               } elseif (in_array($type, ['as:Add', 'as:Remove'])) {
                        $object_data = [];
                        $object_data['id'] = JsonLD::fetchElement($activity, '@id');
                        $object_data['target_id'] = JsonLD::fetchElement($activity, 'as:target', '@id');
@@ -415,7 +424,7 @@ class Receiver
                }
 
                foreach (['as:to', 'as:cc', 'as:bto', 'as:bcc'] as $element) {
-                       if (!empty($urls[$element])) {
+                       if ((empty($object_data['receiver_urls'][$element]) || in_array($element, ['as:bto', 'as:bcc'])) && !empty($urls[$element])) {
                                $object_data['receiver_urls'][$element] = array_unique(array_merge($object_data['receiver_urls'][$element] ?? [], $urls[$element]));
                        }
                }
@@ -463,10 +472,11 @@ class Receiver
         * Processes the activity object
         *
         * @param array   $activity     Array with activity data
-        * @param string  $body
+        * @param string  $body         The unprocessed body
         * @param integer $uid          User ID
         * @param boolean $trust_source Do we trust the source?
         * @param boolean $push         Message had been pushed to our system
+        * @param array   $signer       The signer of the post
         * @throws \Exception
         */
        public static function processActivity($activity, string $body = '', int $uid = null, bool $trust_source = false, bool $push = false, array $signer = [])
@@ -529,6 +539,11 @@ class Receiver
                if (!empty($activity['thread-completion'])) {
                        $object_data['thread-completion'] = $activity['thread-completion'];
                }
+
+               if (!empty($activity['completion-mode'])) {
+                       $object_data['completion-mode'] = $activity['completion-mode'];
+               }
+
                if (!empty($activity['thread-children-type'])) {
                        $object_data['thread-children-type'] = $activity['thread-children-type'];
                }
@@ -538,23 +553,47 @@ class Receiver
                        $object_data['from-relay'] = $activity['from-relay'];
                }
 
+               if (in_array('as:Question', [$object_data['object_type'] ?? '', $object_data['object_object_type'] ?? ''])) {
+                       self::storeUnhandledActivity(false, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
+               }
+
                switch ($type) {
                        case 'as:Create':
                                if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
                                        $item = ActivityPub\Processor::createItem($object_data);
                                        ActivityPub\Processor::postItem($object_data, $item);
+                               } elseif (in_array($object_data['object_type'], ['pt:CacheFile'])) {
+                                       // Unhandled Peertube activity
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
+                               }
+                               break;
+
+                       case 'as:Invite':
+                               if (in_array($object_data['object_type'], ['as:Event'])) {
+                                       $item = ActivityPub\Processor::createItem($object_data);
+                                       ActivityPub\Processor::postItem($object_data, $item);
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
                        case 'as:Add':
                                if ($object_data['object_type'] == 'as:tag') {
                                        ActivityPub\Processor::addTag($object_data);
+                               } elseif (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
+                                       ActivityPub\Processor::addToFeaturedCollection($object_data);
+                               } elseif ($object_data['object_type'] == '') {
+                                       // The object type couldn't be determined. We don't have it and we can't fetch it. We ignore this activity.
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
                        case 'as:Announce':
                                if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
                                        $object_data['thread-completion'] = Contact::getIdForURL($actor);
+                                       $object_data['completion-mode']   = self::COMPLETION_ANNOUCE;
 
                                        $item = ActivityPub\Processor::createItem($object_data);
                                        if (empty($item)) {
@@ -576,24 +615,36 @@ class Receiver
                                        }
 
                                        ActivityPub\Processor::createActivity($announce_object_data, Activity::ANNOUNCE);
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
                        case 'as:Like':
                                if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
                                        ActivityPub\Processor::createActivity($object_data, Activity::LIKE);
+                               } elseif ($object_data['object_type'] == '') {
+                                       // The object type couldn't be determined. We don't have it and we can't fetch it. We ignore this activity.
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
                        case 'as:Dislike':
                                if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
                                        ActivityPub\Processor::createActivity($object_data, Activity::DISLIKE);
+                               } elseif ($object_data['object_type'] == '') {
+                                       // The object type couldn't be determined. We don't have it and we can't fetch it. We ignore this activity.
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
                        case 'as:TentativeAccept':
                                if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
                                        ActivityPub\Processor::createActivity($object_data, Activity::ATTENDMAYBE);
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
@@ -602,14 +653,40 @@ class Receiver
                                        ActivityPub\Processor::updateItem($object_data);
                                } elseif (in_array($object_data['object_type'], self::ACCOUNT_TYPES)) {
                                        ActivityPub\Processor::updatePerson($object_data);
+                               } elseif (in_array($object_data['object_type'], ['pt:CacheFile'])) {
+                                       // Unhandled Peertube activity
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
                        case 'as:Delete':
-                               if ($object_data['object_type'] == 'as:Tombstone') {
+                               if (in_array($object_data['object_type'], array_merge(['as:Tombstone'], self::CONTENT_TYPES))) {
                                        ActivityPub\Processor::deleteItem($object_data);
                                } elseif (in_array($object_data['object_type'], self::ACCOUNT_TYPES)) {
                                        ActivityPub\Processor::deletePerson($object_data);
+                               } elseif ($object_data['object_type'] == '') {
+                                       // The object type couldn't be determined. Most likely we don't have it here. We ignore this activity.
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
+                               }
+                               break;
+
+                       case 'as:Block':
+                               if (in_array($object_data['object_type'], self::ACCOUNT_TYPES)) {
+                                       ActivityPub\Processor::blockAccount($object_data);
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
+                               }
+                               break;
+
+                       case 'as:Remove':
+                               if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
+                                       ActivityPub\Processor::removeFromFeaturedCollection($object_data);                                      
+                               } elseif ($object_data['object_type'] == '') {
+                                       // The object type couldn't be determined. We don't have it and we can't fetch it. We ignore this activity.
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
@@ -619,6 +696,8 @@ class Receiver
                                } elseif (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
                                        $object_data['reply-to-id'] = $object_data['object_id'];
                                        ActivityPub\Processor::createActivity($object_data, Activity::FOLLOW);
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
@@ -627,6 +706,8 @@ class Receiver
                                        ActivityPub\Processor::acceptFollowUser($object_data);
                                } elseif (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
                                        ActivityPub\Processor::createActivity($object_data, Activity::ATTEND);
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
@@ -635,6 +716,8 @@ class Receiver
                                        ActivityPub\Processor::rejectFollowUser($object_data);
                                } elseif (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
                                        ActivityPub\Processor::createActivity($object_data, Activity::ATTENDNO);
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
@@ -642,21 +725,91 @@ class Receiver
                                if (($object_data['object_type'] == 'as:Follow') &&
                                        in_array($object_data['object_object_type'], self::ACCOUNT_TYPES)) {
                                        ActivityPub\Processor::undoFollowUser($object_data);
+                               } elseif (($object_data['object_type'] == 'as:Follow') &&
+                                       in_array($object_data['object_object_type'], self::CONTENT_TYPES)) {
+                                       ActivityPub\Processor::undoActivity($object_data);
                                } elseif (($object_data['object_type'] == 'as:Accept') &&
                                        in_array($object_data['object_object_type'], self::ACCOUNT_TYPES)) {
                                        ActivityPub\Processor::rejectFollowUser($object_data);
-                               } elseif (in_array($object_data['object_type'], self::ACTIVITY_TYPES) &&
-                                       in_array($object_data['object_object_type'], self::CONTENT_TYPES)) {
+                               } elseif (($object_data['object_type'] == 'as:Block') &&
+                                       in_array($object_data['object_object_type'], self::ACCOUNT_TYPES)) {
+                                       ActivityPub\Processor::unblockAccount($object_data);
+                               } elseif (in_array($object_data['object_type'], array_merge(self::ACTIVITY_TYPES, ['as:Announce'])) &&
+                                       in_array($object_data['object_object_type'], array_merge(['as:Tombstone'], self::CONTENT_TYPES))) {
                                        ActivityPub\Processor::undoActivity($object_data);
+                               } elseif (in_array($object_data['object_type'], array_merge(self::ACTIVITY_TYPES, ['as:Announce', 'as:Create', ''])) &&
+                                       empty($object_data['object_object_type'])) {
+                                       // We cannot detect the target object. So we can ignore it.
+                               } elseif (in_array($object_data['object_type'], ['as:Create']) &&
+                                       in_array($object_data['object_object_type'], ['pt:CacheFile'])) {
+                                       // Unhandled Peertube activity
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
                                break;
 
+                       case 'as:View':
+                               if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
+                                       ActivityPub\Processor::createActivity($object_data, Activity::VIEW);
+                               } elseif ($object_data['object_type'] == '') {
+                                       // The object type couldn't be determined. Most likely we don't have it here. We ignore this activity.
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
+                               }
+                               break;
+
+                       case 'litepub:EmojiReact':
+                               if (in_array($object_data['object_type'], self::CONTENT_TYPES)) {
+                                       ActivityPub\Processor::createActivity($object_data, Activity::EMOJIREACT);
+                               } elseif ($object_data['object_type'] == '') {
+                                       // The object type couldn't be determined. We don't have it and we can't fetch it. We ignore this activity.
+                               } else {
+                                       self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
+                               }
+                               break;
+       
                        default:
                                Logger::info('Unknown activity: ' . $type . ' ' . $object_data['object_type']);
+                               self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                break;
                }
        }
 
+       /**
+        * Stores unhandled or unknown Activities as a file
+        *
+        * @param boolean $unknown      "true" if the activity is unknown, "false" if it is unhandled
+        * @param string  $type         Activity type
+        * @param array   $object_data  Preprocessed array that is generated out of the received activity
+        * @param array   $activity     Array with activity data
+        * @param string  $body         The unprocessed body
+        * @param integer $uid          User ID
+        * @param boolean $trust_source Do we trust the source?
+        * @param boolean $push         Message had been pushed to our system
+        * @param array   $signer       The signer of the post
+        * @return void
+        */
+       private static function storeUnhandledActivity(bool $unknown, string $type, array $object_data, array $activity, string $body = '', int $uid = null, bool $trust_source = false, bool $push = false, array $signer = [])
+       {
+               if (!DI::config()->get('debug', 'ap_log_unknown')) {
+                       return;
+               }
+
+               $file = ($unknown  ? 'unknown-' : 'unhandled-') . str_replace(':', '-', $type) . '-';
+       
+               if (!empty($object_data['object_type'])) {
+                       $file .= str_replace(':', '-', $object_data['object_type']) . '-';
+               }
+
+               if (!empty($object_data['object_object_type'])) {
+                       $file .= str_replace(':', '-', $object_data['object_object_type']) . '-';
+               }
+
+               $tempfile = tempnam(System::getTempPath(), $file);
+               file_put_contents($tempfile, json_encode(['activity' => $activity, 'body' => $body, 'uid' => $uid, 'trust_source' => $trust_source, 'push' => $push, 'signer' => $signer, 'object_data' => $object_data], JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE | JSON_PRETTY_PRINT));
+               Logger::notice('Unknown activity stored', ['type' => $type, 'object_type' => $object_data['object_type'], $object_data['object_object_type'] ?? '', 'file' => $tempfile]);
+       }
+
        /**
         * Fetch a user id from an activity array
         *
@@ -785,7 +938,7 @@ class Receiver
 
                                // Fetch the receivers for the public and the followers collection
                                if ((($receiver == $followers) || (($receiver == self::PUBLIC_COLLECTION) && !$is_forum)) && !empty($actor)) {
-                                       $receivers = self::getReceiverForActor($actor, $tags, $receivers, $follower_target);
+                                       $receivers = self::getReceiverForActor($actor, $tags, $receivers, $follower_target, $profile);
                                        continue;
                                }
 
@@ -847,33 +1000,46 @@ class Receiver
         * @param array   $tags
         * @param array   $receivers
         * @param integer $target_type
+        * @param array   $profile
         *
         * @return array with receivers (user id)
         * @throws \Exception
         */
-       private static function getReceiverForActor($actor, $tags, $receivers, $target_type)
+       private static function getReceiverForActor($actor, $tags, $receivers, $target_type, $profile)
        {
                $basecondition = ['rel' => [Contact::SHARING, Contact::FRIEND, Contact::FOLLOWER],
                        'network' => Protocol::FEDERATED, 'archive' => false, 'pending' => false];
 
-               $condition = DBA::mergeConditions($basecondition, ["`nurl` = ? AND `uid` != ?", Strings::normaliseLink($actor), 0]);
-               $contacts = DBA::select('contact', ['uid', 'rel'], $condition);
-               while ($contact = DBA::fetch($contacts)) {
-                       if (empty($receivers[$contact['uid']]) && self::isValidReceiverForActor($contact, $tags)) {
-                               $receivers[$contact['uid']] = ['uid' => $contact['uid'], 'type' => $target_type];
+               if (!empty($profile['uri-id'])) {
+                       $condition = DBA::mergeConditions($basecondition, ["`uri-id` = ? AND `uid` != ?", $profile['uri-id'], 0]);
+                       $contacts = DBA::select('contact', ['uid', 'rel'], $condition);
+                       while ($contact = DBA::fetch($contacts)) {
+                               if (empty($receivers[$contact['uid']]) && self::isValidReceiverForActor($contact, $tags)) {
+                                       $receivers[$contact['uid']] = ['uid' => $contact['uid'], 'type' => $target_type];
+                               }
                        }
-               }
-               DBA::close($contacts);
-
-               // The queries are split because of performance issues
-               $condition = DBA::mergeConditions($basecondition, ["`alias` IN (?, ?) AND `uid` != ?", Strings::normaliseLink($actor), $actor, 0]);
-               $contacts = DBA::select('contact', ['uid', 'rel'], $condition);
-               while ($contact = DBA::fetch($contacts)) {
-                       if (empty($receivers[$contact['uid']]) && self::isValidReceiverForActor($contact, $tags)) {
-                               $receivers[$contact['uid']] = ['uid' => $contact['uid'], 'type' => $target_type];
+                       DBA::close($contacts);
+               } else {
+                       // This part will only be called while post update 1426 wasn't finished
+                       $condition = DBA::mergeConditions($basecondition, ["`nurl` = ? AND `uid` != ?", Strings::normaliseLink($actor), 0]);
+                       $contacts = DBA::select('contact', ['uid', 'rel'], $condition);
+                       while ($contact = DBA::fetch($contacts)) {
+                               if (empty($receivers[$contact['uid']]) && self::isValidReceiverForActor($contact, $tags)) {
+                                       $receivers[$contact['uid']] = ['uid' => $contact['uid'], 'type' => $target_type];
+                               }
+                       }
+                       DBA::close($contacts);
+
+                       // The queries are split because of performance issues
+                       $condition = DBA::mergeConditions($basecondition, ["`alias` IN (?, ?) AND `uid` != ?", Strings::normaliseLink($actor), $actor, 0]);
+                       $contacts = DBA::select('contact', ['uid', 'rel'], $condition);
+                       while ($contact = DBA::fetch($contacts)) {
+                               if (empty($receivers[$contact['uid']]) && self::isValidReceiverForActor($contact, $tags)) {
+                                       $receivers[$contact['uid']] = ['uid' => $contact['uid'], 'type' => $target_type];
+                               }
                        }
+                       DBA::close($contacts);
                }
-               DBA::close($contacts);
                return $receivers;
        }
 
@@ -1287,6 +1453,65 @@ class Receiver
                return $attachlist;
        }
 
+       /**
+        * Convert questions from JSON-LD format into a simplified format
+        *
+        * @param array $object
+        *
+        * @return array Questions in a simplified format
+        */
+       private static function processQuestion(array $object)
+       {
+               $question = [];
+
+               if (!empty($object['as:oneOf'])) {
+                       $question['multiple'] = false;
+                       $options = JsonLD::fetchElementArray($object, 'as:oneOf') ?? [];
+               } elseif (!empty($object['as:anyOf'])) {
+                       $question['multiple'] = true;
+                       $options = JsonLD::fetchElementArray($object, 'as:anyOf') ?? [];
+               } else {
+                       return [];
+               }
+
+               $closed = JsonLD::fetchElement($object, 'as:closed', '@value');
+               if (!empty($closed)) {
+                       $question['end-time'] = $closed;
+               } else {
+                       $question['end-time'] = JsonLD::fetchElement($object, 'as:endTime', '@value');
+               }
+
+               $question['voters']  = (int)JsonLD::fetchElement($object, 'toot:votersCount', '@value');
+               $question['options'] = [];
+
+               $voters = 0;
+
+               foreach ($options as $option) {
+                       if (JsonLD::fetchElement($option, '@type') != 'as:Note') {
+                               continue;
+                       }
+
+                       $name = JsonLD::fetchElement($option, 'as:name', '@value');
+
+                       if (empty($option['as:replies'])) {
+                               continue;
+                       }
+
+                       $replies = JsonLD::fetchElement($option['as:replies'], 'as:totalItems', '@value');
+
+                       $question['options'][] = ['name' => $name, 'replies' => $replies];
+
+                       $voters += (int)$replies;
+               }
+
+               // For single choice question we can count the number of voters if not provided (like with Misskey)
+               if (empty($question['voters']) && !$question['multiple']) {
+                       $question['voters'] = $voters;
+               }
+
+               return $question;
+       }
+
        /**
         * Fetch the original source or content with the "language" Markdown or HTML
         *
@@ -1521,6 +1746,10 @@ class Receiver
                        }
                }
 
+               if (!empty($object_data['alternate-url']) && !Network::isValidHttpUrl($object_data['alternate-url'])) {
+                       $object_data['alternate-url'] = null;
+               }
+
                if (in_array($object_data['object_type'], ['as:Audio', 'as:Video'])) {
                        $object_data['alternate-url'] = self::extractAlternateUrl($object['as:url'] ?? []) ?: $object_data['alternate-url'];
                        $object_data['attachments'] = array_merge($object_data['attachments'], self::processAttachmentUrls($object['as:url'] ?? []));
@@ -1534,6 +1763,10 @@ class Receiver
                        $object_data['alternate-url'] = null;
                }
 
+               if ($object_data['object_type'] == 'as:Question') {
+                       $object_data['question'] = self::processQuestion($object);
+               }
+
                $receiverdata = self::getReceivers($object, $object_data['actor'], $object_data['tags'], true);
                $receivers = $reception_types = [];
                foreach ($receiverdata as $key => $data) {