]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/ActivityPub/Receiver.php
Remove entries from queue / relay detection
[friendica.git] / src / Protocol / ActivityPub / Receiver.php
index 2a56e9e5e793c0336c81e162ad4de3e533cf2fcc..4d7309001604e36e72378960b30c267661c18eb8 100644 (file)
@@ -28,6 +28,7 @@ use Friendica\Content\Text\Markdown;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
 use Friendica\Core\System;
+use Friendica\Database\Database;
 use Friendica\DI;
 use Friendica\Model\Contact;
 use Friendica\Model\APContact;
@@ -36,6 +37,7 @@ use Friendica\Model\Post;
 use Friendica\Model\User;
 use Friendica\Protocol\Activity;
 use Friendica\Protocol\ActivityPub;
+use Friendica\Util\DateTimeFormat;
 use Friendica\Util\HTTPSignature;
 use Friendica\Util\JsonLD;
 use Friendica\Util\LDSignature;
@@ -97,12 +99,13 @@ class Receiver
                $ldactivity = JsonLD::compact($activity);
 
                $actor = JsonLD::fetchElement($ldactivity, 'as:actor', '@id') ?? '';
+
                $apcontact = APContact::getByURL($actor);
 
                if (empty($apcontact)) {
                        Logger::notice('Unable to retrieve AP contact for actor - message is discarded', ['actor' => $actor]);
                        return;
-               } elseif ($apcontact['type'] == 'Application' && $apcontact['nick'] == 'relay') {
+               } elseif (APContact::isRelay($apcontact)) {
                        self::processRelayPost($ldactivity, $actor);
                        return;
                } else {
@@ -153,10 +156,47 @@ class Receiver
                }
 
                $fetchQueue = new FetchQueue();
-               self::processActivity($fetchQueue, $ldactivity, $body, $uid, $trust_source, true, $signer);
+               self::processActivity($fetchQueue, $ldactivity, $body, $uid, $trust_source, true, $signer, $http_signer);
                $fetchQueue->process();
        }
 
+       private static function enqueuePost(array $ldactivity = [], string $type, int $uid, string $http_signer): array
+       {
+               $fields = [
+                       'activity-id' => $ldactivity['id'],
+                       'object-id' => $ldactivity['object_id'],
+                       'type' => $type,
+                       'object-type' => $ldactivity['object_type'],
+                       'activity' => json_encode($ldactivity, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE | JSON_PRETTY_PRINT),
+                       'received' => DateTimeFormat::utcNow(),
+               ];
+
+               if (!empty($ldactivity['object_object_type'])) {
+                       $fields['object-object-type'] = $ldactivity['object_object_type'];
+               }
+
+               if (!empty($http_signer)) {
+                       $fields['signer'] = $http_signer;
+               }
+
+               DBA::insert('inbox-entry', $fields, Database::INSERT_IGNORE);
+
+               $queue = DBA::selectFirst('inbox-entry', ['id'], ['activity-id' => $ldactivity['id']]);
+               if (!empty($queue['id'])) {
+                       $ldactivity['entry-id'] = $queue['id'];
+                       DBA::insert('inbox-entry-receiver', ['queue-id' => $queue['id'], 'uid' => $uid], Database::INSERT_IGNORE);
+               }
+               return $ldactivity;
+       }
+
+       public static function removeFromQueue(array $activity = [])
+       {
+               if (empty($activity['entry-id'])) {
+                       return;
+               }
+               DBA::delete('inbox-entry', ['id' => $activity['entry-id']]);
+       }
+
        /**
         * Process incoming posts from relays
         *
@@ -168,18 +208,18 @@ class Receiver
        {
                $type = JsonLD::fetchElement($activity, '@type');
                if (!$type) {
-                       Logger::info('Empty type', ['activity' => $activity]);
+                       Logger::info('Empty type', ['activity' => $activity, 'actor' => $actor]);
                        return;
                }
 
                if ($type != 'as:Announce') {
-                       Logger::info('Not an announcement', ['activity' => $activity]);
+                       Logger::info('Not an announcement', ['activity' => $activity, 'actor' => $actor]);
                        return;
                }
 
                $object_id = JsonLD::fetchElement($activity, 'as:object', '@id');
                if (empty($object_id)) {
-                       Logger::info('No object id found', ['activity' => $activity]);
+                       Logger::info('No object id found', ['activity' => $activity, 'actor' => $actor]);
                        return;
                }
 
@@ -194,11 +234,11 @@ class Receiver
                        return;
                }
 
-               Logger::info('Got relayed message id', ['id' => $object_id]);
+               Logger::info('Got relayed message id', ['id' => $object_id, 'actor' => $actor]);
 
                $item_id = Item::searchByLink($object_id);
                if ($item_id) {
-                       Logger::info('Relayed message already exists', ['id' => $object_id, 'item' => $item_id]);
+                       Logger::info('Relayed message already exists', ['id' => $object_id, 'item' => $item_id, 'actor' => $actor]);
                        return;
                }
 
@@ -206,7 +246,7 @@ class Receiver
 
                $id = Processor::fetchMissingActivity($fetchQueue, $object_id, [], $actor, self::COMPLETION_RELAY);
                if (empty($id)) {
-                       Logger::notice('Relayed message had not been fetched', ['id' => $object_id]);
+                       Logger::notice('Relayed message had not been fetched', ['id' => $object_id, 'actor' => $actor]);
                        return;
                }
 
@@ -214,9 +254,9 @@ class Receiver
 
                $item_id = Item::searchByLink($object_id);
                if ($item_id) {
-                       Logger::info('Relayed message had been fetched and stored', ['id' => $object_id, 'item' => $item_id]);
+                       Logger::info('Relayed message had been fetched and stored', ['id' => $object_id, 'item' => $item_id, 'actor' => $actor]);
                } else {
-                       Logger::notice('Relayed message had not been stored', ['id' => $object_id]);
+                       Logger::notice('Relayed message had not been stored', ['id' => $object_id, 'actor' => $actor]);
                }
        }
 
@@ -488,7 +528,7 @@ class Receiver
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         * @throws \ImagickException
         */
-       public static function processActivity(FetchQueue $fetchQueue, array $activity, string $body = '', int $uid = null, bool $trust_source = false, bool $push = false, array $signer = [])
+       public static function processActivity(FetchQueue $fetchQueue, array $activity, string $body = '', int $uid = null, bool $trust_source = false, bool $push = false, array $signer = [], string $http_signer = '')
        {
                $type = JsonLD::fetchElement($activity, '@type');
                if (!$type) {
@@ -562,6 +602,8 @@ class Receiver
                        $object_data['from-relay'] = $activity['from-relay'];
                }
 
+               $object_data = self::enqueuePost($object_data, $type, $uid, $http_signer);
+
                if (in_array('as:Question', [$object_data['object_type'] ?? '', $object_data['object_object_type'] ?? ''])) {
                        self::storeUnhandledActivity(false, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                }
@@ -573,6 +615,7 @@ class Receiver
                                        ActivityPub\Processor::postItem($object_data, $item);
                                } elseif (in_array($object_data['object_type'], ['pt:CacheFile'])) {
                                        // Unhandled Peertube activity
+                                       self::removeFromQueue($object_data);
                                } else {
                                        self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
@@ -664,6 +707,7 @@ class Receiver
                                        ActivityPub\Processor::updatePerson($object_data);
                                } elseif (in_array($object_data['object_type'], ['pt:CacheFile'])) {
                                        // Unhandled Peertube activity
+                                       self::removeFromQueue($object_data);
                                } else {
                                        self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
@@ -749,9 +793,11 @@ class Receiver
                                } elseif (in_array($object_data['object_type'], array_merge(self::ACTIVITY_TYPES, ['as:Announce', 'as:Create', ''])) &&
                                        empty($object_data['object_object_type'])) {
                                        // We cannot detect the target object. So we can ignore it.
+                                       self::removeFromQueue($object_data);
                                } elseif (in_array($object_data['object_type'], ['as:Create']) &&
                                        in_array($object_data['object_object_type'], ['pt:CacheFile'])) {
                                        // Unhandled Peertube activity
+                                       self::removeFromQueue($object_data);
                                } else {
                                        self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
@@ -762,6 +808,7 @@ class Receiver
                                        ActivityPub\Processor::createActivity($fetchQueue, $object_data, Activity::VIEW);
                                } elseif ($object_data['object_type'] == '') {
                                        // The object type couldn't be determined. Most likely we don't have it here. We ignore this activity.
+                                       self::removeFromQueue($object_data);
                                } else {
                                        self::storeUnhandledActivity(true, $type, $object_data, $activity, $body, $uid, $trust_source, $push, $signer);
                                }
@@ -801,6 +848,7 @@ class Receiver
        private static function storeUnhandledActivity(bool $unknown, string $type, array $object_data, array $activity, string $body = '', int $uid = null, bool $trust_source = false, bool $push = false, array $signer = [])
        {
                if (!DI::config()->get('debug', 'ap_log_unknown')) {
+                       self::removeFromQueue($activity);
                        return;
                }