} else {
Logger::notice('Relayed message had not been fetched', ['id' => $object_id, 'actor' => $actor, 'activity' => $activity]);
}
- } elseif (!Fetch::hasWorker($object_id)) {
+ } elseif (!Fetch::hasWorker($object_id)) {
Logger::notice('Fetching is done by worker.', ['id' => $object_id]);
Fetch::add($object_id);
$activity['recursion-depth'] = 0;
$object_data['object_id'] = $object_id;
- // Test if it is an answer to a mail
- if (DBA::exists('mail', ['uri' => $object_data['reply-to-id']])) {
+ // Test if it is a direct message
+ if (self::checkForDirectMessage($object_data, $activity)) {
$object_data['directmessage'] = true;
- } else {
- $object_data['directmessage'] = JsonLD::fetchElement($activity, 'litepub:directMessage');
-
- if (!empty(JsonLD::fetchElement($activity['as:object'], 'misskey:_misskey_talk'))) {
- $object_data = self::setChatData($object_data, $receivers);
- }
+ } elseif (!empty(JsonLD::fetchElement($activity['as:object'], 'misskey:_misskey_talk'))) {
+ $object_data = self::setChatData($object_data, $receivers);
}
} elseif (in_array($type, array_merge(self::ACTIVITY_TYPES, ['as:Announce', 'as:Follow'])) && in_array($object_type, self::CONTENT_TYPES)) {
// Create a mostly empty array out of the activity data (instead of the object).
$object_data['receiver'] = array_replace($object_data['receiver'] ?? [], $receivers);
$object_data['reception_type'] = array_replace($object_data['reception_type'] ?? [], $reception_types);
-// This check here interferes with Hubzilla posts where the author host differs from the host the post was created
-// $author = $object_data['author'] ?? $actor;
-// if (!empty($author) && !empty($object_data['id'])) {
-// $author_host = parse_url($author, PHP_URL_HOST);
-// $id_host = parse_url($object_data['id'], PHP_URL_HOST);
-// if ($author_host == $id_host) {
-// Logger::info('Valid hosts', ['type' => $type, 'host' => $id_host]);
-// } else {
-// Logger::notice('Differing hosts on author and id', ['type' => $type, 'author' => $author_host, 'id' => $id_host]);
-// $trust_source = false;
-// }
-// }
-
$account = Contact::selectFirstAccount(['platform'], ['nurl' => Strings::normaliseLink($actor)]);
$platform = $account['platform'] ?? '';
return $object_data;
}
+ /**
+ * Check if the received message is a direct message
+ *
+ * @param array $object_data
+ * @param array $activity
+ * @return boolean
+ */
+ private static function checkForDirectMessage(array $object_data, array $activity): bool
+ {
+ if (DBA::exists('mail', ['uri' => $object_data['reply-to-id']])) {
+ return true;
+ }
+
+ if ($object_data['id'] != $object_data['reply-to-id']) {
+ return false;
+ }
+
+ if (JsonLD::fetchElement($activity, 'litepub:directMessage')) {
+ return true;
+ }
+
+ if (!empty($object_data['attachments'])) {
+ return false;
+ }
+
+ if (!empty($object_data['receiver_urls']['as:cc']) || empty($object_data['receiver_urls']['as:to'])) {
+ return false;
+ }
+
+ if ((count($object_data['receiver_urls']['as:to']) != 1) || !User::getIdForURL($object_data['receiver_urls']['as:to'][0])) {
+ return false;
+ }
+
+ $mentions = 0;
+ foreach ($object_data['tags'] as $mention) {
+ if ($mention['type'] != 'Mention') {
+ continue;
+ }
+ if (!User::getIdForURL($mention['href'])) {
+ return false;
+ }
+ ++$mentions;
+ }
+
+ if ($mentions > 1) {
+ return false;
+ }
+
+ return true;
+ }
+
private static function setChatData(array $object_data, array $receivers): array
{
if (count($receivers) != 1) {
self::addArrivedId($object_data['object_id']);
}
- $decouple = DI::config()->get('system', 'decoupled_receiver') && !in_array($completion, [self::COMPLETION_MANUAL, self::COMPLETION_ANNOUNCE]);
+ $decouple = DI::config()->get('system', 'decoupled_receiver') && !in_array($completion, [self::COMPLETION_MANUAL, self::COMPLETION_ANNOUNCE]) && empty($object_data['directmessage']);
if ($decouple && ($trust_source || DI::config()->get('debug', 'ap_inbox_store_untrusted'))) {
$object_data = Queue::add($object_data, $type, $uid, $http_signer, $push, $trust_source);
* @param boolean $unknown "true" if the activity is unknown, "false" if it is unhandled
* @param string $type Activity type
* @param array $object_data Preprocessed array that is generated out of the received activity
- * @param array $activity Array with activity data
+ * @param array $activity Array with activity data
* @param string $body The unprocessed body
* @param integer $uid User ID
* @param boolean $trust_source Do we trust the source?
*
* @return int user id
*/
- public static function getBestUserForActivity(array $activity, string $actor = ''): int
+ private static function getBestUserForActivity(array $activity, string $actor): int
{
$uid = 0;
$actor = $actor ?: JsonLD::fetchElement($activity, 'as:actor', '@id') ?? '';
$isGroup = false;
}
+ $parent_followers = '';
+ $parent = Post::selectFirstPost(['parent-author-link'], ['uri' => $reply]);
+ if (!empty($parent['parent-author-link'])) {
+ $parent_profile = APContact::getByURL($parent['parent-author-link']);
+ if (!in_array($parent_profile['followers'] ?? '', ['', $followers])) {
+ $parent_followers = $parent_profile['followers'];
+ }
+ }
+
// We have to prevent false follower assumptions upon thread completions
$follower_target = empty($activity['thread-completion']) ? self::TARGET_FOLLOWER : self::TARGET_UNKNOWN;
- foreach (['as:to', 'as:cc', 'as:bto', 'as:bcc','as:audience'] as $element) {
+ foreach (['as:to', 'as:cc', 'as:bto', 'as:bcc', 'as:audience'] as $element) {
$receiver_list = JsonLD::fetchElementArray($activity, $element, '@id');
if (empty($receiver_list)) {
continue;
}
// Fetch the receivers for the public and the followers collection
- if ((($receiver == $followers) || (($receiver == self::PUBLIC_COLLECTION) && !$isGroup) || ($isGroup && ($element == 'as:audience'))) && !empty($actor)) {
- $receivers = self::getReceiverForActor($actor, $tags, $receivers, $follower_target, $profile);
+ if ((($receiver == $followers) || (($receiver == self::PUBLIC_COLLECTION) && !$isGroup) || ($isGroup && ($element == 'as:audience'))) && !empty($profile)) {
+ $receivers = self::getReceiverForActor($tags, $receivers, $follower_target, $profile);
+ continue;
+ }
+
+ if ($receiver == $parent_followers) {
+ $receivers = self::getReceiverForActor([], $receivers, $follower_target, $parent_profile);
continue;
}
/**
* Fetch the receiver list of a given actor
*
- * @param string $actor
* @param array $tags
* @param array $receivers
* @param integer $target_type
* @return array with receivers (user id)
* @throws \Exception
*/
- private static function getReceiverForActor(string $actor, array $tags, array $receivers, int $target_type, array $profile): array
+ private static function getReceiverForActor(array $tags, array $receivers, int $target_type, array $profile): array
{
$basecondition = ['rel' => [Contact::SHARING, Contact::FRIEND, Contact::FOLLOWER],
'network' => Protocol::FEDERATED, 'archive' => false, 'pending' => false];
- if (!empty($profile['uri-id'])) {
- $condition = DBA::mergeConditions($basecondition, ["`uri-id` = ? AND `uid` != ?", $profile['uri-id'], 0]);
- $contacts = DBA::select('contact', ['uid', 'rel'], $condition);
- while ($contact = DBA::fetch($contacts)) {
- if (empty($receivers[$contact['uid']]) && self::isValidReceiverForActor($contact, $tags)) {
- $receivers[$contact['uid']] = ['uid' => $contact['uid'], 'type' => $target_type];
- }
+ $condition = DBA::mergeConditions($basecondition, ["`uri-id` = ? AND `uid` != ?", $profile['uri-id'], 0]);
+ $contacts = DBA::select('contact', ['uid', 'rel'], $condition);
+ while ($contact = DBA::fetch($contacts)) {
+ if (empty($receivers[$contact['uid']]) && self::isValidReceiverForActor($contact, $tags)) {
+ $receivers[$contact['uid']] = ['uid' => $contact['uid'], 'type' => $target_type];
}
- DBA::close($contacts);
- } else {
- // This part will only be called while post update 1426 wasn't finished
- $condition = DBA::mergeConditions($basecondition, ["`nurl` = ? AND `uid` != ?", Strings::normaliseLink($actor), 0]);
- $contacts = DBA::select('contact', ['uid', 'rel'], $condition);
- while ($contact = DBA::fetch($contacts)) {
- if (empty($receivers[$contact['uid']]) && self::isValidReceiverForActor($contact, $tags)) {
- $receivers[$contact['uid']] = ['uid' => $contact['uid'], 'type' => $target_type];
- }
- }
- DBA::close($contacts);
-
- // The queries are split because of performance issues
- $condition = DBA::mergeConditions($basecondition, ["`alias` IN (?, ?) AND `uid` != ?", Strings::normaliseLink($actor), $actor, 0]);
- $contacts = DBA::select('contact', ['uid', 'rel'], $condition);
- while ($contact = DBA::fetch($contacts)) {
- if (empty($receivers[$contact['uid']]) && self::isValidReceiverForActor($contact, $tags)) {
- $receivers[$contact['uid']] = ['uid' => $contact['uid'], 'type' => $target_type];
- }
- }
- DBA::close($contacts);
}
+ DBA::close($contacts);
+
return $receivers;
}
continue;
}
- $element = ['type' => str_replace('as:', '', JsonLD::fetchElement($tag, '@type') ?? ''),
+ $element = [
+ 'type' => str_replace('as:', '', JsonLD::fetchElement($tag, '@type') ?? ''),
'href' => JsonLD::fetchElement($tag, 'as:href', '@id'),
- 'name' => JsonLD::fetchElement($tag, 'as:name', '@value')];
+ 'name' => JsonLD::fetchElement($tag, 'as:name', '@value')
+ ];
if (empty($element['type'])) {
continue;
}
$url = JsonLD::fetchElement($emoji['as:icon'], 'as:url', '@id');
- $element = ['name' => JsonLD::fetchElement($emoji, 'as:name', '@value'),
- 'href' => $url];
+ $element = [
+ 'name' => JsonLD::fetchElement($emoji, 'as:name', '@value'),
+ 'href' => $url
+ ];
$emojilist[] = $element;
}