]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/ActivityPub/Transmitter.php
Merge pull request #8554 from annando/fix-8551
[friendica.git] / src / Protocol / ActivityPub / Transmitter.php
index 23301456a98b178291927b1174f5a066b88822fc..0e5056dbe5e83d3b3f49ad0da946bf94a651e2ec 100644 (file)
@@ -1,7 +1,24 @@
 <?php
 /**
- * @file src/Protocol/ActivityPub/Transmitter.php
+ * @copyright Copyright (C) 2020, Friendica
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
  */
+
 namespace Friendica\Protocol\ActivityPub;
 
 use Friendica\Content\Feature;
@@ -39,7 +56,7 @@ require_once 'mod/share.php';
  * ActivityPub Transmitter Protocol class
  *
  * To-Do:
- * - Undo Announce
+ * @todo Undo Announce
  */
 class Transmitter
 {
@@ -54,7 +71,7 @@ class Transmitter
         */
        public static function getFollowers($owner, $page = null)
        {
-               $condition = ['rel' => [Contact::FOLLOWER, Contact::FRIEND], 'network' => Protocol::NATIVE_SUPPORT, 'uid' => $owner['uid'],
+               $condition = ['rel' => [Contact::FOLLOWER, Contact::FRIEND], 'network' => Protocol::FEDERATED, 'uid' => $owner['uid'],
                        'self' => false, 'deleted' => false, 'hidden' => false, 'archive' => false, 'pending' => false];
                $count = DBA::count('contact', $condition);
 
@@ -103,7 +120,7 @@ class Transmitter
         */
        public static function getFollowing($owner, $page = null)
        {
-               $condition = ['rel' => [Contact::SHARING, Contact::FRIEND], 'network' => Protocol::NATIVE_SUPPORT, 'uid' => $owner['uid'],
+               $condition = ['rel' => [Contact::SHARING, Contact::FRIEND], 'network' => Protocol::FEDERATED, 'uid' => $owner['uid'],
                        'self' => false, 'deleted' => false, 'hidden' => false, 'archive' => false, 'pending' => false];
                $count = DBA::count('contact', $condition);
 
@@ -156,7 +173,7 @@ class Transmitter
                $public_contact = Contact::getIdForURL($owner['url'], 0, true);
 
                $condition = ['uid' => 0, 'contact-id' => $public_contact, 'author-id' => $public_contact,
-                       'private' => false, 'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT],
+                       'private' => [Item::PUBLIC, Item::UNLISTED], 'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT],
                        'deleted' => false, 'visible' => true, 'moderated' => false];
                $count = DBA::count('item', $condition);
 
@@ -176,8 +193,10 @@ class Transmitter
                        $items = Item::select(['id'], $condition, ['limit' => [($page - 1) * 20, 20], 'order' => ['created' => true]]);
                        while ($item = Item::fetch($items)) {
                                $activity = self::createActivityFromItem($item['id'], true);
+                               $activity['type'] = $activity['type'] == 'Update' ? 'Create' : $activity['type'];
+
                                // Only list "Create" activity objects here, no reshares
-                               if (is_array($activity['object']) && ($activity['type'] == 'Create')) {
+                               if (!empty($activity['object']) && ($activity['type'] == 'Create')) {
                                        $list[] = $activity['object'];
                                }
                        }
@@ -247,7 +266,7 @@ class Transmitter
                $data['name'] = $contact['name'];
                $data['vcard:hasAddress'] = ['@type' => 'vcard:Home', 'vcard:country-name' => $profile['country-name'],
                        'vcard:region' => $profile['region'], 'vcard:locality' => $profile['locality']];
-               $data['summary'] = $contact['about'];
+               $data['summary'] = BBCode::convert($contact['about'], false);
                $data['url'] = $contact['url'];
                $data['manuallyApprovesFollowers'] = in_array($user['page-flags'], [User::PAGE_FLAGS_NORMAL, User::PAGE_FLAGS_PRVGROUP]);
                $data['publicKey'] = ['id' => $contact['url'] . '#main-key',
@@ -324,7 +343,11 @@ class Transmitter
                        }
 
                        foreach ($activity[$element] as $receiver) {
-                               if ($receiver == $profile['followers'] && !empty($item_profile['followers'])) {
+                               if (empty($receiver)) {
+                                       continue;
+                               }
+
+                               if (!empty($profile['followers']) && $receiver == $profile['followers'] && !empty($item_profile['followers'])) {
                                        $permissions[$element][] = $item_profile['followers'];
                                } elseif (!in_array($receiver, $exclude)) {
                                        $permissions[$element][] = $receiver;
@@ -384,7 +407,7 @@ class Transmitter
 
                $terms = Term::tagArrayFromItemId($item['id'], [Term::MENTION, Term::IMPLICIT_MENTION]);
 
-               if (!$item['private']) {
+               if ($item['private'] != Item::PRIVATE) {
                        // Directly mention the original author upon a quoted reshare.
                        // Else just ensure that the original author receives the reshare.
                        $announce = self::getAnnounceArray($item);
@@ -396,7 +419,12 @@ class Transmitter
 
                        $data = array_merge($data, self::fetchPermissionBlockFromConversation($item));
 
-                       $data['to'][] = ActivityPub::PUBLIC_COLLECTION;
+                       // Check if the item is completely public or unlisted
+                       if ($item['private'] == Item::PUBLIC) {
+                               $data['to'][] = ActivityPub::PUBLIC_COLLECTION;
+                       } else {
+                               $data['cc'][] = ActivityPub::PUBLIC_COLLECTION;
+                       }
 
                        foreach ($terms as $term) {
                                $profile = APContact::getByURL($term['url'], false);
@@ -450,13 +478,13 @@ class Transmitter
                                                                $data['to'][] = $profile['url'];
                                                        } else {
                                                                $data['cc'][] = $profile['url'];
-                                                               if (!$item['private'] && !empty($actor_profile['followers'])) {
+                                                               if (($item['private'] != Item::PRIVATE) && !empty($actor_profile['followers'])) {
                                                                        $data['cc'][] = $actor_profile['followers'];
                                                                }
                                                        }
                                                } else {
                                                        // Public thread parent post always are directed to the followers
-                                                       if (!$item['private'] && !$forum_mode) {
+                                                       if (($item['private'] != Item::PRIVATE) && !$forum_mode) {
                                                                $data['cc'][] = $actor_profile['followers'];
                                                        }
                                                }
@@ -627,7 +655,7 @@ class Transmitter
                        $blindcopy = in_array($element, ['bto', 'bcc']);
 
                        foreach ($permissions[$element] as $receiver) {
-                               if (Network::isUrlBlocked($receiver)) {
+                               if (empty($receiver) || Network::isUrlBlocked($receiver)) {
                                        continue;
                                }
 
@@ -1190,7 +1218,7 @@ class Transmitter
         */
        private static function isSensitive($item_id)
        {
-               $condition = ['otype' => TERM_OBJ_POST, 'oid' => $item_id, 'type' => TERM_HASHTAG, 'term' => 'nsfw'];
+               $condition = ['otype' => Term::OBJECT_TYPE_POST, 'oid' => $item_id, 'type' => Term::HASHTAG, 'term' => 'nsfw'];
                return DBA::exists('term', $condition);
        }
 
@@ -1378,8 +1406,8 @@ class Transmitter
         */
        private static function createAddTag($item, $data)
        {
-               $object = XML::parseString($item['object'], false);
-               $target = XML::parseString($item["target"], false);
+               $object = XML::parseString($item['object']);
+               $target = XML::parseString($item["target"]);
 
                $data['diaspora:guid'] = $item['guid'];
                $data['actor'] = $item['author-link'];
@@ -1510,14 +1538,14 @@ class Transmitter
        {
                $owner = User::getOwnerDataById($uid);
 
-               $suggestion = DBA::selectFirst('fsuggest', ['url', 'note', 'created'], ['id' => $suggestion_id]);
+               $suggestion = DI::fsuggest()->getById($suggestion_id);
 
                $data = ['@context' => ActivityPub::CONTEXT,
                        'id' => DI::baseUrl() . '/activity/' . System::createGUID(),
                        'type' => 'Announce',
                        'actor' => $owner['url'],
-                       'object' => $suggestion['url'],
-                       'content' => $suggestion['note'],
+                       'object' => $suggestion->url,
+                       'content' => $suggestion->note,
                        'instrument' => self::getService(),
                        'to' => [ActivityPub::PUBLIC_COLLECTION],
                        'cc' => []];