We can delete notes / changed credits

[friendica.git] / src / Protocol / ActivityPub.php

diff --git a/src/Protocol/ActivityPub.php b/src/Protocol/ActivityPub.php
index 6c46da553df745b97bb3ea35c5ac720034cf1fcf..4d7657865c226e3c19bfd7921cd28504df0a4363 100644 (file)
--- a/src/Protocol/ActivityPub.php
+++ b/src/Protocol/ActivityPub.php
@@ -34,20 +34,16 @@ use Friendica\Util\LDSignature;
  *
  * Digest: https://tools.ietf.org/html/rfc5843
  * https://tools.ietf.org/html/draft-cavage-http-signatures-10#ref-15
- * https://github.com/digitalbazaar/php-json-ld
- *
- * Part of the code for HTTP signing is taken from the Osada project.
- * https://framagit.org/macgirvin/osada
  *
  * To-do:
  *
  * Receiver:
- * - Activities: Update, Delete
+ * - Activities: Update, Delete (Activities/Notes)
  * - Object Types: Person, Tombstome
  *
  * Transmitter:
  * - Activities: Announce
- * - Object Tyoes: Person, Tombstone
+ * - Object Tyoes: Person
  *
  * General:
  * - Endpoints: Outbox, Follower, Following
@@ -139,7 +135,12 @@ class ActivityPub
                $actor = JsonLD::fetchElement($activity, 'actor', 'id');
                $profile = ActivityPub::fetchprofile($actor);
 
-               $item_profile = ActivityPub::fetchprofile($item['owner-link']);
+               $item_profile = ActivityPub::fetchprofile($item['author-link']);
+               $exclude[] = $item['author-link'];
+
+               if ($item['gravity'] == GRAVITY_PARENT) {
+                       $exclude[] = $item['owner-link'];
+               }
 
                $permissions = [];
 
@@ -155,7 +156,7 @@ class ActivityPub
                                if ($receiver == $profile['followers'] && !empty($item_profile['followers'])) {
                                        $receiver = $item_profile['followers'];
                                }
-                               if ($receiver != $item['owner-link']) {
+                               if (!in_array($receiver, $exclude)) {
                                        $permissions[$element][] = $receiver;
                                }
                        }
@@ -217,7 +218,7 @@ class ActivityPub
                        }
                }
 
-               $parents = Item::select(['author-link', 'owner-link'], ['parent' => $item['parent']]);
+               $parents = Item::select(['author-link', 'owner-link', 'gravity'], ['parent' => $item['parent']]);
                while ($parent = Item::fetch($parents)) {
                        $profile = self::fetchprofile($parent['author-link']);
                        if (!empty($profile) && empty($contacts[$profile['url']])) {
@@ -225,6 +226,10 @@ class ActivityPub
                                $contacts[$profile['url']] = $profile['url'];
                        }
 
+                       if ($item['gravity'] != GRAVITY_PARENT) {
+                               continue;
+                       }
+
                        $profile = self::fetchprofile($parent['owner-link']);
                        if (!empty($profile) && empty($contacts[$profile['url']])) {
                                $data['cc'][] = $profile['url'];
@@ -250,13 +255,18 @@ class ActivityPub
 
                $inboxes = [];
 
-               $item_profile = ActivityPub::fetchprofile($item['owner-link']);
+               if ($item['gravity'] == GRAVITY_ACTIVITY) {
+                       $item_profile = ActivityPub::fetchprofile($item['author-link']);
+               } else {
+                       $item_profile = ActivityPub::fetchprofile($item['owner-link']);
+               }
 
                $elements = ['to', 'cc', 'bto', 'bcc'];
                foreach ($elements as $element) {
                        if (empty($permissions[$element])) {
                                continue;
                        }
+
                        foreach ($permissions[$element] as $receiver) {
                                if ($receiver == $item_profile['followers']) {
                                        $contacts = DBA::select('contact', ['notify', 'batch'], ['uid' => $uid,
@@ -276,14 +286,6 @@ class ActivityPub
                        }
                }
 
-               if (!empty($item_profile['sharedinbox'])) {
-                       unset($inboxes[$item_profile['sharedinbox']]);
-               }
-
-               if (!empty($item_profile['inbox'])) {
-                       unset($inboxes[$item_profile['inbox']]);
-               }
-
                return $inboxes;
        }
 
@@ -305,16 +307,14 @@ class ActivityPub
                        $type = 'Reject';
                } elseif ($item['verb'] == ACTIVITY_ATTENDMAYBE) {
                        $type = 'TentativeAccept';
-               }
-
-               if ($item['deleted']) {
-                       $type = 'Delete';
+               } else {
+                       $type = '';
                }
 
                return $type;
        }
 
-       public static function createActivityFromItem($item_id)
+       public static function createActivityFromItem($item_id, $object_mode = false)
        {
                $item = Item::selectFirst([], ['id' => $item_id]);
 
@@ -331,14 +331,26 @@ class ActivityPub
                        }
                }
 
-               $data = ['@context' => ['https://www.w3.org/ns/activitystreams', 'https://w3id.org/security/v1',
-                       ['ostatus' => 'http://ostatus.org#', 'sensitive' => 'as:sensitive',
-                       'Hashtag' => 'as:Hashtag', 'atomUri' => 'ostatus:atomUri',
-                       'conversation' => 'ostatus:conversation',
-                       'inReplyToAtomUri' => 'ostatus:inReplyToAtomUri']]];
+               $type = self::getTypeOfItem($item);
+
+               if (!$object_mode) {
+                       $data = ['@context' => ['https://www.w3.org/ns/activitystreams', 'https://w3id.org/security/v1',
+                               ['ostatus' => 'http://ostatus.org#', 'uuid' => 'http://schema.org/identifier',
+                               'sensitive' => 'as:sensitive', 'Hashtag' => 'as:Hashtag',
+                               'atomUri' => 'ostatus:atomUri', 'conversation' => 'ostatus:conversation',
+                               'inReplyToAtomUri' => 'ostatus:inReplyToAtomUri']]];
 
-               $data['id'] = $item['uri'] . '#activity';
-               $data['type'] = self::getTypeOfItem($item);;
+                       if ($item['deleted'] && ($item['gravity'] == GRAVITY_ACTIVITY)) {
+                               $type = 'Undo';
+                       } elseif ($item['deleted']) {
+                               $type = 'Delete';
+                       }
+               } else {
+                       $data = [];
+               }
+
+               $data['id'] = $item['uri'] . '#' . $type;
+               $data['type'] = $type;
                $data['actor'] = $item['author-link'];
 
                $data['published'] = DateTimeFormat::utc($item["created"]."+00:00", DateTimeFormat::ATOM);
@@ -347,20 +359,25 @@ class ActivityPub
                        $data['updated'] = DateTimeFormat::utc($item["edited"]."+00:00", DateTimeFormat::ATOM);
                }
 
-               $data['context_id'] = $item['parent'];
                $data['context'] = self::createConversationURLFromItem($item);
 
                $data = array_merge($data, ActivityPub::createPermissionBlockForItem($item));
 
-               if (in_array($data['type'], ['Create', 'Update', 'Announce'])) {
+               if (in_array($data['type'], ['Create', 'Update', 'Announce', 'Delete'])) {
                        $data['object'] = self::CreateNote($item);
+               } elseif ($data['type'] == 'Undo') {
+                       $data['object'] = self::createActivityFromItem($item_id, true);
                } else {
                        $data['object'] = $item['thr-parent'];
                }
 
                $owner = User::getOwnerDataById($item['uid']);
 
-               return LDSignature::sign($data, $owner);
+               if (!$object_mode) {
+                       return LDSignature::sign($data, $owner);
+               } else {
+                       return $data;
+               }
        }
 
        public static function createObjectFromItemID($item_id)
@@ -372,9 +389,9 @@ class ActivityPub
                }
 
                $data = ['@context' => ['https://www.w3.org/ns/activitystreams', 'https://w3id.org/security/v1',
-                       ['ostatus' => 'http://ostatus.org#', 'sensitive' => 'as:sensitive',
-                       'Hashtag' => 'as:Hashtag', 'atomUri' => 'ostatus:atomUri',
-                       'conversation' => 'ostatus:conversation',
+                       ['ostatus' => 'http://ostatus.org#', 'uuid' => 'http://schema.org/identifier',
+                       'sensitive' => 'as:sensitive', 'Hashtag' => 'as:Hashtag',
+                       'atomUri' => 'ostatus:atomUri', 'conversation' => 'ostatus:conversation',
                        'inReplyToAtomUri' => 'ostatus:inReplyToAtomUri']]];
 
                $data = array_merge($data, self::CreateNote($item));
@@ -422,9 +439,18 @@ class ActivityPub
                        $type = 'Note';
                }
 
+               if ($item['deleted']) {
+                       $type = 'Tombstone';
+               }
+
                $data = [];
                $data['id'] = $item['uri'];
                $data['type'] = $type;
+
+               if ($item['deleted']) {
+                       return $data;
+               }
+
                $data['summary'] = null; // Ignore by now
 
                if ($item['uri'] != $item['thr-parent']) {
@@ -433,6 +459,7 @@ class ActivityPub
                        $data['inReplyTo'] = null;
                }
 
+               $data['uuid'] = $item['guid'];
                $data['published'] = DateTimeFormat::utc($item["created"]."+00:00", DateTimeFormat::ATOM);
 
                if ($item["created"] != $item["edited"]) {
@@ -443,7 +470,6 @@ class ActivityPub
                $data['attributedTo'] = $item['author-link'];
                $data['actor'] = $item['author-link'];
                $data['sensitive'] = false; // - Query NSFW
-               $data['context_id'] = $item['parent'];
                $data['conversation'] = $data['context'] = self::createConversationURLFromItem($item);
 
                if (!empty($item['title'])) {