]> git.mxchange.org Git - friendica.git/blobdiff - src/Protocol/DFRN.php
Remove deprecated code
[friendica.git] / src / Protocol / DFRN.php
index a5deb490b09de23f4fdbcfaa5af5ecceac27412c..424b519063da5385fb0ac06ab6314cbab5ddd134 100644 (file)
@@ -1,7 +1,7 @@
 <?php
 /**
  * @file include/dfrn.php
- * @brief The implementation of the dfrn protocol
+ * The implementation of the dfrn protocol
  *
  * @see https://github.com/friendica/friendica/wiki/Protocol and
  * https://github.com/friendica/friendica/blob/master/spec/dfrn2.pdf
@@ -10,16 +10,15 @@ namespace Friendica\Protocol;
 
 use DOMDocument;
 use DOMXPath;
-use Friendica\App;
+use Friendica\App\BaseURL;
 use Friendica\Content\OEmbed;
 use Friendica\Content\Text\BBCode;
 use Friendica\Content\Text\HTML;
-use Friendica\Core\Config;
 use Friendica\Core\Hook;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
-use Friendica\Core\System;
 use Friendica\Database\DBA;
+use Friendica\DI;
 use Friendica\Model\Contact;
 use Friendica\Model\Conversation;
 use Friendica\Model\Event;
@@ -29,10 +28,10 @@ use Friendica\Model\Mail;
 use Friendica\Model\PermissionSet;
 use Friendica\Model\Profile;
 use Friendica\Model\User;
-use Friendica\Object\Image;
-use Friendica\Util\BaseURL;
+use Friendica\Network\Probe;
 use Friendica\Util\Crypto;
 use Friendica\Util\DateTimeFormat;
+use Friendica\Util\Images;
 use Friendica\Util\Network;
 use Friendica\Util\Strings;
 use Friendica\Util\XML;
@@ -40,7 +39,7 @@ use HTMLPurifier;
 use HTMLPurifier_Config;
 
 /**
- * @brief This class contain functions to create and send DFRN XML files
+ * This class contain functions to create and send DFRN XML files
  */
 class DFRN
 {
@@ -50,7 +49,7 @@ class DFRN
        const REPLY_RC = 2;     // Reply that will be relayed
 
        /**
-        * @brief Generates an array of contact and user for DFRN imports
+        * Generates an array of contact and user for DFRN imports
         *
         * This array contains not only the receiver but also the sender of the message.
         *
@@ -91,7 +90,7 @@ class DFRN
        }
 
        /**
-        * @brief Generates the atom entries for delivery.php
+        * Generates the atom entries for delivery.php
         *
         * This function is used whenever content is transmitted via DFRN.
         *
@@ -117,8 +116,8 @@ class DFRN
                foreach ($items as $item) {
                        // These values aren't sent when sending from the queue.
                        /// @todo Check if we can set these values from the queue or if they are needed at all.
-                       $item["entry:comment-allow"] = defaults($item, "entry:comment-allow", true);
-                       $item["entry:cid"] = defaults($item, "entry:cid", 0);
+                       $item["entry:comment-allow"] = ($item["entry:comment-allow"] ?? '') ?: true;
+                       $item["entry:cid"] = $item["entry:cid"] ?? 0;
 
                        $entry = self::entry($doc, "text", $item, $owner, $item["entry:comment-allow"], $item["entry:cid"]);
                        if (isset($entry)) {
@@ -130,7 +129,7 @@ class DFRN
        }
 
        /**
-        * @brief Generate an atom feed for the given user
+        * Generate an atom feed for the given user
         *
         * This function is called when another server is pulling data from the user feed.
         *
@@ -146,7 +145,7 @@ class DFRN
         */
        public static function feed($dfrn_id, $owner_nick, $last_update, $direction = 0, $onlyheader = false)
        {
-               $a = \get_app();
+               $a = DI::app();
 
                $sitefeed    = ((strlen($owner_nick)) ? false : true); // not yet implemented, need to rewrite huge chunks of following logic
                $public_feed = (($dfrn_id) ? false : true);
@@ -257,7 +256,7 @@ class DFRN
                        STRAIGHT_JOIN `contact` ON `contact`.`id` = `item`.`contact-id`
                        WHERE `item`.`uid` = %d AND `item`.`wall` AND `item`.`changed` > '%s'
                        AND `item`.`visible` $sql_extra
-                       ORDER BY `item`.`parent` ".$sort.", `item`.`created` ASC LIMIT 0, 300",
+                       ORDER BY `item`.`parent` ".$sort.", `item`.`received` ASC LIMIT 0, 300",
                        intval($owner_id),
                        DBA::escape($check_date),
                        DBA::escape($sort)
@@ -340,7 +339,7 @@ class DFRN
        }
 
        /**
-        * @brief Generate an atom entry for a given item id
+        * Generate an atom entry for a given item id
         *
         * @param int     $item_id      The item id
         * @param boolean $conversation Show the conversation. If false show the single post.
@@ -379,18 +378,18 @@ class DFRN
                $type = 'html';
 
                if ($conversation) {
-                       $root = $doc->createElementNS(NAMESPACE_ATOM1, 'feed');
+                       $root = $doc->createElementNS(ActivityNamespace::ATOM1, 'feed');
                        $doc->appendChild($root);
 
-                       $root->setAttribute("xmlns:thr", NAMESPACE_THREAD);
-                       $root->setAttribute("xmlns:at", NAMESPACE_TOMB);
-                       $root->setAttribute("xmlns:media", NAMESPACE_MEDIA);
-                       $root->setAttribute("xmlns:dfrn", NAMESPACE_DFRN);
-                       $root->setAttribute("xmlns:activity", NAMESPACE_ACTIVITY);
-                       $root->setAttribute("xmlns:georss", NAMESPACE_GEORSS);
-                       $root->setAttribute("xmlns:poco", NAMESPACE_POCO);
-                       $root->setAttribute("xmlns:ostatus", NAMESPACE_OSTATUS);
-                       $root->setAttribute("xmlns:statusnet", NAMESPACE_STATUSNET);
+                       $root->setAttribute("xmlns:thr", ActivityNamespace::THREAD);
+                       $root->setAttribute("xmlns:at", ActivityNamespace::TOMB);
+                       $root->setAttribute("xmlns:media", ActivityNamespace::MEDIA);
+                       $root->setAttribute("xmlns:dfrn", ActivityNamespace::DFRN);
+                       $root->setAttribute("xmlns:activity", ActivityNamespace::ACTIVITY);
+                       $root->setAttribute("xmlns:georss", ActivityNamespace::GEORSS);
+                       $root->setAttribute("xmlns:poco", ActivityNamespace::POCO);
+                       $root->setAttribute("xmlns:ostatus", ActivityNamespace::OSTATUS);
+                       $root->setAttribute("xmlns:statusnet", ActivityNamespace::STATUSNET);
 
                        //$root = self::addHeader($doc, $owner, "dfrn:owner", "", false);
 
@@ -409,7 +408,7 @@ class DFRN
        }
 
        /**
-        * @brief Create XML text for DFRN mails
+        * Create XML text for DFRN mails
         *
         * @param array $item  message elements
         * @param array $owner Owner record
@@ -446,7 +445,7 @@ class DFRN
        }
 
        /**
-        * @brief Create XML text for DFRN friend suggestions
+        * Create XML text for DFRN friend suggestions
         *
         * @param array $item  suggestion elements
         * @param array $owner Owner record
@@ -476,7 +475,7 @@ class DFRN
        }
 
        /**
-        * @brief Create XML text for DFRN relocations
+        * Create XML text for DFRN relocations
         *
         * @param array $owner Owner record
         * @param int   $uid   User ID
@@ -489,11 +488,11 @@ class DFRN
        {
 
                /* get site pubkey. this could be a new installation with no site keys*/
-               $pubkey = Config::get('system', 'site_pubkey');
+               $pubkey = DI::config()->get('system', 'site_pubkey');
                if (! $pubkey) {
                        $res = Crypto::newKeypair(1024);
-                       Config::set('system', 'site_prvkey', $res['prvkey']);
-                       Config::set('system', 'site_pubkey', $res['pubkey']);
+                       DI::config()->set('system', 'site_prvkey', $res['prvkey']);
+                       DI::config()->set('system', 'site_pubkey', $res['pubkey']);
                }
 
                $rp = q(
@@ -502,10 +501,10 @@ class DFRN
                        $uid
                );
                $photos = [];
-               $ext = Image::supportedTypes();
+               $ext = Images::supportedTypes();
 
                foreach ($rp as $p) {
-                       $photos[$p['scale']] = System::baseUrl().'/photo/'.$p['resource-id'].'-'.$p['scale'].'.'.$ext[$p['type']];
+                       $photos[$p['scale']] = DI::baseUrl().'/photo/'.$p['resource-id'].'-'.$p['scale'].'.'.$ext[$p['type']];
                }
 
 
@@ -527,7 +526,7 @@ class DFRN
                XML::addElement($doc, $relocate, "dfrn:confirm", $owner['confirm']);
                XML::addElement($doc, $relocate, "dfrn:notify", $owner['notify']);
                XML::addElement($doc, $relocate, "dfrn:poll", $owner['poll']);
-               XML::addElement($doc, $relocate, "dfrn:sitepubkey", Config::get('system', 'site_pubkey'));
+               XML::addElement($doc, $relocate, "dfrn:sitepubkey", DI::config()->get('system', 'site_pubkey'));
 
                $root->appendChild($relocate);
 
@@ -535,7 +534,7 @@ class DFRN
        }
 
        /**
-        * @brief Adds the header elements for the DFRN protocol
+        * Adds the header elements for the DFRN protocol
         *
         * @param DOMDocument $doc           XML document
         * @param array       $owner         Owner record
@@ -554,20 +553,20 @@ class DFRN
                        $alternatelink = $owner['url'];
                }
 
-               $root = $doc->createElementNS(NAMESPACE_ATOM1, 'feed');
+               $root = $doc->createElementNS(ActivityNamespace::ATOM1, 'feed');
                $doc->appendChild($root);
 
-               $root->setAttribute("xmlns:thr", NAMESPACE_THREAD);
-               $root->setAttribute("xmlns:at", NAMESPACE_TOMB);
-               $root->setAttribute("xmlns:media", NAMESPACE_MEDIA);
-               $root->setAttribute("xmlns:dfrn", NAMESPACE_DFRN);
-               $root->setAttribute("xmlns:activity", NAMESPACE_ACTIVITY);
-               $root->setAttribute("xmlns:georss", NAMESPACE_GEORSS);
-               $root->setAttribute("xmlns:poco", NAMESPACE_POCO);
-               $root->setAttribute("xmlns:ostatus", NAMESPACE_OSTATUS);
-               $root->setAttribute("xmlns:statusnet", NAMESPACE_STATUSNET);
-
-               XML::addElement($doc, $root, "id", System::baseUrl()."/profile/".$owner["nick"]);
+               $root->setAttribute("xmlns:thr", ActivityNamespace::THREAD);
+               $root->setAttribute("xmlns:at", ActivityNamespace::TOMB);
+               $root->setAttribute("xmlns:media", ActivityNamespace::MEDIA);
+               $root->setAttribute("xmlns:dfrn", ActivityNamespace::DFRN);
+               $root->setAttribute("xmlns:activity", ActivityNamespace::ACTIVITY);
+               $root->setAttribute("xmlns:georss", ActivityNamespace::GEORSS);
+               $root->setAttribute("xmlns:poco", ActivityNamespace::POCO);
+               $root->setAttribute("xmlns:ostatus", ActivityNamespace::OSTATUS);
+               $root->setAttribute("xmlns:statusnet", ActivityNamespace::STATUSNET);
+
+               XML::addElement($doc, $root, "id", DI::baseUrl()."/profile/".$owner["nick"]);
                XML::addElement($doc, $root, "title", $owner["name"]);
 
                $attributes = ["uri" => "https://friendi.ca", "version" => FRIENDICA_VERSION."-".DB_UPDATE_VERSION];
@@ -584,13 +583,13 @@ class DFRN
                        // DFRN itself doesn't uses this. But maybe someone else wants to subscribe to the public feed.
                        OStatus::hublinks($doc, $root, $owner["nick"]);
 
-                       $attributes = ["rel" => "salmon", "href" => System::baseUrl()."/salmon/".$owner["nick"]];
+                       $attributes = ["rel" => "salmon", "href" => DI::baseUrl()."/salmon/".$owner["nick"]];
                        XML::addElement($doc, $root, "link", "", $attributes);
 
-                       $attributes = ["rel" => "http://salmon-protocol.org/ns/salmon-replies", "href" => System::baseUrl()."/salmon/".$owner["nick"]];
+                       $attributes = ["rel" => "http://salmon-protocol.org/ns/salmon-replies", "href" => DI::baseUrl()."/salmon/".$owner["nick"]];
                        XML::addElement($doc, $root, "link", "", $attributes);
 
-                       $attributes = ["rel" => "http://salmon-protocol.org/ns/salmon-mention", "href" => System::baseUrl()."/salmon/".$owner["nick"]];
+                       $attributes = ["rel" => "http://salmon-protocol.org/ns/salmon-mention", "href" => DI::baseUrl()."/salmon/".$owner["nick"]];
                        XML::addElement($doc, $root, "link", "", $attributes);
                }
 
@@ -613,7 +612,7 @@ class DFRN
        }
 
        /**
-        * @brief Adds the author element in the header for the DFRN protocol
+        * Adds the author element in the header for the DFRN protocol
         *
         * @param DOMDocument $doc           XML document
         * @param array       $owner         Owner record
@@ -651,7 +650,7 @@ class DFRN
                }
 
                XML::addElement($doc, $author, "name", $owner["name"], $attributes);
-               XML::addElement($doc, $author, "uri", System::baseUrl().'/profile/'.$owner["nickname"], $attributes);
+               XML::addElement($doc, $author, "uri", DI::baseUrl().'/profile/'.$owner["nickname"], $attributes);
                XML::addElement($doc, $author, "dfrn:handle", $owner["addr"], $attributes);
 
                $attributes = ["rel" => "photo", "type" => "image/jpeg",
@@ -688,7 +687,7 @@ class DFRN
                                `profile`.`pub_keywords`, `profile`.`xmpp`, `profile`.`dob`
                        FROM `profile`
                                INNER JOIN `user` ON `user`.`uid` = `profile`.`uid`
-                               WHERE `profile`.`is-default` AND NOT `user`.`hidewall` AND `user`.`uid` = %d",
+                               WHERE NOT `user`.`hidewall` AND `user`.`uid` = %d",
                        intval($owner['uid'])
                );
                if (DBA::isResult($r)) {
@@ -758,7 +757,7 @@ class DFRN
        }
 
        /**
-        * @brief Adds the author elements in the "entry" elements of the DFRN protocol
+        * Adds the author elements in the "entry" elements of the DFRN protocol
         *
         * @param DOMDocument $doc         XML document
         * @param string $element     Element name for the author
@@ -803,7 +802,7 @@ class DFRN
        }
 
        /**
-        * @brief Adds the activity elements
+        * Adds the activity elements
         *
         * @param DOMDocument $doc      XML document
         * @param string      $element  Element name for the activity
@@ -870,7 +869,7 @@ class DFRN
        }
 
        /**
-        * @brief Adds the elements for attachments
+        * Adds the elements for attachments
         *
         * @param object $doc  XML document
         * @param object $root XML root
@@ -906,7 +905,7 @@ class DFRN
        }
 
        /**
-        * @brief Adds the "entry" elements for the DFRN protocol
+        * Adds the "entry" elements for the DFRN protocol
         *
         * @param DOMDocument $doc     XML document
         * @param string      $type    "text" or "html"
@@ -938,18 +937,18 @@ class DFRN
                if (!$single) {
                        $entry = $doc->createElement("entry");
                } else {
-                       $entry = $doc->createElementNS(NAMESPACE_ATOM1, 'entry');
+                       $entry = $doc->createElementNS(ActivityNamespace::ATOM1, 'entry');
                        $doc->appendChild($entry);
 
-                       $entry->setAttribute("xmlns:thr", NAMESPACE_THREAD);
-                       $entry->setAttribute("xmlns:at", NAMESPACE_TOMB);
-                       $entry->setAttribute("xmlns:media", NAMESPACE_MEDIA);
-                       $entry->setAttribute("xmlns:dfrn", NAMESPACE_DFRN);
-                       $entry->setAttribute("xmlns:activity", NAMESPACE_ACTIVITY);
-                       $entry->setAttribute("xmlns:georss", NAMESPACE_GEORSS);
-                       $entry->setAttribute("xmlns:poco", NAMESPACE_POCO);
-                       $entry->setAttribute("xmlns:ostatus", NAMESPACE_OSTATUS);
-                       $entry->setAttribute("xmlns:statusnet", NAMESPACE_STATUSNET);
+                       $entry->setAttribute("xmlns:thr", ActivityNamespace::THREAD);
+                       $entry->setAttribute("xmlns:at", ActivityNamespace::TOMB);
+                       $entry->setAttribute("xmlns:media", ActivityNamespace::MEDIA);
+                       $entry->setAttribute("xmlns:dfrn", ActivityNamespace::DFRN);
+                       $entry->setAttribute("xmlns:activity", ActivityNamespace::ACTIVITY);
+                       $entry->setAttribute("xmlns:georss", ActivityNamespace::GEORSS);
+                       $entry->setAttribute("xmlns:poco", ActivityNamespace::POCO);
+                       $entry->setAttribute("xmlns:ostatus", ActivityNamespace::OSTATUS);
+                       $entry->setAttribute("xmlns:statusnet", ActivityNamespace::STATUSNET);
                }
 
                if ($item['private']) {
@@ -988,7 +987,7 @@ class DFRN
                }
 
                // Add conversation data. This is used for OStatus
-               $conversation_href = System::baseUrl()."/display/".$item["parent-guid"];
+               $conversation_href = DI::baseUrl()."/display/".$item["parent-guid"];
                $conversation_uri = $conversation_href;
 
                if (isset($parent_item)) {
@@ -1029,7 +1028,7 @@ class DFRN
                        "link",
                        "",
                        ["rel" => "alternate", "type" => "text/html",
-                                "href" => System::baseUrl() . "/display/" . $item["guid"]]
+                                "href" => DI::baseUrl() . "/display/" . $item["guid"]]
                );
 
                // "comment-allow" is some old fashioned stuff for old Friendica versions.
@@ -1076,9 +1075,9 @@ class DFRN
                if ($item['object-type'] != "") {
                        XML::addElement($doc, $entry, "activity:object-type", $item['object-type']);
                } elseif ($item['id'] == $item['parent']) {
-                       XML::addElement($doc, $entry, "activity:object-type", ACTIVITY_OBJ_NOTE);
+                       XML::addElement($doc, $entry, "activity:object-type", Activity\ObjectType::NOTE);
                } else {
-                       XML::addElement($doc, $entry, "activity:object-type", ACTIVITY_OBJ_COMMENT);
+                       XML::addElement($doc, $entry, "activity:object-type", Activity\ObjectType::COMMENT);
                }
 
                $actobj = self::createActivity($doc, "activity:object", $item['object']);
@@ -1121,7 +1120,7 @@ class DFRN
                                        "link",
                                        "",
                                        ["rel" => "mentioned",
-                                                       "ostatus:object-type" => ACTIVITY_OBJ_GROUP,
+                                                       "ostatus:object-type" => Activity\ObjectType::GROUP,
                                                        "href" => $mention]
                                );
                        } else {
@@ -1131,7 +1130,7 @@ class DFRN
                                        "link",
                                        "",
                                        ["rel" => "mentioned",
-                                                       "ostatus:object-type" => ACTIVITY_OBJ_PERSON,
+                                                       "ostatus:object-type" => Activity\ObjectType::PERSON,
                                                        "href" => $mention]
                                );
                        }
@@ -1143,7 +1142,7 @@ class DFRN
        }
 
        /**
-        * @brief encrypts data via AES
+        * encrypts data via AES
         *
         * @param string $data The data that is to be encrypted
         * @param string $key  The AES key
@@ -1156,7 +1155,7 @@ class DFRN
        }
 
        /**
-        * @brief decrypts data via AES
+        * decrypts data via AES
         *
         * @param string $encrypted The encrypted data
         * @param string $key       The AES key
@@ -1169,7 +1168,7 @@ class DFRN
        }
 
        /**
-        * @brief Delivers the atom content to the contacts
+        * Delivers the atom content to the contacts
         *
         * @param array  $owner    Owner record
         * @param array  $contact  Contact record of the receiver
@@ -1192,12 +1191,12 @@ class DFRN
                        $idtosend = '1:' . $orig_id;
                }
 
-               $rino = Config::get('system', 'rino_encrypt');
+               $rino = DI::config()->get('system', 'rino_encrypt');
                $rino = intval($rino);
 
                Logger::log("Local rino version: ". $rino, Logger::DEBUG);
 
-               $ssl_val = intval(Config::get('system', 'ssl_policy'));
+               $ssl_val = intval(DI::config()->get('system', 'ssl_policy'));
 
                switch ($ssl_val) {
                        case BaseURL::SSL_POLICY_FULL:
@@ -1257,7 +1256,7 @@ class DFRN
                $sent_dfrn_id = hex2bin((string) $res->dfrn_id);
                $challenge    = hex2bin((string) $res->challenge);
                $perm         = (($res->perm) ? $res->perm : null);
-               $dfrn_version = (float) (($res->dfrn_version) ? $res->dfrn_version : 2.0);
+               $dfrn_version = floatval($res->dfrn_version ?: 2.0);
                $rino_remote_version = intval($res->rino);
                $page         = (($owner['page-flags'] == User::PAGE_FLAGS_COMMUNITY) ? 1 : 0);
 
@@ -1405,7 +1404,7 @@ class DFRN
        }
 
        /**
-        * @brief Transmits atom content to the contacts via the Diaspora transport layer
+        * Transmits atom content to the contacts via the Diaspora transport layer
         *
         * @param array  $owner   Owner record
         * @param array  $contact Contact record of the receiver
@@ -1455,6 +1454,11 @@ class DFRN
 
                $dest_url = ($public_batch ? $contact["batch"] : $contact["notify"]);
 
+               if (empty($dest_url)) {
+                       Logger::info('Empty destination', ['public' => $public_batch, 'contact' => $contact]);
+                       return -24;
+               }
+
                $content_type = ($public_batch ? "application/magic-envelope+xml" : "application/json");
 
                $postResult = Network::post($dest_url, $envelope, ["Content-Type: ".$content_type]);
@@ -1490,7 +1494,7 @@ class DFRN
        }
 
        /**
-        * @brief Fetch the author data from head or entry items
+        * Fetch the author data from head or entry items
         *
         * @param object $xpath     XPath object
         * @param object $context   In which context should the data be searched
@@ -1684,64 +1688,26 @@ class DFRN
                                Event::createBirthday($contact, $birthday);
                        }
 
-                       // Get all field names
-                       $fields = [];
-                       foreach ($contact_old as $field => $data) {
-                               $fields[$field] = $data;
-                       }
+                       $fields = ['name' => $contact['name'], 'nick' => $contact['nick'], 'about' => $contact['about'],
+                               'location' => $contact['location'], 'addr' => $contact['addr'], 'keywords' => $contact['keywords'],
+                               'bdyear' => $contact['bdyear'], 'bd' => $contact['bd'], 'hidden' => $contact['hidden'],
+                               'xmpp' => $contact['xmpp'], 'name-date' => DateTimeFormat::utc($contact['name-date']),
+                               'unsearchable' => $contact['hidden'], 'uri-date' => DateTimeFormat::utc($contact['uri-date'])];
 
-                       unset($fields["id"]);
-                       unset($fields["uid"]);
-                       unset($fields["url"]);
-                       unset($fields["avatar-date"]);
-                       unset($fields["avatar"]);
-                       unset($fields["name-date"]);
-                       unset($fields["uri-date"]);
+                       DBA::update('contact', $fields, ['id' => $contact['id'], 'network' => $contact['network']], $contact_old);
 
-                       $update = false;
-                       // Update check for this field has to be done differently
-                       $datefields = ["name-date", "uri-date"];
-                       foreach ($datefields as $field) {
-                               // The date fields arrives as '2018-07-17T10:44:45Z' - the database return '2018-07-17 10:44:45'
-                               // The fields have to be in the same format to be comparable, since strtotime does add timezones.
-                               $contact[$field] = DateTimeFormat::utc($contact[$field]);
+                       // Update the public contact. Don't set the "hidden" value, this is used differently for public contacts
+                       unset($fields['hidden']);
+                       $condition = ['uid' => 0, 'nurl' => Strings::normaliseLink($contact_old['url'])];
+                       DBA::update('contact', $fields, $condition, true);
 
-                               if (strtotime($contact[$field]) > strtotime($contact_old[$field])) {
-                                       Logger::log("Difference for contact " . $contact["id"] . " in field '" . $field . "'. New value: '" . $contact[$field] . "', old value '" . $contact_old[$field] . "'", Logger::DEBUG);
-                                       $update = true;
-                               }
-                       }
+                       Contact::updateAvatar($author['avatar'], $importer['importer_uid'], $contact['id']);
 
-                       foreach ($fields as $field => $data) {
-                               if ($contact[$field] != $contact_old[$field]) {
-                                       Logger::log("Difference for contact " . $contact["id"] . " in field '" . $field . "'. New value: '" . $contact[$field] . "', old value '" . $contact_old[$field] . "'", Logger::DEBUG);
-                                       $update = true;
-                               }
+                       $pcid = Contact::getIdForURL($contact_old['url']);
+                       if (!empty($pcid)) {
+                               Contact::updateAvatar($author['avatar'], 0, $pcid);
                        }
 
-                       if ($update) {
-                               Logger::log("Update contact data for contact " . $contact["id"] . " (" . $contact["nick"] . ")", Logger::DEBUG);
-
-                               q(
-                                       "UPDATE `contact` SET `name` = '%s', `nick` = '%s', `about` = '%s', `location` = '%s',
-                                       `addr` = '%s', `keywords` = '%s', `bdyear` = '%s', `bd` = '%s', `hidden` = %d,
-                                       `xmpp` = '%s', `name-date`  = '%s', `uri-date` = '%s'
-                                       WHERE `id` = %d AND `network` = '%s'",
-                                       DBA::escape($contact["name"]), DBA::escape($contact["nick"]), DBA::escape($contact["about"]),   DBA::escape($contact["location"]),
-                                       DBA::escape($contact["addr"]), DBA::escape($contact["keywords"]), DBA::escape($contact["bdyear"]),
-                                       DBA::escape($contact["bd"]), intval($contact["hidden"]), DBA::escape($contact["xmpp"]),
-                                       DBA::escape(DateTimeFormat::utc($contact["name-date"])), DBA::escape(DateTimeFormat::utc($contact["uri-date"])),
-                                       intval($contact["id"]), DBA::escape($contact["network"])
-                               );
-                       }
-
-                       Contact::updateAvatar(
-                               $author['avatar'],
-                               $importer['importer_uid'],
-                               $contact['id'],
-                               (strtotime($contact['avatar-date']) > strtotime($contact_old['avatar-date']) || ($author['avatar'] != $contact_old['avatar']))
-                       );
-
                        /*
                         * The generation is a sign for the reliability of the provided data.
                         * It is used in the socgraph.php to prevent that old contact data
@@ -1762,7 +1728,7 @@ class DFRN
        }
 
        /**
-        * @brief Transforms activity objects into an XML string
+        * Transforms activity objects into an XML string
         *
         * @param object $xpath    XPath object
         * @param object $activity Activity object
@@ -1780,7 +1746,7 @@ class DFRN
                $obj_doc = new DOMDocument("1.0", "utf-8");
                $obj_doc->formatOutput = true;
 
-               $obj_element = $obj_doc->createElementNS(NAMESPACE_ATOM1, $element);
+               $obj_element = $obj_doc->createElementNS( ActivityNamespace::ATOM1, $element);
 
                $activity_type = $xpath->query("activity:object-type/text()", $activity)->item(0)->nodeValue;
                XML::addElement($obj_doc, $obj_element, "type", $activity_type);
@@ -1817,7 +1783,7 @@ class DFRN
        }
 
        /**
-        * @brief Processes the mail elements
+        * Processes the mail elements
         *
         * @param object $xpath    XPath object
         * @param object $mail     mail elements
@@ -1846,7 +1812,7 @@ class DFRN
        }
 
        /**
-        * @brief Processes the suggestion elements
+        * Processes the suggestion elements
         *
         * @param object $xpath      XPath object
         * @param object $suggestion suggestion elements
@@ -1933,11 +1899,11 @@ class DFRN
                                'to_email'     => $importer['email'],
                                'uid'          => $importer['importer_uid'],
                                'item'         => $suggest,
-                               'link'         => System::baseUrl().'/notifications/intros',
+                               'link'         => DI::baseUrl().'/notifications/intros',
                                'source_name'  => $importer['name'],
                                'source_link'  => $importer['url'],
                                'source_photo' => $importer['photo'],
-                               'verb'         => ACTIVITY_REQ_FRIEND,
+                               'verb'         => Activity::REQ_FRIEND,
                                'otype'        => 'intro']
                );
 
@@ -1945,7 +1911,7 @@ class DFRN
        }
 
        /**
-        * @brief Processes the relocation elements
+        * Processes the relocation elements
         *
         * @param object $xpath      XPath object
         * @param object $relocation relocation elements
@@ -2030,7 +1996,7 @@ class DFRN
        }
 
        /**
-        * @brief Updates an item
+        * Updates an item
         *
         * @param array $current   the current item record
         * @param array $item      the new item record
@@ -2050,8 +2016,8 @@ class DFRN
                                return false;
                        }
 
-                       $fields = ['title' => defaults($item, 'title', ''), 'body' => defaults($item, 'body', ''),
-                                       'tag' => defaults($item, 'tag', ''), 'changed' => DateTimeFormat::utcNow(),
+                       $fields = ['title' => $item['title'] ?? '', 'body' => $item['body'] ?? '',
+                                       'tag' => $item['tag'] ?? '', 'changed' => DateTimeFormat::utcNow(),
                                        'edited' => DateTimeFormat::utc($item["edited"])];
 
                        $condition = ["`uri` = ? AND `uid` IN (0, ?)", $item["uri"], $importer["importer_uid"]];
@@ -2063,7 +2029,7 @@ class DFRN
        }
 
        /**
-        * @brief Detects the entry type of the item
+        * Detects the entry type of the item
         *
         * @param array $importer Record of the importer user mixed with contact of the content
         * @param array $item     the new item record
@@ -2131,7 +2097,7 @@ class DFRN
        }
 
        /**
-        * @brief Send a "poke"
+        * Send a "poke"
         *
         * @param array $item      The new item record
         * @param array $importer  Record of the importer user mixed with contact of the content
@@ -2147,7 +2113,7 @@ class DFRN
                }
                $xo = XML::parseString($item["object"], false);
 
-               if (($xo->type == ACTIVITY_OBJ_PERSON) && ($xo->id)) {
+               if (($xo->type == Activity\ObjectType::PERSON) && ($xo->id)) {
                        // somebody was poked/prodded. Was it me?
                        $Blink = '';
                        foreach ($xo->link as $l) {
@@ -2161,7 +2127,7 @@ class DFRN
                                }
                        }
 
-                       if ($Blink && Strings::compareLink($Blink, System::baseUrl() . "/profile/" . $importer["nickname"])) {
+                       if ($Blink && Strings::compareLink($Blink, DI::baseUrl() . "/profile/" . $importer["nickname"])) {
                                $author = DBA::selectFirst('contact', ['name', 'thumb', 'url'], ['id' => $item['author-id']]);
 
                                $parent = Item::selectFirst(['id'], ['uri' => $item['parent-uri'], 'uid' => $importer["importer_uid"]]);
@@ -2177,7 +2143,7 @@ class DFRN
                                        "to_email"     => $importer["email"],
                                        "uid"          => $importer["importer_uid"],
                                        "item"         => $item,
-                                       "link"         => System::baseUrl()."/display/".urlencode($item['guid']),
+                                       "link"         => DI::baseUrl()."/display/".urlencode($item['guid']),
                                        "source_name"  => $author["name"],
                                        "source_link"  => $author["url"],
                                        "source_photo" => $author["thumb"],
@@ -2191,7 +2157,7 @@ class DFRN
        }
 
        /**
-        * @brief Processes several actions, depending on the verb
+        * Processes several actions, depending on the verb
         *
         * @param int   $entrytype Is it a toplevel entry, a comment or a relayed comment?
         * @param array $importer  Record of the importer user mixed with contact of the content
@@ -2209,36 +2175,38 @@ class DFRN
                if (($entrytype == DFRN::TOP_LEVEL) && !empty($importer['id'])) {
                        // The filling of the the "contact" variable is done for legcy reasons
                        // The functions below are partly used by ostatus.php as well - where we have this variable
-                       $contact = Contact::select([], ['id' => $importer['id']]);
+                       $contact = Contact::selectFirst([], ['id' => $importer['id']]);
+
+                       $activity = DI::activity();
 
                        // Big question: Do we need these functions? They were part of the "consume_feed" function.
                        // This function once was responsible for DFRN and OStatus.
-                       if (activity_match($item["verb"], ACTIVITY_FOLLOW)) {
+                       if ($activity->match($item["verb"], Activity::FOLLOW)) {
                                Logger::log("New follower");
                                Contact::addRelationship($importer, $contact, $item);
                                return false;
                        }
-                       if (activity_match($item["verb"], ACTIVITY_UNFOLLOW)) {
+                       if ($activity->match($item["verb"], Activity::UNFOLLOW)) {
                                Logger::log("Lost follower");
                                Contact::removeFollower($importer, $contact, $item);
                                return false;
                        }
-                       if (activity_match($item["verb"], ACTIVITY_REQ_FRIEND)) {
+                       if ($activity->match($item["verb"], Activity::REQ_FRIEND)) {
                                Logger::log("New friend request");
                                Contact::addRelationship($importer, $contact, $item, true);
                                return false;
                        }
-                       if (activity_match($item["verb"], ACTIVITY_UNFRIEND)) {
+                       if ($activity->match($item["verb"], Activity::UNFRIEND)) {
                                Logger::log("Lost sharer");
                                Contact::removeSharer($importer, $contact, $item);
                                return false;
                        }
                } else {
-                       if (($item["verb"] == ACTIVITY_LIKE)
-                               || ($item["verb"] == ACTIVITY_DISLIKE)
-                               || ($item["verb"] == ACTIVITY_ATTEND)
-                               || ($item["verb"] == ACTIVITY_ATTENDNO)
-                               || ($item["verb"] == ACTIVITY_ATTENDMAYBE)
+                       if (($item["verb"] == Activity::LIKE)
+                               || ($item["verb"] == Activity::DISLIKE)
+                               || ($item["verb"] == Activity::ATTEND)
+                               || ($item["verb"] == Activity::ATTENDNO)
+                               || ($item["verb"] == Activity::ATTENDMAYBE)
                        ) {
                                $is_like = true;
                                $item["gravity"] = GRAVITY_ACTIVITY;
@@ -2265,11 +2233,11 @@ class DFRN
                                $is_like = false;
                        }
 
-                       if (($item["verb"] == ACTIVITY_TAG) && ($item["object-type"] == ACTIVITY_OBJ_TAGTERM)) {
+                       if (($item["verb"] == Activity::TAG) && ($item["object-type"] == Activity\ObjectType::TAGTERM)) {
                                $xo = XML::parseString($item["object"], false);
                                $xt = XML::parseString($item["target"], false);
 
-                               if ($xt->type == ACTIVITY_OBJ_NOTE) {
+                               if ($xt->type == Activity\ObjectType::NOTE) {
                                        $item_tag = Item::selectFirst(['id', 'tag'], ['uri' => $xt->id, 'uid' => $importer["importer_uid"]]);
 
                                        if (!DBA::isResult($item_tag)) {
@@ -2291,7 +2259,7 @@ class DFRN
        }
 
        /**
-        * @brief Processes the link elements
+        * Processes the link elements
         *
         * @param object $links link elements
         * @param array  $item  the item record
@@ -2335,7 +2303,7 @@ class DFRN
        }
 
        /**
-        * @brief Processes the entry elements which contain the items and comments
+        * Processes the entry elements which contain the items and comments
         *
         * @param array  $header   Array of the header elements that always stay the same
         * @param object $xpath    XPath object
@@ -2396,13 +2364,13 @@ class DFRN
                $item["body"] = XML::getFirstNodeValue($xpath, "dfrn:env/text()", $entry);
                $item["body"] = str_replace([' ',"\t","\r","\n"], ['','','',''], $item["body"]);
                // make sure nobody is trying to sneak some html tags by us
-               $item["body"] = Strings::escapeTags(Strings::base64UrlDecode($item["body"]));
+               $item["body"] = Strings::base64UrlDecode($item["body"]);
 
                $item["body"] = BBCode::limitBodySize($item["body"]);
 
                /// @todo Do we really need this check for HTML elements? (It was copied from the old function)
                if ((strpos($item['body'], '<') !== false) && (strpos($item['body'], '>') !== false)) {
-                       $base_url = \get_app()->getBaseURL();
+                       $base_url = DI::baseUrl()->get();
                        $item['body'] = HTML::relToAbs($item['body'], $base_url);
 
                        $item['body'] = HTML::toBBCodeVideo($item['body']);
@@ -2544,7 +2512,7 @@ class DFRN
                // Now assign the rest of the values that depend on the type of the message
                if (in_array($entrytype, [DFRN::REPLY, DFRN::REPLY_RC])) {
                        if (!isset($item["object-type"])) {
-                               $item["object-type"] = ACTIVITY_OBJ_COMMENT;
+                               $item["object-type"] = Activity\ObjectType::COMMENT;
                        }
 
                        if ($item["contact-id"] != $owner["contact-id"]) {
@@ -2564,15 +2532,18 @@ class DFRN
                        }
                }
 
+               // Ensure to have the correct share data
+               $item = Item::addShareDataFromOriginal($item);
+
                if ($entrytype == DFRN::REPLY_RC) {
                        $item["wall"] = 1;
                } elseif ($entrytype == DFRN::TOP_LEVEL) {
                        if (!isset($item["object-type"])) {
-                               $item["object-type"] = ACTIVITY_OBJ_NOTE;
+                               $item["object-type"] = Activity\ObjectType::NOTE;
                        }
 
                        // Is it an event?
-                       if (($item["object-type"] == ACTIVITY_OBJ_EVENT) && !$owner_unknown) {
+                       if (($item["object-type"] == Activity\ObjectType::EVENT) && !$owner_unknown) {
                                Logger::log("Item ".$item["uri"]." seems to contain an event.", Logger::DEBUG);
                                $ev = Event::fromBBCode($item["body"]);
                                if ((!empty($ev['desc']) || !empty($ev['summary'])) && !empty($ev['start'])) {
@@ -2669,7 +2640,7 @@ class DFRN
                                Item::distribute($posted_id);
                        }
 
-                       if (stristr($item["verb"], ACTIVITY_POKE)) {
+                       if (stristr($item["verb"], Activity::POKE)) {
                                $item['id'] = $posted_id;
                                self::doPoke($item, $importer);
                        }
@@ -2677,7 +2648,7 @@ class DFRN
        }
 
        /**
-        * @brief Deletes items
+        * Deletes items
         *
         * @param object $xpath    XPath object
         * @param object $deletion deletion elements
@@ -2738,7 +2709,7 @@ class DFRN
        }
 
        /**
-        * @brief Imports a DFRN message
+        * Imports a DFRN message
         *
         * @param string $xml          The DFRN message
         * @param array  $importer     Record of the importer user mixed with contact of the content
@@ -2758,16 +2729,16 @@ class DFRN
                @$doc->loadXML($xml);
 
                $xpath = new DOMXPath($doc);
-               $xpath->registerNamespace("atom", NAMESPACE_ATOM1);
-               $xpath->registerNamespace("thr", NAMESPACE_THREAD);
-               $xpath->registerNamespace("at", NAMESPACE_TOMB);
-               $xpath->registerNamespace("media", NAMESPACE_MEDIA);
-               $xpath->registerNamespace("dfrn", NAMESPACE_DFRN);
-               $xpath->registerNamespace("activity", NAMESPACE_ACTIVITY);
-               $xpath->registerNamespace("georss", NAMESPACE_GEORSS);
-               $xpath->registerNamespace("poco", NAMESPACE_POCO);
-               $xpath->registerNamespace("ostatus", NAMESPACE_OSTATUS);
-               $xpath->registerNamespace("statusnet", NAMESPACE_STATUSNET);
+               $xpath->registerNamespace("atom", ActivityNamespace::ATOM1);
+               $xpath->registerNamespace("thr", ActivityNamespace::THREAD);
+               $xpath->registerNamespace("at", ActivityNamespace::TOMB);
+               $xpath->registerNamespace("media", ActivityNamespace::MEDIA);
+               $xpath->registerNamespace("dfrn", ActivityNamespace::DFRN);
+               $xpath->registerNamespace("activity", ActivityNamespace::ACTIVITY);
+               $xpath->registerNamespace("georss", ActivityNamespace::GEORSS);
+               $xpath->registerNamespace("poco", ActivityNamespace::POCO);
+               $xpath->registerNamespace("ostatus", ActivityNamespace::OSTATUS);
+               $xpath->registerNamespace("statusnet", ActivityNamespace::STATUSNET);
 
                $header = [];
                $header["uid"] = $importer["importer_uid"];
@@ -2881,116 +2852,7 @@ class DFRN
        }
 
        /**
-        * @param App    $a            App
-        * @param string $contact_nick contact nickname
-        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
-        */
-       public static function autoRedir(App $a, $contact_nick)
-       {
-               // prevent looping
-               if (!empty($_REQUEST['redir'])) {
-                       Logger::log('autoRedir might be looping because redirect has been redirected', Logger::DEBUG);
-                       // looping prevention also appears to sometimes prevent authentication for images
-                       // because browser may have multiple connections open and load an image on a connection
-                       // whose session wasn't updated when a previous redirect authenticated
-                       // Leaving commented in case looping reappears
-                       //return;
-               }
-
-               if ((! $contact_nick) || ($contact_nick === $a->user['nickname'])) {
-                       return;
-               }
-
-               if (local_user()) {
-                       // We need to find out if $contact_nick is a user on this hub, and if so, if I
-                       // am a contact of that user. However, that user may have other contacts with the
-                       // same nickname as me on other hubs or other networks. Exclude these by requiring
-                       // that the contact have a local URL. I will be the only person with my nickname at
-                       // this URL, so if a result is found, then I am a contact of the $contact_nick user.
-                       //
-                       // We also have to make sure that I'm a legitimate contact--I'm not blocked or pending.
-
-                       $baseurl = System::baseUrl();
-                       $domain_st = strpos($baseurl, "://");
-                       if ($domain_st === false) {
-                               return;
-                       }
-                       $baseurl = substr($baseurl, $domain_st + 3);
-                       $nurl = Strings::normaliseLink($baseurl);
-
-                       $r = User::getByNickname($contact_nick, ["uid"]);
-                       $contact_uid = $r["uid"];
-
-                       /// @todo Why is there a query for "url" *and* "nurl"? Especially this normalising is strange.
-                       $r = q("SELECT `id` FROM `contact` WHERE `uid` = (SELECT `uid` FROM `user` WHERE `nickname` = '%s' LIMIT 1)
-                                       AND `nick` = '%s' AND NOT `self` AND (`url` LIKE '%%%s%%' OR `nurl` LIKE '%%%s%%') AND NOT `blocked` AND NOT `pending` LIMIT 1",
-                               DBA::escape($contact_nick),
-                               DBA::escape($a->user['nickname']),
-                               DBA::escape($baseurl),
-                               DBA::escape($nurl)
-                       );
-                       if ((! DBA::isResult($r))) {
-                               return;
-                       }
-                       // test if redirect authentication already succeeded
-                       // Note that "contact" in the sense used in the $contact_nick argument to this function
-                       // and the sense in the $remote[]["cid"] in the session are opposite.
-                       // In the session variable the user currently fetching is the contact
-                       // while $contact_nick is the nick of tho user who owns the stuff being fetched.
-                       foreach (\Friendica\Core\Session::get('remote', []) as $visitor) {
-                               if ($visitor['uid'] == $contact_uid && $visitor['cid'] == $r[0]['id']) {
-                                       return;
-                               }
-                       }
-
-                       $r = q("SELECT * FROM contact WHERE nick = '%s'
-                                       AND network = '%s' AND uid = %d  AND url LIKE '%%%s%%' LIMIT 1",
-                               DBA::escape($contact_nick),
-                               DBA::escape(Protocol::DFRN),
-                               intval(local_user()),
-                               DBA::escape($baseurl)
-                       );
-                       if (! DBA::isResult($r)) {
-                               return;
-                       }
-
-                       $cid = $r[0]['id'];
-
-                       $dfrn_id = (($r[0]['issued-id']) ? $r[0]['issued-id'] : $r[0]['dfrn-id']);
-
-                       if ($r[0]['duplex'] && $r[0]['issued-id']) {
-                               $orig_id = $r[0]['issued-id'];
-                               $dfrn_id = '1:' . $orig_id;
-                       }
-                       if ($r[0]['duplex'] && $r[0]['dfrn-id']) {
-                               $orig_id = $r[0]['dfrn-id'];
-                               $dfrn_id = '0:' . $orig_id;
-                       }
-
-                       // ensure that we've got a valid ID. There may be some edge cases with forums and non-duplex mode
-                       // that may have triggered some of the "went to {profile/intro} and got an RSS feed" issues
-
-                       if (strlen($dfrn_id) < 3) {
-                               return;
-                       }
-
-                       $sec = Strings::getRandomHex();
-
-                       DBA::insert('profile_check', ['uid' => local_user(), 'cid' => $cid, 'dfrn_id' => $dfrn_id, 'sec' => $sec, 'expire' => time() + 45]);
-
-                       $url = curPageURL();
-
-                       Logger::log('auto_redir: ' . $r[0]['name'] . ' ' . $sec, Logger::DEBUG);
-                       $dest = (($url) ? '&destination_url=' . $url : '');
-                       System::externalRedirect($r[0]['poll'] . '?dfrn_id=' . $dfrn_id
-                               . '&dfrn_version=' . DFRN_PROTOCOL_VERSION . '&type=profile&sec=' . $sec . $dest);
-               }
-
-               return;
-       }
-
-       /**
-        * @brief Returns the activity verb
+        * Returns the activity verb
         *
         * @param array $item Item array
         *
@@ -3001,7 +2863,7 @@ class DFRN
                if ($item['verb']) {
                        return $item['verb'];
                }
-               return ACTIVITY_POST;
+               return Activity::POST;
        }
 
        private static function tgroupCheck($uid, $item)
@@ -3022,13 +2884,13 @@ class DFRN
                $community_page = ($user['page-flags'] == User::PAGE_FLAGS_COMMUNITY);
                $prvgroup = ($user['page-flags'] == User::PAGE_FLAGS_PRVGROUP);
 
-               $link = Strings::normaliseLink(System::baseUrl() . '/profile/' . $user['nickname']);
+               $link = Strings::normaliseLink(DI::baseUrl() . '/profile/' . $user['nickname']);
 
                /*
                 * Diaspora uses their own hardwired link URL in @-tags
                 * instead of the one we supply with webfinger
                 */
-               $dlink = Strings::normaliseLink(System::baseUrl() . '/u/' . $user['nickname']);
+               $dlink = Strings::normaliseLink(DI::baseUrl() . '/u/' . $user['nickname']);
 
                $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER);
                if ($cnt) {
@@ -3074,4 +2936,19 @@ class DFRN
 
                return (strcmp($existing_edited, $update_edited) < 0);
        }
+
+       /**
+        * Checks if the given contact url does support DFRN
+        *
+        * @param string  $url    profile url
+        * @param boolean $update Update the profile
+        * @return boolean
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
+        */
+       public static function isSupportedByContactUrl($url, $update = false)
+       {
+               $probe = Probe::uri($url, Protocol::DFRN, 0, !$update);
+               return $probe['network'] == Protocol::DFRN;
+       }
 }